[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

lebedev.ri added a comment. In https://reviews.llvm.org/D50250#1236478, @rjmccall wrote: > It might help if you're more specific about whose review you're asking for. I suppose the main suspect is still the @rsmith. Though, https://reviews.llvm.org/D50901 is less controversial, so maybe best to

[PATCH] D52084: [clangd] NFC: Update documentation of Iterator's dump format

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:96 /// ChildN is N-th iterator child. Raw iterators over PostingList are - /// represented as "[ID1, ID2, ..

[clang-tools-extra] r342362 - [clangd] Get rid of AST matchers in SymbolCollector. NFC

Author: ioeric Date: Mon Sep 17 00:43:49 2018 New Revision: 342362 URL: http://llvm.org/viewvc/llvm-project?rev=342362&view=rev Log: [clangd] Get rid of AST matchers in SymbolCollector. NFC Reviewers: ilya-biryukov, kadircet Subscribers: MaskRay, jkorous, arphaman, cfe-commits Differential Revi

[PATCH] D52089: [clangd] Get rid of AST matchers in SymbolCollector. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL342362: [clangd] Get rid of AST matchers in SymbolCollector. NFC (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52089 Files

r342363 - [clang-Format] Fix indentation of member call after block

Author: ibiryukov Date: Mon Sep 17 00:46:20 2018 New Revision: 342363 URL: http://llvm.org/viewvc/llvm-project?rev=342363&view=rev Log: [clang-Format] Fix indentation of member call after block Summary: before patch: > echo "test() {([]() -> {int b = 32;return 3;}).as("");});" | clang-format > -

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ilya-biryukov added a comment. Landed the patch as r342363. Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

This revision was automatically updated to reflect the committed changes. Closed by commit rC342363: [clang-Format] Fix indentation of member call after block (authored by ibiryukov, committed by ). Repository: rC Clang https://reviews.llvm.org/D45719 Files: lib/Format/ContinuationIndenter.

[PATCH] D52047: [clangd] Add a "benchmark" for tracking memory

ioeric added a comment. The benchmark change looks fine to me. But I'm not very familiar with the trick, so I'll let Sam (who proposed the idea as you mentioned), stamp the patch. Comment at: clang-tools-extra/clangd/index/dex/Dex.h:75 +

[PATCH] D52021: Fix Bug 38926: don't merge short case labels if followed by a block

owenpan added a comment. ping any review. Repository: rC Clang https://reviews.llvm.org/D52021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51633: [ASTImporter] Added error handling for AST import.

balazske added a comment. Hi, Did you mean to split the review only or the patches? It is not trivial how to make incremental patches for this change, every part is connected to the other. The import functions for a type (`Decl` or `Stmt`) call imports of other types (`Expr` for example) too. If

[PATCH] D45741: Python bindings: Fix handling of file bodies with multi-byte characters

mheinzler updated this revision to Diff 165728. mheinzler added a comment. Sorry, here's the diff for the whole files. The `b` function defined at the top of the file already does what you suggest. For python2 it returns the string unchanged, for python3 it calls `encode`. So there shouldn't be

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

alexfh added inline comments. Comment at: clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:102-108 + if (childrenCount(ND.decls()) == 0) { +SourceRange Removal(Namespaces.front().Begin, Namespaces.front().RBrace); + +diag(Namespaces.front().Begin, + "Nested n

[PATCH] D52158: [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use FunctionParmMutationAnalyzer instead.

JonasToth added a comment. LG from my side Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

JonasToth accepted this revision. JonasToth added a comment. The last testcase i mentioned, after that LGTM Comment at: unittests/Analysis/ExprMutationAnalyzerTest.cpp:441 + Results = match(withEnclosingCompound(declRefTo("x")), AST->getASTContext()); + EXPECT_FALSE(isMutated

r342365 - [Analyzer] Define and use diff_plist in tests, NFC

Author: miyuki Date: Mon Sep 17 03:19:46 2018 New Revision: 342365 URL: http://llvm.org/viewvc/llvm-project?rev=342365&view=rev Log: [Analyzer] Define and use diff_plist in tests, NFC This patch defines a new substitution and uses it to reduce duplication in the Clang Analyzer test cases. Differ

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rC342365: [Analyzer] Define and use diff_plist in tests, NFC (authored by miyuki, committed by ). Changed prior to commit: https://reviews.llvm.org/D52036?vs=165469&id=165732#toc Repository: rC Clang

[PATCH] D52036: [Analyzer] Use diff_plist in tests, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL342365: [Analyzer] Define and use diff_plist in tests, NFC (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52036?vs=16546

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

JonasToth added a comment. > In https://reviews.llvm.org/D52135#1236220, @JonasToth wrote: > >> Why is the cast to void diagnosed anyway? It is not an argument nor is it >> used in a function context. Do you have an explaination for that? > > > Yes, this because when we find a function and the

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

ilya-biryukov added a comment. Sorry for the late response. Please see the comments about adding closing quotes and slashes. It does not seem to work in the clients that auto-add closing quotes or when completing inside existing includes. Comment at: lib/Lex/Lexer.cpp:1931 +

r342367 - Merge two attribute diagnostics into one

Author: asavonic Date: Mon Sep 17 03:39:46 2018 New Revision: 342367 URL: http://llvm.org/viewvc/llvm-project?rev=342367&view=rev Log: Merge two attribute diagnostics into one Summary: Merged the recently added `err_attribute_argument_negative` diagnostic with existing `err_attribute_requires_pos

[PATCH] D51853: Merge two attribute diagnostics into one

This revision was automatically updated to reflect the committed changes. Closed by commit rC342367: Merge two attribute diagnostics into one (authored by asavonic, committed by ). Changed prior to commit: https://reviews.llvm.org/D51853?vs=164651&id=165734#toc Repository: rC Clang https://

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ilya-biryukov added a comment. Overall LG, see the major comment about running without the preprocessor. Comment at: include/clang/Index/IndexingAction.h:44 bool IndexImplicitInstantiation = false; + bool IndexMacrosInPreprocessor = false; }; Maybe add a c

[PATCH] D51341: [HEADER] Overloadable function candidates for half/double types

sidorovd added a comment. For now this patch is on hold since it adds no new functionality. Its future will be decided after @asavonic finished https://reviews.llvm.org/D51544 https://reviews.llvm.org/D51341 ___ cfe-commits mailing list cfe-commits

r342370 - [OpenCL] Allow blocks to capture arrays in OpenCL

Author: asavonic Date: Mon Sep 17 04:19:42 2018 New Revision: 342370 URL: http://llvm.org/viewvc/llvm-project?rev=342370&view=rev Log: [OpenCL] Allow blocks to capture arrays in OpenCL Summary: Patch by Egor Churaev Reviewers: Anastasia, yaxunl Reviewed By: Anastasia Subscribers: asavonic, bad

[PATCH] D51722: [OpenCL] Allow blocks to capture arrays in OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL342370: [OpenCL] Allow blocks to capture arrays in OpenCL (authored by asavonic, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51722?vs=1642

[libunwind] r342382 - Creating release candidate final from release_700 branch

Author: hans Date: Mon Sep 17 04:38:04 2018 New Revision: 342382 URL: http://llvm.org/viewvc/llvm-project?rev=342382&view=rev Log: Creating release candidate final from release_700 branch Added: libunwind/tags/RELEASE_700/final/ (props changed) - copied from r342381, libunwind/branche

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

IdrissRio updated this revision to Diff 165741. IdrissRio added a comment. Thank you @JonasToth. As you suggest I have added the test for the templatic function. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52135 Files: clang-tidy/modernize/RedundantVoidArgCheck.cpp test

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

JonasToth added inline comments. Comment at: test/clang-tidy/modernize-redundant-void-arg.cpp:495 + void g_1(void) const { + // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: redundant void argument list in + // function definition [modernize-redunda

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LG from my side. I guess you found this in a real code base, if so could you please verify its fixed now. If @aaron.ballman, @alexfh or @hokein have no complaints it can be committed. D

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

IdrissRio added a comment. In https://reviews.llvm.org/D52135#1236690, @JonasToth wrote: > LG from my side. > I guess you found this in a real code base, if so could you please verify > its fixed now. Actually I'm searching for the bug in bugzilla and I try to fix them. > If @aaron.ballman,

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 165742. JonasToth added a comment. - [Feature] initial commit for extract decl experiment - [Feature] implement the last-element extraction version kinda ok - [Misc] work further on the experiment - do a full transformation of the multi decl stmt - [Misc] ad

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

JonasToth added a comment. Ok, if possible double check that it actually worked, otherwise not ;) Perfect! You can ofcourse commit yourself Am 17.09.2018 um 13:47 schrieb Idriss via Phabricator: > IdrissRio added a comment. > > In https://reviews.llvm.org/D52135#1236690, @JonasToth wrote: > >

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with the nits corrected (there are still some formatting concerns). Comment at: test/clang-tidy/modernize-redundant-void-arg.cpp:541 +template +void g_3(void){ + // CHECK-MESSAGES: :[[@LINE-1]]:10:

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

baloghadamsoftware added a comment. This looks better than using the "raw" dumps. Should not it we have its own test in `expr-inspection.c`? Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:65 REGISTER_SET_WITH_PROGRAMSTATE(MarkedSymbols, SymbolRef) +REGISTER

[PATCH] D51597: [ASTImporter] Fix import of VarDecl init

This revision was automatically updated to reflect the committed changes. Closed by commit rL342384: [ASTImporter] Fix import of VarDecl init (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D51597 Files: cfe/trunk/l

r342384 - [ASTImporter] Fix import of VarDecl init

Author: martong Date: Mon Sep 17 05:04:52 2018 New Revision: 342384 URL: http://llvm.org/viewvc/llvm-project?rev=342384&view=rev Log: [ASTImporter] Fix import of VarDecl init Summary: The init expression of a VarDecl is overwritten in the "To" context if we import a VarDecl without an init expres

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth marked 7 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:51 + +return TypeAndName + " = " + Initializer + ";"; + } kbobyrev wrote: > JonasToth wrote: > > kbobyrev wrote: > > > This s

[PATCH] D52083: [clangd] Store OR iterator children in heap

ilya-biryukov added a comment. > Seems like this optimization is not worth (yet?). As soon as we get more > proximity paths (and hence more OR iterator children) that might make sense. WDYT about storing **all** the elements with the minimal doc-id outside the heap? I.e. we can pop **all** elem

[PATCH] D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342388: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about… (authored by IdrissRio, committed by ). Changed prior to commit: https://reviews.llvm.org/D52135?vs=165741&id=16

[clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

Author: idrissrio Date: Mon Sep 17 05:29:29 2018 New Revision: 342388 URL: http://llvm.org/viewvc/llvm-project?rev=342388&view=rev Log: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void Summary: Hello, i would like to suggest a fix for one of the

[clang-tools-extra] r342389 - Fix

Author: idrissrio Date: Mon Sep 17 05:58:19 2018 New Revision: 342389 URL: http://llvm.org/viewvc/llvm-project?rev=342389&view=rev Log: Fix Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-redundant-void-arg.cpp Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-redundan

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 165749. JonasToth marked an inline comment as done. JonasToth added a comment. - improve diagnostic to include number of declared variables Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.tx

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth marked 5 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:71 + auto Diag = + diag(WholeDecl->getBeginLoc(), "make only one declaration per statement"); + kbobyrev wrote: > Maybe it'

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

It looks like this commit breaks buildbots (e.g. http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6711). Could you take a look? On Mon, Sep 17, 2018 at 2:33 PM Idriss Riouak via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: idrissrio > Date: Mon Sep 17 05:29:29 2018 >

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

(If there's no clear idea of how to fix this, reverting until the fix is found is usually the best strategy.) On Mon, Sep 17, 2018 at 3:14 PM Alexander Kornienko wrote: > It looks like this commit breaks buildbots (e.g. > http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/6711). >

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

Ah, now I see your fix in r342389. Thanks! On Mon, Sep 17, 2018 at 3:15 PM Alexander Kornienko wrote: > (If there's no clear idea of how to fix this, reverting until the fix is > found is usually the best strategy.) > > On Mon, Sep 17, 2018 at 3:14 PM Alexander Kornienko > wrote: > >> It looks

Re: [clang-tools-extra] r342388 - [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void

Yes I have already make the fix commit. It was an error in the tests. https://github.com/llvm-mirror/clang-tools-extra/commit/77ed1cd838a249d6134de9a6bdbe17ef46ecf946 Now on my Mac it compile a

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 165752. JonasToth marked an inline comment as done. JonasToth added a comment. - use static functions instead anonymous namespace Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:191 +void templated_thrower() { throw T{}(); } +// CHECK-MESSAGES: [[@LINE-1]]:34: warning: throwing an exception

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. @ilya-biryukov, gentle ping. I'd like to patch this for 7.0.0 in Gentoo. Do you think my patch would be good enough, or do you expect to submit something else soonish? https://reviews.llvm.org/D50171 ___ cfe-commits mailing

[clang-tools-extra] r342393 - [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

Author: jonastoth Date: Mon Sep 17 06:55:10 2018 New Revision: 342393 URL: http://llvm.org/viewvc/llvm-project?rev=342393&view=rev Log: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly Summary: PR37913 documents wrong behaviour for a templated exception factory function.

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 165756. JonasToth added a comment. get up to date to master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rL342393: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.ll

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall updated this revision to Diff 165759. sammccall added a comment. Address comments. Only complete last segment for better compatibility. Repository: rC Clang https://reviews.llvm.org/D52076 Files: include/clang-c/Index.h include/clang/Lex/CodeCompletionHandler.h include/clang/

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall added a comment. After experimenting, editor support for replacing non-identifier text before the cursor is... spotty at best. So switched to just replacing the last path component. (This makes me a bit sad because the completions now have closing quotes but not opening ones, which lo

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric updated this revision to Diff 165761. ioeric marked 4 inline comments as done. ioeric added a comment. - addressed review comments. Repository: rC Clang https://reviews.llvm.org/D52098 Files: include/clang/Index/IndexingAction.h lib/Index/IndexingAction.cpp unittests/CMakeLists.

[PATCH] D52098: [Index] Add an option to collect macros from preprocesor.

ioeric added inline comments. Comment at: include/clang/Index/IndexingAction.h:44 bool IndexImplicitInstantiation = false; + bool IndexMacrosInPreprocessor = false; }; ilya-biryukov wrote: > Maybe add a comment or change a name to indicate that this currentl

[PATCH] D51867: [Diagnostics] Add error handling to FormatDiagnostic()

jkorous added a comment. Hi Volodymyr, do you think you might take another look? Repository: rC Clang https://reviews.llvm.org/D51867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D52157: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with a request for the documentation. Comment at: include/clang/ASTMatchers/ASTMatchers.h:4698-4702 /// class Y { /// void x() { this->x(); x(); Y

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4683-4686 + "Member '%0' marked with 'exclude_from_explicit_instantiation' attribute is " + "not defined but an explicit template instantiation declaration exists. " + "Reliance on this

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne updated this revision to Diff 165766. ldionne added a comment. Reformat warning message and run clang-format on changed lines. Repository: rC Clang https://reviews.llvm.org/D51789 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:2990 +on static and non-static member functions of class templates, static data +members of class templates and member classes of class templates. + }]; An example that demons

[PATCH] D52173: Python bindings TypeError in reparse method

bdcht created this revision. bdcht added a reviewer: clang. bdcht added a project: clang. Herald added a subscriber: cfe-commits. In method 'reparse' of the python bindings (cindex.py), a TypeError is raised when 'unsaved_files_array' is set from name/value arguments when using Python3. (This is

[PATCH] D51789: [clang] Add the exclude_from_explicit_instantiation attribute

ldionne updated this revision to Diff 165768. ldionne added a comment. Add example of how to use the attribute, per Aaron's comment. Repository: rC Clang https://reviews.llvm.org/D51789 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/B

[PATCH] D52141: Thread safety analysis: Run more tests with capability attributes [NFC]

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with a minor formatting nit. Comment at: test/SemaCXX/thread-safety-annotations.h:29 +#define PT_GUARDED_VAR __attribute__((pt_guarded_va

[PATCH] D51432: [AArch64] Unwinding support for return address signing

LukeCheeseman added inline comments. Comment at: src/Registers.hpp:1835 + if (((regNum >= 0) && (regNum < 32)) || regNum == UNW_ARM64_RA_SIGN_STATE) return _registers.__x[regNum]; + olista01 wrote: > When regNum == UNW_ARM64_RA_SIGN_STATE, the index into __

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

ilya-biryukov added inline comments. Comment at: lib/Lex/Lexer.cpp:2086 + StringRef PartialPath(PathStart, CompletionPoint - PathStart); + auto Slash = PartialPath.rfind('/'); + StringRef Dir = This will probably break for backslash includes. We should probabl

[PATCH] D51223: Update tests for new YAMLIO polymorphic traits

nhaehnle added a subscriber: tpr. nhaehnle added a comment. Adding @tpr as a subscriber due to the (admittedly maybe a bit indirect) MsgPack connection. Repository: rC Clang https://reviews.llvm.org/D51223 ___ cfe-commits mailing list cfe-commit

[PATCH] D51432: [AArch64] Unwinding support for return address signing

LukeCheeseman updated this revision to Diff 165775. LukeCheeseman added a comment. return an error code when trying to sign return addresses and cross unwinding https://reviews.llvm.org/D51432 Files: include/libunwind.h src/DwarfInstructions.hpp src/DwarfParser.hpp src/Registers.hpp s

[PATCH] D49549: Change 'clang-test' to 'check-clang' on the hacking webpage

JDevlieghere added a comment. Hey Arnaud, let me know if you want me to commit this for you. Repository: rC Clang https://reviews.llvm.org/D49549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySotkin added inline comments. Comment at: include/clang/Basic/OpenCLExtensionTypes.def:27 + +INTEL_SGAVC_TYPE(mce_payload_t, McePayload) +INTEL_SGAVC_TYPE(ime_payload_t, ImePayload) Anastasia wrote: > AlexeySachkov wrote: > > Anastasia wrote: > > > From the

[PATCH] D52178: [clang-tidy] use CHECK-NOTES in tests for bugprone-argument-comment

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. This patch uses CHECK-NOTES for the tests. Its part of an effort to test *ALL* generated diagnostics in clang-tidy, as emitted notes were previously ignored.

Re: r342053 - [CodeGen] Align rtti and vtable data

Hi David, I'm seeing test failures after this patch. I'm trying to get a test case reduced, but can we revert until we figure it out? Thanks! -eric On Wed, Sep 12, 2018 at 7:10 AM David Green via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dmgreen > Date: Wed Sep 12 07:09:06 201

Re: r342053 - [CodeGen] Align rtti and vtable data

Hello Interesting, what kind of failures? If they are causing you problems, of course feel free to revert. Dave From: Eric Christopher Sent: 17 September 2018 18:07:47 To: David Green Cc: cfe-commits@lists.llvm.org Subject: Re: r342053 - [CodeGen] Align rtti and vtable data Hi David, I'm

[PATCH] D52076: [CodeComplete] Add completions for filenames in #include directives.

sammccall updated this revision to Diff 165787. sammccall marked an inline comment as done. sammccall added a comment. Handle completion after a backslash in MSVC-compat mode. Repository: rC Clang https://reviews.llvm.org/D52076 Files: include/clang-c/Index.h include/clang/Lex/CodeComple

[PATCH] D52058: Add Parameters to DW_AT_name Attribute of Template Variables

ormris updated this revision to Diff 165789. ormris added a comment. - Removed unneeded comment - Renamed variable Repository: rC Clang https://reviews.llvm.org/D52058 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGenCXX/debug-info-template-member.cpp Index: te

[clang-tools-extra] r342403 - [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use FunctionParmMutationAnalyzer instead.

Author: shuaiwang Date: Mon Sep 17 10:59:51 2018 New Revision: 342403 URL: http://llvm.org/viewvc/llvm-project?rev=342403&view=rev Log: [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use FunctionParmMutationAnalyzer instead. Reviewers: alexfh, JonasToth, george.karpenkov

[PATCH] D52158: [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use FunctionParmMutationAnalyzer instead.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342403: [clang-tidy] Remove duplicated logic in UnnecessaryValueParamCheck and use… (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

Re: r342053 - [CodeGen] Align rtti and vtable data

> Interesting, what kind of failures? > > If they are causing you problems, of course feel free to revert. > > Dave Turns out they are all real issues which running the test under asan mode flags as global-buffer-overflow. I'm guessing the over-alignment was hiding the bug as reads there would be

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra created this revision. tra added reviewers: alexfh, rsmith. Herald added subscribers: bixia, xazax.hun, jlebar, sanjoy. findStyleKind is only called if D is an explicit identifier with a name, so the checks for operators will never return true. The explicit assert() enforces this invariant.

[PATCH] D51808: [CUDA] Ignore uncallable functions when we check for usual deallocators.

tra updated this revision to Diff 165794. tra added a comment. Addressed Richard's comments. Moved clang-tidy changes into separate review https://reviews.llvm.org/D52179. https://reviews.llvm.org/D51808 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Sema/Sema.h clang/lib/AS

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

cdavis5x added a comment. Ping. Repository: rUNW libunwind https://reviews.llvm.org/D51657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

Meinersbur added a comment. In https://reviews.llvm.org/D52118#1235897, @jdoerfert wrote: > > save an iteration over the loop's basic blocks (which is what getLoopLatch > > does) > > I'm not sure this is true. getLoopLatch() in LoopInfoImpl.h > only traverses the children of the header in the

[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342406: [Loopinfo] Remove one latch-case in getLoopID. NFC. (authored by Meinersbur, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52118?vs=

Re: r342053 - [CodeGen] Align rtti and vtable data

Thanks for looking Jordan! On Mon, Sep 17, 2018, 11:16 AM Jordan Rupprecht wrote: > > Interesting, what kind of failures? > > > > If they are causing you problems, of course feel free to revert. > > > > Dave > > Turns out they are all real issues which running the test under asan > mode flags as

r342407 - [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

Author: shuaiwang Date: Mon Sep 17 11:48:43 2018 New Revision: 342407 URL: http://llvm.org/viewvc/llvm-project?rev=342407&view=rev Log: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr Reviewers: aaron.ballman Subscribers: cfe-commits Differential Revisi

[PATCH] D52157: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

shuaiwang updated this revision to Diff 165799. shuaiwang marked an inline comment as done. shuaiwang added a comment. Addressed review comment. Repository: rC Clang https://reviews.llvm.org/D52157 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittes

[PATCH] D52157: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr, CXXDependentScopeMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL342407: [ASTMatchers] Let isArrow also support UnresolvedMemberExpr… (authored by shuaiwang, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52157

[PATCH] D52120: [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

shuaiwang updated this revision to Diff 165801. shuaiwang marked an inline comment as done. shuaiwang added a comment. Added test case with copy-ctor & assignment operator taking value as param. Repository: rC Clang https://reviews.llvm.org/D52120 Files: lib/Analysis/ExprMutationAnalyzer.c

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

JonasToth added a comment. Is the condition for this assertion checked beforehand or could this create runtime failures? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D52185: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52185 Files: test/clang-tidy/bugprone-forward-declaration-namespace.cpp Index: test/clan

[PATCH] D52186: [clang-tidy] use CHECK-NOTES in bugprone-forwarding-reference-overload

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52186 Files: test/clang-tidy/bugprone-forwarding-reference-overload.cpp Index: test/clan

[PATCH] D52187: [clang-tidy] use CHECK-NOTES in bugprone-unused-return-value

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, alexfh, hokein. Herald added subscribers: cfe-commits, xazax.hun. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52187 Files: test/clang-tidy/bugprone-unused-return-value-custom.cpp test/clang-tidy/bug

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ updated this revision to Diff 165810. NoQ added a comment. Address comments. Add more sanity checks and test them. https://reviews.llvm.org/D52133 Files: docs/analyzer/DebugChecks.rst lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp test/Analysis/expr-inspection.cpp test/Analys

[PATCH] D52133: [analyzer] A testing facility for testing relationships between symbols.

NoQ marked an inline comment as done. NoQ added a comment. > Should not it we have its own test in `expr-inspection.c`? This isn't usually necessary when we're testing all code paths anyway, but i guess it's worth it to test our sanity-check warnings. Comment at: lib/StaticAn

[PATCH] D52179: [clang-tidy] Replace redundant checks with an assert().

tra added a comment. In https://reviews.llvm.org/D52179#1237194, @JonasToth wrote: > Is the condition for this assertion checked beforehand or could this create > runtime failures? It's checked by the (only) caller of the function on line 791: if (const auto *Decl = Result.Nodes.getNodeAs

Re: r342165 - Support -fno-omit-frame-pointer with -pg.

Seems like it might be problematic to have this separate implementation of checking whether frame pointers are enabled compared to the canonical one (the one actually used to enable/disable frame pointers) in the static "shouldUseFramePointer" Function? (eg: apparently on some targets (mustUseNonL

Re: r342214 - remove 11 years old videos from the homepage. if you have a suggestion, please drop me an email

If you're going to remove these, might as well remove the html files they link to? On the other hand, might be worth keeping these around/linked to, but for posterity/archival purposes, rather than as sources of legitimately useful information for people trying to use LLVM today. On Fri, Sep 14,

[clang-tools-extra] r342408 - Fix build failure caused by D52157

Author: shuaiwang Date: Mon Sep 17 13:10:33 2018 New Revision: 342408 URL: http://llvm.org/viewvc/llvm-project?rev=342408&view=rev Log: Fix build failure caused by D52157 Modified: clang-tools-extra/trunk/unittests/clang-query/QueryEngineTest.cpp Modified: clang-tools-extra/trunk/unittests/c

r342409 - [analyzer] Treat std::{move, forward} as casts in ExprMutationAnalyzer.

Author: shuaiwang Date: Mon Sep 17 13:10:56 2018 New Revision: 342409 URL: http://llvm.org/viewvc/llvm-project?rev=342409&view=rev Log: [analyzer] Treat std::{move,forward} as casts in ExprMutationAnalyzer. Summary: This is a follow up of D52008 and should make the analyzer being able to handle

  1   2   >