Author: d0k
Date: Fri Sep 14 11:05:30 2018
New Revision: 342252
URL: http://llvm.org/viewvc/llvm-project?rev=342252&view=rev
Log:
[modernize-use-transparent-functors] TypeLocs can be implicitly created, don't
crash when encountering those.
Modified:
clang-tools-extra/trunk/clang-tidy/moderni
shuaiwang updated this revision to Diff 165552.
shuaiwang marked 8 inline comments as done.
shuaiwang added a comment.
Addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D52008
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
lib/Analysis/ExprMutationAn
shuaiwang added a comment.
In https://reviews.llvm.org/D52008#1234828, @JonasToth wrote:
> The `std::move` as cast is a follow up patch?
Yes I'll send a follow up patch.
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:381
+FunctionParmMutationAnalyzer::findMutation(const P
Author: sammccall
Date: Fri Sep 14 11:49:16 2018
New Revision: 342261
URL: http://llvm.org/viewvc/llvm-project?rev=342261&view=rev
Log:
[clangd] Work around compiler macro expansion bugs(?) in completion tests
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified:
george.karpenkov created this revision.
george.karpenkov added reviewers: NoQ, rsmith, aprantl.
https://reviews.llvm.org/D52113
Files:
clang/include/clang/AST/DeclBase.h
clang/lib/AST/DeclBase.cpp
Index: clang/lib/AST/DeclBase.cpp
Meinersbur created this revision.
Meinersbur added reviewers: hfinkel, amusman, ABataev, tyler.nowicki.
Meinersbur added a dependency: D52116: Introduce llvm.loop.parallel_accesses
and llvm.access.group metadata..
Instead of generating llvm.mem.parallel_loop_access metadata, generate
llvm.access
JonasToth added a comment.
Soonish it might be able to do so ;)
Am 14.09.2018 um 17:13 schrieb Dávid Bolvanský via Phabricator:
> xbolva00 added a comment.
>
> Yeah, it would be super useful if Clang can add const to all places where
> possible :) love this work, great!
>
> Repository:
>
>
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:381
+FunctionParmMutationAnalyzer::findMutation(const ParmVarDecl *Parm) {
+ const auto Memoized = Results.find(
JonasToth updated this revision to Diff 165568.
JonasToth added a comment.
- fix actually use clang-analyses correctly
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.
ldionne updated this revision to Diff 165569.
ldionne added a comment.
Change no_extern_template to exclude_from_explicit_instantiation
Repository:
rC Clang
https://reviews.llvm.org/D51789
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/AttrDocs.td
clang/include/clan
Author: jonastoth
Date: Fri Sep 14 12:42:37 2018
New Revision: 342267
URL: http://llvm.org/viewvc/llvm-project?rev=342267&view=rev
Log:
[NFC][clangd] silence pedantic extra ';' warning
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-tools-extra/trunk/
Meinersbur created this revision.
Meinersbur added reviewers: hfinkel, jdoerfert.
getLoopID has different control flow for two cases: If there is a single loop
latch and for any other number of loop latches (0 and more than one). The
latter case should return the same result if there is a single
Author: shuaiwang
Date: Fri Sep 14 13:07:18 2018
New Revision: 342271
URL: http://llvm.org/viewvc/llvm-project?rev=342271&view=rev
Log:
[analyzer] Handle forwarding reference better in ExprMutationAnalyzer.
Summary:
We used to treat an `Expr` mutated whenever it's passed as non-const
reference ar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342271: [analyzer] Handle forwarding reference better in
ExprMutationAnalyzer. (authored by shuaiwang, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
shuaiwang created this revision.
shuaiwang added reviewers: lebedev.ri, JonasToth.
Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin,
szepet, xazax.hun.
Herald added a reviewer: george.karpenkov.
This is a follow up of https://reviews.llvm.org/D52008 and should make the
shuaiwang added a comment.
@lebedev.ri could you help test whether this fully resolves PR38891? Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
lebedev.ri added a comment.
In https://reviews.llvm.org/D52120#1235479, @shuaiwang wrote:
> @lebedev.ri could you help test whether this fully resolves PR38891? Thanks!
That is what i'm trying to do here :)
Still waiting for the build to finish...
Repository:
rC Clang
https://reviews.llvm.
tks2103 added a comment.
ping @GorNishanov
Repository:
rC Clang
https://reviews.llvm.org/D51741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:164
+ // - sizeof(dst)
+ if (Append && isSizeof(LenArg, DstArg))
+return true;
george.karpenkov wrote:
> george.karpenkov wrote:
> > george.karpenkov wrote:
> >
Author: rnk
Date: Fri Sep 14 13:50:39 2018
New Revision: 342281
URL: http://llvm.org/viewvc/llvm-project?rev=342281&view=rev
Log:
Relax assumption about default method calling convention in new test
Modified:
cfe/trunk/test/CodeGenCXX/debug-info-lambda.cpp
Modified: cfe/trunk/test/CodeGenCXX
Author: rnk
Date: Fri Sep 14 13:51:07 2018
New Revision: 342282
URL: http://llvm.org/viewvc/llvm-project?rev=342282&view=rev
Log:
Mark index-tools.test as REQUIRES: shell so that it does not run with the
internal lit shell which does not support "if"
Modified:
clang-tools-extra/trunk/test/cl
That construct does not work on Windows, where we don't use bash. We use
the lit internal shell, which doesn't support 'if [ ...]'. I marked it
REQUIRES: shell in r342282.
On Wed, Sep 12, 2018 at 2:29 AM Kirill Bobyrev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: omtcyfz
> Date:
devnexen added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:199
+if (Append)
+ RemainingBufferLen -= 1;
+if (RemainingBufferLen < ILRawVal)
MaskRay wrote:
> `RemainingBufferLen` is `uint64_t`. Can the
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Thank you for working on this!
In https://reviews.llvm.org/D52120#1235480, @lebedev.ri wrote:
> In https://reviews.llvm.org/D52120#1235479, @shuaiwang wrote:
>
> > @lebedev.ri could yo
vlad.tsyrklevich added a comment.
In https://reviews.llvm.org/D51905#1234308, @zhaomo wrote:
> In https://reviews.llvm.org/D51905#1231383, @vlad.tsyrklevich wrote:
>
> > This change causes all compiler-rt cfi tests to be UNSUPPORTED for me
> > locally, do you have any idea why that might be? The
Oh, I see. Thank you very much for fixing it!
I had concerns about platform dependence, but I’ve seen seen some tests in
libcxx which use `if […]` so I thought it should be alright (because there was
no REQUIRES there). I can see now, that it is a Darwin test, my bad.
Again, thank you very much
sammccall updated this revision to Diff 165593.
sammccall marked 9 inline comments as done.
sammccall added a comment.
Unify common completion code from angled/quoted strings in Lexer.
Handle #include paths with \ on windows (normalize them to /)
Document why we picked particular extensions for he
sammccall added a comment.
Addressed the comments I was sure about.
A couple of open questions in SemaCodeComplete about the formatting of the
completions, but want to know what you think.
Comment at: lib/Sema/SemaCodeComplete.cpp:8046
+ !EC && It != vfs::directory_ite
Author: maskray
Date: Fri Sep 14 14:36:35 2018
New Revision: 342290
URL: http://llvm.org/viewvc/llvm-project?rev=342290&view=rev
Log:
test/Driver/output-file-cleanup.c: delete non-readable temporary file
%t-dir/2.c made tools (rsync, ripgrep, ...) sad (EACCES warning).
Modified:
cfe/trunk/te
MaskRay added inline comments.
Comment at: test/Analysis/cstring-syntax.c:49
+ strlcat(dest, "0123456789", badlen / 2);
+ strlcat(dest, "0123456789", badlen); // expected-warning {{The third
argument allows to potentially copy more bytes than it should. Replace with the
value
devnexen updated this revision to Diff 165604.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This is definitely the right thing to do, thanks for finding it!
I've got a long comment about how everything used to be simpler in the good old
days :-) I'm itching to refactor a bit, bu
vsapsai commandeered this revision.
vsapsai added a reviewer: pete.
vsapsai added a comment.
Taking over the change, I'll address the reviewers' comments.
https://reviews.llvm.org/D30882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
vsapsai updated this revision to Diff 165610.
vsapsai added a comment.
- Improve tests, fix -MMD, address comments.
https://reviews.llvm.org/D30882
Files:
clang/include/clang/Lex/PPCallbacks.h
clang/lib/Frontend/DependencyFile.cpp
clang/lib/Lex/PPMacroExpansion.cpp
clang/test/Frontend/d
rsmith added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:551
if (Decl->isMain() || !Decl->isUserProvided() ||
-Decl->isUsualDeallocationFunction() ||
-Decl->isCopyAssignmentOperator() || Decl->isMoveAssignm
vsapsai marked 3 inline comments as done.
vsapsai added inline comments.
Comment at: include/clang/Lex/PPCallbacks.h:263
+ /// \brief Callback invoked when a has_include directive is read.
+ virtual void HasInclude(SourceLocation Loc, const FileEntry *File) {
+ }
-
vsapsai marked 2 inline comments as done.
vsapsai added inline comments.
Comment at: lib/Frontend/DependencyFile.cpp:325
+void DFGImpl::HasInclude(SourceLocation Loc, const FileEntry *File) {
+ if (!File)
+return;
rsmith wrote:
> Have you thought about wheth
bruno updated this revision to Diff 165612.
bruno added a comment.
Addressed Adrian's review. Added support to consider the environment and well
the combination platform-environment. @aprantl also handled multiple variants
of simulator combinations.
https://reviews.llvm.org/D51910
Files:
do
rsmith added inline comments.
Comment at: lib/Frontend/DependencyFile.cpp:325
+void DFGImpl::HasInclude(SourceLocation Loc, const FileEntry *File) {
+ if (!File)
+return;
vsapsai wrote:
> rsmith wrote:
> > Have you thought about whether we should add a depen
aprantl added inline comments.
Comment at: docs/Modules.rst:470
+*platform variant*
+ A specific os/platform variant (e.g. ``ios``, ``macos``, ``android``,
``win32``, ``linux``, etc) is available.
aprantl wrote:
> Does this work with platforms+environment com
rsmith added inline comments.
Comment at: clang/lib/Frontend/DependencyFile.cpp:340
+return;
+ StringRef Filename = File->getName();
+ if (!FileMatchesDepCriteria(Filename.data(), FileType))
Should we really be using the (arbitrary) name of the file from th
aprantl added inline comments.
Comment at: lib/Basic/Module.cpp:101
+ // variant (2), the simulator is hardcoded as part of the platform name. Both
+ // forms above should match "iossimulator" and "ios-simulator" features.
+ if (Target.getTriple().isOSDarwin() && PlatformEnv.e
rsmith added inline comments.
Comment at: docs/Modules.rst:476-477
+
+*platform-environment*
+ A platform-environment variant (e.g. ``linux-gnueabi``, ``windows-msvc``) is
available.
What is the reason to allow these to be combined into a single feature name
vsapsai added inline comments.
Comment at: clang/lib/Frontend/DependencyFile.cpp:300-304
StringRef Filename = FE->getName();
if (!FileMatchesDepCriteria(Filename.data(), FileType))
return;
AddFilename(llvm::sys::path::remove_leading_dotslash(Filename));
--
rsmith accepted this revision.
rsmith added inline comments.
Comment at: clang/lib/Frontend/DependencyFile.cpp:340
+return;
+ StringRef Filename = File->getName();
+ if (!FileMatchesDepCriteria(Filename.data(), FileType))
vsapsai wrote:
> rsmith wrote:
> >
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
We're getting pretty good at it ^^
https://reviews.llvm.org/D52113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
rsmith added a comment.
Looks good other than the warning, which I don't yet understand.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4683-4686
+ "Member '%0' marked with 'exclude_from_explicit_instantiation' attribute is "
+ "not defined but an explicit templ
Author: rsmith
Date: Fri Sep 14 18:21:15 2018
New Revision: 342304
URL: http://llvm.org/viewvc/llvm-project?rev=342304&view=rev
Log:
[modules] Frontend support for building a header module from a list of
headaer files.
Added:
cfe/trunk/test/Modules/Inputs/no-module-map/
cfe/trunk/test/Mod
Author: rsmith
Date: Fri Sep 14 18:21:18 2018
New Revision: 342306
URL: http://llvm.org/viewvc/llvm-project?rev=342306&view=rev
Log:
[modules] Support use of -E on modules built from the command line.
Modified:
cfe/trunk/lib/Frontend/FrontendAction.cpp
cfe/trunk/lib/Frontend/FrontendActio
Author: rsmith
Date: Fri Sep 14 18:21:16 2018
New Revision: 342305
URL: http://llvm.org/viewvc/llvm-project?rev=342305&view=rev
Log:
[modules] Driver support for precompiling a collection of files as a single
action.
Added:
cfe/trunk/test/Driver/header-module.cpp
Modified:
cfe/trunk/inclu
malaperle added a comment.
why?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri Sep 14 18:59:39 2018
New Revision: 342307
URL: http://llvm.org/viewvc/llvm-project?rev=342307&view=rev
Log:
[modules] Don't bother creating a global module fragment when building a
header module.
Modified:
cfe/trunk/lib/Sema/Sema.cpp
Modified: cfe/trunk/lib/Sema/Sema
Author: george.karpenkov
Date: Fri Sep 14 19:01:26 2018
New Revision: 342308
URL: http://llvm.org/viewvc/llvm-project?rev=342308&view=rev
Log:
[analyzer] Skip printing duplicate nodes, even if nodes have multiple
predecessors/successors
Still generate a node, but leave the redundant field empty.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342308: [analyzer] Skip printing duplicate nodes, even if
nodes have multiple… (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://rev
Author: george.karpenkov
Date: Fri Sep 14 19:02:31 2018
New Revision: 342311
URL: http://llvm.org/viewvc/llvm-project?rev=342311&view=rev
Log:
StmtPrinter: allow customizing the end-of-line character
Differential Revision: https://reviews.llvm.org/D51824
Modified:
cfe/trunk/include/clang/AST
Author: george.karpenkov
Date: Fri Sep 14 19:01:47 2018
New Revision: 342309
URL: http://llvm.org/viewvc/llvm-project?rev=342309&view=rev
Log:
Support generating unique identifiers for Stmt objects
The generated identifiers are stable across multiple runs, and can be a
great debug or visualizatio
Author: george.karpenkov
Date: Fri Sep 14 19:02:09 2018
New Revision: 342310
URL: http://llvm.org/viewvc/llvm-project?rev=342310&view=rev
Log:
[analyzer] Dump unique identifiers for statements in exploded graph
Differential Revision: https://reviews.llvm.org/D51823
Modified:
cfe/trunk/lib/St
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342309: Support generating unique identifiers for Stmt
objects (authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51822?vs=164547&id=165625#toc
Repository
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342311: StmtPrinter: allow customizing the end-of-line
character (authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
Author: george.karpenkov
Date: Fri Sep 14 19:02:56 2018
New Revision: 342312
URL: http://llvm.org/viewvc/llvm-project?rev=342312&view=rev
Log:
[analyzer] Use correct end-of-line character when printing statements for
exploded graph
Prevents bad centering.
Differential Revision: https://reviews.
Author: george.karpenkov
Date: Fri Sep 14 19:03:17 2018
New Revision: 342313
URL: http://llvm.org/viewvc/llvm-project?rev=342313&view=rev
Log:
[analyzer] Dump reproducible identifiers for statements in exploded graph in
store
Differential Revision: https://reviews.llvm.org/D51826
Modified:
Author: george.karpenkov
Date: Fri Sep 14 19:03:36 2018
New Revision: 342314
URL: http://llvm.org/viewvc/llvm-project?rev=342314&view=rev
Log:
[analyzer] Generate and use stable identifiers for LocationContext
Those are not created in the allocator.
Since they are created fairly rarely, a counter
Author: george.karpenkov
Date: Fri Sep 14 19:03:58 2018
New Revision: 342315
URL: http://llvm.org/viewvc/llvm-project?rev=342315&view=rev
Log:
Generate unique identifiers for Decl objects
The generated identifier is stable across multiple runs,
and can be a great visualization or debugging aide.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342315: Generate unique identifiers for Decl objects
(authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52113?vs=165564&id=165631#toc
Repository:
rC Cla
Author: george.karpenkov
Date: Fri Sep 14 19:34:45 2018
New Revision: 342316
URL: http://llvm.org/viewvc/llvm-project?rev=342316&view=rev
Log:
[analyzer] Further printing improvements: use declarations,
skip pointers whenever redundant, use unique prefixes.
Differential Revision: https://reviews
Author: george.karpenkov
Date: Fri Sep 14 19:35:06 2018
New Revision: 342317
URL: http://llvm.org/viewvc/llvm-project?rev=342317&view=rev
Log:
[analyzer] Temporary disabling svalbuilder-rearrange-comparisons test
As debug printing has changed, and format was not guaranteed to be
stable.
Artem is
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342316: [analyzer] Further printing improvements: use
declarations, (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.o
phosek created this revision.
phosek added reviewers: mcgrathr, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
This ensures that whether the user uses short or cannonical version
of the triple, Clang will still find the runtimes under the cannonical
triple name.
Repository:
rC Cl
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs, baloghadamsoftware.
Herald added subscribers: cfe-commits, Szelethus, jfb, mikhail.ramalho.
A test introduced in https://reviews.llvm.org/rC329780 was disabled in
https://reviews.
lebedev.ri added inline comments.
Comment at: lib/Driver/ToolChains/Linux.cpp:674
// removing them.
- "/usr/include/i686-linux-gnu/64", "/usr/include/i486-linux-gnu/64"};
const StringRef X86MultiarchIncludeDirs[] = {
This *might* be what clang-form
ioeric added inline comments.
Comment at: clangd/index/FileIndex.h:93
std::pair
indexAST(ASTContext &AST, std::shared_ptr PP,
+ bool IndexMacros = false,
sammccall wrote:
> I'm concerned about the proliferation of parameters here. (Not new with this
>
ioeric added a comment.
In https://reviews.llvm.org/D52089#1235777, @malaperle wrote:
> why?
I wanted to get some numbers and update the patch summary, but somehow forgot.
Sorry about that and thanks for asking!
The AST matcher pops up in performance profile. Although not the most expensive
101 - 173 of 173 matches
Mail list logo
