sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
The dir component ("somedir" in #include ) is considered fixed.
We append "foo" to each directory on the include path, and then list its files.
Completions are of the forms:
^-te
kbobyrev updated this revision to Diff 165437.
kbobyrev added a comment.
- Start measuring time in ms
- Add Tokens' `Data` size for more precise memory usage estimation (accounts
for ~1MB of Static Index in LLVM)
https://reviews.llvm.org/D52047
Files:
clang-tools-extra/clangd/benchmarks/Inde
kbobyrev updated this revision to Diff 165440.
kbobyrev added a comment.
Move `vlog` message to the outer `build(...)` function: otherwise
`BackingMemorySize` is not set to the correct value and log reports index
overhead (instead of the complete index + slab) size.
https://reviews.llvm.org/D5
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Pros:
o Loading macros from preamble for every completion is slow (see profile).
o Calculating macro USR is also slow (see profile).
o Sema c
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D52079
Files:
include/clang/Sema/CodeCompleteOptions.h
lib/Sema/SemaCodeComplete.cpp
Index: lib/Sema/SemaCodeComplete.cpp
===
ioeric updated this revision to Diff 165444.
ioeric added a comment.
- minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52078
Files:
clangd/ClangdServer.cpp
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
unittests/clangd/CodeCompleteTests.cpp
unittest
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rC Clang
https://reviews.llvm.org/D51921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Author: sylvestre
Date: Fri Sep 14 01:52:18 2018
New Revision: 342211
URL: http://llvm.org/viewvc/llvm-project?rev=342211&view=rev
Log:
gcc is now returning the same output on this example, removing this example
Modified:
cfe/trunk/www/diagnostics.html
Modified: cfe/trunk/www/diagnostics.htm
Author: sylvestre
Date: Fri Sep 14 01:55:09 2018
New Revision: 342212
URL: http://llvm.org/viewvc/llvm-project?rev=342212&view=rev
Log:
update the doc to compare with gcc 4.9 instead of 4.2
Modified:
cfe/trunk/www/features.html
Modified: cfe/trunk/www/features.html
URL:
http://llvm.org/view
Author: szelethus
Date: Fri Sep 14 01:58:21 2018
New Revision: 342213
URL: http://llvm.org/viewvc/llvm-project?rev=342213&view=rev
Log:
[analyzer][UninitializedObjectChecker] Fixed dereferencing
iThis patch aims to fix derefencing, which has been debated for months now.
Instead of working with S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342213: [analyzer][UninitializedObjectChecker] Fixed
dereferencing (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D510
Author: sylvestre
Date: Fri Sep 14 02:00:48 2018
New Revision: 342214
URL: http://llvm.org/viewvc/llvm-project?rev=342214&view=rev
Log:
remove 11 years old videos from the homepage. if you have a suggestion, please
drop me an email
Modified:
cfe/trunk/www/index.html
Modified: cfe/trunk/www/
Author: szelethus
Date: Fri Sep 14 02:07:40 2018
New Revision: 342215
URL: http://llvm.org/viewvc/llvm-project?rev=342215&view=rev
Log:
[analyzer][UninitializedObjectChecker] Updated comments
Some of the comments are incorrect, imprecise, or simply nonexistent.
Since I have a better grasp on how
Author: sylvestre
Date: Fri Sep 14 02:08:21 2018
New Revision: 342216
URL: http://llvm.org/viewvc/llvm-project?rev=342216&view=rev
Log:
Use Chrome and Firefox as example of success for clang
Modified:
cfe/trunk/www/index.html
Modified: cfe/trunk/www/index.html
URL:
http://llvm.org/viewvc/ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342215: [analyzer][UninitializedObjectChecker] Updated
comments (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51417?
Author: szelethus
Date: Fri Sep 14 02:13:36 2018
New Revision: 342217
URL: http://llvm.org/viewvc/llvm-project?rev=342217&view=rev
Log:
[analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for
record pointees
Differential Revision: https://reviews.llvm.org/D50892
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342217: [analyzer][UninitializedObjectChecker] Correct
dynamic type is acquired for… (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Neat, I was unaware that single-file mode completions actually work nicely in
that case.
LGTM!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52071
_
Author: szelethus
Date: Fri Sep 14 02:39:26 2018
New Revision: 342219
URL: http://llvm.org/viewvc/llvm-project?rev=342219&view=rev
Log:
[analyzer][UninitializedObjectChecker] Refactored checker options
Since I plan to add a number of new flags, it made sense to encapsulate
them in a new struct, i
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342219: [analyzer][UninitializedObjectChecker] Refactored
checker options (authored by Szelethus, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51679?vs=164009&id=165449#toc
Reposi
Szelethus marked an inline comment as done.
Szelethus added inline comments.
Comment at: test/Analysis/cxx-uninitialized-object-unionlike-constructs.cpp:1-4
+// RUN: %clang_analyze_cc1
-analyzer-checker=core,alpha.cplusplus.UninitializedObject \
+// RUN: -analyzer-config alpha
Author: szelethus
Date: Fri Sep 14 03:10:09 2018
New Revision: 342220
URL: http://llvm.org/viewvc/llvm-project?rev=342220&view=rev
Log:
[analyzer][UninitializedObjectChecker] New flag to ignore records based on it's
fields
Based on a suggestion from @george.karpenkov.
In some cases, structs are
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342220: [analyzer][UninitializedObjectChecker] New flag to
ignore records based on it's… (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https:/
andobence updated this revision to Diff 165453.
andobence added a comment.
Fixed everything mentioned in comments.
https://reviews.llvm.org/D51332
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp
clang-tidy/modernize/DeprecatedIosBaseAliase
Author: szelethus
Date: Fri Sep 14 03:18:26 2018
New Revision: 342221
URL: http://llvm.org/viewvc/llvm-project?rev=342221&view=rev
Log:
[analyzer][UninitializedObjectChecker] Support for nonloc::LocAsInteger
Differential Revision: https://reviews.llvm.org/D49437
Modified:
cfe/trunk/lib/Stat
kadircet updated this revision to Diff 165462.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Add matchers to test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51747
Files:
clangd/ClangdServer.cpp
unittests/clangd/ClangdTests.cpp
Index: unittest
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Use min-heap invariant for OR iterator's children. This helps to avoid
iterating through all chi
glaubitz added a comment.
I don't have commit access, btw. So it would be nice if someone else could
commit this for me.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
kadircet added a comment.
In https://reviews.llvm.org/D51747#1233530, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D51747#1233499, @kadircet wrote:
>
> > Np, not planning to land it before we figure out the issue with vim can't
> > handling lots of diagnostics anyway.
>
>
> Just wondering
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Raw posting list iterator's `dump()` was changed in
https://reviews.llvm.org/rCTE342155, but the
ilya-biryukov added a comment.
Amazing, can't wait for it to land!
Comment at: lib/Lex/Lexer.cpp:1931
+ StringRef PartialPath(AfterQuote, CurPtr - 1 - AfterQuote);
+ auto Slash = PartialPath.rfind('/');
+ StringRef Dir =
It's also val
andobence marked 2 inline comments as done.
andobence added inline comments.
Comment at: clang-tidy/modernize/DeprecatedIosBaseAliasesCheck.cpp:34
+ // provide any benefit to other languages, despite being benign.
+ if (!getLangOpts().CPlusPlus)
+return;
Jo
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:128
+// Return LHS > RHS.
+auto Compare = [](const std::unique_ptr &LHS,
NIT: use triple-slash comments.
NIT: LHS > RHS seems to be exactly what's defined by this f
LukeCheeseman updated this revision to Diff 165467.
LukeCheeseman added a comment.
- updated tests to check the default a_key attribute is included in functions
that have the return address signing scope attribute
- setting the return-address-sign-key attribute of global static constructors
htt
miyuki updated this revision to Diff 165469.
miyuki retitled this revision from "[Analyzer] Make plist tests less fragile"
to "[Analyzer] Use diff_plist in tests, NFC".
miyuki edited the summary of this revision.
miyuki added a comment.
Use a different approach (suggested by Artem).
https://rev
ilya-biryukov added a comment.
~1% increase in memory usage seems totally fine. Actually surprised it's that
small.
Overall LG, just a single comment about extra copying. Thanks for the change,
looks like a great improvement!
Comment at: clangd/index/FileIndex.cpp:84
+Mer
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:128
+// Return LHS > RHS.
+auto Compare = [](const std::unique_ptr &LHS,
ilya-biryukov wrote:
> NIT: use triple-slash comments.
> NIT: LHS > RHS seems to be exactly
This introduced revision introduced a new warning:
../tools/clang/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:62:7:
warning: '(anonymous namespace)::NeedsCastLocField' has virtual functions
but non-virtual destructor [-Wnon-virtual-dtor]
Which is turned into an error o
Ah, the reason why it does not fire on other inheritors is because they're
final. Any reason to remove final from NeedsCastLocField?
On Fri, Sep 14, 2018 at 1:17 PM Ilya Biryukov wrote:
> This introduced revision introduced a new warning:
> ../tools/clang/lib/StaticAnalyzer/Checkers/Uninitialize
Author: szelethus
Date: Fri Sep 14 04:20:16 2018
New Revision: 342223
URL: http://llvm.org/viewvc/llvm-project?rev=342223&view=rev
Log:
[analyzer] Attempt to make a windows buildbot happy.
Got an error that a cast is happening from a pointer type to long, which is
smaller.
Modified:
cfe/trun
Author: ibiryukov
Date: Fri Sep 14 04:28:48 2018
New Revision: 342225
URL: http://llvm.org/viewvc/llvm-project?rev=342225&view=rev
Log:
[analyzer] Restore final on NeedsCastLocField. NFC
To fix compiler warning about non-virtual dtor introduced in r342221.
Modified:
cfe/trunk/lib/StaticAnal
Szelethus added a comment.
Cool! Looks a lot cleaner.
https://reviews.llvm.org/D52036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I've sent a quick workaround restoring final (r342225) to unbreak our
internal buildbots.
On Fri, Sep 14, 2018 at 1:20 PM Ilya Biryukov wrote:
> Ah, the reason why it does not fire on other inheritors is because they're
> final. Any reason to remove final from NeedsCastLocField?
>
> On Fri, Sep
ioeric added inline comments.
Comment at: clangd/index/FileIndex.cpp:84
+Merged.insert(Macro);
+ for (const auto &Sym : Collector.takeSymbols())
+Merged.insert(Sym);
ilya-biryukov wrote:
> Why make an extra copy of the symbols? Why not add macros to the
Author: ibiryukov
Date: Fri Sep 14 04:39:05 2018
New Revision: 342226
URL: http://llvm.org/viewvc/llvm-project?rev=342226&view=rev
Log:
[clangd] Update IndexerMain.cpp file comment after rename. NFC
Modified:
clang-tools-extra/trunk/clangd/indexer/IndexerMain.cpp
Modified: clang-tools-extra/
ilya-biryukov added inline comments.
Comment at: clangd/index/FileIndex.cpp:84
+Merged.insert(Macro);
+ for (const auto &Sym : Collector.takeSymbols())
+Merged.insert(Sym);
ioeric wrote:
> ilya-biryukov wrote:
> > Why make an extra copy of the symbols? W
kbobyrev updated this revision to Diff 165471.
kbobyrev marked 3 inline comments as done.
kbobyrev edited the summary of this revision.
kbobyrev added a comment.
Fixed the bug with incorrect assumption of `Children` being sorted (instead of
being a heap). This caused a huge overhead (~30%). When
Author: omtcyfz
Date: Fri Sep 14 05:21:09 2018
New Revision: 342227
URL: http://llvm.org/viewvc/llvm-project?rev=342227&view=rev
Log:
[clangd] NFC: Fix IndexBenchmark CLI arguments handling
Modified:
clang-tools-extra/trunk/clangd/benchmarks/IndexBenchmark.cpp
Modified: clang-tools-extra/tru
Author: sammccall
Date: Fri Sep 14 05:24:09 2018
New Revision: 342228
URL: http://llvm.org/viewvc/llvm-project?rev=342228&view=rev
Log:
[Tooling] JSONCompilationDatabasePlugin infers compile commands for missing
files
Summary:
See the existing InterpolatingCompilationDatabase for details on how
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342228: [Tooling] JSONCompilationDatabasePlugin infers
compile commands for missing… (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51729?vs=164192&id=165472#
kristina accepted this revision.
kristina added a comment.
This revision is now accepted and ready to land.
LGTM.
In the future please make sure you supply all patches with context (ie.
`-U9`), without context they may be harder to review and more importantly
`patch` may mess up.
Reposito
Author: sammccall
Date: Fri Sep 14 05:32:08 2018
New Revision: 342229
URL: http://llvm.org/viewvc/llvm-project?rev=342229&view=rev
Log:
[clangd] Don't double-infer compile commands after r342228
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
Modified: clang-tools-extr
Author: sammccall
Date: Fri Sep 14 05:36:06 2018
New Revision: 342230
URL: http://llvm.org/viewvc/llvm-project?rev=342230&view=rev
Log:
[clangd] Don't override the preamble while completing inside it, it doesn't
work.
Summary:
To stay fast, enable single-file-mode instead. This is fine since com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342230: [clangd] Don't override the preamble while
completing inside it, it doesn't… (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342230: [clangd] Don't override the preamble while
completing inside it, it doesn't… (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52071?vs=165421&id=16547
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342231: [Driver] Fix missing MultiArch include dir on
powerpcspe (authored by kristina, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D52066
Files:
lib/Driver/ToolChains/Linux.cpp
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342231: [Driver] Fix missing MultiArch include dir on
powerpcspe (authored by kristina, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52066?
Author: kristina
Date: Fri Sep 14 05:42:13 2018
New Revision: 342231
URL: http://llvm.org/viewvc/llvm-project?rev=342231&view=rev
Log:
[Driver] Fix missing MultiArch include dir on powerpcspe
On powerpc-linux-gnuspe, the header files are located in their
own include directory named /usr/lib/power
On Fri, Sep 14, 2018 at 3:21 PM, Kirill Bobyrev via cfe-commits
wrote:
> Author: omtcyfz
> Date: Fri Sep 14 05:21:09 2018
> New Revision: 342227
>
> URL: http://llvm.org/viewvc/llvm-project?rev=342227&view=rev
> Log:
> [clangd] NFC: Fix IndexBenchmark CLI arguments handling
>
> Modified:
> cla
Author: sammccall
Date: Fri Sep 14 05:47:38 2018
New Revision: 342232
URL: http://llvm.org/viewvc/llvm-project?rev=342232&view=rev
Log:
[VFS] vfs::directory_iterator yields path and file type instead of full Status
Summary:
Most callers I can find are using only `getName()`. Type is used by the
r
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342232: [VFS] vfs::directory_iterator yields path and file
type instead of full Status (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51921?vs=165250&id=16548
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52089
Files:
clangd/index/SymbolCollector.cpp
Index: clangd/index/SymbolCollector.c
lebedev.ri added inline comments.
Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:701
"/usr/include/mips64el-linux-gnuabi64"};
const StringRef PPCMultiarchIncludeDirs[] = {
+ "/usr/include/powerpc-linux-gnu",
This is probably missing test cov
glaubitz added a comment.
Not sure how this is supposed to be tested as this requires a proper Debian
powerpcspe chroot.
I also checked saw that not all mips64 include paths are covered by the
testsuite.
Repository:
rL LLVM
https://reviews.llvm.org/D52066
___
sammccall added a comment.
Thanks a lot, great comments!
I haven't made changes yet (I will) but there's a few questions to work out
first...
Comment at: lib/Lex/Lexer.cpp:1931
+ StringRef PartialPath(AfterQuote, CurPtr - 1 - AfterQuote);
+ auto Slash = Parti
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
kristina created this revision.
kristina added a reviewer: rsmith.
kristina added a project: clang.
Herald added a subscriber: cfe-commits.
Currently it seems like a mess in terms of where newlines are used. Cleaning it
up so all of them use newlines and are aligned and moving the default switch
JDevlieghere added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3126
+ } else {
+templateParameters = nullptr;//llvm::DINodeArray().get();
+ }
What's the meaning of this comment?
Comment at: lib/CodeGen/CGDebugInfo.h:654
+
nemanjai added a comment.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D52074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonasToth added a comment.
The `std::move` as cast is a follow up patch?
From my side only the nits are left.
Comment at: lib/Analysis/ExprMutationAnalyzer.cpp:333
+const auto *Parm = Nodes.getNodeAs("parm");
+const auto AllParams =
+Func->getPrimaryTemplate()-
JonasToth added a comment.
LG from my side, please rebase that patch on top of master. Currently the
Release Notes would conflict (and please sort the release note alphabetically).
If the other reviewers do not say anything within a reasonable time it can be
committed. Do you have commit rights
JonasToth added a comment.
And i forgot: Could you please run this over a real code base, if you know one
that actually uses these types?
I assume not so many code bases actually use these.
https://reviews.llvm.org/D51332
___
cfe-commits mailing li
JonasToth marked 9 inline comments as done.
JonasToth added a comment.
I do consider the diagnostic thing as resolved given the lack of further
comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48714
___
cfe-commits mailing
JonasToth updated this revision to Diff 165497.
JonasToth added a comment.
- update to ExprMutAnalyzer living in clang now
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/ConstCorrectnessCh
Author: ldionne
Date: Fri Sep 14 07:07:16 2018
New Revision: 342238
URL: http://llvm.org/viewvc/llvm-project?rev=342238&view=rev
Log:
[clang] Make sure attributes on member classes are applied properly
Summary:
Attributes on member classes of class templates and member class templates
of class te
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342238: [clang] Make sure attributes on member classes are
applied properly (authored by ldionne, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51997?vs=165375&id=165502#toc
Reposi
ldionne updated this revision to Diff 165507.
ldionne added a comment.
Fix the tests and remove some warnings that I wasn't able to generate properly
(to avoid false positives).
Repository:
rC Clang
https://reviews.llvm.org/D51789
Files:
clang/include/clang/Basic/Attr.td
clang/include/cl
ldionne added a comment.
I think now's a good time to bikeshed the name of the attribute if you have
other suggestions.
Repository:
rC Clang
https://reviews.llvm.org/D51789
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
patricklyster created this revision.
patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice,
kkwli0, hfinkel, gtbercea.
patricklyster added projects: OpenMP, clang.
Herald added subscribers: cfe-commits, jfb, guansong.
Move declarations for `OMPClauseReader`, `OMPClauseWrit
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, mgorny.
Also added unit tests for the index library; lit+c-index-test is painful...
Repository:
rC Clang
https://reviews.llvm.org/D52098
Files:
include/clang/Index/IndexingAction.h
ioeric updated this revision to Diff 165514.
ioeric added a comment.
- remove debug message.
Repository:
rC Clang
https://reviews.llvm.org/D52098
Files:
include/clang/Index/IndexingAction.h
lib/Index/IndexingAction.cpp
unittests/CMakeLists.txt
unittests/Index/CMakeLists.txt
unittes
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
https://reviews.llvm.org/D52097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
xbolva00 added a comment.
Yeah, it would be super useful if Clang can add const to all places where
possible :) love this work, great!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
___
cfe-commits mailing list
cfe-commits@li
ioeric updated this revision to Diff 165516.
ioeric added a comment.
- another cleanup...
Repository:
rC Clang
https://reviews.llvm.org/D52098
Files:
include/clang/Index/IndexingAction.h
lib/Index/IndexingAction.cpp
unittests/CMakeLists.txt
unittests/Index/CMakeLists.txt
unittests/
Author: hans
Date: Fri Sep 14 08:18:30 2018
New Revision: 342240
URL: http://llvm.org/viewvc/llvm-project?rev=342240&view=rev
Log:
[clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit
instantiation and PCH
The code in ASTContext::DeclMustBeEmitted was supposed to handle
ioeric updated this revision to Diff 165517.
ioeric added a comment.
- Move macro collection to indexTopLevelDecls.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52078
Files:
clangd/ClangdServer.cpp
clangd/FindSymbols.cpp
clangd/XRefs.cpp
clangd/index/FileIndex.cpp
c
ioeric added a comment.
In https://reviews.llvm.org/D52078#1234667, @ilya-biryukov wrote:
> ~1% increase in memory usage seems totally fine. Actually surprised it's that
> small.
Tested on a larger file: it's ~5% for `ClangdServer.cpp`. I think it's still
worth it for the speedup.
ormris added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3126
+ } else {
+templateParameters = nullptr;//llvm::DINodeArray().get();
+ }
JDevlieghere wrote:
> What's the meaning of this comment?
Hmm... That should be removed.
Anastasia added a comment.
Ping! Do you still plan to do this? :)
Repository:
rC Clang
https://reviews.llvm.org/D43783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D51411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
rsmith added a comment.
In https://reviews.llvm.org/D51789#1234903, @ldionne wrote:
> I think now's a good time to bikeshed the name of the attribute if you have
> other suggestions.
OK, so the semantics of this attribute are "explicit instantiation declarations
or definitions applied to the
ldionne added a comment.
In https://reviews.llvm.org/D51789#1235096, @rsmith wrote:
> In https://reviews.llvm.org/D51789#1234903, @ldionne wrote:
>
> > I think now's a good time to bikeshed the name of the attribute if you have
> > other suggestions.
>
>
> OK, so the semantics of this attribute
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Thanks!
A substitution would probably need to be defined in a different file though.
https://reviews.llvm.org/D52036
___
cfe-
rsmith added a comment.
In https://reviews.llvm.org/D51789#1235100, @ldionne wrote:
> In https://reviews.llvm.org/D51789#1235096, @rsmith wrote:
>
> > OK, so the semantics of this attribute are "explicit instantiation
> > declarations or definitions applied to the enclosing class do not apply to
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Great, thanks! Seems that your code is a better version of this check.
Repository:
rC Clang
https://reviews.llvm.org/D51946
__
george.karpenkov added a comment.
This looks very useful!
Repository:
rC Clang
https://reviews.llvm.org/D52008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: shuaiwang
Date: Fri Sep 14 10:27:27 2018
New Revision: 342246
URL: http://llvm.org/viewvc/llvm-project?rev=342246&view=rev
Log:
Remove PseudoConstantAnalysis
Summary: It's not used anywhere for years. The last usage is removed in
https://reviews.llvm.org/rL198476 in 2014.
Subscribers: m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342246: Remove PseudoConstantAnalysis (authored by
shuaiwang, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51946
Files:
cfe/trunk/include/cl
yaxunl added a comment.
In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote:
> Ping! Do you still plan to do this? :)
Sorry I caught up in something else. Since there are some subsequent commits,
it may take some efforts to revert it.
Repository:
rC Clang
https://reviews.llvm.org
ldionne added a comment.
In https://reviews.llvm.org/D51789#1235113, @rsmith wrote:
> In https://reviews.llvm.org/D51789#1235100, @ldionne wrote:
>
> > In https://reviews.llvm.org/D51789#1235096, @rsmith wrote:
> >
> > > OK, so the semantics of this attribute are "explicit instantiation
> > > de
1 - 100 of 173 matches
Mail list logo
