NoQ requested changes to this revision.
NoQ added a comment.
This revision now requires changes to proceed.
Or, wait, hmm, no, we can still de-duplicate the reports with a global set
stored in the checker object. Because we would probably like to de-duplicate
across different paths as well.
ht
NoQ accepted this revision.
NoQ added inline comments.
This revision is now accepted and ready to land.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h:61-63
+ bool IsPedantic;
+ bool ShouldConvertNotesToWarnings;
+ bool CheckPointeeInitializ
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I hope we'll be able to come up with a reasonable default regex.
Comment at: test/Analysis/cxx-uninitialized-object-unionlike-constructs.cpp:1-4
+// RUN: %clang_analyze_cc1
-analy
zhaomo added a comment.
In https://reviews.llvm.org/D51905#1231383, @vlad.tsyrklevich wrote:
> This change causes all compiler-rt cfi tests to be UNSUPPORTED for me
> locally, do you have any idea why that might be? The lit changes don't make
> it immediately clear.
Not sure why that happened
zhaomo updated this revision to Diff 165415.
zhaomo added a comment.
Fixed issues pointed out by Peter and Vlad.
Richard:
I just saw comments but I will travel tomorrow and this weekend so I will reply
to your comments when I get a chance.
https://reviews.llvm.org/D51905
Files:
clang/inclu
shuaiwang updated this revision to Diff 165420.
shuaiwang marked 10 inline comments as done.
shuaiwang added a comment.
More test cases addressing review comments
Repository:
rC Clang
https://reviews.llvm.org/D52008
Files:
include/clang/Analysis/Analyses/ExprMutationAnalyzer.h
lib/Analys
shuaiwang added a comment.
In https://reviews.llvm.org/D52008#1232923, @lebedev.ri wrote:
> Thanks for working on this! I tried, and it appears to not fix the issue at
> hand.
>
> - ``` struct C1 { C1(const C1* c, int num); };
>
> int x = 0; auto y = std::make_unique(nullptr, x); // <- still
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
To stay fast, enable single-file-mode instead. This is fine since completions
in the preamble are simple.
The net effect for now is to
wuzish created this revision.
wuzish added reviewers: hfinkel, nemanjai, kbarton.
Herald added a subscriber: kristina.
> unsigned long long __builtin_unpack_vector_int128 (vector __int128_t, int);
> vector __int128_t __builtin_pack_vector_int128 (unsigned long long, unsigned
> long long);
Built
wuzish added a comment.
Please make this patch commit after https://reviews.llvm.org/D52072
Repository:
rC Clang
https://reviews.llvm.org/D52074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
201 - 210 of 210 matches
Mail list logo