[PATCH] D50359: Add a new library, libclang-cxx

kristina added a comment. To elaborate, consider a scenario where a customer wants to build the clang driver, `diagtool` and just for the sake of the argument `change-namespace` from extras. Clang tools do not provide nearly the same level of control as most LLVM tools, so in that scenario, you

[PATCH] D48581: [AArch64] Support reserving x1-7 registers.

trong updated this revision to Diff 165132. trong added a comment. Added test cases for combination of -ffixed flags. https://reviews.llvm.org/D48581 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/AArch64.cpp test/Driver/aarch64-fixe

[libcxx] r342073 - Implement the infrastructure for feature-test macros. Very few actual feature test macros, though. Reviewed as: https://reviews.llvm.org/D51955

Author: marshall Date: Wed Sep 12 12:41:40 2018 New Revision: 342073 URL: http://llvm.org/viewvc/llvm-project?rev=342073&view=rev Log: Implement the infrastructure for feature-test macros. Very few actual feature test macros, though. Reviewed as: https://reviews.llvm.org/D51955 Added: libcx

[PATCH] D51955: Create infrastructure for defining and testing feature test macros

mclow.lists closed this revision. mclow.lists added a comment. landed as revision 342073 https://reviews.llvm.org/D51955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52000: Feedback/direction Review for cpu-dispatch emit stage into GlobalDecl

erichkeane created this revision. erichkeane added a reviewer: rsmith. Herald added a subscriber: cfe-commits. In the feedback in https://reviews.llvm.org/D51650 (https://reviews.llvm.org/D51650), @rsmith points out an implementation detail of CPU-Dispatch is improperly done. I'd like to fix thi

[PATCH] D51905: Front-end of the implementation of the interleaving algorithm

zhaomo added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1767 + bool InBounds = shouldInterleaveVTables(VTableClass) ? false : true; return llvm::ConstantExpr::getGetElementPtr(VTable->getValueType(), VTable, pcc wrote: > Remind me why

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

manojgupta added a comment. What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount? __gnu_mcount_nc with "-pg" is known to be broken ( https://bugs.llvm.org/show_bug.cgi?id=33845) Repository: rC Clang https://reviews.llvm.org/D51713

r342078 - [Hexagon] Remove fp-contract=fast setting for at O3

Author: bcahoon Date: Wed Sep 12 13:35:56 2018 New Revision: 342078 URL: http://llvm.org/viewvc/llvm-project?rev=342078&view=rev Log: [Hexagon] Remove fp-contract=fast setting for at O3 Change Hexagon so that the setting for fp-contract is the default setting. This makes Hexagon consistent with a

[PATCH] D49999: [Hexagon] Remove fp-contract=fast setting for at O3

This revision was automatically updated to reflect the committed changes. Closed by commit rC342078: [Hexagon] Remove fp-contract=fast setting for at O3 (authored by bcahoon, committed by ). Changed prior to commit: https://reviews.llvm.org/D4?vs=158029&id=165143#toc Repository: rC Clang

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

DiamondLovesYou added a comment. In https://reviews.llvm.org/D51986#1232320, @beanz wrote: > I don’t think this is the right solution. The build system knows what > components are in the dylib and should remove them from the list of libraries > linked individually. You should be able to make Po

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

DiamondLovesYou added a comment. In https://reviews.llvm.org/D51986#1232419, @DiamondLovesYou wrote: > In https://reviews.llvm.org/D51986#1232320, @beanz wrote: > > > I don’t think this is the right solution. The build system knows what > > components are in the dylib and should remove them from

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

beanz added a comment. After line 18 in this file you could do something like: if(WITH_POLLY) list(APPEND LLVM_LINK_COMPONENTS Polly) endif() Then you can get rid of the `target_link_libraries` call. Repository: rC Clang https://reviews.llvm.org/D51986 _

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

DiamondLovesYou added a comment. In https://reviews.llvm.org/D51986#1232440, @beanz wrote: > After line 18 in this file you could do something like: > > if(WITH_POLLY) > list(APPEND LLVM_LINK_COMPONENTS Polly) > endif() > > > Then you can get rid of the `target_link_libraries` call. Ah, i

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

kbobyrev added a comment. I've been thinking about corner-cases (e.g. don't split `DeclStmt`s within init-statement declaration) a while and it seems that there might be many of them. I didn't notice https://reviews.llvm.org/D27621 in the first place, it seems to have a solid test suite (and i

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

lebedev.ri added a comment. In https://reviews.llvm.org/D51949#1232443, @kbobyrev wrote: > I've been thinking about corner-cases (e.g. don't split `DeclStmt`s within > init-statement declaration) a while and it seems that there might be many of > them. It should at least diagnose these cases.

[PATCH] D51996: [clangd] Simplify cancellation public API

kadircet added a comment. Seems a lot cleaner now, thanks! Do you plan to have other changes like moving control to JSONRPCDispatcher and recording timings for analysis on this patch? If not maybe we can add some fixme's so that we won't forget. Also the somewhat "caching" of cancellation toke

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

sammccall created this revision. sammccall added reviewers: ilya-biryukov, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. The cancelable scopes are managed by JSONRPCDispatcher so that all Handlers run in cancelable contexts. (Previously ClangdServer did this,

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

srhines added a comment. In https://reviews.llvm.org/D51713#1232414, @manojgupta wrote: > What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount? > __gnu_mcount_nc with "-pg" is known to be broken ( > https://bugs.llvm.org/show_bug.cgi?id=33845) I CCed myself on that issue

[PATCH] D51996: [clangd] Simplify cancellation public API

sammccall added a comment. In https://reviews.llvm.org/D51996#1232459, @kadircet wrote: > Seems a lot cleaner now, thanks! > > Do you plan to have other changes like moving control to JSONRPCDispatcher > and recording timings for analysis on this patch? https://reviews.llvm.org/D52004 is the J

[PATCH] D51996: [clangd] Simplify cancellation public API

sammccall updated this revision to Diff 165158. sammccall marked 2 inline comments as done. sammccall added a comment. Address comments by adding comments! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51996 Files: clangd/Cancellation.cpp clangd/Cancellation.h clangd/Cla

[PATCH] D51713: Support -fno-omit-frame-pointer with -pg.

manojgupta added a comment. In https://reviews.llvm.org/D51713#1232497, @srhines wrote: > In https://reviews.llvm.org/D51713#1232414, @manojgupta wrote: > > > What is the call generated with -pg for AMR32, __gnu_mcount_nc or _mount? > > __gnu_mcount_nc with "-pg" is known to be broken ( > > ht

[PATCH] D52004: [clangd] Allow all LSP methods to signal cancellation via $/cancelRequest

kadircet added a comment. Wonder if we can still keep the onCancelRequest registry within ProtocolHandler's scope, so that it is clear that we implement it. Other than that seems fascinating, thanks! Comment at: clangd/JSONRPCDispatcher.cpp:246 + auto StrID = llvm::to_string

[PATCH] D51333: Diagnose likely typos in include statements

christylee updated this revision to Diff 165162. christylee edited the summary of this revision. christylee added a comment. Emit non-fatal error for typo if file exists. https://reviews.llvm.org/D51333 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp Index: lib/L

[PATCH] D48581: [AArch64] Support reserving x1-7 registers.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Great work Tri, thank you! https://reviews.llvm.org/D48581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r342096 - When we leave a module header, make that header visible in its

Author: rsmith Date: Wed Sep 12 16:09:23 2018 New Revision: 342096 URL: http://llvm.org/viewvc/llvm-project?rev=342096&view=rev Log: When we leave a module header, make that header visible in its includer's context, even if its overall module is unavailable. Added: cfe/trunk/test/Modules/Inpu

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

DiamondLovesYou added a comment. In https://reviews.llvm.org/D51986#1232440, @beanz wrote: > After line 18 in this file you could do something like: > > if(WITH_POLLY) > list(APPEND LLVM_LINK_COMPONENTS Polly) > endif() > > > Then you can get rid of the `target_link_libraries` call. It tu

r342097 - Track definition merging on the canonical declaration even when local

Author: rsmith Date: Wed Sep 12 16:37:00 2018 New Revision: 342097 URL: http://llvm.org/viewvc/llvm-project?rev=342097&view=rev Log: Track definition merging on the canonical declaration even when local submodule visibility is disabled. Attempting to pick a specific declaration to make visible wh

r342098 - Remove dead code made unnecessary by r342018.

Author: rsmith Date: Wed Sep 12 16:37:58 2018 New Revision: 342098 URL: http://llvm.org/viewvc/llvm-project?rev=342098&view=rev Log: Remove dead code made unnecessary by r342018. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cpp URL: http://llvm.org/vie

[PATCH] D51997: [clang] Make sure attributes on member classes are applied properly

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1267-1269 + // Instantiate the attributes on both the template declaration and the associated record declaration. + SemaRef.InstantiateAttrsForDecl(TemplateArgs, Pattern, Inst, La

[PATCH] D48581: [AArch64] Support reserving x1-7 registers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342100: [AArch64] Support reserving x1-7 registers. (authored by trong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48581?vs=165132&id=165

Buildbot numbers for the week of 8/26/2018 - 9/01/2018

Hello everyone, Below are some buildbot numbers for the week of 8/26/2018 - 9/01/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to r

Buildbot numbers for the week of 9/02/2018 - 9/08/2018

Hello everyone, Below are some buildbot numbers for the last week of 9/02/2018 - 9/08/2018. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D51986: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

beanz added a comment. I agree that changing the naming scheme probably makes sense, but I also think that you can probably make a fairly well contained change to the LLVM CMake module that maps components to libnames to special case Polly and make this all work. I’d really like to see us avoi

[PATCH] D52008: [analyzer] Handle forwarding reference better in ExprMutationAnalyzer.

shuaiwang created this revision. shuaiwang added reviewers: lebedev.ri, JonasToth. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin, szepet, xazax.hun. Herald added a reviewer: george.karpenkov. We used to treat an `Expr` mutated whenever it's passed as non-const refer

[PATCH] D51333: Diagnose likely typos in include statements

rsmith added a comment. Thanks, some comments but the approach here looks great. Comment at: include/clang/Basic/DiagnosticLexKinds.td:428-429 +def err_pp_file_not_found_typo_not_fatal +: Error<"'%0' file not found due to leading or trailing non-alphanumeric " +

r342100 - [AArch64] Support reserving x1-7 registers.

Author: trong Date: Wed Sep 12 16:45:04 2018 New Revision: 342100 URL: http://llvm.org/viewvc/llvm-project?rev=342100&view=rev Log: [AArch64] Support reserving x1-7 registers. Summary: Reserving registers x1-7 is used to support CONFIG_ARM64_LSE_ATOMICS in Linux kernel. This change adds support

[libcxx] r342103 - Mark LWG#3102 as complete. No code changes, but I updated a test or two

Author: marshall Date: Wed Sep 12 19:23:52 2018 New Revision: 342103 URL: http://llvm.org/viewvc/llvm-project?rev=342103&view=rev Log: Mark LWG#3102 as complete. No code changes, but I updated a test or two Modified: libcxx/trunk/test/std/containers/views/span.iterators/end.pass.cpp libcx

[PATCH] D51847: Print correctly dependency paths on Windows

xbolva00 updated this revision to Diff 165204. xbolva00 added a comment. Adjusted regexes in two more tests https://reviews.llvm.org/D51847 Files: lib/Frontend/DependencyFile.cpp test/Frontend/dependency-gen-escaping.c test/Frontend/dependency-gen.c test/Modules/relative-dep-gen.cpp In

<    1   2