[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta marked 2 inline comments as done. takuto.ikuta added a comment. In https://reviews.llvm.org/D51340#1222013, @hans wrote: > Did both your builds use PCH? It'd be interesting to see the difference > without PCH too; the effect should be even larger. Added stats of without PCH build.

[PATCH] D51774: [clangd] NFC: Move Dex to clangd/index

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, mgorny. kbobyrev updated this revision to Diff 164367. kbobyrev added a comment. `%s/DexIndex/Dex

[PATCH] D51774: [clangd] NFC: Move Dex to clangd/index

kbobyrev updated this revision to Diff 164367. kbobyrev added a comment. `%s/DexIndex/Dex` https://reviews.llvm.org/D51774 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/Dex.cpp clang-tools-extra/clangd/index/Dex.h clang-tools-extra/clangd/index/Iterator.c

[PATCH] D51774: [clangd] NFC: Rename DexIndex to Dex

kbobyrev updated this revision to Diff 164368. kbobyrev retitled this revision from "[clangd] NFC: Move Dex to clangd/index" to "[clangd] NFC: Rename DexIndex to Dex". kbobyrev edited the summary of this revision. https://reviews.llvm.org/D51774 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:144 +size_t FileIndex::estimateMemoryUsage() const { + return FSymbols.estimateMemoryUsage(); +} This can be a bit tricky. Generally, the size of a `FileIndex` is the size of

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

ioeric added inline comments. Comment at: clangd/Diagnostics.cpp:299 +D.Severity = +D.Category == "Deprecations" ? DiagnosticsEngine::Note : DiagLevel; return D; kadircet wrote: > Couldn't find a better way to check for this one. Category types a

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

sammccall added a comment. LG with a few nits Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:121 +size_t FileSymbols::estimateMemoryUsage() const { + size_t Result = 0; + for (const auto &FileAndSlab : FileToSlabs) this isn't safe as it doesn't acqu

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:144 +size_t FileIndex::estimateMemoryUsage() const { + return FSymbols.estimateMemoryUsage(); +} sammccall wrote: > ioeric wrote: > > This can be a bit tricky. Generally, the

[PATCH] D51774: [clangd] NFC: Rename DexIndex to Dex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/dex/Dex.h:20 #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_INDEX_DEX_DEXINDEX_H #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_INDEX_D

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164369. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Address a round of comments. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/c

[clang-tools-extra] r341639 - [clangd] NFC: Document URIDistance

Author: omtcyfz Date: Fri Sep 7 02:18:58 2018 New Revision: 341639 URL: http://llvm.org/viewvc/llvm-project?rev=341639&view=rev Log: [clangd] NFC: Document URIDistance `URIDistance` constructor should mention that `Sources` must contain *absolute paths*, not URIs. This is not very clear when loo

r341641 - [MSan] add KMSAN support to Clang driver

Author: glider Date: Fri Sep 7 02:21:09 2018 New Revision: 341641 URL: http://llvm.org/viewvc/llvm-project?rev=341641&view=rev Log: [MSan] add KMSAN support to Clang driver Boilerplate code for using KMSAN instrumentation in Clang. We add a new command line flag, -fsanitize=kernel-memory, with

[PATCH] D51211: [Sema] Emit -Wformat properly for bitfield promotions.

ebevhan added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D51211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51691: [clangd] NFC: Document URIDistance

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341639: [clangd] NFC: Document URIDistance (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51691?vs=164197&id=164373#toc Repository: rL LLVM https://review

[PATCH] D51691: [clangd] NFC: Document URIDistance

This revision was automatically updated to reflect the committed changes. Closed by commit rL341639: [clangd] NFC: Document URIDistance (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51691?vs=164197&id=164372#toc

[clang-tools-extra] r341643 - [clang-tidy] Abseil: Allow macros inside of absl to use internal absl things

Author: d0k Date: Fri Sep 7 02:25:23 2018 New Revision: 341643 URL: http://llvm.org/viewvc/llvm-project?rev=341643&view=rev Log: [clang-tidy] Abseil: Allow macros inside of absl to use internal absl things Modified: clang-tools-extra/trunk/clang-tidy/abseil/AbseilMatcher.h clang-tools-ex

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:135 + std::move(RefsStorage)), + /*BackingDataSize=*/0); } this size should be calculated from the slabs above https://reviews.llvm.org/D51539

r341644 - Replaces __inline by __inline__ / C89 compatible

Author: dnsampaio Date: Fri Sep 7 02:37:27 2018 New Revision: 341644 URL: http://llvm.org/viewvc/llvm-project?rev=341644&view=rev Log: Replaces __inline by __inline__ / C89 compatible Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp Modified: cfe/trunk/utils/TableGen/NeonEmitter.cpp URL:

[clang-tools-extra] r341645 - [clangd] Canonicalize include paths in clangd.

Author: ioeric Date: Fri Sep 7 02:40:36 2018 New Revision: 341645 URL: http://llvm.org/viewvc/llvm-project?rev=341645&view=rev Log: [clangd] Canonicalize include paths in clangd. Get rid of "../" and "../../". Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp clang-t

[PATCH] D51683: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89

dnsampaio added a comment. In https://reviews.llvm.org/D51683#1226329, @joerg wrote: > Correct. The protected name is double underscore as both suffix and prefix. Ok, fixed. Cheers. https://reviews.llvm.org/D51683 ___ cfe-commits mailing list cfe

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164377. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd/index/Index.h clang-tools-extra/clangd/index/MemI

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

whisperity added a comment. https://reviews.llvm.org/D50353 has landed, so after a rebase this patch will not compile. https://reviews.llvm.org/D45050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:131 + size_t StorageSize = 0; + for (const auto &Slab : SymbolSlabs) +StorageSize += Slab->bytes(); also the refslabs and refsstorage https://reviews.llvm.org/D51539

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta updated this revision to Diff 164379. takuto.ikuta edited the summary of this revision. https://reviews.llvm.org/D51340 Files: clang/include/clang/Driver/CLCompatOptions.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-no

[PATCH] D51539: [clangd] Add symbol slab size to index memory consumption estimates

kbobyrev updated this revision to Diff 164383. kbobyrev marked an inline comment as done. kbobyrev added a comment. Oh, I thought they're empty. https://reviews.llvm.org/D51539 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/c

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

ilya-biryukov added a comment. Not sure if it's fine to hijack our own diagnostic-specific flags in to clang command args. Const that I see: 1. There is no way for the users to turn them off if they find them non-useful. If we add a way, it would be more config parameters which overlap with ot

[PATCH] D51057: [analyzer][UninitializedObjectChecker] Fixed dereferencing

Szelethus added inline comments. Comment at: test/Analysis/cxx-uninitialized-object.cpp:879-902 +struct LambdaWrapper { + void *func; // no-crash + int dontGetFilteredByNonPedanticMode = 0; + + LambdaWrapper(void *ptr) : func(ptr) {} // expected-warning{{1 uninitialized field

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

lewis-revill added a comment. @asb can we get this committed? Repository: rC Clang https://reviews.llvm.org/D50246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added inline comments. Comment at: test/Index/complete-block-property-assignment.m:71 +// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck -check-prefix=CHECK-NO1 %s +// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35) ---

Re: r335081 - Recommit r335063: [Darwin] Add a warning for missing include path for libstdc++

On Wed, Sep 5, 2018 at 9:25 PM Alex L wrote: > Sorry for the late response, > > On Sat, 18 Aug 2018 at 20:10, Nico Weber wrote: > >> Also, the diag text should probably say "pass '-stdlib=libc++' " not >> "pass '-std=libc++' "? >> > > Good catch, thanks! I'll commit a fixup for it. > > >> >> On

Re: r341560 - Reverting r 341390 because it is causing test failures on GreenDragon.

Relanded with a fix attempt at 341654. On Thu, Sep 6, 2018 at 12:31 PM A Bergen via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sudofortune > Date: Thu Sep 6 09:29:40 2018 > New Revision: 341560 > > URL: http://llvm.org/viewvc/llvm-project?rev=341560&view=rev > Log: > Reverting r

r341654 - Reland r341390 clang-cl: Pass /Brepro to linker if it was passed to the compiler

Author: nico Date: Fri Sep 7 05:47:02 2018 New Revision: 341654 URL: http://llvm.org/viewvc/llvm-project?rev=341654&view=rev Log: Reland r341390 clang-cl: Pass /Brepro to linker if it was passed to the compiler The test was missing '--' on mac as pointed out by -Wslash-u-filename: :5:69: note:

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta added a comment. In https://reviews.llvm.org/D51340#1226989, @takuto.ikuta wrote: > In https://reviews.llvm.org/D51340#1222013, @hans wrote: > > > Did both your builds use PCH? It'd be interesting to see the difference > > without PCH too; the effect should be even larger. > > > Add

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

kristina added a comment. Going to land it as it's approved by code owner. Repository: rC Clang https://reviews.llvm.org/D50246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r341655 - Differential Revision: https://reviews.llvm.org/D50246

Author: kristina Date: Fri Sep 7 06:03:31 2018 New Revision: 341655 URL: http://llvm.org/viewvc/llvm-project?rev=341655&view=rev Log: Differential Revision: https://reviews.llvm.org/D50246 [RISCV] Add support for computing sysroot for riscv32-unknown-elf Extends r338385 to allow the driver to c

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

kristina closed this revision. kristina added a comment. Closed by https://reviews.llvm.org/rC341655. Repository: rC Clang https://reviews.llvm.org/D50246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D51782: [CodeComplete] Clearly distinguish signature help and code completion.

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, kadircet. Code completion in clang is actually a mix of two features: - Code completion is a familiar feature. Results are exposed via the CodeCompleteConsumer::ProcessCodeCompleteResults callback. - Signature help fi

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added inline comments. Comment at: test/Index/complete-block-property-assignment.m:71 +// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck -check-prefix=CHECK-NO1 %s +// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35) ---

r341656 - [libclang] Return the proper pointee type for 'auto' deduced to pointer

Author: yvvan Date: Fri Sep 7 06:23:51 2018 New Revision: 341656 URL: http://llvm.org/viewvc/llvm-project?rev=341656&view=rev Log: [libclang] Return the proper pointee type for 'auto' deduced to pointer Currently the resulting type is always invalid in such case. Differential Revision: https://

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL341656: [libclang] Return the proper pointee type for 'auto' deduced to pointer (authored by yvvan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D51784: ms: Insert $$Z in mangling between directly consecutive parameter packs.

thakis created this revision. thakis added a reviewer: rnk. Fixes PR38783. For comparing: https://godbolt.org/z/XBSdiq https://reviews.llvm.org/D51784 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-templates.cpp Index: clang/test/CodeGenCXX/mangle-ms-templates.c

[PATCH] D51784: ms: Insert $$Z in mangling between directly consecutive parameter packs.

thakis added inline comments. Comment at: clang/test/CodeGenCXX/mangle-ms-templates.cpp:201 + multi_variadic_mixed(1, 2, 3); + multi_variadic_mixed(1, 2, 3, 4); } These notably don't get a $$Z because there's a regular template parameter in between. https:/

[PATCH] D51090: [clangd] Add index benchmarks

kbobyrev updated this revision to Diff 164414. kbobyrev added a comment. Sync with HEAD https://reviews.llvm.org/D51090 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp Index: clang-to

r341660 - [CodeComplete] Clearly distinguish signature help and code completion.

Author: ibiryukov Date: Fri Sep 7 07:04:39 2018 New Revision: 341660 URL: http://llvm.org/viewvc/llvm-project?rev=341660&view=rev Log: [CodeComplete] Clearly distinguish signature help and code completion. Summary: Code completion in clang is actually a mix of two features: - Code completion is

[PATCH] D51782: [CodeComplete] Clearly distinguish signature help and code completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rC341660: [CodeComplete] Clearly distinguish signature help and code completion. (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51782?vs=164398&id=164415#toc R

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

ilya-biryukov added inline comments. Comment at: test/Index/complete-block-property-assignment.m:71 +// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck -check-prefix=CHECK-NO1 %s +// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35) ---

[PATCH] D51771: [X86] Modify addcarry/subborrow builtins to emit an 2 result and intrinsic and an store instruction.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D51771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D51544: [OpenCL] Split opencl-c.h header

Anastasia added a comment. In https://reviews.llvm.org/D51544#1224780, @asavonic wrote: > In https://reviews.llvm.org/D51544#1224730, @Anastasia wrote: > > > It seems generally good to partition this big header but I am trying to > > understand what problem is it trying to solve now? > > > Main

[PATCH] D51628: [clangd] Implement a Proof-of-Concept tool for symbol index exploration

ilya-biryukov added a comment. Definitely like the idea of the tool. The main complication seems to be parsing of user input at this point. I suggest we explore an option proposed before, that is reusing the LLVM command-line parser (see inline comment too). If that turns out to be much work, w

r341668 - Revert "[OPENMP][NVPTX] Disable runtime-type info for CUDA devices."

Author: abataev Date: Fri Sep 7 07:50:25 2018 New Revision: 341668 URL: http://llvm.org/viewvc/llvm-project?rev=341668&view=rev Log: Revert "[OPENMP][NVPTX] Disable runtime-type info for CUDA devices." Still need the RTTI for NVPTX target to pass sema checks. Removed: cfe/trunk/test/OpenMP/

[PATCH] D51544: [OpenCL] Split opencl-c.h header

asavonic added a comment. In https://reviews.llvm.org/D51544#1227313, @Anastasia wrote: > Currently the main header still contains everything, so the size of the PCH > won't change. The idea is that we don't pre-compile the whole opencl-c.h, we split it into several headers (3 of them are targ

[PATCH] D51531: [analyzer][UninitializedObjectChecker] Uninit regions are only reported once

Szelethus added a comment. Polite ping :) https://reviews.llvm.org/D51531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51789: [WIP][clang] Add the no_extern_template attribute

dexonsmith edited subscribers, added: cfe-commits; removed: llvm-commits. dexonsmith added a comment. +cfe-commits -llvm-commits Repository: rL LLVM https://reviews.llvm.org/D51789 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[libcxx] r341671 - [asan] Update a vector's storage annotation during destruction. Reviewed as https://reviews.llvm.org/D50101. Thanks to bobsayshilol (Ben) for the patch.

Author: marshall Date: Fri Sep 7 08:47:59 2018 New Revision: 341671 URL: http://llvm.org/viewvc/llvm-project?rev=341671&view=rev Log: [asan] Update a vector's storage annotation during destruction. Reviewed as https://reviews.llvm.org/D50101. Thanks to bobsayshilol (Ben) for the patch. Modified

[PATCH] D50101: [asan] Update a vector's storage annotation during destruction.

mclow.lists closed this revision. mclow.lists added a comment. landed as revision 341671. Repository: rCXX libc++ https://reviews.llvm.org/D50101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r341678 - [X86] Modify addcarry/subborrow builtins to emit an 2 result and intrinsic and an store instruction.

Author: ctopper Date: Fri Sep 7 09:58:57 2018 New Revision: 341678 URL: http://llvm.org/viewvc/llvm-project?rev=341678&view=rev Log: [X86] Modify addcarry/subborrow builtins to emit an 2 result and intrinsic and an store instruction. This is the clang side of D51769. The llvm intrinsics now ret

[PATCH] D51771: [X86] Modify addcarry/subborrow builtins to emit an 2 result and intrinsic and an store instruction.

This revision was automatically updated to reflect the committed changes. Closed by commit rC341678: [X86] Modify addcarry/subborrow builtins to emit an 2 result and intrinsic and… (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D51771?vs=164357&id=164452

[PATCH] D51802: [clangd] Make advanceTo() faster on Posting Lists

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. If the current element is already beyond advanceTo()'s DocID, just return instead of doing binar

[PATCH] D51802: [clangd] Make advanceTo() faster on Posting Lists

kbobyrev updated this revision to Diff 164462. kbobyrev edited the summary of this revision. https://reviews.llvm.org/D51802 Files: clang-tools-extra/clangd/index/dex/Iterator.cpp Index: clang-tools-extra/clangd/index/dex/Iterator.cpp ==

[PATCH] D51805: [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out parameter

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. This is the clang side of https://reviews.llvm.org/D51803. The llvm intrinsic now returns two results. So we need to emit an explicit store in IR for the out parameter. This is similar to addcarry/subborrow/rdrand

[PATCH] D51806: [clang-cl] Enable -march

aganea created this revision. aganea added reviewers: thakis, ddunbar, hans. Herald added a subscriber: cfe-commits. Currently, `-march` does not work in the `clang-cl` driver. We are currently migrating from MSVC. The project size makes that we have to stick with `clang-cl` for a little while.

[PATCH] D51807: Remove all uses of DIFlagBlockByrefStruct from Clang

aprantl created this revision. aprantl added a reviewer: debug-info. Herald added a subscriber: JDevlieghere. This patch removes the last reason why DIFlagBlockByrefStruct from Clang by directly implementing the drilling into the member type done in DwarfDebug::DbgVariable::getType() into the f

[PATCH] D51038: [clang] Make sure codecompletion is called for calls even when inside a token.

kadircet updated this revision to Diff 164477. kadircet added a comment. - Rebase and use new signature help. Currently the problem is, there are again some tests out there that rely on CodeCompeleteOrdinaryName to be called even when getting overloads at an unknown parameter type. These tests ar

[PATCH] D51752: NFC: move isRepeatedBytePattern from clang to Constant

jfb updated this revision to Diff 164481. jfb added a comment. - Use isBytewiseValue instead. Repository: rC Clang https://reviews.llvm.org/D51752 Files: lib/CodeGen/CGDecl.cpp Index: lib/CodeGen/CGDecl.cpp === --- lib/CodeGe

[PATCH] D51805: [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out parameter

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - The lack of existing tests is worrying. https://reviews.llvm.org/D51805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D51807: Remove all uses of DIFlagBlockByrefStruct from Clang

aprantl added a comment. ( https://reviews.llvm.org/D51763 is not *really* a dependency, but it's closely related. ) https://reviews.llvm.org/D51807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D51808: [CUDA] Ignore uncallable functions when we check for usual deallocators.

tra created this revision. tra added a reviewer: rsmith. Herald added subscribers: bixia, jlebar, sanjoy. Previously clang considered function variants from both sides of compilation and that sometimes resulted in picking up wrong deallocation function. https://reviews.llvm.org/D51808 Files:

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

kadircet added a comment. In https://reviews.llvm.org/D51747#1227089, @ilya-biryukov wrote: > Not sure if it's fine to hijack our own diagnostic-specific flags in to clang > command args. > > Cons that I see: > > 1. There is no way for the users to turn them off if they find them > non-useful.

r341697 - warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std'

Author: arphaman Date: Fri Sep 7 11:59:45 2018 New Revision: 341697 URL: http://llvm.org/viewvc/llvm-project?rev=341697&view=rev Log: warn_stdlibcxx_not_found: suggest '-stdlib=libc++' instead of '-std' Addresses first post-commit feedback for r335081 from Nico Modified: cfe/trunk/include/c

Re: r335081 - Recommit r335063: [Darwin] Add a warning for missing include path for libstdc++

On Fri, 7 Sep 2018 at 05:41, Nico Weber wrote: > On Wed, Sep 5, 2018 at 9:25 PM Alex L wrote: > >> Sorry for the late response, >> >> On Sat, 18 Aug 2018 at 20:10, Nico Weber wrote: >> >>> Also, the diag text should probably say "pass '-stdlib=libc++' " not >>> "pass '-std=libc++' "? >>> >> >>

r341699 - [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out parameter

Author: ctopper Date: Fri Sep 7 12:14:24 2018 New Revision: 341699 URL: http://llvm.org/viewvc/llvm-project?rev=341699&view=rev Log: [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out parameter This is the clang side of D51803. The llvm intrinsic now returns two res

[PATCH] D51805: [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL341699: [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out… (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r341700 - PR38870: Add warning for zero-width unicode characters appearing in

Author: rsmith Date: Fri Sep 7 12:25:39 2018 New Revision: 341700 URL: http://llvm.org/viewvc/llvm-project?rev=341700&view=rev Log: PR38870: Add warning for zero-width unicode characters appearing in identifiers. Modified: cfe/trunk/include/clang/Basic/DiagnosticLexKinds.td cfe/trunk/lib

[PATCH] D51809: [CUDA][HIP] Fix assertion in LookupSpecialMember

yaxunl created this revision. yaxunl added a reviewer: tra. ShouldDeleteSpecialMember is called upon inherited constructors. It calls inferCUDATargetForImplicitSpecialMember, which in turn calls LookupSpecialMember. LookupSpecialMember expects ConstArg==false for CXXDefaultConstructor. For inheri

[PATCH] D51789: [WIP][clang] Add the no_extern_template attribute

rsmith added a comment. It'd be good to test that `[[no_extern_template]]` affects instantiation, not just code generation (eg, put something in the body of the entity that will trigger an error if instantiated, and check that the diagnostic is produced at the right times). Repository: rL L

[PATCH] D51784: ms: Insert $$Z in mangling between directly consecutive parameter packs.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! I thought that was going to be more of a pain. :) https://reviews.llvm.org/D51784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51752: NFC: deduplicate isRepeatedBytePattern from clang to LLVM's isBytewiseValue

MatzeB accepted this revision. MatzeB added a comment. This revision is now accepted and ready to land. Looks obvious and LGTM. Repository: rC Clang https://reviews.llvm.org/D51752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D51809: [CUDA][HIP] Fix assertion in LookupSpecialMember

tra added a comment. @jlebar Justin, can you take a look? https://reviews.llvm.org/D51809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51812: Simplify CheckFallThroughForBody

gromer created this revision. gromer added a reviewer: rsmith. Herald added subscribers: cfe-commits, modocache. Split CheckFallThroughForBody into separate implementations for blocks, lambdas, coroutines, and all other functions. This simplifies the code because virtually every part of it vari

[PATCH] D51747: [clangd] Implement deprecation diagnostics with lower severity.

ioeric added a comment. In https://reviews.llvm.org/D51747#1227089, @ilya-biryukov wrote: > Not sure if it's fine to hijack our own diagnostic-specific flags in to clang > command args. > > Cons that I see: > > 1. There is no way for the users to turn them off if they find them > non-useful. If

r341710 - Make -Watomic-alignment say whether the atomic operation was oversized

Author: rsmith Date: Fri Sep 7 14:24:27 2018 New Revision: 341710 URL: http://llvm.org/viewvc/llvm-project?rev=341710&view=rev Log: Make -Watomic-alignment say whether the atomic operation was oversized or misaligned. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/tru

[PATCH] D51817: Do not use optimized atomic libcalls for misaligned atomics.

rsmith created this revision. rsmith added reviewers: jyknight, t.p.northover. Herald added a subscriber: jfb. The optimized (__atomic_foo_) libcalls assume that the atomic object is properly aligned, so should never be called on an underaligned object. This addresses one of several problems iden

[PATCH] D51752: NFC: deduplicate isRepeatedBytePattern from clang to LLVM's isBytewiseValue

jfb added a comment. Will wait on https://reviews.llvm.org/D51751 before committing, otherwise clang tests will start failing (because current `isRepeatedBytePattern` isn't capable enough). Repository: rC Clang https://reviews.llvm.org/D51752 _

[PATCH] D51819: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck

benhamilton created this revision. benhamilton added reviewers: Wizard, hokein. Herald added a subscriber: cfe-commits. This adds a few common acronyms we found were missing from PropertyDeclarationCheck. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51819 Files: clang-tidy

[PATCH] D51812: Simplify CheckFallThroughForBody

rsmith added a comment. I'm not a fan of the duplication introduced here, but the new code is definitely more obvious. On balance, this seems like a small improvement, so let's go for it. Comment at: b/llvm/tools/clang/lib/Sema/AnalysisBasedWarnings.cpp:542-544 + // cpu_disp

[PATCH] D51819: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. We need to update the documentation http://clang.llvm.org/extra/clang-tidy/checks/objc-property-declaration.html as well. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D5181

[clang-tools-extra] r341720 - [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck

Author: benhamilton Date: Fri Sep 7 15:02:38 2018 New Revision: 341720 URL: http://llvm.org/viewvc/llvm-project?rev=341720&view=rev Log: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck Summary: This adds a few common acronyms we found were missing from PropertyDeclarationC

[clang-tools-extra] r341721 - [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck

Author: benhamilton Date: Fri Sep 7 15:03:48 2018 New Revision: 341721 URL: http://llvm.org/viewvc/llvm-project?rev=341721&view=rev Log: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck Summary: This adds a few common acronyms we found were missing from PropertyDeclarationC

[PATCH] D51819: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck

benhamilton updated this revision to Diff 164523. benhamilton added a comment. - Update docs. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51819 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst Index: docs/clang-ti

[PATCH] D51819: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rL341720: [clang-tidy/ObjC] Update list of acronyms in PropertyDeclarationCheck (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

r341722 - [analyzer] Remove the "postponed" hack, deal with derived symbols using an extra map

Author: george.karpenkov Date: Fri Sep 7 15:07:57 2018 New Revision: 341722 URL: http://llvm.org/viewvc/llvm-project?rev=341722&view=rev Log: [analyzer] Remove the "postponed" hack, deal with derived symbols using an extra map The "derived" symbols indicate children fields of a larger symbol. A

r341723 - [analyzer] [NFC] Use StringRef when returning a large string literal in HTMLDiagnostics

Author: george.karpenkov Date: Fri Sep 7 15:13:15 2018 New Revision: 341723 URL: http://llvm.org/viewvc/llvm-project?rev=341723&view=rev Log: [analyzer] [NFC] Use StringRef when returning a large string literal in HTMLDiagnostics (NB: could be a clang-tidy / analyzer check) Differential Revisi

r341724 - [analyzer] [NFC] Move methods for dumping the coverage in HTMLDiagnostics into the class

Author: george.karpenkov Date: Fri Sep 7 15:13:35 2018 New Revision: 341724 URL: http://llvm.org/viewvc/llvm-project?rev=341724&view=rev Log: [analyzer] [NFC] Move methods for dumping the coverage in HTMLDiagnostics into the class Differential Revision: https://reviews.llvm.org/D51513 Modified

[PATCH] D51513: [analyzer] [NFC] Move methods for dumping the coverage in HTMLDiagnostics into the class

This revision was automatically updated to reflect the committed changes. Closed by commit rC341724: [analyzer] [NFC] Move methods for dumping the coverage in HTMLDiagnostics into… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: ht

[PATCH] D51512: [analyzer] [NFC] Use StringRef when returning a large string literal in HTMLDiagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC341723: [analyzer] [NFC] Use StringRef when returning a large string literal in… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://r

[PATCH] D51817: Do not use optimized atomic libcalls for misaligned atomics.

efriedma added inline comments. Comment at: lib/CodeGen/CGAtomic.cpp:949 case AtomicExpr::AO__opencl_atomic_compare_exchange_strong: case AtomicExpr::AO__atomic_load_n: case AtomicExpr::AO__atomic_store_n: Is there any particular reason to expect t

[PATCH] D51817: Do not use optimized atomic libcalls for misaligned atomics.

rsmith added inline comments. Comment at: lib/CodeGen/CGAtomic.cpp:949 case AtomicExpr::AO__opencl_atomic_compare_exchange_strong: case AtomicExpr::AO__atomic_load_n: case AtomicExpr::AO__atomic_store_n: efriedma wrote: > Is there any particular re

[PATCH] D51817: Do not use optimized atomic libcalls for misaligned atomics.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/CodeGen/CGAtomic.cpp:949 case AtomicExpr::AO__opencl_atomic_compare_exchange_strong: case AtomicExpr::AO__atomic_load_n: case AtomicEx

[PATCH] D51817: Do not use optimized atomic libcalls for misaligned atomics.

This revision was automatically updated to reflect the committed changes. Closed by commit rC341734: Do not use optimized atomic libcalls for misaligned atomics. (authored by rsmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D51817?vs=164517&id=164544#toc Repository:

  1   2   >