tks2103 added a comment.
currently changes the behavior for a few cases:
something like
void coro() {
co_return {4};
}
throws `illegal initializer type 'void'`
Repository:
rC Clang
https://reviews.llvm.org/D51741
___
cfe-commits mailin
george.karpenkov updated this revision to Diff 164255.
george.karpenkov marked 2 inline comments as done.
https://reviews.llvm.org/D51393
Files:
llvm/include/llvm/Support/Allocator.h
Index: llvm/include/llvm/Support/Allocator.h
=
tks2103 added a comment.
also fails
https://github.com/llvm-mirror/clang/blob/master/test/SemaCXX/coroutines.cpp#L494
with `address of overloaded function 'g' does not match required type
''`
also fails
https://github.com/llvm-mirror/clang/blob/master/test/SemaCXX/coroutines.cpp#L505
with `ad
steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.
Brilliant, I've wanted to do this for years, and I still have many improvements
to the LLVM/Clang cmake files on my todo list. Good to know others are
similarly motivated.
=
ioeric updated this revision to Diff 164258.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51724
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Protocol.cpp
clangd
ioeric updated this revision to Diff 164259.
ioeric added a comment.
- merged with origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51724
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Protocol.cpp
clangd/Protocol.h
clangd/Quality.cpp
clangd
Author: ioeric
Date: Thu Sep 6 11:52:26 2018
New Revision: 341576
URL: http://llvm.org/viewvc/llvm-project?rev=341576&view=rev
Log:
[clangd] Add "Deprecated" field to Symbol and CodeCompletion.
Summary: Also set "deprecated" field in LSP CompletionItem.
Reviewers: sammccall, kadircet
Reviewed
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341576: [clangd] Add "Deprecated" field to
Symbol and CodeCompletion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51724?vs=164259&id=164260#toc
Repository:
steveire added a comment.
How? This is 'private' code. I don't think it's worth changing that or creating
a test with a huge amount of infrastructure in order to test this indirectly.
Am I missing something?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
_
kadircet added inline comments.
Comment at: unittests/clangd/SymbolCollectorTests.cpp:1020
+ const std::string Header = R"(
+void TestClangc() __attribute__((deprecated("", "")));
+void TestClangd();
No need for the optional parameters,
```
void TestCl
kadircet created this revision.
kadircet added reviewers: ioeric, sammccall, ilya-biryukov, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Adds deprecation warnings to diagnostics. Also lowers the severity from
warning to notes to not to annoy people that work on big co
Yes, this was a prerequisite to https://reviews.llvm.org/D51259. For
some reason the reviewer accepted that one, but not this one. I simply
assumed that was a mistake and committed this one.
Perhaps part of the problem is that I do one thing per commit, and that
confuses reviewers. Maybe I s
tks2103 updated this revision to Diff 164265.
tks2103 added a comment.
get NRVOCandidate to determine if we should try to move return var
Repository:
rC Clang
https://reviews.llvm.org/D51741
Files:
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutine-rvo.cpp
Index: test/SemaCXX/coroutine-
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226257, @steveire wrote:
> How? This is 'private' code. I don't think it's worth changing that or
> creating a test with a huge amount of infrastructure in order to test this
> indirectly.
This is changing the observable behav
kadircet added inline comments.
Comment at: clangd/Diagnostics.cpp:299
+D.Severity =
+D.Category == "Deprecations" ? DiagnosticsEngine::Note : DiagLevel;
return D;
Couldn't find a better way to check for this one. Category types are coming
from
kadircet updated this revision to Diff 164268.
kadircet added a comment.
- Formatting.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51747
Files:
clangd/ClangdServer.cpp
clangd/Diagnostics.cpp
unittests/clangd/ClangdUnitTests.cpp
Index: unittests/clangd/ClangdUnitTests
steveire added a comment.
In https://reviews.llvm.org/D51192#1226282, @aaron.ballman wrote:
> In https://reviews.llvm.org/D51192#1226257, @steveire wrote:
>
> > How? This is 'private' code. I don't think it's worth changing that or
> > creating a test with a huge amount of infrastructure in or
On Thu, Sep 6, 2018 at 10:05 PM, Stephen Kelly via cfe-commits
wrote:
>
> Yes, this was a prerequisite to https://reviews.llvm.org/D51259. For some
> reason the reviewer accepted that one, but not this one. I simply assumed
> that was a mistake and committed this one.
I'm not sure this is how the
On 06/09/18 20:42, Roman Lebedev wrote:
You can specify the dependencies between the differentials in phabricator.
I didn't know that, thanks!
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226312, @steveire wrote:
> In https://reviews.llvm.org/D51192#1226282, @aaron.ballman wrote:
>
> > I'd probably pipe the diagnostic output to a temporary file that gets
> > FileChecked with strict whitespace to see if the underli
steveire added a comment.
As far as I know, no existing clang-tidy checks are affected. I discovered this
while implementing a custom check. See
https://bugs.llvm.org/show_bug.cgi?id=38678
By the way, is there some keyword I should use in commit messages to link to
bugs properly?
Repository:
joerg added a comment.
Correct. The protected name is double underscore as both suffix and prefix.
https://reviews.llvm.org/D51683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D51192#1226326, @steveire wrote:
> As far as I know, no existing clang-tidy checks are affected. I discovered
> this while implementing a custom check
steveire added a comment.
Thanks.
The `arc` tool already inserted `Differential Revision:` into my git commit,
but that's not what I wonder about. I'm looking for something I can insert into
my git commit so that the bug will automatically be closed when I commit (and
so that the bug will get
aaron.ballman added a comment.
In https://reviews.llvm.org/D51192#1226341, @steveire wrote:
> Thanks.
>
> The `arc` tool already inserted `Differential Revision:` into my git commit,
> but that's not what I wonder about. I'm looking for something I can insert
> into my git commit so that the bu
Author: steveire
Date: Thu Sep 6 13:16:34 2018
New Revision: 341583
URL: http://llvm.org/viewvc/llvm-project?rev=341583&view=rev
Log:
Fix reported range of partial token replacement
Summary: Fixes bug: 38678
Reviewers: klimek, rsmith
Subscribers: cfe-commits
Differential Revision: https://rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341583: Fix reported range of partial token replacement
(authored by steveire, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51192?vs=163447&id=164275#toc
Repository:
rCTE Clan
jfb created this revision.
Herald added subscribers: cfe-commits, dexonsmith.
This code was in CGDecl.cpp and really belongs to Constant. This will allow me
to use it in a subsequent patch.
LLVM part of this patch: https://reviews.llvm.org/D51751
Repository:
rC Clang
https://reviews.llvm.org
MatzeB added a comment.
- I'm not a good person to review clang changes.
- I assume the review lacks the changes on the llvm side?
- On the LLVM side this feels like something for `Analysis/ValueTracking.h` in
fact I already see `Value *isBytewiseValue(Value *V);` there, maybe that is
good enoug
jfb added a comment.
In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
> - I'm not a good person to review clang changes.
> - I assume the review lacks the changes on the llvm side?
> - On the LLVM side this feels like something for `Analysis/ValueTracking.h`
> in fact I already see `Va
jfb added a comment.
In https://reviews.llvm.org/D51752#1226465, @jfb wrote:
> In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
>
> > - I'm not a good person to review clang changes.
> > - I assume the review lacks the changes on the llvm side?
> > - On the LLVM side this feels like som
MatzeB added a comment.
In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
> - I assume the review lacks the changes on the llvm side?
Oops missed the link to the llvm changes in the description... At least in
theory you should be able to make a review over all changes in parallel by
jfb added a comment.
In https://reviews.llvm.org/D51752#1226474, @MatzeB wrote:
> In https://reviews.llvm.org/D51752#1226462, @MatzeB wrote:
>
> > - I assume the review lacks the changes on the llvm side?
>
>
> Oops missed the link to the llvm changes in the description... At least in
> theory y
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I very very much appreciate this.
https://reviews.llvm.org/D51395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
george.karpenkov updated this revision to Diff 164291.
https://reviews.llvm.org/D51393
Files:
llvm/include/llvm/Support/Allocator.h
Index: llvm/include/llvm/Support/Allocator.h
===
--- llvm/include/llvm/Support/Allocator.h
+++ ll
george.karpenkov updated this revision to Diff 164292.
https://reviews.llvm.org/D51393
Files:
llvm/include/llvm/Support/Allocator.h
Index: llvm/include/llvm/Support/Allocator.h
===
--- llvm/include/llvm/Support/Allocator.h
+++ ll
dblaikie added a comment.
Just to clarify - the general philosophy (there are many cases of exceptions
due to complications in various areas) is that clang changes should have clang
tests (source code to IR), LLVM changes should have LLVM tests (IR to assembly
or object code+dwarf dump) & if de
george.karpenkov updated this revision to Diff 164294.
george.karpenkov added a comment.
More casts.
https://reviews.llvm.org/D51393
Files:
llvm/include/llvm/Support/Allocator.h
Index: llvm/include/llvm/Support/Allocator.h
===
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I'm happy with the code.
Comment at: llvm/include/llvm/Support/Allocator.h:298
+ if (P >= S && P < S + computeSlabSize(Idx))
+return InSlabIdx + static_cast(P - S);
+
kadircet added inline comments.
Comment at: test/Index/complete-block-property-assignment.m:71
+// RUN: c-index-test -code-completion-at=%s:54:15 %s | FileCheck
-check-prefix=CHECK-NO1 %s
+// CHECK-NO1: ObjCPropertyDecl:{ResultType int}{TypedText foo} (35)
ily
kadircet updated this revision to Diff 164307.
kadircet added a comment.
- Fix tests.
Repository:
rC Clang
https://reviews.llvm.org/D51038
Files:
include/clang/Parse/Parser.h
lib/Parse/ParseExpr.cpp
test/CodeCompletion/function-overloads-inside-param.cpp
test/CodeCompletion/function-
Author: george.karpenkov
Date: Thu Sep 6 16:07:26 2018
New Revision: 341600
URL: http://llvm.org/viewvc/llvm-project?rev=341600&view=rev
Log:
[analyzer] Dump a reproducible, deterministic ID of program state to exploded
graph
Differential Revision: https://reviews.llvm.org/D51395
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341599: Provide a method for generating deterministic IDs
for pointers allocated in… (authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51393?vs=164294&id=
Author: george.karpenkov
Date: Thu Sep 6 16:07:47 2018
New Revision: 341601
URL: http://llvm.org/viewvc/llvm-project?rev=341601&view=rev
Log:
[analyzer] Remove traces of ubigraph visualization
Ubigraph project has been dead since about 2008, and to the best of my
knowledge, no one was using it.
Author: george.karpenkov
Date: Thu Sep 6 16:08:07 2018
New Revision: 341602
URL: http://llvm.org/viewvc/llvm-project?rev=341602&view=rev
Log:
[analyzer] Dump stable identifiers for exploded nodes
Differential Revision: https://reviews.llvm.org/D51667
Modified:
cfe/trunk/include/clang/Static
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341601: [analyzer] Remove traces of ubigraph visualization
(authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5165
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341600: [analyzer] Dump a reproducible, deterministic ID of
program state to exploded… (authored by george.karpenkov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
Author: george.karpenkov
Date: Thu Sep 6 16:08:27 2018
New Revision: 341603
URL: http://llvm.org/viewvc/llvm-project?rev=341603&view=rev
Log:
[analyzer] [NFC] Move dumping program point into a separate function
Differential Revision: https://reviews.llvm.org/D51666
Modified:
cfe/trunk/lib/S
erik.pilkington added a comment.
In https://reviews.llvm.org/D51189#1211910, @steven_wu wrote:
> I feel like this is a much tricky situation than just new and init. Following
> example is the same situation.
>
> __attribute__((objc_root_class))
> @interface NSObject
> - (void) foo;
> - (
erik.pilkington updated this revision to Diff 164316.
erik.pilkington marked 4 inline comments as done.
erik.pilkington added a comment.
Address @arphaman's review comments.
https://reviews.llvm.org/D51189
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/DeclObjC.h
clan
Quuxplusone added a comment.
@EricWF ping?
Repository:
rCXX libc++
https://reviews.llvm.org/D47344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: george.karpenkov
Date: Thu Sep 6 17:42:53 2018
New Revision: 341617
URL: http://llvm.org/viewvc/llvm-project?rev=341617&view=rev
Log:
[analyzer] Push updating-the-executed-lines logic into the BugReporter.
So it can be reused across different consumers.
Differential Revision: https://re
Author: george.karpenkov
Date: Thu Sep 6 17:42:32 2018
New Revision: 341616
URL: http://llvm.org/viewvc/llvm-project?rev=341616&view=rev
Log:
[analyzer] Skip printing trivial nodes in exploded graph
A node is considered to be trivial if it only has one successor, one
predecessor, and a state equ
Author: george.karpenkov
Date: Thu Sep 6 17:43:37 2018
New Revision: 341619
URL: http://llvm.org/viewvc/llvm-project?rev=341619&view=rev
Log:
[analyzer] Executed lines: store file IDs, not hashes.
Raw FileIDs are needed for the PlistDiagnostics to produce stable filenames.
Differential Revision
Author: george.karpenkov
Date: Thu Sep 6 17:43:55 2018
New Revision: 341620
URL: http://llvm.org/viewvc/llvm-project?rev=341620&view=rev
Log:
[analyzer] [NFC] Prefer passing around reference to std::unique_ptr&
When object is owned elsewhere
Differential Revision: https://reviews.llvm.org/D5166
Author: george.karpenkov
Date: Thu Sep 6 17:43:17 2018
New Revision: 341618
URL: http://llvm.org/viewvc/llvm-project?rev=341618&view=rev
Log:
[analyzer] Do not add invalid source location to the coverage information
Invalid source locations may arise from generated code.
Differential Revision:
NoQ added a comment.
Herald added a subscriber: Szelethus.
Dunno, i guess you can just commit it.
Comment at: lib/Sema/SemaStmtAsm.cpp:57
+ }
+Parent = Child;
+ }
Like father, like son :D
Repository:
rC Clang
https://reviews.llvm.org/D45416
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341621: [analyzer] Add coverage information to plist output,
update tests (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341620: [analyzer] [NFC] Prefer passing around reference to
std::unique_ptr& (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://revie
NoQ added inline comments.
Comment at: test/Analysis/cstring-syntax.c:49
+ strlcat(dest, "0123456789", badlen / 2);
+ strlcat(dest, "0123456789", badlen); // expected-warning {{The third
argument allows to potentially copy more bytes than it should. Replace with the
value 'ba
NoQ added a comment.
I'm generally fine with landing the patch as long as the overall direction is
chosen (and be moved towards) for how to safely identify the non-deterministic
iterators (my previous inline question). This has to be addressed before we
move out of alpha, but i believe we shoul
NoQ added inline comments.
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedPointee.cpp:126-127
if (V.isUndef()) {
+assert(!FR->getDecl()->getType()->isReferenceType() &&
+ "References must be initialized!");
return addFieldToUninits
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Comments always welcome!
Comment at:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:363-364
+
+ // ImmutableList::getHead() isn't a const method,
Author: ahatanak
Date: Thu Sep 6 19:38:01 2018
New Revision: 341629
URL: http://llvm.org/viewvc/llvm-project?rev=341629&view=rev
Log:
[Sema] Check that the destructor for each element of class type is
accessible from the context where aggregate initialization occurs.
rdar://problem/38168772
Dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341629: [Sema] Check that the destructor for each element of
class type is (authored by ahatanak, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45898
Files:
lib/Sema/SemaInit.cpp
michaelwu accepted this revision.
michaelwu added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D51281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
devnexen added inline comments.
Comment at: test/Analysis/cstring-syntax.c:49
+ strlcat(dest, "0123456789", badlen / 2);
+ strlcat(dest, "0123456789", badlen); // expected-warning {{The third
argument allows to potentially copy more bytes than it should. Replace with the
valu
takuto.ikuta updated this revision to Diff 164353.
takuto.ikuta edited the summary of this revision.
takuto.ikuta added a comment.
Herald added a subscriber: dschuff.
Make patch closer to Nico's original implementation, but warns local static
variable instead of detecting it.
In checkClassLevelDL
takuto.ikuta marked 4 inline comments as done.
takuto.ikuta added inline comments.
Comment at: clang/include/clang/Basic/LangOptions.def:117
LANGOPT(Digraphs , 1, 0, "digraphs")
+LANGOPT(DllexportInlines , 1, 1, "If dllexport a class should dllexport
implicit inline m
devnexen updated this revision to Diff 164355.
devnexen added a comment.
- Correcting misleading message and advising proper fix.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.
Herald added subscribers: cfe-commits, kristina.
This is the clang side of https://reviews.llvm.org/D51769. The llvm intrinsics
now return two results instead of using an out parameter.
Repository:
rC Clang
ht
101 - 171 of 171 matches
Mail list logo
