[PATCH] D51381: [clang-tidy] fix check_clang_tidy to properly mix CHECK-NOTES and CHECK-MESSAGES

JonasToth added a comment. Yes, you are write. I would ensure in the script that `CHECK-MESSAGES XOR CHECK-NOTES` is used, to avoid the mistake i made. I can do it in this diff as well. Am 29.08.2018 um 20:29 schrieb Roman Lebedev via Phabricator: > lebedev.ri added a comment. > > In https://r

[PATCH] D51381: [clang-tidy] fix check_clang_tidy to properly mix CHECK-NOTES and CHECK-MESSAGES

JonasToth updated this revision to Diff 163273. JonasToth added a comment. - adjust check_clang_tidy to use either CHECK-NOTES or CHECK-MESSAGES but not both Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51381 Files: test/clang-tidy/check_clang_tidy.py Index: test/clang-t

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 163274. JonasToth added a comment. - [Misc] migrate to CHECK-NOTES - fix outcommented check messages as well Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicp

[PATCH] D51381: [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK-MESSAGES

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG, thank you! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51381 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D51475: [clangd] Load YAML static index asyncrhonously.

ioeric created this revision. ioeric added reviewers: sammccall, kbobyrev. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Loading static index can be slow (>10s for LLVM index). This allows the clangd server to be initialized before index is lo

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ioeric updated this revision to Diff 163276. ioeric added a comment. - revert unintended change Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51475 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.cpp ==

[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:5745 +// C99 6.5.2.5p6: Function scope compound literals must have automatic +// storage which generally excludes address space-qualified ones. +Diag(LParenLoc, diag::err_compound_literal_with_address_s

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

phosek added a comment. What about other compiler-rt runtimes? Shouldn't we use the same approach for those? In case of multiarch runtime layout, we already add the runtime directory to the new `LibraryPaths` list,

r341033 - AMDGPU: Default to hidden visibility

Author: arsenm Date: Thu Aug 30 01:18:06 2018 New Revision: 341033 URL: http://llvm.org/viewvc/llvm-project?rev=341033&view=rev Log: AMDGPU: Default to hidden visibility Object linking isn't supported, so it's not useful to emit default visibility. Default visibility requires relocations we don't

[PATCH] D51209: AMDGPU: Default to hidden visibility

arsenm closed this revision. arsenm added a comment. r341033 https://reviews.llvm.org/D51209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r341034 - Merging r340823:

Author: hans Date: Thu Aug 30 01:19:15 2018 New Revision: 341034 URL: http://llvm.org/viewvc/llvm-project?rev=341034&view=rev Log: Merging r340823: r340823 | marshall | 2018-08-28 15:29:30 +0200 (Tue, 28 Aug 2018) | 1 line U

Re: [libcxx] r340823 - Use addressof instead of operator& in make_shared. Fixes PR38729. As a drive-by, make the same change in raw_storage_iterator (twice).

Merged to 7.0 in r341034. On Tue, Aug 28, 2018 at 3:29 PM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Tue Aug 28 06:29:30 2018 > New Revision: 340823 > > URL: http://llvm.org/viewvc/llvm-project?rev=340823&view=rev > Log: > Use addressof instead of operator& in make_shared. F

[PATCH] D51437: [clangd] Report position of opening paren in singature help

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/Protocol.h:832 + + /// Position of the opening paren of the argument list. + /// This is a clangd-specific extension, it is only available via

[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

ebevhan updated this revision to Diff 163277. ebevhan edited the summary of this revision. ebevhan added a comment. Added Embedded-C clause quote. Fixed formatting. https://reviews.llvm.org/D51426 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/Sema/address_sp

[PATCH] D51356: [docs][mips] Clang 7.0 Release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks! Go ahead and commit directly to the branch, or let me know if you'd prefer me to do it. Repository: rC Clang https://reviews.llvm.org/D51356 __

[PATCH] D51381: [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK-MESSAGES

This revision was automatically updated to reflect the committed changes. Closed by commit rL341039: [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK… (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews

[clang-tools-extra] r341039 - [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK-MESSAGES

Author: jonastoth Date: Thu Aug 30 01:44:27 2018 New Revision: 341039 URL: http://llvm.org/viewvc/llvm-project?rev=341039&view=rev Log: [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK-MESSAGES Summary: The check_clang_tidy.py script would allow mixing of `CHECK-NOTES`

[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

rjmccall accepted this revision. rjmccall added a comment. LGTM. https://reviews.llvm.org/D51426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51440: [ToolChains] Link to compiler-rt with -L + -l when possible

mstorsjo added a comment. In https://reviews.llvm.org/D51440#1218817, @phosek wrote: > What about other compiler-rt runtimes? Shouldn't we use the same approach for > those? Yes, I guess so. > In case of multiarch runtime layout, we already add >

[PATCH] D50958: [clangd] WIP: xrefs for dynamic index.

hokein updated this revision to Diff 163284. hokein marked 8 inline comments as done. hokein added a comment. - address review comments - rescope the patch only focus on `findReferences` implementation. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50958 Files: clangd/XRefs.

[PATCH] D50958: [clangd] Implement findReferences function

hokein added inline comments. Comment at: clangd/XRefs.cpp:666 +std::vector references(ParsedAST &AST, Position Pos, + bool IncludeDeclaration, + const SymbolIndex *Index) { sammccall wrote: > I'm no

[PATCH] D51437: [clangd] Report position of opening paren in singature help

ilya-biryukov updated this revision to Diff 163286. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Clarify the docs, add example. - Parse each test separately. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51437 Files: clangd/CodeComplete.cp

[PATCH] D51437: [clangd] Report position of opening paren in singature help

ilya-biryukov added inline comments. Comment at: unittests/clangd/CodeCompleteTests.cpp:914 +TEST(SignatureHelpTest, OpeningParen) { + Annotations Code(R"cpp( sammccall wrote: > Hmm, I think this test would be easier to follow if tests 1-5 were written > sepa

[PATCH] D51296: [OpenCL] Traverse vector types for ocl extensions support

vmaksimo updated this revision to Diff 163287. vmaksimo retitled this revision from "[Sema] Traverse vector types for ocl extensions support" to "[OpenCL] Traverse vector types for ocl extensions support". vmaksimo edited the summary of this revision. Repository: rC Clang https://reviews.llvm

[PATCH] D51356: [docs][mips] Clang 7.0 Release notes

sdardis added inline comments. Comment at: ReleaseNotes.rst:121 +- On MIPS FreeBSD default CPUs have been changed to ``mips2`` + for 32-bit targets and ``mips3`` for 32-bit targets. + ``mips3`` for 64 bit targets. D48499. Repository: rC Clang https://revie

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

kbobyrev created this revision. kbobyrev added reviewers: ioeric, ilya-biryukov, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, mgrang, jkorous, MaskRay, mgorny. https://reviews.llvm.org/D51481 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

kbobyrev updated this revision to Diff 163294. kbobyrev added a comment. Stop query generation as soon as one valid URI scheme was found. https://reviews.llvm.org/D51481 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/DexIndex.cpp clang-tools-extra/clangd

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov created this revision. AlexeySachkov added reviewers: Anastasia, yaxunl. Documentation can be found at https://www.khronos.org/registry/OpenCL/extensions/intel/cl_intel_device_side_avc_motion_estimation.txt Patch by Kristina Bessonova Repository: rC Clang https://reviews.llvm.

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

Hahnfeld added a comment. In https://reviews.llvm.org/D51378#1218184, @RaviNarayanaswamy wrote: > We should just go with generating an error if the DeclareTargetNestingLevel > is not 0 at the end of compilation unit. > Hard to detect if user accidentally forgot to have end declare in header

[clang-tools-extra] r341057 - [clangd] Implement iterator cost

Author: omtcyfz Date: Thu Aug 30 04:23:58 2018 New Revision: 341057 URL: http://llvm.org/viewvc/llvm-project?rev=341057&view=rev Log: [clangd] Implement iterator cost This patch introduces iterator cost concept to improve the performance of Dex query iterators (mainly, AND iterator). Benchmarks s

[PATCH] D51310: [clangd] Implement iterator cost

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341057: [clangd] Implement iterator cost (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D51310?vs=163024&id=163297#toc Repository: rCTE Clang Tools Extra h

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

ioeric added a comment. Some high-level comments :) Comment at: clang-tools-extra/clangd/index/dex/DexIndex.h:45 + void build(std::shared_ptr> Symbols, + llvm::ArrayRef URISchemes); URI schemes are property of `Symbols`. We shouldn't need to pass

[PATCH] D51446: [OpenMP][bugfix] Add missing macros for Power

Hahnfeld requested changes to this revision. Hahnfeld added a comment. This revision now requires changes to proceed. Please also update the test. Comment at: lib/Frontend/InitPreprocessor.cpp:1115-1130 case llvm::Triple::ppc64: +if (AuxTI.getLongDoubleWidth() == 128) {

[PATCH] D51360: [clang-tidy] Use simple string matching instead of Regex

kbobyrev updated this revision to Diff 163302. kbobyrev marked an inline comment as done. kbobyrev added a comment. Ah, correct. I totally forgot about the `^string$` for the exact match. This should not change behavior now. I believe what you propose would make the code easier (there'd only be

[PATCH] D51292: [docs] Update clang-rename documentation

kbobyrev updated this revision to Diff 163305. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Herald added a subscriber: arphaman. - Fix the `.py` (should be `.el` in the second case) typo - Move piece about rename request to Clangd docs and advertise it htere - Use better wo

[PATCH] D51485: [Sema][NFC] Trivial cleanup in ActOnCallExpr

jkorous created this revision. jkorous added reviewers: rsmith, doug.gregor, JDevlieghere, thegameg. jkorous added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. Use logical or operator instead of a bool variable and if/else. Repository: rC Clang https://reviews.llvm.org

[PATCH] D51297: [docs] Create a guide for Vim users on how to setup Clangd

kbobyrev updated this revision to Diff 163306. kbobyrev added a comment. Now that there's a Wiki page on how to use Clangd with LanguageClient-neovim, we should just redirect (Neo)Vim users to that page. https://reviews.llvm.org/D51297 Files: clang-tools-extra/docs/clangd.rst Index: clang-

[PATCH] D51291: [clangd] Support multiple #include headers in one symbol.

sammccall added a comment. - It would be useful for the C++ API (CodeCompletion struct) to provide the includes/edits in ranked order, if possible. Frontends could experiment with showing all the options. - Still not sure that adding more complicated behavior to Code Complete (vs just improving

[PATCH] D51426: [Sema] Prohibit function-scope compound literals with address spaces.

ebevhan added a comment. Thanks! I don't have commit access, so it would be appreciated if someone could commit it. https://reviews.llvm.org/D51426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

ilya-biryukov added a comment. The implementation is really simple. LG! To get proper operation order in tests, we can wait in the diagnostics callback that runs on the worker thread (IIRC, we do that in some of the other tests too). Comment at: clangd/TUScheduler.cpp:188 +

[PATCH] D51485: [Sema][NFC] Trivial cleanup in ActOnCallExpr

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice cleanup, LGTM. Repository: rC Clang https://reviews.llvm.org/D51485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/DexIndex.h:45 + void build(std::shared_ptr> Symbols, + llvm::ArrayRef URISchemes); ioeric wrote: > URI schemes are property of `Symbols`. We shouldn't need to pass spec

[PATCH] D51360: [clang-tidy] Use simple string matching instead of Regex

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D51360#1219024, @kbobyrev wrote: > Ah, correct. I totally forgot about the `^string$` for the exact match. > > This should not change behavior now. I believe what yo

[clang-tools-extra] r341060 - [clangd] Fix tests after rL341057

Author: omtcyfz Date: Thu Aug 30 05:29:36 2018 New Revision: 341060 URL: http://llvm.org/viewvc/llvm-project?rev=341060&view=rev Log: [clangd] Fix tests after rL341057 Since OR iterator children are not longer sorted by the estimated size, string representation should be different. Modified:

[PATCH] D51360: [clang-tidy] Use simple string matching instead of Regex

kbobyrev updated this revision to Diff 163309. kbobyrev marked an inline comment as done. kbobyrev added a comment. Mention that the code actually performs `absl/(any|absl|library)` substring match. https://reviews.llvm.org/D51360 Files: clang-tools-extra/clang-tidy/abseil/AbseilMatcher.h

Re: r341009 - Adjust Attr representation so that changes to documentation don't affect

On Wed, Aug 29, 2018 at 9:01 PM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Wed Aug 29 18:01:07 2018 > New Revision: 341009 > > URL: http://llvm.org/viewvc/llvm-project?rev=341009&view=rev > Log: > Adjust Attr representation so that changes to documentation don't affect > how we

[clang-tools-extra] r341061 - [clang-tidy] Use simple string matching instead of Regex

Author: omtcyfz Date: Thu Aug 30 05:42:19 2018 New Revision: 341061 URL: http://llvm.org/viewvc/llvm-project?rev=341061&view=rev Log: [clang-tidy] Use simple string matching instead of Regex Instead of parsing and compiling the `llvm::Regex` each time, it's faster to use basic string matching for

[PATCH] D51360: [clang-tidy] Use simple string matching instead of Regex

This revision was automatically updated to reflect the committed changes. Closed by commit rL341061: [clang-tidy] Use simple string matching instead of Regex (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51360?v

[PATCH] D50438: [clangd] Sort GoToDefinition results.

hokein added a comment. Sorry, I just realized I didn't reply the comments in the first review (they were in my draft). Comment at: clangd/XRefs.cpp:71 +struct DeclInfo { + const Decl *D; ilya-biryukov wrote: > NIT: maybe call `Occurence` instead? As this i

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/dex/DexIndex.h:45 + void build(std::shared_ptr> Symbols, + llvm::ArrayRef URISchemes); sammccall wrote: > ioeric wrote: > > URI schemes are property of `Symbols`. We shouldn't

[PATCH] D50438: [clangd] Sort GoToDefinition results.

hokein updated this revision to Diff 163311. hokein marked 3 inline comments as done. hokein added a comment. Address review comments, return deterministic results. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50438 Files: clangd/XRefs.cpp unittests/clangd/XRefsTests.cpp

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ilya-biryukov added inline comments. Comment at: clangd/tool/ClangdMain.cpp:86 + return nullptr; +Index = AsyncLoad.get(); +return Index.get(); I believe is a data race (multiple threads may run this line concurrently). You would want some synchroniz

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ilya-biryukov added a comment. Any reason to not just wait for the index to load? Is this a UX concern or a problem when experimenting? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51475 ___ cfe-commits mailing list cfe-commits@l

r341063 - [CodeComplete] Report location of opening parens for signature help

Author: ibiryukov Date: Thu Aug 30 06:08:03 2018 New Revision: 341063 URL: http://llvm.org/viewvc/llvm-project?rev=341063&view=rev Log: [CodeComplete] Report location of opening parens for signature help Summary: Used in clangd. Reviewers: sammccall Reviewed By: sammccall Subscribers: ioeric,

[PATCH] D51436: [CodeComplete] Report location of opening parens for signature help

This revision was automatically updated to reflect the committed changes. Closed by commit rL341063: [CodeComplete] Report location of opening parens for signature help (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org

[clang-tools-extra] r341065 - [clangd] Report position of opening paren in singature help

Author: ibiryukov Date: Thu Aug 30 06:14:31 2018 New Revision: 341065 URL: http://llvm.org/viewvc/llvm-project?rev=341065&view=rev Log: [clangd] Report position of opening paren in singature help Summary: Only accessible via the C++ API at the moment. Reviewers: sammccall Reviewed By: sammccall

[PATCH] D51437: [clangd] Report position of opening paren in singature help

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341065: [clangd] Report position of opening paren in singature help (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D51437?vs=163286&id=163317#toc Repository

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

asb accepted this revision. asb added a comment. Looks good to me, thanks! Repository: rC Clang https://reviews.llvm.org/D50246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r341066 - [clangd] Remove UB introduced in rL341057

Author: omtcyfz Date: Thu Aug 30 06:30:34 2018 New Revision: 341066 URL: http://llvm.org/viewvc/llvm-project?rev=341066&view=rev Log: [clangd] Remove UB introduced in rL341057 Modified: clang-tools-extra/trunk/clangd/index/dex/Iterator.cpp Modified: clang-tools-extra/trunk/clangd/index/dex/I

[PATCH] D51446: [OpenMP][bugfix] Add missing macros for Power

kkwli0 added a comment. Need to update the test too? Repository: rC Clang https://reviews.llvm.org/D51446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ioeric updated this revision to Diff 163321. ioeric added a comment. - Fix data race. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51475 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.cpp ===

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ioeric added a comment. In https://reviews.llvm.org/D51475#1219133, @ilya-biryukov wrote: > Any reason to not just wait for the index to load? Is this a UX concern or a > problem when experimenting? The index loading can be slow. When using LLVM YAML index, I need to wait for >10s before clan

[PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

sammccall updated this revision to Diff 163322. sammccall marked 2 inline comments as done. sammccall added a comment. Herald added a subscriber: jfb. Add test, address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51438 Files: clangd/ClangdServer.cpp clangd/TUSc

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ilya-biryukov added a comment. In https://reviews.llvm.org/D51475#1219184, @ioeric wrote: > The index loading can be slow. When using LLVM YAML index, I need to wait for > >10s before clangd starts giving me anything useful. We could potentially > speed up loading (e.g. replacing yaml), but the

[PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ioeric added a comment. In https://reviews.llvm.org/D51475#1219197, @ilya-biryukov wrote: > In https://reviews.llvm.org/D51475#1219184, @ioeric wrote: > > > The index loading can be slow. When using LLVM YAML index, I need to wait > > for >10s before clangd starts giving me anything useful. We c

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

yaxunl added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:256 +CC1Args.append({"-fvisibility", "hidden"}); } arsenm wrote: > We should probably start subclassing the HIP toolchain from AMDGPU and share > more of this I'd like to defer the re

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/HIP.cpp:256 +CC1Args.append({"-fvisibility", "hidden"}); } yaxunl wrote: > arsenm wrote: > > We should probably

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

arsenm added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:256 +CC1Args.append({"-fvisibility", "hidden"}); } arsenm wrote: > yaxunl wrote: > > arsenm wrote: > > > We should probably start subclassing the HIP toolchain from AMDGPU and > > > s

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

yaxunl added inline comments. Comment at: lib/Driver/ToolChains/HIP.cpp:256 +CC1Args.append({"-fvisibility", "hidden"}); } arsenm wrote: > arsenm wrote: > > yaxunl wrote: > > > arsenm wrote: > > > > We should probably start subclassing the HIP toolchain fr

r341073 - [OPENMP][NVPTX] Add options -f[no-]openmp-cuda-force-full-runtime.

Author: abataev Date: Thu Aug 30 07:45:24 2018 New Revision: 341073 URL: http://llvm.org/viewvc/llvm-project?rev=341073&view=rev Log: [OPENMP][NVPTX] Add options -f[no-]openmp-cuda-force-full-runtime. Added options -f[no-]openmp-cuda-force-full-runtime to [not] force use of the full runtime for O

r341074 - [Sema][NFC] Trivial cleanup in ActOnCallExpr

Author: jkorous Date: Thu Aug 30 07:46:48 2018 New Revision: 341074 URL: http://llvm.org/viewvc/llvm-project?rev=341074&view=rev Log: [Sema][NFC] Trivial cleanup in ActOnCallExpr Use logical or operator instead of a bool variable and if/else. Differential Revision: https://reviews.llvm.org/D5148

[PATCH] D51485: [Sema][NFC] Trivial cleanup in ActOnCallExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL341074: [Sema][NFC] Trivial cleanup in ActOnCallExpr (authored by jkorous, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51485?vs=163304&id=

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 marked 7 inline comments as done. usaxena95 added a comment. > Could we try removing Status from the base class and move it into > `InMemoryFile` and `InMemoryDir`? Moved the Stat and **getStatus** into the subclasses. User of **getStatus** now calls **getStatus** of individual subcla

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ilya-biryukov added inline comments. Comment at: clangd/tool/ClangdMain.cpp:86 + return nullptr; +Index = AsyncLoad.get(); +return Index.get(); ioeric wrote: > ilya-biryukov wrote: > > ioeric wrote: > > > ilya-biryukov wrote: > > > > I believe is a d

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163330. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. - Moved Stat to the subclasses of InMemoryNode Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileS

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

kbobyrev updated this revision to Diff 163332. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address couple of comments. https://reviews.llvm.org/D51481 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/dex/DexIndex.cpp clang-tools-extra/

[PATCH] D51481: [clangd] Implement proximity path boosting for Dex

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/dex/DexIndex.h:45 + void build(std::shared_ptr> Symbols, + llvm::ArrayRef URISchemes); sammccall wrote: > ioeric wrote: > > URI schemes are property of `Symbols`. We shouldn

[PATCH] D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?

jkorous created this revision. jkorous added reviewers: rsmith, vsapsai, JDevlieghere. jkorous added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. Since there's no change to ArgExprs between here and the previous early exit starting at L 5333 it's effectively a dead code.

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

sammccall added a comment. I don't have a strong opinion on async vs sync - startup time is important and we shouldn't block simple AST-based functionality on the index, but this introduces some slightly confusing UX for that speed. However I think this should be based on https://reviews.llvm.o

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

sammccall added a comment. (Sorry for catching this earlier, and that the patch isn't landed yet - feel free to pick up the review, else @kbobyrev will take a first pass tomorrow I think) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51475 _

[clang-tools-extra] r341076 - [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

Author: sammccall Date: Thu Aug 30 08:07:34 2018 New Revision: 341076 URL: http://llvm.org/viewvc/llvm-project?rev=341076&view=rev Log: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed. Summary: After code completion inserts a header, running signature help using the old

[PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

This revision was automatically updated to reflect the committed changes. Closed by commit rL341076: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.

r341077 - [HIP] Add -fvisibility hidden option to clang

Author: yaxunl Date: Thu Aug 30 08:10:20 2018 New Revision: 341077 URL: http://llvm.org/viewvc/llvm-project?rev=341077&view=rev Log: [HIP] Add -fvisibility hidden option to clang AMDGPU target need -fvisibility hidden option for clang to work around a limitation of no PLT support, otherwise there

[PATCH] D51434: [HIP] Add -fvisibility hidden option to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL341077: [HIP] Add -fvisibility hidden option to clang (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51434?vs=163196&id=

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ioeric added inline comments. Comment at: clangd/tool/ClangdMain.cpp:86 + return nullptr; +Index = AsyncLoad.get(); +return Index.get(); ilya-biryukov wrote: > ioeric wrote: > > ilya-biryukov wrote: > > > ioeric wrote: > > > > ilya-biryukov wrote: >

[PATCH] D51475: [clangd] Load YAML static index asynchronously.

ioeric added a comment. In https://reviews.llvm.org/D51475#1219291, @sammccall wrote: > I don't have a strong opinion on async vs sync - startup time is important > and we shouldn't block simple AST-based functionality on the index, but this > introduces some slightly confusing UX for that spee

[PATCH] D51438: [clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.

sammccall added inline comments. Comment at: clangd/TUScheduler.cpp:474 +llvm::unique_function)> Callback) { + if (RunSync) +return Callback(getPossiblyStalePreamble()); ilya-biryukov wrote: > It seems we could remove the special-casing of `RunSync` and

[PATCH] D50438: [clangd] Sort GoToDefinition results.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LG, thanks. And a question of what are the things we can accidentally misdetect as explicit Comment at: clangd/XRefs.cpp:105 +// Sort results. Declarations

[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

lewis-revill updated this revision to Diff 163339. lewis-revill added a comment. Rebased and ensured that -fuse-init-array is always used (as intended in https://reviews.llvm.org/D50043), since addClangTargetOptions is overidden for this patch. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster added a comment. In https://reviews.llvm.org/D51378#1218184, @RaviNarayanaswamy wrote: > We should just go with generating an error if the DeclareTargetNestingLevel > is not 0 at the end of compilation unit. > Hard to detect if user accidentally forgot to have end declare in hea

[PATCH] D51488: [Sema][NFC] Small cleanup - remove dead code from ActOnCallExpr() ?

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Assuming `ArgExprs` doesn't change between those two calls this seems fine. Comment at: Sema/SemaExpr.cpp:5338 Context.DependentTy, VK_RValue, RParen

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

ilya-biryukov added inline comments. Comment at: include/clang/Basic/VirtualFileSystem.h:359 + /// Add a HardLink from one file to another. + /// Makes the UniqueID of To file same as that of From file. If CopyBuffer is ilya-biryukov wrote: > Maybe use the co

r341082 - [libFuzzer] Port to Windows

Author: morehouse Date: Thu Aug 30 08:54:44 2018 New Revision: 341082 URL: http://llvm.org/viewvc/llvm-project?rev=341082&view=rev Log: [libFuzzer] Port to Windows Summary: Port libFuzzer to windows-msvc. This patch allows libFuzzer targets to be built and run on Windows, using -fsanitize=fuzzer

[PATCH] D51022: [libFuzzer] Port to Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rC341082: [libFuzzer] Port to Windows (authored by morehouse, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D51022?vs=163338&id=163348#toc Repo

[PATCH] D51291: [clangd] Support multiple #include headers in one symbol.

ioeric updated this revision to Diff 163351. ioeric added a comment. - Return all possible #includes in CodeComplete. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51291 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/index/Index.cpp clangd/index/Index.h

[PATCH] D51422: [clangd] Factor out the data-swapping functionality from MemIndex/DexIndex.

ioeric added inline comments. Comment at: clangd/index/FileIndex.h:47 + // The shared_ptr keeps the symbols alive. + std::shared_ptr buildMemIndex(); Maybe avoid hardcoding the index name, so that we could potentially switch to use a different index implemen

[PATCH] D51177: [DEBUGINFO] Add support for emission of the debug directives only.

ABataev updated this revision to Diff 163353. ABataev added a comment. Address comment from David. Repository: rC Clang https://reviews.llvm.org/D51177 Files: include/clang/Basic/DebugInfoOptions.h include/clang/Driver/Options.td lib/CodeGen/CGDebugInfo.cpp lib/Driver/ToolChains/Clan

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan marked 5 inline comments as done. leonardchan added a comment. @rsmith When you clarify what you mean by `outermost macro expansion`? Say I have the following: #define ATTR __attribute__ #define AS(i) address_space(i) #define AS1 ATTR((address_space(1))) #define AS2 ATTR((AS(

r341083 - Test the cross-product of how libgcc-related arguments are passed to the linker.

Author: saugustine Date: Thu Aug 30 09:37:06 2018 New Revision: 341083 URL: http://llvm.org/viewvc/llvm-project?rev=341083&view=rev Log: Test the cross-product of how libgcc-related arguments are passed to the linker. Modified: cfe/trunk/test/Driver/linux-ld.c Modified: cfe/trunk/test/Drive

  1   2   3   >