[PATCH] D50901: [clang][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

lebedev.ri added a comment. ping. Repository: rC Clang https://reviews.llvm.org/D50901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50250: [clang][ubsan] Implicit Conversion Sanitizer - integer sign change - clang part

lebedev.ri added a comment. ping. Repository: rC Clang https://reviews.llvm.org/D50250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51372: FENV_ACCESS support for libm-style constrained intrinsics

kpn created this revision. kpn added a reviewer: rsmith. Herald added a reviewer: javed.absar. Herald added a subscriber: cfe-commits. This builds on https://reviews.llvm.org/D49865 to get #pragma STDC FENV_ACCESS ON to and used by AST handling of function calls to math intrinsics. This now emit

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

aaron.ballman added a comment. In https://reviews.llvm.org/D51132#1215916, @hugoeg wrote: > @aaron.ballman when you get the chance could you take another look at this > and commit if it is ready? My internship ends rather soon and this is a tad > time sensitive. Thank you for your time! When

r340867 - Revert "[libFuzzer] Port to Windows"

Author: morehouse Date: Tue Aug 28 12:07:24 2018 New Revision: 340867 URL: http://llvm.org/viewvc/llvm-project?rev=340867&view=rev Log: Revert "[libFuzzer] Port to Windows" This reverts commit r340860 due to failing tests. Modified: cfe/trunk/lib/Driver/ToolChains/MSVC.cpp Modified: cfe/tru

[PATCH] D51333: Diagnose likely typos in include statements

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:476 + ExtWarn<"likely typo, expected \"FILENAME\" or " + "but filename is '%0'">, InGroup; + This seems like the wrong warning group for this diagnostic as it doesn't r

[PATCH] D51321: [Tooling] Improve handling of CL-style options

hamzasood added a comment. Thanks for the detailed feedback; I’ll try to get a new patch up in a few hours. However I disagree with some of them (see replies). Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:124 +// Determine whether the given file path is the cla

[PATCH] D51132: [clang-tidy] abseil-redundant-strcat-calls-check

hugoeg updated this revision to Diff 162932. hugoeg added a comment. merge conflicts resolved @aaron.ballman https://reviews.llvm.org/D51132 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/RedundantStrcatCallsCheck.cpp clang-tidy/abseil/R

Re: [PATCH] D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker

LGTM On Tue, Aug 28, 2018, 7:49 AM Simon Atanasyan via Phabricator < revi...@reviews.llvm.org> wrote: > atanasyan created this revision. > atanasyan added reviewers: echristo, ruiu. > > The "-flavor old-gnu" option were introduced to enable old version of LLD > ELF linker implementation. This opt

[PATCH] D50892: [analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for record pointees

NoQ added inline comments. Comment at: test/Analysis/cxx-uninitialized-object-inheritance.cpp:802 +struct DynTBase2 { + int x; // expected-note{{uninitialized field 'static_cast(this->bptr)->DynTBase2::x'}} +}; Mmm, what's the value of casting to derived type an

[PATCH] D51311: (WIP) Type hierarchy

kadircet added inline comments. Comment at: clangd/ProtocolHandlers.cpp:70 Register("textDocument/hover", &ProtocolCallbacks::onHover); + Register("textDocument/typeHierarchy", &ProtocolCallbacks::onTypeHierarchy); Register("textDocument/documentSymbol", &ProtocolCallback

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

patricklyster created this revision. patricklyster added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. Herald added subscribers: cfe-commits, guansong. Add the capability to nest multiple declare target directives - including header files within a declare

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D51378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

teemperor updated this revision to Diff 162940. teemperor marked an inline comment as done. teemperor added a comment. - Reverted unintended change to test case that slipped into the latest diff. https://reviews.llvm.org/D43871 Files: lib/Headers/mm_malloc.h lib/Sema/SemaExceptionSpec.cpp

[PATCH] D51300: [analyzer][UninitializedObjectChecker] No longer using nonloc::LazyCompoundVal

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, looks correct to me! Comment at: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp:448-449 Loc ThisLoc = Context.getSValBuilder().getCXXThis

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

ABataev added a comment. When is ITT Notify used? Does it have some preconditions like debug info, some optimizations level etc.? https://reviews.llvm.org/D51331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 162945. JonasToth added a comment. - [Misc] comment the matcher to better understand it - [Fix] adjust the test cases to properly function now Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBasecla

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth added a subscriber: lebedev.ri. JonasToth added a comment. I had to revert the `CHECK-NOTES` change that @lebedev.ri introduced with his revision. It fails the test, i think there is an inconsistency or so in the check-clang-tidy script. I will try to figure out whats the issue. ===

[PATCH] D45050: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Charusso updated this revision to Diff 162942. Charusso marked an inline comment as done. Charusso retitled this revision from "[clang-tidy] New checker for not null-terminated result caused by strlen or wcslen" to "[clang-tidy] New checker for not null-terminated result caused by strlen(), size(

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

JonasToth updated this revision to Diff 162950. JonasToth added a comment. - [Test] use CHECK-NOTES again based on the fix in check_clang_tidy Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48714 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exce

[PATCH] D51381: [clang-tidy] fix check_clang_tidy to properly mix CHECK-NOTES and CHECK-MESSAGES

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, lebedev.ri, hokein. Herald added subscribers: cfe-commits, xazax.hun. This patch adjusts the check_clang_tidy.py script to tolerate warnings in the codepath that checks for notes. Checking for warnings itself should

[PATCH] D51380: Fix incorrect usage of std::error_category

aganea created this revision. aganea added reviewers: ilya-biryukov, zturner. Herald added a subscriber: cfe-commits. As mentionned here , this change prevents a dangling pointer in `std:error_code` by using a singleton. Repository: rC Clang htt

[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

mstorsjo created this revision. mstorsjo added reviewers: rnk, pcc. Since MinGW supports automatically importing external variables from DLLs even without the DLLImport attribute, we shouldn't mark them as DSO local unless we actually know them to be local for sure. Keep marking thread local va

r340873 - [HIP] Fix output file extension

Author: yaxunl Date: Tue Aug 28 14:09:09 2018 New Revision: 340873 URL: http://llvm.org/viewvc/llvm-project?rev=340873&view=rev Log: [HIP] Fix output file extension OffloadBundlingJobAction constructor accepts a list of JobAction as inputs. The host JobAction is the last one. The file type of Off

[PATCH] D51336: [HIP] Fix output file extension

This revision was automatically updated to reflect the committed changes. Closed by commit rC340873: [HIP] Fix output file extension (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D51336 Files: lib/Driver/Action.cpp test/Driver/hip-output-file-name.hip

[PATCH] D50892: [analyzer][UninitializedObjectChecker] Correct dynamic type is acquired for record pointees

Szelethus added inline comments. Comment at: test/Analysis/cxx-uninitialized-object-inheritance.cpp:802 +struct DynTBase2 { + int x; // expected-note{{uninitialized field 'static_cast(this->bptr)->DynTBase2::x'}} +}; NoQ wrote: > Mmm, what's the value of casting

[PATCH] D51378: [OPENMP] Add support for nested 'declare target' directives

RaviNarayanaswamy added a comment. Is there a way to tell if the header files have matching omp declare target/omp end declare target. The reason is if one of the header files is missing a matching omp end declare target all files which include it will end up having everything marked with dec

[PATCH] D51382: [MinGW] Don't mark external variables as DSO local

rnk added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:737 +// potentially could come from another DLL as DSO local. +if (GV->hasExternalLinkage() && GV->isDeclaration() && +isa(GV) && !GV->isThreadLocal()) I think this linkage and d

[PATCH] D51385: [analyzer] InnerPointerChecker: Fix a segfault.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. Return value of `dyn_cast_or_null` should be checked before use. Otherwise we may put a nul

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 162966. leonardchan marked 3 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D51329 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Lex/Preprocessor.h lib/AST/ASTContext.cpp lib/AST/TypePrin

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: lib/AST/TypePrinter.cpp:1370 + +// Remove the underlying address space so it won't be printed. +SplitQualType SplitTy = T->getModifiedType().split(); rsmith wrote: > This is unnecessary; just print the modifi

[PATCH] D50927: [Sema] Remove location from implicit capture init expr

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaLambda.cpp:1422-1424 auto Entity = InitializedEntity::InitializeLambdaCapture( Var->getIdentifier(), Field->getType(), Loc); I

[PATCH] D50564: Add support for SEH unwinding on Windows.

cdavis5x added a comment. Ping. Repository: rUNW libunwind https://reviews.llvm.org/D50564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r340879 - [X86] Add kadd intrinsics to match gcc and icc.

Author: ctopper Date: Tue Aug 28 15:32:14 2018 New Revision: 340879 URL: http://llvm.org/viewvc/llvm-project?rev=340879&view=rev Log: [X86] Add kadd intrinsics to match gcc and icc. This adds the following intrinsics: _kadd_mask64 _kadd_mask32 _kadd_mask16 _kadd_mask8 These are missing from the

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

rsmith added a comment. +@aaron.ballman for attributes-related changes. It would be easier and more precise to track the macro corresponding to an attribute in the `Parser` rather than in `Sema` (and stash it on the `ParsedAttr` for consumers such as `Sema` that want it). That way, we still ha

[PATCH] D51265: Headers: fix collisions with .h files of other projects

efriedma added a comment. Can you give the text of the error messages? If you're seeing a "typedef redefinition with different types" error, libclang is getting confused about the target. And parsing code for the wrong target cannot work in general. Repository: rC Clang https://reviews.ll

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Headers/mm_malloc.h:42 extern "C" int posix_memalign(void **__memptr, size_t __alignment, size_t __size); +extern "C" void(free)(void *ptr); +extern "C"

[PATCH] D51385: [analyzer] InnerPointerChecker: Fix a segfault.

rnkovacs added a comment. > Return value of `dyn_cast_or_null` should be checked before use. Otherwise we > may put a null pointer into the map as a key and eventually crash in > `checkDeadSymbols`. Hm, so with the last `CallDescription` patch we removed some code here that essentially checked

[PATCH] D51388: [analyzer] Legalize state manager factory injection.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. When a checker maintains a program state trait that isn't a simple list/set/map, but is a c

[PATCH] D51390: [analyzer] CallDescription: Improve array management.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. `CallDescription` constructor now accepts an `ArrayRef`, instead of two different construct

[PATCH] D51294: Fix Bug 38713: clang-format mishandles a short block after "default:" in a switch statement

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:486 return 0; +if (Line.First->is(tok::kw_default)) { + const FormatToken *Tok = Line.First->getNextNonComment(); sammccall

[PATCH] D33314: clang-format: Add option to remove semicolon at end of namespace

anatol.pomozov added a comment. Would it be possible to add a Fixer that removes unneeded semicolon after C function? https://reviews.llvm.org/D33314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D51294: Fix Bug 38713: clang-format mishandles a short block after "default:" in a switch statement

owenpan updated this revision to Diff 162989. owenpan marked an inline comment as done. owenpan added a comment. Added a comment suggested by @sammccall Repository: rC Clang https://reviews.llvm.org/D51294 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Ind

[PATCH] D51391: [clang-cl,PCH] Add support for #pragma hdrstop

mikerice created this revision. mikerice added reviewers: thakis, hans. With clang-cl, when the user specifies /Yc or /Yu without a header the compiler uses a #pragma hdrstop in the main source file to determine the end of the PCH. If a header is specified with /Yc or /Yu #pragma hdrstop has no e

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

jfb added inline comments. Comment at: lib/Sema/SemaChecking.cpp:10668 + if (Source->isAtomicType() || Target->isAtomicType()) +S.Diag(E->getBeginLoc(), diag::warn_atomic_implicit_seq_cst); + rjmccall wrote: > Why would the target be an atomic type? And if

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

rjmccall added inline comments. Comment at: lib/Sema/SemaChecking.cpp:10668 + if (Source->isAtomicType() || Target->isAtomicType()) +S.Diag(E->getBeginLoc(), diag::warn_atomic_implicit_seq_cst); + jfb wrote: > rjmccall wrote: > > Why would the target be an a

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

jfb added inline comments. Comment at: lib/Sema/SemaChecking.cpp:10668 + if (Source->isAtomicType() || Target->isAtomicType()) +S.Diag(E->getBeginLoc(), diag::warn_atomic_implicit_seq_cst); + rjmccall wrote: > jfb wrote: > > rjmccall wrote: > > > Why would t

[PATCH] D51393: Provide a method for generating deterministic IDs for pointers allocated in BumpPtrAllocator

george.karpenkov created this revision. george.karpenkov added reviewers: NoQ, bogner, chandlerc, zturner, aprantl. Herald added a subscriber: mgrang. There are many "dumping" actions available from the compiler: Clang dumps AST, Clang static analyzer dumps generated nodes in the "exploded graph"

[PATCH] D51395: [analyzer] Dump a reproducible, deterministic ID of program state to exploded graph

george.karpenkov created this revision. george.karpenkov added reviewers: dcoughlin, NoQ. Herald added subscribers: Szelethus, mikhail.ramalho, a.sidorin, mgrang, szepet, baloghadamsoftware, xazax.hun. https://reviews.llvm.org/D51395 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive

[PATCH] D51007: Test the cross-product of options that affect how libgcc-related arguments are passed to the linker.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Feel free to add any tests like this that test existing behavior without review in the future. If we want to change the behavior we should probably review that though :) -eric Repositor

[PATCH] D51084: Implement -Watomic-implicit-seq-cst

rjmccall added a comment. It says the type of the assignment expression, not the type of the LHS. C11 [6.5.16]p2: "The type of an assignment expression is the type the left operand would have after lvalue conversion." C11 [6.3.2.1]p2: "...this is called lvalue conversion. If the lvalue has qua

r340889 - Start reserving x18 by default on Android targets.

Author: pcc Date: Tue Aug 28 18:38:47 2018 New Revision: 340889 URL: http://llvm.org/viewvc/llvm-project?rev=340889&view=rev Log: Start reserving x18 by default on Android targets. Differential Revision: https://reviews.llvm.org/D45588 Modified: cfe/trunk/test/Driver/sanitizer-ld.c Modified

[PATCH] D45588: Start reserving x18 by default on Android targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rC340889: Start reserving x18 by default on Android targets. (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D45588?vs=142448&id

[PATCH] D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D51358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D51354: Fix the -print-multi-directory flag to print the selected multilib.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Repository: rC Clang https://reviews.llvm.org/D51354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

michaelwu added a comment. It shouldn't be too hard to make a test using `c-index-test`. `-test-print-type` will print out the pointee type if it's valid. Comment at: tools/libclang/CXType.cpp:448 break; +case Type::Auto: + TP = cast(TP)->getDeducedType().getTy

[PATCH] D51381: [clang-tidy] fix check_clang_tidy to properly mix CHECK-NOTES and CHECK-MESSAGES

lebedev.ri added a comment. You would still have to duplicate the check-lines for `error:` though. As it was discussed in https://reviews.llvm.org/D36892 i would think the current behavior is correct: the `CHECK-MESSAGES` vs `CHECK-NOTES` denotes the severity of the output msg that is ok to be

[PATCH] D48714: [clang-tidy] fix PR37913, templated exception factory diagnosed correctly

lebedev.ri added a comment. In https://reviews.llvm.org/D48714#1216537, @JonasToth wrote: > I had to revert the `CHECK-NOTES` change that @lebedev.ri introduced with his > revision. It fails the test, i think there is an inconsistency or so in the > check-clang-tidy script. I will try to figure

[PATCH] D51281: [libclang] Return the proper pointee type for 'auto' deduced to pointer

yvvan added a comment. You are completely right! Thanks! I did not think that -test-print-type also checks for the pointee. https://reviews.llvm.org/D51281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D51221: [clangd] Some nitpicking around the new split (preamble/main) dynamic index

sammccall added inline comments. Comment at: clangd/TUScheduler.cpp:632 bool StorePreamblesInMemory, - ParsingCallbacks &Callbacks, + std::unique_ptr Callbacks, std::chrono::steady

[PATCH] D51221: [clangd] Some nitpicking around the new split (preamble/main) dynamic index

sammccall updated this revision to Diff 163013. sammccall marked an inline comment as done. sammccall added a comment. Address review comments, add missing dynamicIndex() implementation. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51221 Files: clangd/ClangdServer.cpp cla

<    1   2