[PATCH] D50927: [Sema] Remove location from implicit capture init expr

vsk updated this revision to Diff 162764. vsk added a comment. - Partially address some of @rsmith's feedback. Instead of using the capture default location, I used the beginning location of the capture list. This results in smoother single-stepping when those two locations are on different lin

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan created this revision. leonardchan added reviewers: rsmith, rjmccall, ebevhan, mcgrathr, phosek. leonardchan added a project: clang. If an `address_space` attribute is defined in a macro, print the macro instead when diagnosing a warning or error for incompatible pointers with differe

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added a comment. Actually, after posting this I realize I didn't handle the macro expansion very well. I'll fix this first. Repository: rC Clang https://reviews.llvm.org/D51329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51331: [OPENMP] Create non-const ident_t structs.

mikerice created this revision. mikerice added a reviewer: ABataev. Herald added subscribers: jfb, guansong. ITT Notify in the OpenMP runtime uses (and writes to) the reserved_2 field in the ident_t struct. See __kmp_itt_region_forking in openmp/runtime/src/kmp_itt.inl. Currently clang is crea

[PATCH] D51332: Replace deprecated std::ios_base aliases

andobence created this revision. Herald added subscribers: cfe-commits, mgorny. This check warns the uses of the deprecated member types of std::ios_base and replaces those that have a non-deprecated equivalent. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51332 Files: clan

[PATCH] D50927: [Sema] Remove location from implicit capture init expr

rsmith added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1422-1424 auto Entity = InitializedEntity::InitializeLambdaCapture( Var->getIdentifier(), Field->getType(), Loc); InitializationKind InitKind = InitializationKind::CreateDirect(Loc, Loc, Loc); -

[PATCH] D51333: Diagnose likely typos in include statements

christylee created this revision. Herald added a subscriber: cfe-commits. When someone writes #include "" or #include " some_file.h " the compiler returns "file not fond..." with fonts and quotes that may make it hard to see there are excess quotes or surprising bytes in the filename. Th

[PATCH] D51321: [Tooling] Improve handling of CL-style options

rnk added inline comments. Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:136 + // Otherwise just check the clang file name. + return llvm::sys::path::stem(CmdLine.front()).endswith_lower("clang-cl"); +} We support being called "CL.exe", but with

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

rsmith added inline comments. Comment at: include/clang/AST/ASTContext.h:1428 + QualType equivalentType, + IdentifierInfo *AddressSpaceMacroII = nullptr); There is no reason to make this specific to addres

[PATCH] D51190: [AttrDocs]: document gnu_inline function attribute

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3514-3516 +(possibly due to being referred to by function pointer), then no out of line +definition will be emitted (instead of c99's behaviour of always emitting an +out of line definition). --

[PATCH] D6260: Add -mlong-double-64 flag

rsmith added a comment. What about `-mlong-double-128`? It seems sensible to me to add support for that at the same time. It looks like this also needs to affect name mangling. As far as I can tell from some quick testing, on ppc64-linux-gnu GCC uses `e` for 64-bit `long double` and `g` for 12

[PATCH] D51311: (WIP) Type hierarchy

kadircet added inline comments. Comment at: clangd/Protocol.h:889 + // Does this node implement the method targeted by the request? + bool DeclaresMethod; + I think comment and the name is in contradiction here, do you mean DefinesMethod? Co

[PATCH] D51265: Headers: fix collisions with .h files of other projects

andrewrk marked an inline comment as done. andrewrk added a comment. In https://reviews.llvm.org/D51265#1215060, @efriedma wrote: > What is this change actually solving? Even if the typedef is actually > redundant, it shouldn't cause a compiler error: redundant typedefs are > allowed in the la

[PATCH] D51336: [HIP] Fix output file extension

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. OffloadBundlingJobAction constructor accepts a list of JobAction as inputs. The host JobAction is the last one. The file type of OffloadBundlingJobAction should be determined by the host JobAction (the last one) instead of the fi

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

devnexen added a comment. ping https://reviews.llvm.org/D49722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r340798 - [X86] Add kortest intrinsics for 8, 32, and 64 bit masks. Add new intrinsic names for 16 bit masks.

Author: ctopper Date: Mon Aug 27 23:28:25 2018 New Revision: 340798 URL: http://llvm.org/viewvc/llvm-project?rev=340798&view=rev Log: [X86] Add kortest intrinsics for 8, 32, and 64 bit masks. Add new intrinsic names for 16 bit masks. This matches gcc and icc despite not being documented in the I

[PATCH] D50385: [clangd] Collect symbol occurrences in SymbolCollector

sammccall added a comment. This looks pretty good! Comment at: clangd/index/Index.h:376 + + llvm::ArrayRef find(const SymbolID &ID) const { + auto It = Occurrences.find(ID); assert frozen? looking up in a non-frozen array is probably a mistake. if we choo

<    1   2