cdavis5x added a comment.
Ping...
Repository:
rUNW libunwind
https://reviews.llvm.org/D50564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added a comment.
In https://reviews.llvm.org/D49511#1194716, @leonardchan wrote:
> @rsmith any more feedback on this current version? If it still looks
> incorrect to use the record this way, I don't mind simplifying it to work on
> lvalue to rvalue conversions without checking for a lea
rsmith added a comment.
In https://reviews.llvm.org/D49511#1206265, @rsmith wrote:
> In https://reviews.llvm.org/D49511#1194716, @leonardchan wrote:
>
> > @rsmith any more feedback on this current version? If it still looks
> > incorrect to use the record this way, I don't mind simplifying it to
joerg added a comment.
Is there a reason for defining them? As in: does anything outside libunwind use
them? I haven't seen such software yet.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50413
___
cfe-commits mailing list
cfe-commits@li
deannagarcia updated this revision to Diff 161526.
deannagarcia edited the summary of this revision.
deannagarcia added a comment.
This revision includes a matcher so that the warning does not trigger on
internal Abseil files.
https://reviews.llvm.org/D50580
Files:
clang-tidy/abseil/AbseilMa
thakis added a comment.
In https://reviews.llvm.org/D50979#1206211, @rsmith wrote:
> I don't think this is NFC. Testcase:
>
> long long int a, b, c, d;
> unsigned char f() { return _InterlockedCompareExchange128(&(++a), ++b, ++c,
> &(++d)); }
>
>
> Today, Clang increments `a`, `b`, `c`, and
deannagarcia added inline comments.
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23
+
+ Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"),
+ this);
hokein wrote:
> JonasToth wrote:
> > hugoeg wrote:
> > > deannaga
thakis added a comment.
In https://reviews.llvm.org/D50979#1206282, @thakis wrote:
> In https://reviews.llvm.org/D50979#1206211, @rsmith wrote:
>
> > I don't think this is NFC. Testcase:
> >
> > long long int a, b, c, d;
> > unsigned char f() { return _InterlockedCompareExchange128(&(++a), ++
kristina added a comment.
This doesn't seem like a great idea to me, it's a negligible amount of type
safety gained over using `stdint.h` types most people are more familiar with
anyway. If you need something niche like those typedefs it's probably better to
include the header and define them y
MaskRay added a comment.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D50945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: maskray
Date: Mon Aug 20 12:15:02 2018
New Revision: 340198
URL: http://llvm.org/viewvc/llvm-project?rev=340198&view=rev
Log:
[Lex] Make HeaderMaps a unique_ptr vector
Summary: unique_ptr makes the ownership clearer than a raw pointer container.
Reviewers: Eugene.Zelenko, dblaikie
Subsc
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340198: [Lex] Make HeaderMaps a unique_ptr vector (authored
by MaskRay, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50945?vs=161391&id=161530#toc
Repository:
rC Clang
https://
krytarowski added a comment.
From my point of view, the number of people who have idea about these types and
why do they differ between ABIs and OSes is so low, that it's even hard to get
someone to review it here.
Repository:
rUNW libunwind
https://reviews.llvm.org/D50413
__
kristina added a comment.
I'm all for this change except the core issue is that you're using libunwind as
a shim around the actual unwinding API provided by Windows. It would be nice to
have something that did not have to do that and was capable of performing
unwinding of SEH-style exceptions w
kbarton created this revision.
kbarton added reviewers: power-llvm-team, hfinkel, echristo, rsmith.
Herald added a subscriber: nemanjai.
This is the clang counterpart to the patch posted in
https://reviews.llvm.org/D50988.
The patch removes Darwin support from the POWER backend. A similar approa
t.p.northover added a comment.
> EmitAArch64BuiltinExpr() also emits args into Ops before the big switch (with
> some more subtlety around the last arg that I don't understand), but then
> almost every switch case does EmitScalarExpr(E->getArg(n)).
Took me a while to remember, but I can at leas
ioeric updated this revision to Diff 161537.
ioeric added a comment.
- Make sure completion result callback can be called even if the unused
speculative request has not finished.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
Files:
clangd/ClangdServer.cpp
clangd/Cla
vsk updated this revision to Diff 161536.
vsk added a comment.
- Here is a GIF that might help illustrate the bug:
http://net.vedantk.com/static/llvm/lambda-implicit-capture-bug.gif
- Update test/SemaCXX/uninitialized.cpp to highlight the behavior change which
comes from using getBeginOrDeclLoc(
rjmccall added a comment.
In https://reviews.llvm.org/D50616#1206181, @leonardchan wrote:
> I made a post on llvm-dev
> (http://lists.llvm.org/pipermail/llvm-dev/2018-August/125433.html) to see if
> other people have opinions on this. In the meantime, do you think I should
> make a separate pa
cdavis5x added a comment.
In https://reviews.llvm.org/D50564#1206302, @kristina wrote:
> I'm all for this change except the core issue is that you're using libunwind
> as a shim around the actual unwinding API provided by Windows. It would be
> nice to have something that did not have to do tha
krytarowski added a comment.
If there are no more comments, I will land this by the end of this week.
Repository:
rL LLVM
https://reviews.llvm.org/D47814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
eandrews updated this revision to Diff 161544.
eandrews added a comment.
Based on Reid's feedback, I changed option to CodeGenOption
https://reviews.llvm.org/D40925
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenModule.cpp
lib/Driver/
mstorsjo added a comment.
In https://reviews.llvm.org/D50564#1206370, @cdavis5x wrote:
> In https://reviews.llvm.org/D50564#1206302, @kristina wrote:
>
> > I'm all for this change except the core issue is that you're using
> > libunwind as a shim around the actual unwinding API provided by Windo
eandrews marked an inline comment as done.
eandrews added inline comments.
Comment at: include/clang/Basic/LangOptions.def:311
+BENIGN_LANGOPT(KeepStaticConsts , 1, 0, "keep static const variables even
if unused")
+
rnk wrote:
> Let's make this a CodeGenO
hugoeg updated this revision to Diff 161550.
hugoeg added a comment.
refined test to include some more cases as a result of the new matcher
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm!
https://reviews.llvm.org/D40925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Dmitry.Kozhevnikov created this revision.
Dmitry.Kozhevnikov added reviewers: ilya-biryukov, sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric.
By default it's 512K, which is way to small for clang parser to run on. There
is no way to do it via platfo
Author: dblaikie
Date: Mon Aug 20 13:14:08 2018
New Revision: 340206
URL: http://llvm.org/viewvc/llvm-project?rev=340206&view=rev
Log:
DebugInfo: Add the ability to disable DWARF name tables entirely
This changes the current default behavior (from emitting pubnames by
default, to not emitting the
eandrews marked an inline comment as done.
eandrews added a comment.
In https://reviews.llvm.org/D40925#1206416, @rnk wrote:
> lgtm!
Thanks!
https://reviews.llvm.org/D40925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
chandlerc added a comment.
In https://reviews.llvm.org/D47814#1206372, @krytarowski wrote:
> If there are no more comments, I will land this by the end of this week.
Just for the record, this is not OK and not how LLVM's code review works.
You can and must wait for review. I think Joerg alread
erik.pilkington created this revision.
erik.pilkington added reviewers: jfb, rsmith, aaron.ballman, rjmccall, bruno.
Herald added a subscriber: dexonsmith.
See the recent thread here:
http://lists.llvm.org/pipermail/cfe-dev/2018-July/058494.html
This patch adds the flag -fno-c++-static-destructo
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D50527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krytarowski added a comment.
@chandlerc thank you for your note. I've originally treated this change as an
obvious code change, just the reviewers regardless of reviewing an analogous
change for MUSL, had no interest in NetBSD.
Repository:
rL LLVM
https://reviews.llvm.org/D47814
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:537
+ mutable APIMisuse BT{this, "null passed to CF memory management function"};
+ CallDescription CFRetain{"CFRetain", 1},
+ CFRelease{"CFRelease", 1
a_sidorin accepted this revision.
a_sidorin added inline comments.
This revision is now accepted and ready to land.
Comment at: tools/clang-import-test/clang-import-test.cpp:199
Inv->getLangOpts()->RTTI = true;
+ Inv->getLangOpts()->Exceptions = true;
+ Inv->getLangOpts()->C
jfb added inline comments.
Comment at: clang/include/clang/AST/Decl.h:1472
+ /// Do we need to emit an exit-time destructor for this variable?
+ bool isNoDestroy(const ASTContext &) const;
This is only valid for static variables, right? It's probably better t
beanz added a comment.
Just want to bring an IRC conversation that I had with @phosek into the proper
code review.
This patch is great as-is, but if we want to extend this to Darwin there are
some problems because of how Darwin handles triples. Specifically Darwin has
multiple potentially vali
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D50527#1206460, @erik.pilkington wrote:
> Ping!
If the build came back clean, then I think our combination of previous
sign-offs is good enough. :)
https://
kadircet added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:1710
+ $bol^
+ ab$ab^
+ x.ab$dot^
Maybe an EXPECT for this one as well?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50962
__
rsmith added inline comments.
Comment at: clang/include/clang/AST/Decl.h:1472
+ /// Do we need to emit an exit-time destructor for this variable?
+ bool isNoDestroy(const ASTContext &) const;
jfb wrote:
> This is only valid for static variables, right? It's p
Author: rsmith
Date: Mon Aug 20 14:47:29 2018
New Revision: 340215
URL: http://llvm.org/viewvc/llvm-project?rev=340215&view=rev
Log:
Model type attributes as regular Attrs.
Specifically, AttributedType now tracks a regular attr::Kind rather than
having its own parallel Kind enumeration, and Attri
jfb added inline comments.
Comment at: clang/include/clang/AST/Decl.h:1472
+ /// Do we need to emit an exit-time destructor for this variable?
+ bool isNoDestroy(const ASTContext &) const;
rsmith wrote:
> jfb wrote:
> > This is only valid for static variables
steveire updated this revision to Diff 161570.
steveire added a comment.
Add dump() and supporting methods to SourceRange
Repository:
rC Clang
https://reviews.llvm.org/D50662
Files:
include/clang/Basic/SourceLocation.h
lib/Basic/SourceLocation.cpp
Index: lib/Basic/SourceLocation.cpp
==
steveire added a comment.
Thanks, I've done that now.
Repository:
rC Clang
https://reviews.llvm.org/D50662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a_sidorin requested changes to this revision.
a_sidorin added a comment.
This revision now requires changes to proceed.
Hello Stephen,
These methods will be really useful.
Comment at: lib/Basic/SourceLocation.cpp:90
+ B.print(OS, SM);
+ OS << ",\n ";
+ E.print(OS, SM);
-
rsmith added inline comments.
Comment at: lib/Basic/SourceLocation.cpp:89-93
+ B.print(OS, SM);
+ OS << ",\n ";
+ E.print(OS, SM);
+ OS << "]\n";
+}
It would seem somewhat more natural to dump `SourceRange`s the same way we dump
them in `-ast-dump`. (That is
teemperor created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D51001
Files:
test/Import/cxx-for-range/Inputs/F.cpp
test/Import/cxx-for-range/test.cpp
Index: test/Import/cxx-for-range/test
teemperor updated this revision to Diff 161580.
teemperor added a comment.
- Clarified that the Exception options in LangOpts are not related to the
dynamic_cast support by moving them above the comment (Thanks Aleksei!)
https://reviews.llvm.org/D50978
Files:
test/Import/cxx-try-catch/Inputs
Author: teemperor
Date: Mon Aug 20 15:13:24 2018
New Revision: 340220
URL: http://llvm.org/viewvc/llvm-project?rev=340220&view=rev
Log:
[ASTImporter] Add test for C++'s try/catch statements.
Summary: Also enable exceptions in clang-import-test so that we can parse the
test files.
Reviewers: a.s
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340220: [ASTImporter] Add test for C++'s try/catch
statements. (authored by teemperor, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50978
Files:
test/Import/cxx-try-catch/Inputs/F.
Author: kamil
Date: Mon Aug 20 15:29:20 2018
New Revision: 340224
URL: http://llvm.org/viewvc/llvm-project?rev=340224&view=rev
Log:
Teach libc++ to use native NetBSD's max_align_t
Summary:
The NetBSD headers ship with max_align_t, that is not
compatible with the fallback version in libc++.
There
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX340224: Teach libc++ to use native NetBSD's
max_align_t (authored by kamil, committed by ).
Herald added a subscriber: ldionne.
Repository:
rCXX libc++
https://reviews.llvm.org/D47814
Files:
inclu
erik.pilkington updated this revision to Diff 161594.
erik.pilkington marked 7 inline comments as done.
erik.pilkington added a comment.
In this new patch:
- Fix some grammar errors in the documentation.
- Add a testcase for both attributes appearing on a variable.
- Just use hasArg() in the driv
erik.pilkington added inline comments.
Comment at: clang/include/clang/AST/Decl.h:1472
+ /// Do we need to emit an exit-time destructor for this variable?
+ bool isNoDestroy(const ASTContext &) const;
jfb wrote:
> rsmith wrote:
> > jfb wrote:
> > > This is on
aaronpuchert updated this revision to Diff 161595.
aaronpuchert added a comment.
Proper capitalization of member function, reduction of test code.
Repository:
rC Clang
https://reviews.llvm.org/D49885
Files:
lib/Analysis/ThreadSafety.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index
aaronpuchert updated this revision to Diff 161596.
aaronpuchert added a comment.
Formatting changes.
Repository:
rC Clang
https://reviews.llvm.org/D49885
Files:
lib/Analysis/ThreadSafety.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn-thread-safety-analysis.cpp
Author: compnerd
Date: Mon Aug 20 15:50:18 2018
New Revision: 340228
URL: http://llvm.org/viewvc/llvm-project?rev=340228&view=rev
Log:
libclang: add install/distribution targets for python
Add installation support for the python bindings for libclang. Add an
additional CMake configuration variab
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Seems fine to me, once you add the test for always_destroy + no_destroy.
Comment at: clang/include/clang/Basic/LangOptions.def:311
+LANGOPT(RegisterStaticDestructors, 1, 1,
aaronpuchert updated this revision to Diff 161598.
aaronpuchert added a comment.
Reformat tests. I promise, this is the last one.
Repository:
rC Clang
https://reviews.llvm.org/D49885
Files:
lib/Analysis/ThreadSafety.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/wa
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp:537
+ mutable APIMisuse BT{this, "null passed to CF memory management function"};
+ CallDescription CFRetain{"CFRetain", 1},
+ CFRelease{"CFRelease", 1},
--
jfb accepted this revision.
jfb added inline comments.
Comment at: clang/include/clang/AST/Decl.h:1472
+ /// Do we need to emit an exit-time destructor for this variable?
+ bool isNoDestroy(const ASTContext &) const;
erik.pilkington wrote:
> jfb wrote:
> > rs
delesley accepted this revision.
delesley added a comment.
This looks good to me. Thanks for the patch.
Comment at: lib/Analysis/ThreadSafety.cpp:932
+ // We're relocking the underlying mutexes. Warn on double locking.
+ if (FSet.findLock(FactMan, UnderCp))
+
saugustine created this revision.
saugustine added a reviewer: echristo.
Herald added a subscriber: cfe-commits.
NFC. Add tests to verify how the driver passes libgcc arguments to the linker
Repository:
rC Clang
https://reviews.llvm.org/D51007
Files:
test/Driver/linux-ld.c
Index: test/Dr
saugustine added a comment.
I am refactoring the code that does this, in preparation for adding support for
-shared-libgcc, and, after that, shared compiler-rt. These tests are to defend
against mistakes in that refactoring and prepare for correct handling of the
other cases.
Repository:
rC
metzman created this revision.
Herald added a subscriber: cfe-commits.
This allows -fsanitize=fuzzer and -fsanitize=fuzzer-no-link to be used on
Windows.
When either used, Clang will also use some default flags that are needed (such
as incremental linking and debug).
Repository:
rC Clang
ht
nickdesaulniers created this revision.
nickdesaulniers added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Building the Linux kernel with clang is now broken as of commit
cafa0010cd51 ("Raise the minimum required gcc version to 4.6").
We were getting lucky that Clang previous
aheejin created this revision.
aheejin added a reviewer: dschuff.
Herald added subscribers: cfe-commits, jfb, sunfish, jgravelle-google, sbc100.
We decided to revert this from i64 to i32 in Nov 28 CG meeting. Fixes
PR38632.
Repository:
rC Clang
https://reviews.llvm.org/D51013
Files:
includ
metzman added a reviewer: morehouse.
metzman added a comment.
Matt could you please take a look at this?
I'll add rnk as reviewer once you sign off, since he is a CODE_OWNER for
Windows in Clang.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D51008
__
Author: aheejin
Date: Mon Aug 20 16:49:34 2018
New Revision: 340235
URL: http://llvm.org/viewvc/llvm-project?rev=340235&view=rev
Log:
[WebAssembly] Revert type of wake count in atomic.wake to i32
Summary:
We decided to revert this from i64 to i32 in Nov 28 CG meeting. Fixes
PR38632.
Reviewers: d
This revision was automatically updated to reflect the committed changes.
Closed by commit rC340235: [WebAssembly] Revert type of wake count in
atomic.wake to i32 (authored by aheejin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51013?vs=161615&id=161620#toc
Repository:
morehouse added a comment.
LGTM
Comment at: lib/Driver/ToolChains/MSVC.cpp:373
+ TC.getCompilerRTArgString(Args, "fuzzer",
false)));
+CmdArgs.push_back(Args.MakeArgString("-debug"));
+// Prevent the linker from padding sections we use for in
metzman added inline comments.
Comment at: lib/Driver/ToolChains/MSVC.cpp:373
+ TC.getCompilerRTArgString(Args, "fuzzer",
false)));
+CmdArgs.push_back(Args.MakeArgString("-debug"));
+// Prevent the linker from padding sections we use for instr
rsmith added a comment.
We are not fully compatible with any version of GCC later than 4.2, as we do
not implement `__builtin_va_arg_pack` / `__builtin_va_arg_pack_len`. These
builtins are used by the glibc headers if we claim to be GCC >= 4.3 (at least
according to
http://clang.llvm.org/docs/
rsmith added a comment.
Another possibility would be to add a command-line argument to set the version
of GCC that clang pretends to be. We have a similar mechanism for our MSVC
compatibility mode already.
Repository:
rC Clang
https://reviews.llvm.org/D51011
_
tstellar created this revision.
tstellar added a reviewer: homerdin.
Repository:
rT test-suite
https://reviews.llvm.org/D51020
Files:
MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMR/MallocPlus.h
Index: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMR/MallocPlus.h
=
tstellar created this revision.
tstellar added a reviewer: Sunil_Srivastava.
The check lines for this test assume the old c++11 ABI.
This resolved PR33132.
Repository:
rT test-suite
https://reviews.llvm.org/D51021
Files:
ABI-Testsuite/test/mangling/test.xpp
Index: ABI-Testsuite/test/man
ahatanak created this revision.
ahatanak added a reviewer: rjmccall.
Herald added a subscriber: dexonsmith.
Currently IRGen doesn't handle variables captured by a block correctly when the
variable is captured by reference by a lambda that encloses the block.
For example, in the following code, t
101 - 177 of 177 matches
Mail list logo
