thakis accepted this revision.
thakis added a comment.
Thanks! Do you need someone to land this?
https://reviews.llvm.org/D50640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vedantk
Date: Thu Aug 16 15:24:47 2018
New Revision: 339955
URL: http://llvm.org/viewvc/llvm-project?rev=339955&view=rev
Log:
[InstrProf] Use atomic profile counter updates for TSan
Thread sanitizer instrumentation fails to skip all loads and stores to
profile counters. This can happen if
hugoeg updated this revision to Diff 161130.
hugoeg added a comment.
added IsInAbseilFile Matcher
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.cpp
clang-tidy/abseil/NoInternalDepsChec
arphaman marked 2 inline comments as done.
arphaman added inline comments.
Comment at: lib/Basic/SourceManager.cpp:2035
+ "Passed invalid source location!");
+ assert(Start.isFileID() && End.isFileID() && Loc.isFileID() &&
+ "Passed non-file source location!");
-
arphaman updated this revision to Diff 161132.
arphaman marked an inline comment as done.
arphaman added a comment.
- Use lambda
- Work with spelling locs
Repository:
rC Clang
https://reviews.llvm.org/D50740
Files:
include/clang/Basic/SourceManager.h
lib/Basic/SourceManager.cpp
unittes
This brakes some bots
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/22441
/b/sanitizer-x86_64-linux-fast/build/libcxx_build_msan/include/c++/v1/algorithm:648:10:
fatal error: 'bit' file not found
#include
^
1 error generated.
On Thu, Aug 16, 2018 at 2:36 PM M
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/27733
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/14670
On Thu, Aug 16, 2018 at 3:30 PM Vitaly Buka wrote:
> This brakes some bots
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/2
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mikerice added a comment.
In https://reviews.llvm.org/D50640#1203314, @thakis wrote:
> Thanks! Do you need someone to land this?
Feel free to commit it if you want. Otherwise I'll have my colleague take care
of it in the morning. Thanks!
https://reviews.llvm.org/D50640
_
rsmith added a comment.
In https://reviews.llvm.org/D50740#1203126, @arphaman wrote:
> In https://reviews.llvm.org/D50740#1202248, @jkorous wrote:
>
> > Hi Alex, nice work!
> >
> > I am just wondering if it would be beneficial to assert Loc and End are in
> > the same file. It might help to catc
rsmith added inline comments.
Comment at: clang/lib/Sema/SemaInit.cpp:6927-6928
} else if (isa(L)) {
-Diag(DiagLoc, diag::warn_ret_addr_label) << DiagRange;
+if (LK == LK_Return)
+ Diag(DiagLoc, diag::warn_ret_addr_label) << DiagRange;
} els
ahatanak updated this revision to Diff 161137.
ahatanak added a comment.
Try harder to shorten the names of block descriptor global variables.
The strings extracted from the names of the copy and dispose helpers are merged
whenever it is possible to do so. The block layout string doesn't include
rjmccall added a comment.
Okay.
Repository:
rC Clang
https://reviews.llvm.org/D50783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:271-276
llvm::GlobalVariable *global =
-elements.finishAndCreateGlobal("__block_descriptor_tmp",
- CGM.getPointerAlign(),
- /*constant*/ t
Author: vedantk
Date: Thu Aug 16 16:19:50 2018
New Revision: 339964
URL: http://llvm.org/viewvc/llvm-project?rev=339964&view=rev
Log:
Relax a CHECK line to allow for dso_local
Fixes a bot failure:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/11806
Modified:
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:271-276
llvm::GlobalVariable *global =
-elements.finishAndCreateGlobal("__block_descriptor_tmp",
- CGM.getPointerAlign(),
- /*constant*/
leonardchan added a comment.
In https://reviews.llvm.org/D50616#1202034, @ebevhan wrote:
> I think I've mentioned this before, but I would like to discuss the
> possibility of adding a target hook(s) for some of these operations
> (conversions, arithmetic when it comes). Precisely matching the
arphaman updated this revision to Diff 161142.
arphaman marked 3 inline comments as done.
arphaman added a comment.
address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D49462
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
li
arphaman added a comment.
Sorry for the delay.
In https://reviews.llvm.org/D49462#1166032, @rjmccall wrote:
> Hmm. I think this is a reasonable change to make to the language. Have you
> investigated to see if this causes source-compatibility problems?
Yes, I tested this change on internal
mclow.lists created this revision.
mclow.lists added reviewers: ldionne, EricWF.
Still NFC here.
1. Take the 9 functions that each had an `#ifndef _LIBCPP_COMPILER_MSVC` ..
`#else` .. `endif` block in them and make just two blocks, each with 9
functions. Much easier to read, but makes for a ter
mclow.lists added inline comments.
Comment at: include/bit:113
inline _LIBCPP_INLINE_VISIBILITY
unsigned __clz(unsigned __x) {
static_assert(sizeof(unsigned) == sizeof(unsigned long), "");
Missed this one. Should be `int`
https://reviews.llvm.org/D50876
Author: juliehockett
Date: Thu Aug 16 16:50:51 2018
New Revision: 339966
URL: http://llvm.org/viewvc/llvm-project?rev=339966&view=rev
Log:
Revert "Implement a (simple) Markdown generator"
This reverts commit r339948, as it's breaking a few bots in ways that I
can't reproduce right now.
Removed:
Author: dblaikie
Date: Thu Aug 16 16:56:32 2018
New Revision: 339968
URL: http://llvm.org/viewvc/llvm-project?rev=339968&view=rev
Log:
Disable pubnames in NVPTX debug info using metadata
Added:
cfe/trunk/test/CodeGen/debug-nvptx.c
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified:
Author: hubert.reinterpretcast
Date: Thu Aug 16 16:56:54 2018
New Revision: 339969
URL: http://llvm.org/viewvc/llvm-project?rev=339969&view=rev
Log:
[libc++] Use correct rand.eng.mers all-zeroes seed sequence fallback
Summary:
When a seed sequence would lead to having no non-zero significant bits
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX339969: [libc++] Use correct rand.eng.mers all-zeroes seed
sequence fallback (authored by hubert.reinterpretcast, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50736?vs=160923&id=
Author: vitalybuka
Date: Thu Aug 16 16:57:16 2018
New Revision: 339971
URL: http://llvm.org/viewvc/llvm-project?rev=339971&view=rev
Log:
Revert "Establish the header. NFC yet. Reviewed as
https://reviews.llvm.org/D50815";
Breaks build on sanitizer bots.
This reverts commit r339943.
Removed:
vitalybuka reopened this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
Reverted r339971 as it breaks sanitizer bots
https://reviews.llvm.org/D50815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
rnk created this revision.
rnk added reviewers: majnemer, inglorion, hans.
Herald added subscribers: dexonsmith, JDevlieghere, aprantl, mehdi_amini.
This is needed to avoid conflicts in mangled names for codeview types in
anonymous namespaces. In CodeView, types refer to each other typically
throu
rnk updated this revision to Diff 161148.
rnk added a comment.
- return to avoid bad notes
https://reviews.llvm.org/D50805
Files:
clang/lib/Sema/SemaInit.cpp
clang/test/Sema/statements.c
Index: clang/test/Sema/statements.c
==
tra added a comment.
It appears that libcxx/include/CMakeLists.txt needs to be updated to include
`bit` file into the file set.
https://reviews.llvm.org/D50815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
majnemer added a comment.
How does MSVC handle this case? What mangled name does it generate?
https://reviews.llvm.org/D50877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
IIRC it’s `?A0xABCDABCD@` where the hex value is some kind of hash
On Thu, Aug 16, 2018 at 5:27 PM David Majnemer via Phabricator <
revi...@reviews.llvm.org> wrote:
> majnemer added a comment.
>
> How does MSVC handle this case? What mangled name does it generate?
>
>
> https://reviews.llvm.org/D5
zturner added subscribers: rnk, zturner.
zturner added a comment.
IIRC it’s `?A0xABCDABCD@` where the hex value is some kind of hash
https://reviews.llvm.org/D50877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Rakete added a comment.
It would be nice to be able to diagnose `X`:
template
struct Foo {
struct [[trivially_relocatable]] X { // no warning
X(X &&) = delete;
};
};
Foo f; // no warning
static_assert(!__is_trivially_relocatable(Foo::X)); // ok
But otherwise, you
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/abseil-faster-strsplit-delimiter.rst:6
+
+This check triggers on calls to ``absl::StrSplit()`` or ``absl::MaxSplits()``
+where the delimiter is a single character string literal. The check will offer
---
mgrang updated this revision to Diff 161152.
mgrang added a comment.
Changed patch to use AST Matchers.
https://reviews.llvm.org/D50488
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp
mgrang added a comment.
This was my first time using AST matchers so it took me a while to figure out
how exactly to get this right. clang-query helped a lot. Backspace seems to be
a problem with clang-query though.
https://reviews.llvm.org/D50488
___
inglorion added inline comments.
Comment at: clang/lib/AST/MicrosoftMangle.cpp:389
+ if (FE) {
+llvm::MD5 Hasher;
+llvm::MD5::MD5Result Hash;
Instead of MD5, can we use xxhash (or whatever the fastest hash algorithm in
LLVM is these days)? I don't think
Hello everyone,
Below are some buildbot numbers for the week of 7/29/2018 - 8/04/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to r
Hello everyone,
Below are some buildbot numbers for the last week of 8/05/2018 - 8/11/2018.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
ahatanak updated this revision to Diff 161155.
ahatanak marked an inline comment as done.
ahatanak added a comment.
Mark the block descriptor global variable as `unnamed_addr`.
Repository:
rC Clang
https://reviews.llvm.org/D50783
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
l
Rakete requested changes to this revision.
Rakete added a comment.
This revision now requires changes to proceed.
Your patch breaks a lot of stuff in the test suite. For example:
void f() {
int A = 0;
(A++, A) = 1; // warning from this patch, but this is perfectly valid since
f
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339979: [hexagon] restore -fuse-cxa-atexit by default
(authored by bcain, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D50816?vs=160928&id=16
tejohnson created this revision.
tejohnson added a reviewer: pcc.
Herald added subscribers: dexonsmith, steven_wu, eraman, inglorion, mehdi_amini.
The number of threads used for ThinLTO backend parallelism was
dropped to the number of cores in r284618 to avoid oversubscribing
physical cores due to
Author: bcain
Date: Thu Aug 16 20:53:51 2018
New Revision: 339979
URL: http://llvm.org/viewvc/llvm-project?rev=339979&view=rev
Log:
[hexagon] restore -fuse-cxa-atexit by default
"-fno-use-cxa-atexit" was a default provided by the initial
commit offering hexagon support. This is no longer require
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D50882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
shuaiwang created this revision.
shuaiwang added a reviewer: hokein.
Herald added subscribers: cfe-commits, Szelethus, a.sidorin, xazax.hun.
Herald added a reviewer: george.karpenkov.
For smart pointers like std::unique_ptr which uniquely owns the
underlying object, treat the mutation of the point
mgrang updated this revision to Diff 161165.
mgrang edited the summary of this revision.
mgrang added a comment.
Added checks for more algorithms: stable_sort, is_sorted, partial_sort,
partition, stable_partition, nth_element.
https://reviews.llvm.org/D50488
Files:
include/clang/StaticAnalyz
rjmccall added inline comments.
Comment at: test/CodeGenObjC/forward-declare-protocol-gnu.m:6
-Protocol *getProtocol(void)
-{
- return @protocol(P);
-}
+@interface I
+@end
arphaman wrote:
> rjmccall wrote:
> > Does this really not require a defin
rjmccall added a comment.
In https://reviews.llvm.org/D50616#1203446, @leonardchan wrote:
> In https://reviews.llvm.org/D50616#1202034, @ebevhan wrote:
>
> > I think I've mentioned this before, but I would like to discuss the
> > possibility of adding a target hook(s) for some of these operation
201 - 250 of 250 matches
Mail list logo
