[PATCH] D50739: Clean up macros to detect underling C library functionality

mclow.lists added inline comments. Comment at: include/__config:433 -#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L +#if __ISO_C_VISIBLE >= 2011 # if defined(__FreeBSD__) Should we be using `__ISO_C_VISIBLE` here, or `__STDC_VERSION__`? I didn't change

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Szelethus. Looks great, let's land this! https://reviews.llvm.org/D32747 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D50739: Clean up macros to detect underling C library functionality

ldionne added inline comments. Comment at: include/__config:433 -#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L +#if __ISO_C_VISIBLE >= 2011 # if defined(__FreeBSD__) mclow.lists wrote: > Should we be using `__ISO_C_VISIBLE` here, or `__STDC_VERSION__`

[PATCH] D50740: [SourceManager] isPointWithin: avoid using isBeforeInTranslationUnit, compare buffer offsets directly for lexical correctness

arphaman created this revision. arphaman added reviewers: jkorous, klimek, ioeric, vsapsai, ilya-biryukov. Herald added a subscriber: dexonsmith. The current implementation of `isPointWithin` uses `isBeforeInTranslationUnit` to check if a location is within a range. The problem is that `isPointWi

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Szelethus. Looks good. I guess we may have to tone down the heuristic about "all template functions" if we see it fail. @a.sidorin and @whisperity have some valid minor co

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like keys

NoQ added a comment. I guess one of the things the analyzer could find with path-sensitive analysis is direct comparison of non-aliasing pointers. Not only this is non-deterministic, but there's a related problem that comparison for equality would always yield false and is therefore useless. Ho

[PATCH] D50739: Clean up macros to detect underling C library functionality

ldionne added inline comments. Comment at: include/__config:433 -#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L +#if __ISO_C_VISIBLE >= 2011 # if defined(__FreeBSD__) ldionne wrote: > mclow.lists wrote: > > Should we be using `__ISO_C_VISIBLE` here, or

[clang-tools-extra] r339737 - [clangd] add missing test from r339454

Author: arphaman Date: Tue Aug 14 15:20:35 2018 New Revision: 339737 URL: http://llvm.org/viewvc/llvm-project?rev=339737&view=rev Log: [clangd] add missing test from r339454 I forgot to checkin the test for the fixits into SVN. Added: clang-tools-extra/trunk/test/clangd/fixits-embed-in-diagn

[clang-tools-extra] r339738 - [clangd] add an extension field to LSP to transfer the diagnostic's category

Author: arphaman Date: Tue Aug 14 15:21:40 2018 New Revision: 339738 URL: http://llvm.org/viewvc/llvm-project?rev=339738&view=rev Log: [clangd] add an extension field to LSP to transfer the diagnostic's category This patch adds a 'category' extension field to the LSP diagnostic that's sent by Cla

[PATCH] D50571: [clangd] add an extension field to LSP to transfer the diagnostic's category

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE339738: [clangd] add an extension field to LSP to transfer the diagnostic's category (authored by arphaman, committed by ). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50571 Files:

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Szelethus. I think this patch is in good shape. In https://reviews.llvm.org/D32859#1187551, @baloghadamsoftware wrote: > I do not see which lines exactly you commented T

[PATCH] D32906: [Analyzer] Iterator Checker - Part 10: Support for iterators passed as parameter

NoQ requested changes to this revision. NoQ added a comment. This revision now requires changes to proceed. Herald added subscribers: Szelethus, mikhail.ramalho. Let's see if this is still necessary after https://reviews.llvm.org/D49443. Iterators will be constructed directly into the argument re

[clang-tools-extra] r339739 - [clangd] update the new test to check for diagnostic's category as well

Author: arphaman Date: Tue Aug 14 15:27:03 2018 New Revision: 339739 URL: http://llvm.org/viewvc/llvm-project?rev=339739&view=rev Log: [clangd] update the new test to check for diagnostic's category as well Modified: clang-tools-extra/trunk/test/clangd/fixits-embed-in-diagnostic.test Modifie

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. I don't have any other comments. Looks good to me. Repository: rCXX libc++ https://reviews.llvm.org/D50341 ___ cfe-commits mailing list cfe-

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert updated this revision to Diff 160719. aaronpuchert added a comment. Found a much simpler solution. After introducing a new virtual function HandleLock() in FactEntry, I just needed to change two lines in ThreadSafetyAnalyzer::addLock. Changes in BuildLockset::handleCall are no long

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert marked 4 inline comments as done. aaronpuchert added a comment. @aaron.ballman Maybe you can have a look again — this is much more elegant. I'm not sure why I didn't see this in the first place. Comment at: test/SemaCXX/warn-thread-safety-analysis.cpp:2765-2768 +

[PATCH] D49890: Clang-Tidy Export Problem

TheAhmad added a comment. In https://reviews.llvm.org/D49890#1182556, @alexfh wrote: > Could you describe the specific problem you're solving and provide an > example? As mentioned by others, a test would be very welcome as well. Sorry for so much delay, @alexfh. I didn't see your comment. I

[PATCH] D50748: [libc++] Detect C11 features on non-Clang compilers

ldionne created this revision. ldionne added a reviewer: mclow.lists. Herald added a reviewer: EricWF. Herald added subscribers: cfe-commits, dexonsmith, christof, krytarowski. The macros were inside `#if defined(_LIBCPP_COMPILER_CLANG)`, which means we would never detect C11 features on non-Clang

[PATCH] D50748: [libc++] Detect C11 features on non-Clang compilers

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D50748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[libcxx] r339741 - [libc++] Detect C11 features on non-Clang compilers

Author: ldionne Date: Tue Aug 14 17:16:41 2018 New Revision: 339741 URL: http://llvm.org/viewvc/llvm-project?rev=339741&view=rev Log: [libc++] Detect C11 features on non-Clang compilers Summary: The macros were inside `#if defined(_LIBCPP_COMPILER_CLANG)`, which means we would never detect C11 fe

[PATCH] D50748: [libc++] Detect C11 features on non-Clang compilers

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX339741: [libc++] Detect C11 features on non-Clang compilers (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D50748?vs=160725&id=160727#toc Repository: rCXX l

[libcxx] r339742 - [libc++] Disable failing C11 feature tests for and

Author: ldionne Date: Tue Aug 14 17:18:01 2018 New Revision: 339742 URL: http://llvm.org/viewvc/llvm-project?rev=339742&view=rev Log: [libc++] Disable failing C11 feature tests for and Summary: Those tests are breaking the test bots. A Bugzilla has been filed to make sure those tests are re-ena

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

This revision was automatically updated to reflect the committed changes. Closed by commit rL339743: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions (authored by ldionne, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[libcxx] r339743 - [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

Author: ldionne Date: Tue Aug 14 17:30:03 2018 New Revision: 339743 URL: http://llvm.org/viewvc/llvm-project?rev=339743&view=rev Log: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions Summary: Since r338934, Clang emits an error when aligned allocation functions are used in c

r339745 - [analyzer] Add support for constructors of arguments.

Author: dergachev Date: Tue Aug 14 17:33:55 2018 New Revision: 339745 URL: http://llvm.org/viewvc/llvm-project?rev=339745&view=rev Log: [analyzer] Add support for constructors of arguments. Once CFG-side support for argument construction contexts landed in r338436, the analyzer could make use of

r339747 - Silence "unused variable" warning.

Author: rsmith Date: Tue Aug 14 18:06:30 2018 New Revision: 339747 URL: http://llvm.org/viewvc/llvm-project?rev=339747&view=rev Log: Silence "unused variable" warning. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngi

[PATCH] D50670: Implementation of multiple loops in cxx_loop_proto

emmettneyman updated this revision to Diff 160740. emmettneyman added a comment. Changed the multiloop protos to nested loop protos. All the protos have an inner loop and an outer loop. Repository: rC Clang https://reviews.llvm.org/D50670 Files: clang/tools/clang-fuzzer/cxx_loop_proto.pro

[PATCH] D50755: [Driver] -print-target-triple and -print-effective-triple options

phosek created this revision. phosek added reviewers: beanz, rnk. Herald added a subscriber: cfe-commits. These can be used to print Clang target and effective triple. Repository: rC Clang https://reviews.llvm.org/D50755 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Drive

<    1   2   3