[PATCH] D50547: [Driver] Use normalized triples for multiarch runtime path

rnk added a comment. Would it be to much to check both the normalized and non-normalized? Repository: rC Clang https://reviews.llvm.org/D50547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r339632 - Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for

Author: ahatanak Date: Mon Aug 13 17:15:41 2018 New Revision: 339632 URL: http://llvm.org/viewvc/llvm-project?rev=339632&view=rev Log: Fix check strings in test/CodeGenObjC/arc-blocks.m in preperation for fixing a bug introduced in r339438. Check the descriptor global variables in the IR at both

r339633 - [CodeGen] Before returning a copy/dispose helper function, bitcast it to

Author: ahatanak Date: Mon Aug 13 17:15:42 2018 New Revision: 339633 URL: http://llvm.org/viewvc/llvm-project?rev=339633&view=rev Log: [CodeGen] Before returning a copy/dispose helper function, bitcast it to a void pointer type. This fixes a bug introduced in r339438. Modified: cfe/trunk/lib

[PATCH] D50683: [Android] Set NewAlign for 64-bit Android to 8 bytes

pirama created this revision. pirama added reviewers: rsmith, srhines. Android uses jemalloc allocator, which returns 8-byte-aligned pointers for allocations smaller than 8 bytes for 64-bit architectures. Set NewAlign conservatively to 8 bytes. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > BillyONeal wrote: > >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal updated this revision to Diff 160498. BillyONeal edited the summary of this revision. BillyONeal added a comment. Remove changes to detach tests. https://reviews.llvm.org/D50549 Files: test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp Index: tes

[PATCH] D50630: [AST] Update/correct the static_asserts for the bit-fields in Type

rjmccall added a comment. In https://reviews.llvm.org/D50630#1198053, @riccibruno wrote: > I actually did exactly this. My approach was to extend what is already done, > that is add nested classes SomethingBitfields in Type and add an instance of > each to the anonymous union. The classes which

[PATCH] D50678: [InlineAsm] Update the min-legal-vector-width function attribute based on inputs and outputs to inline assembly

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D50678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert reopened this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. This didn't cross my mind, because an `ACQUIRES` attribute with arguments on a function other than the constructor does not add the argument locks to the set of managed mutexes. So

[PATCH] D50526: Model type attributes as regular Attrs

rnk added a comment. I suspect that somehow this change broke compiling ATL: https://ci.chromium.org/buildbot/chromium.clang/ToTWin64%28dbg%29/993 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTWin64_dbg_%2F995%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Flogs%2Fraw_io.output_failur

r339638 - Revert r339623 "Model type attributes as regular Attrs."

Author: rnk Date: Mon Aug 13 18:55:37 2018 New Revision: 339638 URL: http://llvm.org/viewvc/llvm-project?rev=339638&view=rev Log: Revert r339623 "Model type attributes as regular Attrs." This breaks compiling atlwin.h in Chromium. I'm sure the code is invalid in some way, but we put a lot of work

[PATCH] D50526: Model type attributes as regular Attrs

rnk added a comment. I went ahead and reverted this in https://reviews.llvm.org/rC339638, and will produce a reduction soon. Repository: rC Clang https://reviews.llvm.org/D50526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert updated this revision to Diff 160505. aaronpuchert added a comment. Fix crash. The problem was that ACQUIRES with arguments did not no longer have (only) `this` as argument, hence our assumption that we would have only ScopedLockableFactEntry's was false. So now we lock a bit closer

[PATCH] D50341: [libcxx] Fix XFAILs for aligned allocation tests on older OSX versions

vsapsai added a comment. What about defining a feature for unsupported configurations? I've tried if '__cpp_aligned_new' not in macros or \ intMacroValue(macros['__cpp_aligned_new']) < 201606: self.config.available_features.add('libcpp-no-aligned-new') and `// UNSUPPORTED: libc

[PATCH] D49885: Thread safety analysis: Allow relockable scopes

aaronpuchert added a comment. The case distinction in `case attr::AcquireCapability` is not very beautiful, but it's due to the fact that scoped capabilities are not "real" capabilities and so we need to distinguish them. What this still doesn't allow for is attributes on other classes than the

[PATCH] D50663: [libunwind] [cmake] Add MINGW_LIBRARIES to the linker flags

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rUNW libunwind https://reviews.llvm.org/D50663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: r339428 - Add Windows support for the GNUstep Objective-C ABI V2.

Hello David, This commit broke the following test on the expensive check builder: CodeGenObjC/2007-04-03-ObjcEH.m The last green build is for r339427 - http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/11726 r339428 makes it red - http://lab.llvm.org:8011/builders/ll

r339641 - [CStringSyntaxChecker] Check strlcat sizeof check

Author: devnexen Date: Mon Aug 13 22:12:53 2018 New Revision: 339641 URL: http://llvm.org/viewvc/llvm-project?rev=339641&view=rev Log: [CStringSyntaxChecker] Check strlcat sizeof check - Assuming strlcat is used with strlcpy we check as we can if the last argument does not equal os not larger t

[PATCH] D49722: [CStringSyntaxChecker] Check strlcat sizeof check

This revision was automatically updated to reflect the committed changes. Closed by commit rL339641: [CStringSyntaxChecker] Check strlcat sizeof check (authored by devnexen, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49722?vs=1602

[libunwind] r339642 - [cmake] Add MINGW_LIBRARIES to the linker flags

Author: mstorsjo Date: Mon Aug 13 23:13:36 2018 New Revision: 339642 URL: http://llvm.org/viewvc/llvm-project?rev=339642&view=rev Log: [cmake] Add MINGW_LIBRARIES to the linker flags This is essential when building with -nodefaultlibs. In some CMake versions (noticed in 3.5.1), the same librarie

[PATCH] D50663: [libunwind] [cmake] Add MINGW_LIBRARIES to the linker flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL339642: [cmake] Add MINGW_LIBRARIES to the linker flags (authored by mstorsjo, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit: https://reviews.llvm.org/D50663?

[PATCH] D46892: [X86] Lowering addus/subus intrinsics to native IR (Clang part)

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D46892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

<    1   2   3