stella.stamenova updated this revision to Diff 159395.
Repository:
rC Clang
https://reviews.llvm.org/D50281
Files:
test/Tooling/clang-diff-json.cpp
Index: test/Tooling/clang-diff-json.cpp
===
--- test/Tooling/clang-diff-json.c
george.karpenkov added a comment.
@Szelethus in any case, could you commit this change for now? I'm very keen on
seeing the results on a few of our internal projects, and it's much easier to
do that once the change is committed.
https://reviews.llvm.org/D49438
__
jfb created this revision.
Herald added subscribers: cfe-commits, dexonsmith.
r337887 started using memset for automatic variable initialization where
sensible. A follow-up discussion leads me to believe that we should better test
automatic variable initialization, and that there are probably fo
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1643
+if (Ctx.getBlockVarCopyInits(VD))
+ return true;
+ return false;
ahatanak wrote:
> ahatanak wrote:
> > rjmccall wrote:
> > > Can you just ask Sema to check `canThrow` for the exp
Szelethus added a comment.
I'll be back in office tomorrow, about ~13 hours later. But feel free to commit
it on my behalf if it's urgent.
https://reviews.llvm.org/D49438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
rjmccall added a comment.
You might want to ask Richard on IRC if there are caveats when using that for
these purposes.
Repository:
rC Clang
https://reviews.llvm.org/D50152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
simark added a comment.
In https://reviews.llvm.org/D48903#1189056, @ilya-biryukov wrote:
> I see, thanks for the explanation.
>
> LGTM for the update revision, given we have confirmation the tests pass on
> Windows.
Thanks, I'll push it, let's hope this time is the right time!
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339063: [VirtualFileSystem] InMemoryFileSystem::status:
Return a Status with the… (authored by simark, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48903?vs=158625&id=159401#toc
R
Author: simark
Date: Mon Aug 6 14:48:20 2018
New Revision: 339063
URL: http://llvm.org/viewvc/llvm-project?rev=339063&view=rev
Log:
[VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the
requested name
Summary:
InMemoryFileSystem::status behaves differently than
RealFileSystem
bricci added a comment.
Added some comments inline.
However I have not looked at the logic too closely and
have not looked at the tests at all.
Comment at: cfe/trunk/include/clang/AST/ASTContext.h:1966
unsigned char getFixedPointIBits(QualType Ty) const;
+ FixedPointSemant
jfb added a comment.
I'm honestly not sure there's anything to review here since it's just showing
us what the current behavior is. LMK if I'm not testing something that I should.
I'd much rather test current behavior as one patch first, because then the
follow-ups show a clear before / after d
Author: rkovacs
Date: Mon Aug 6 15:03:42 2018
New Revision: 339067
URL: http://llvm.org/viewvc/llvm-project?rev=339067&view=rev
Log:
[analyzer] InnerPointerChecker: fix displayed checker name.
For InnerPointerChecker to function properly, both the checker itself
and parts of MallocChecker that h
leonardchan updated this revision to Diff 159405.
leonardchan marked an inline comment as done.
leonardchan added a comment.
- Replaced instances of a `pointer type mismatch` warning involving 2
conditional operands with different address spaces with a new error
specifically for this situation.
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware,
eraman.
I don't see why BasicValueFactory::getTruthValue(bool, QualType) always returns
an unsigned `A
rnkovacs closed this revision.
rnkovacs added a comment.
Committed in r339067, I just messed up the revision-closing line in the commit
message.
https://reviews.llvm.org/D50211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
NoQ added a comment.
Welcome to the club!
https://reviews.llvm.org/D50211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnkovacs added a comment.
In https://reviews.llvm.org/D50211#1190146, @NoQ wrote:
> Welcome to the club!
:D
Thanks, makes me feel better.
https://reviews.llvm.org/D50211
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
leonardchan updated this revision to Diff 159409.
leonardchan marked 3 inline comments as done.
leonardchan added a comment.
- Changed tick to single quote in diagnostic
Repository:
rC Clang
https://reviews.llvm.org/D49511
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
inc
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:127
+<< "define void @foo(i32* %a, i32* %b, i32* %c, i64 %s) {\n"
+<< "%1 = icmp sgt i64 %s, 0\n"
+<< "br i1 %1, label %start, label %end
Author: stella.stamenova
Date: Mon Aug 6 15:37:45 2018
New Revision: 339074
URL: http://llvm.org/viewvc/llvm-project?rev=339074&view=rev
Log:
[lit, python] Always add quotes around the python path in lit
Summary:
The issue with the python path is that the path to python on Windows can
contain s
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339074: [lit, python] Always add quotes around the python
path in lit (authored by stella.stamenova, committed by ).
Heral
rsmith added a comment.
Looking promising, but this patch will need some rework: you need to track the
trailing requires clause on the `Declarator` itself, not on the `DeclChunk`,
because it's not part of the `DeclChunk` (and may appear in contexts where
there is no function chunk).
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:127
+<< "define void @foo(i32* %a, i32* %b, i32* %c, i64 %s) {\n"
+<< "%1 = icmp sgt i64 %s, 0\n"
+<< "br i1 %1, label %start, label %
rjmccall added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:6522
+bool HasDifferingLAddrSpace = LAddrSpace != ResultAddrSpace;
+bool HasDifferingRAddrSpace = RAddrSpace != ResultAddrSpace;
+
I was going to tell you to use the predicate
`Qualifiers:
emmettneyman updated this revision to Diff 159421.
emmettneyman added a comment.
Some small fixes to improve simplicity of generated IR
Repository:
rC Clang
https://reviews.llvm.org/D50342
Files:
clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp
Index: clang/tools/clang-fuzze
Author: george.karpenkov
Date: Mon Aug 6 16:09:07 2018
New Revision: 339079
URL: http://llvm.org/viewvc/llvm-project?rev=339079&view=rev
Log:
[analyzer] Add ASTContext to CheckerManager
Some checkers require ASTContext. Having it in the constructor saves a
lot of boilerplate of having to pass it
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339079: [analyzer] Add ASTContext to CheckerManager
(authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D50111?vs=158
emmettneyman updated this revision to Diff 159425.
emmettneyman added a comment.
Rebased and ready to land
Repository:
rC Clang
https://reviews.llvm.org/D50342
Files:
clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp
Index: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_
Author: emmettneyman
Date: Mon Aug 6 16:11:38 2018
New Revision: 339080
URL: http://llvm.org/viewvc/llvm-project?rev=339080&view=rev
Log:
Changed how LLVM IR was generated to increase vectorization
Summary: Changed the structure of the generated IR to make it easier to
vectorize
Reviewers: mor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339080: Changed how LLVM IR was generated to increase
vectorization (authored by emmettneyman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50342?vs=159425&id=159427#toc
Repositor
rsmith added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:3007
+/// \brief Definition of concept, not just declaration actually.
+class ConceptDecl : public TemplateDecl {
This comment isn't appropriate. Please just describe what the node is. (
NoQ updated this revision to Diff 159435.
NoQ added a comment.
Whoops, how did this `T, ` thing get in there.
https://reviews.llvm.org/D50363
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h
test/Analysis/casts.c
test/Analysis/std-c-library-functions-inlined.c
efriedma added a comment.
I mean, which of the callers of startFrontendTimer() is calling it with a
pointer to std::declval()?
https://reviews.llvm.org/D47196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
rsmith added inline comments.
Comment at: include/clang/AST/ExprCXX.h:4420
+ /// \brief The concept named.
+ ConceptDecl *NamedConcept;
+
You should also track the `FoundDecl` and the optional `NestedNameSpecifierLoc`
(just like a `DeclRefExpr` would). Clang-b
rsmith added inline comments.
Comment at: lib/AST/DeclTemplate.cpp:203
+
+Expr *TemplateDecl::getAssociatedConstraints() {
+ return getOrCollectAssociatedConstraints(getASTContext(),
Rather than producing an `Expr*` (which will presumably eventually need to
con
rsmith added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:6045
// Inform the class that we've finished declaring this member.
Record->finishedDefaultedOrDeletedMember(M);
M->setTrivialForCall(
Your new handling should go
zhaomo created this revision.
zhaomo added reviewers: pcc, vlad.tsyrklevich.
Herald added a subscriber: cfe-commits.
Dimitar et. al. in [1] proposed a novel VTable layout scheme that enables
efficient implementation of virtual call CFI.
This patch adds an introduction of this scheme to the CFI d
test case?
On Mon, Jul 30, 2018 at 1:39 PM Stephen Kelly via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: steveire
> Date: Mon Jul 30 13:39:14 2018
> New Revision: 338301
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338301&view=rev
> Log:
> Avoid returning an invalid end source
Author: dergachev
Date: Mon Aug 6 19:22:59 2018
New Revision: 339087
URL: http://llvm.org/viewvc/llvm-project?rev=339087&view=rev
Log:
[analyzer] NFC: Document that we support implicit argument constructors.
The change in the AST in r338135 caused us to accidentally support
inlining constructors
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339087: [analyzer] NFC: Document that we support implicit
argument constructors. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49627
Files:
include/clang/Ana
Author: dergachev
Date: Mon Aug 6 19:27:38 2018
New Revision: 339088
URL: http://llvm.org/viewvc/llvm-project?rev=339088&view=rev
Log:
[analyzer] pr37204: Take signedness into account in getTruthValue().
It now actually produces a signed APSInt when the QualType passed into it is
signed, which i
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339088: [analyzer] pr37204: Take signedness into account in
getTruthValue(). (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50363?vs=159435&id=159446#toc
Rep
pcc added a comment.
Please upload patches with context. `arc diff` will do this for you.
Comment at: clang/docs/ControlFlowIntegrityDesign.rst:277
+Forward-Edge CFI for Virtual Calls by Interleaving Virtual Tables
+
Author: jfb
Date: Mon Aug 6 20:12:52 2018
New Revision: 339089
URL: http://llvm.org/viewvc/llvm-project?rev=339089&view=rev
Log:
[NFC] Test automatic variable initialization
Summary:
r337887 started using memset for automatic variable initialization where
sensible. A follow-up discussion leads
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339089: [NFC] Test automatic variable initialization
(authored by jfb, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50361?vs=159397&id=159448#toc
Repository:
rC Clang
https://r
HsiangKai added a comment.
In https://reviews.llvm.org/D45045#1189201, @vext01 wrote:
> Hi,
>
> I've been experimenting some more with this patch.
>
> It seems to me that if a label is optimised away, but you've requested it be
> preserved, then you get a DWARF label with a zero offset. Is that
Author: jfb
Date: Mon Aug 6 21:03:03 2018
New Revision: 339090
URL: http://llvm.org/viewvc/llvm-project?rev=339090&view=rev
Log:
Remove broken command flag
I was using it for testing, r339089 shouldn't have contained it.
Modified:
cfe/trunk/test/CodeGenCXX/auto-var-init.cpp
Modified: cfe/t
erik.pilkington updated this revision to Diff 159449.
erik.pilkington retitled this revision from "[Sema] Dig through AutoTypes that
have been deduced to an undeduced AutoType in Type::isUndeducedType" to "[Sema]
Fix an error with C++17 auto non-type template parameters".
erik.pilkington edited t
Author: jfb
Date: Mon Aug 6 21:44:13 2018
New Revision: 339093
URL: http://llvm.org/viewvc/llvm-project?rev=339093&view=rev
Log:
Auto var init test fix #2
It turns out that the AVX bots have different alignment for their vectors, and
my test mistakenly assumed a particular vector alignent on th
hans added a comment.
In https://reviews.llvm.org/D50349#1190029, @rsmith wrote:
> +Hans (release manager for LLVM 7)
>
> Hans, this patch series will affect the API of common Clang classes,
> resulting in patches to Clang SVN needing some (mechanical) modifications to
> be applied to the Clang
hans added a comment.
What do you other reviewers say? I'm not familiar with this code, but this
seems reasonable to me.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D50170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Merged to 7.0 in r339102.
On Wed, Aug 1, 2018 at 10:38 PM, Michal Gorny via cfe-commits
wrote:
> Author: mgorny
> Date: Wed Aug 1 13:38:22 2018
> New Revision: 338627
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338627&view=rev
> Log:
> [test] Fix %hmaptool path for standalone builds
>
> Fix
ahatanak updated this revision to Diff 159250.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D50152
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
lib/CodeGen/CGDecl.cpp
lib/CodeGen/
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1691
+
+Name += "_" + llvm::to_string(E.Capture->getOffset().getQuantity());
+ }
rjmccall wrote:
> I feel like this reads a little better if you write the quantity first. Also
> I think y
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D48903#1187605, @simark wrote:
> In https://reviews.llvm.org/D48903#1187596, @ilya-biryukov wrote:
>
> > This revision got 'reopened' and is now in the
ebevhan added a comment.
Sorry for the late response, I've been away.
LGTM, although my browser doesn't want to let me set Accepted on this.
Comment at: unittests/Basic/FixedPointTest.cpp:380
+}
+
+// Check the value in a given fixed point sema overflows to the saturated max
-
ebevhan accepted this revision.
ebevhan added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D49945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D50307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
ebevhan added a comment.
When I try the test case on our downstream (and when compiling for our target
with an extra flag that enables a bunch of OpenCL-related address space code),
I get:
ascrash.c:5:12: error: comparison between ('__attribute__((address_space(1)))
char *' and '__attribute_
devnexen abandoned this revision.
devnexen added a comment.
Commited in the branch.
Repository:
rC Clang
https://reviews.llvm.org/D49906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
devnexen abandoned this revision.
devnexen added a comment.
Committed in the branch.
Repository:
rC Clang
https://reviews.llvm.org/D49873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
JonasToth updated this revision to Diff 159259.
JonasToth added a comment.
- rebase
Repository:
rC Clang
https://reviews.llvm.org/D50307
Files:
tools/clang-rename/clang-rename.py
Index: tools/clang-rename/clang-rename.py
===
Author: jonastoth
Date: Mon Aug 6 02:08:06 2018
New Revision: 338996
URL: http://llvm.org/viewvc/llvm-project?rev=338996&view=rev
Log:
[clang-rename] make clang-rename.py vim integration python3 compatible
Summary:
This patch makes the clang-rename.py script useable for vim with only python3
sup
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338996: [clang-rename] make clang-rename.py vim integration
python3 compatible (authored by JonasToth, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
JonasToth added a comment.
@hokein Do you think this should go into the 7.0 release?
Repository:
rL LLVM
https://reviews.llvm.org/D50307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
kadircet updated this revision to Diff 159261.
kadircet marked 4 inline comments as done.
kadircet added a comment.
Added functionality to suggest FixIts for conversion of '->' to '.' and vice
versa.
- Fixes for comments.
- Take unnecessary patches back
- Second pass for comments.
- Add downrank
hokein marked 2 inline comments as done.
hokein added inline comments.
Comment at: clangd/index/Index.h:288
+ Unknown = 0,
+ Declaration = static_cast(index::SymbolRole::Declaration),
+ Definition = static_cast(index::SymbolRole::Definition),
ilya-biryukov wro
vext01 added a comment.
Hi,
I've been experimenting some more with this patch.
It seems to me that if a label is optimised away, but you've requested it be
preserved, then you get a DWARF label with a zero offset. Is that the expected
behaviour? Should it be documented?
E.g.:
< 6><0x00
kosarev added a comment.
Ping.
https://reviews.llvm.org/D49075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hsiangkai
Date: Sun Aug 5 22:58:59 2018
New Revision: 338989
URL: http://llvm.org/viewvc/llvm-project?rev=338989&view=rev
Log:
[DebugInfo] Generate debug information for labels. (Fix PR37395)
Generate DILabel metadata and call llvm.dbg.label after label
statement to associate the metadat
Author: hsiangkai
Date: Sun Aug 5 21:00:08 2018
New Revision: 338985
URL: http://llvm.org/viewvc/llvm-project?rev=338985&view=rev
Log:
[DebugInfo] Use DbgVariableIntrinsic as the base class of variables.
After refactoring DbgInfoIntrinsic class hierarchy, we use
DbgVariableIntrinsic as the base
Author: hsiangkai
Date: Mon Aug 6 00:07:18 2018
New Revision: 338992
URL: http://llvm.org/viewvc/llvm-project?rev=338992&view=rev
Log:
Revert "[DebugInfo] Generate debug information for labels. (Fix PR37395)"
Build failed in
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/build
Author: hans
Date: Mon Aug 6 04:34:46 2018
New Revision: 339008
URL: http://llvm.org/viewvc/llvm-project?rev=339008&view=rev
Log:
clang-cl: Parse the new /JMC flag
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/include/
ebevhan added inline comments.
Comment at: lib/AST/Expr.cpp:788
FixedPointValueToString(
- S, llvm::APSInt::getUnsigned(getValue().getZExtValue()), Scale, Radix);
+ S, llvm::APSInt::getUnsigned(getValue().getZExtValue()), Scale);
return S.str();
U
Szelethus added a comment.
@NoQ, we had quite a few conversations about this fix. How do you feel about
this implementation?
https://reviews.llvm.org/D49199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
theraven added inline comments.
Comment at: include/clang/Driver/Options.td:1491
// Objective-C ABI options.
-def fobjc_runtime_EQ : Joined<["-"], "fobjc-runtime=">, Group,
Flags<[CC1Option]>,
+def fobjc_runtime_EQ : Joined<["-"], "fobjc-runtime=">, Group,
Flags<[CC1Option, Co
balazske updated this revision to Diff 159279.
balazske added a comment.
- Rebase, common checks at ASTStructuralEquivalenceContext
Repository:
rC Clang
https://reviews.llvm.org/D49223
Files:
include/clang/AST/ASTStructuralEquivalence.h
lib/AST/ASTStructuralEquivalence.cpp
unittests/AS
Hi, sorry for the delayed response, I only just got back into the office. I've
added the author of the patch to this email chain.
-Original Message-
From: Abramo Bagnara [mailto:abramo.bagn...@bugseng.com]
Sent: Sunday, August 5, 2018 5:03 AM
To: Keane, Erich ; cfe-commits@lists.llvm.or
aaron.ballman added a comment.
The functionality is looking good, aside from a few small nits remaining.
However, I'm wondering how this should integrate with other const-correctness
efforts like `readability-non-const-parameter`? Also, I'm wondering how this
check performs over a large code ba
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, hokein.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Currently, dynamic index collects symbols for the entire TU for each open/active
file. When static index is enabled, this can be wasteful as (intuitively)
hokein updated this revision to Diff 159287.
hokein marked 2 inline comments as done.
hokein added a comment.
Rebase
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49658
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/Index.h
clangd/index/MemInde
Author: hokein
Date: Mon Aug 6 06:14:32 2018
New Revision: 339011
URL: http://llvm.org/viewvc/llvm-project?rev=339011&view=rev
Log:
[clangd] Index Interfaces for Xrefs
Summary:
This is the first step of implementing Xrefs in clangd:
- add index interfaces, and related data structures.
Reviewe
ioeric added a comment.
Code is not polished. I'd like to get some high-level feedback before
proceeding further and splitting this into smaller patches.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50331
___
cfe-commits mailing
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339011: [clangd] Index Interfaces for Xrefs (authored by
hokein, committed by ).
Herald added a subscriber: llvm-commits.
Szelethus updated this revision to Diff 159291.
Szelethus added a comment.
Fixed the comments.
https://reviews.llvm.org/D49438
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
test/Analysis/cxx-uninitialized-object-no
theraven updated this revision to Diff 159293.
theraven added a comment.
- Fix an issue in protocol generation.
Repository:
rC Clang
https://reviews.llvm.org/D50144
Files:
include/clang/Driver/Options.td
lib/AST/MicrosoftMangle.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGException.cpp
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D49075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Dear LLVM and compiler interested people,
this Thursday, 19:00, Dr. Oleksandre Zinenko will present Tensor-Comprehension,
a Deep-Learning compiler jointly developed by Facebook, ENS Paris, and ETH
Zurich at the LLVM compiler social.
Tech-Talk: Deep Learning is the Killer App for Polyhedral Comp
erichkeane added a comment.
Bump! I don't see anything here that seems questionable (and this has
extensive testing), but I presume @rsmith should be the final one to approve.
https://reviews.llvm.org/D40218
___
cfe-commits mailing list
cfe-commit
On Mon, Aug 6, 2018, at 15:42, Tobias Grosser wrote:
> Dear LLVM and compiler interested people,
>
> this Thursday, 19:00, Dr. Oleksandre Zinenko will present Tensor-
> Comprehension, a Deep-Learning compiler jointly developed by Facebook,
> ENS Paris, and ETH Zurich at the LLVM compiler social.
Hello,
This is the only occurence of such an enum in a SomethingDeclBitfields
introduced by this patch so it probably is the only instance of this bug.
I will quickly commit a patch moving the enum above as you suggest.
In the future I am not sure this enum will stay since as explained
in the com
Author: ldionne
Date: Mon Aug 6 07:11:50 2018
New Revision: 339012
URL: http://llvm.org/viewvc/llvm-project?rev=339012&view=rev
Log:
[libc++] Add the _LIBCPP_HIDE_FROM_ABI_AFTER_V1 macro
Summary:
This macro allows hiding symbols from the ABI when the library is built
with an ABI version after AB
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339012: [libc++] Add the _LIBCPP_HIDE_FROM_ABI_AFTER_V1
macro (authored by ldionne, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49914?vs=1
101 - 193 of 193 matches
Mail list logo
