aaronpuchert added a comment.
In https://reviews.llvm.org/D49355#1188603, @phosek wrote:
> In https://reviews.llvm.org/D49355#1188520, @aaronpuchert wrote:
>
> > Could you explain what annotations like `LOCK_UNLOCK` are useful for? What
> > do they check? The annotation should certainly not be n
Author: brunoricci
Date: Sun Aug 5 02:48:59 2018
New Revision: 338966
URL: http://llvm.org/viewvc/llvm-project?rev=338966&view=rev
Log:
[AST][NFC] Remove unneeded forward declarations in Type.h
These forward declarations for various classes in the Type
hierarchy are not needed since they are all
Il 01/08/2018 22:48, Erich Keane via cfe-commits ha scritto:
> Author: erichkeane
> Date: Wed Aug 1 13:48:16 2018
> New Revision: 338630
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338630&view=rev
> Log:
> [AST][1/4] Move the bit-fields from TagDecl, EnumDecl and RecordDecl into
> DeclConte
JonasToth created this revision.
JonasToth added reviewers: arphaman, klimek.
Herald added a subscriber: cfe-commits.
This patch makes the clang-rename.py script useable for vim with only python3
support. It uses the print-function and adjust the doc slightly to mention
the correct python3 command
JonasToth updated this revision to Diff 159209.
JonasToth added a comment.
- remove double blank line
Repository:
rC Clang
https://reviews.llvm.org/D50307
Files:
tools/clang-rename/clang-rename.py
Index: tools/clang-rename/clang-rename.py
=
aaron.ballman added a comment.
I think this is close. If @alexfh doesn't chime in on the open question in the
next few days, I would say the check is ready to go in and we can address the
open question in follow-up commits.
Comment at: clang-tidy/readability/MagicNumbersCheck
echristo added a comment.
Looks pretty good. Could you pass CGM in and just make the functions static I
couldn't see any other class variables, but might have missed something. One
inline comment as well.
-eric
Comment at: lib/CodeGen/CGDebugInfo.cpp:997
llvm::DINode::DIF
aaron.ballman added a comment.
I'm sorry for the delay in reviewing this; I'm not certain how it fell off my
radar for so long!
Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:32
+ *
+ * Handle = either a pointer or reference
+ * Value = everything else (Type variable
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1129-1130
+ return;
+ }
+ // That's it. We can't rule out any more cases with the data we have.
Actually, after messing with souper a little, if we are converting from
*larger* *
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338971: Fix tests for changed opt remarks format (authored
by xbolva00, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50241
Files:
test/CodeG
Author: xbolva00
Date: Sun Aug 5 07:53:34 2018
New Revision: 338971
URL: http://llvm.org/viewvc/llvm-project?rev=338971&view=rev
Log:
Fix tests for changed opt remarks format
Summary:
Optimization remark format is slightly changed by LLVM patch D49412.
Two tests are fixed with expected messages
JonasToth added a comment.
> I'm sorry for the delay in reviewing this; I'm not certain how it fell off my
> radar for so long!
No problem :)
Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:32
+ *
+ * Handle = either a pointer or reference
+ * Value = everything else
xbolva00 added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:28
+ * For now: Only local variables are considered. Globals/namespace variables,
+ * paramters and class members are not analyzed.
+ * Parameters have a check already: readability-non-const-p
JonasToth updated this revision to Diff 159220.
JonasToth marked 11 inline comments as done.
JonasToth added a comment.
- Merge branch 'master' into check_const
- [Misc] rename and first review comments
- language stuff
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ConstCheck.cpp:141-142
+void ConstCheck::registerMatchers(MatchFinder *Finder) {
+ if (!getLangOpts().CPlusPlus)
+return;
+
aaron.ballman wrote:
> Why is this check disabled for C code
JonasToth updated this revision to Diff 159221.
JonasToth added a comment.
- doc list
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp
clang-tidy/cppcoreguideline
0x8000- updated this revision to Diff 159222.
0x8000- added a comment.
Address several style comments. Rebase to current trunk (8.0).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49114
Files:
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/
JonasToth updated this revision to Diff 159224.
JonasToth added a comment.
- revert breaking change in LocalVar matcher.
Reverting the change from `allOf(...)` to `unless(anyOf(..))`. I did not
investigate
the reason for it breaking, because basic logic suggests that transformation
should be cor
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:147
+ // Example: `int i = 10`, `int i` (will be used if program is correct)
+ const auto LocalValDecl = varDecl(unless(anyOf(
+ isLocal(), hasInitializer(anything()), unles
JonasToth updated this revision to Diff 159225.
JonasToth marked an inline comment as done.
JonasToth added a comment.
- fix typo
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/ConstCorrec
JonasToth updated this revision to Diff 159226.
JonasToth added a comment.
- update ReleaseNotes
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp
clang-tidy/cppco
lebedev.ri updated this revision to Diff 159230.
lebedev.ri added a comment.
Do not emit sign-change check in `signed int -> signed char` case.
The truncation check is sufficient:
https://godbolt.org/g/r1wgQG
https://rise4fun.com/Alive/ifj
The middle-end [clearly] does not understand that,
but si
saar.raz updated this revision to Diff 159234.
saar.raz added a comment.
Herald added a subscriber: jfb.
- Switch to ASTTemplateArgumentListInfo, add ConstantEvaluated context when
parsing constraints
Repository:
rC Clang
https://reviews.llvm.org/D41217
Files:
include/clang/AST/DeclTempla
saar.raz updated this revision to Diff 159236.
saar.raz added a comment.
- Consider requires clause when determining if TPL has an unexpanded pack
Repository:
rC Clang
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.h
includ
michaelwu created this revision.
michaelwu added reviewers: manmanren, friss, doug.gregor.
This adds support for Swift platform availability attributes. It's largely a
port of the changes made to https://github.com/apple/swift-clang/ for Swift
availability attributes. Specifically,
https://gith
Author: chandlerc
Date: Sun Aug 5 18:28:42 2018
New Revision: 338979
URL: http://llvm.org/viewvc/llvm-project?rev=338979&view=rev
Log:
[docs] Don't use the `asm` syntax highlighting (which our docs builder
errors on) and clean up the formattting.
This isn't actualy assembly anyways, so dropping
simark added a comment.
In https://reviews.llvm.org/D48903#1188566, @malaperle wrote:
> Both check-clang and check-clang-tools pass successfully for me on Windows
> with the patch.
Awesome, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D48903
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338985: [DebugInfo] Use DbgVariableIntrinsic as the base
class of variables. (authored by HsiangKai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
saar.raz updated this revision to Diff 159242.
saar.raz added a comment.
Herald added a subscriber: jfb.
- Adjusted to switch to ASTTemplateArgumentList
Repository:
rC Clang
https://reviews.llvm.org/D41569
Files:
include/clang/AST/ExprCXX.h
include/clang/Basic/DiagnosticSemaKinds.td
in
rnkovacs updated this revision to Diff 159244.
rnkovacs marked an inline comment as done.
rnkovacs added a comment.
Replace empty `Optional`s with `None`s.
https://reviews.llvm.org/D50211
Files:
lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
lib/StaticAnalyzer/Checkers/InterCheckerAPI.
arsenm created this revision.
arsenm added reviewers: kzhuravl, yaxunl.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng.
https://reviews.llvm.org/D50320
Files:
include/clang/Basic/BuiltinsAMDGPU.def
test/CodeGenOpenCL/builtins-amdgcn-ci.cl
test/SemaOpenCL/builtins-amdgcn-err
arsenm created this revision.
arsenm added reviewers: yaxunl, kzhuravl.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng.
https://reviews.llvm.org/D50321
Files:
include/clang/Basic/BuiltinsAMDGPU.def
test/CodeGenOpenCL/builtins-amdgcn-vi.cl
test/SemaOpenCL/builtins-amdgcn-err
32 matches
Mail list logo
