[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

2018-08-03 Thread Emmett Neyman via Phabricator via cfe-commits
emmettneyman updated this revision to Diff 159151. emmettneyman added a comment. ready to land Repository: rC Clang https://reviews.llvm.org/D50194 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp clang/tools/clang-fuzzer/handle-llvm/handle_llvm.h clang/tools/clang-fuzzer/ha

r338943 - LLVM Proto Fuzzer - Run Functions on Suite of Inputs

2018-08-03 Thread Emmett Neyman via cfe-commits
Author: emmettneyman Date: Fri Aug 3 18:18:37 2018 New Revision: 338943 URL: http://llvm.org/viewvc/llvm-project?rev=338943&view=rev Log: LLVM Proto Fuzzer - Run Functions on Suite of Inputs Summary: Added corpus of arrays to use as inputs for the functions. Check that the two functions modify t

[PATCH] D50194: LLVM Proto Fuzzer - Run Functions on Suite of Inputs

2018-08-03 Thread Emmett Neyman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC338943: LLVM Proto Fuzzer - Run Functions on Suite of Inputs (authored by emmettneyman, committed by ). Changed prior to commit: https://reviews.llvm.org/D50194?vs=159151&id=159152#toc Repository: rC

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

2018-08-03 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 159153. https://reviews.llvm.org/D50286 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/conditional-temporaries.cpp test/CodeGenCXX/lifetime-asan.cpp Index: test/CodeGenCXX/lifetime-asan.cpp

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

2018-08-03 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:521 + CGM.getCodeGenOpts().OptimizationLevel > 0 && + !CGM.getCodeGenOpts().SanitizeAddressUseAfterScope) { +OldConditional = OutermostConditional;

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

2018-08-03 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D50286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r338945 - Avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

2018-08-03 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Aug 3 18:25:06 2018 New Revision: 338945 URL: http://llvm.org/viewvc/llvm-project?rev=338945&view=rev Log: Avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls When a non-extended temporary object is created in a conditional branch, the l

[PATCH] D50286: avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end calls

2018-08-03 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. rsmith marked an inline comment as done. Closed by commit rC338945: Avoid creating conditional cleanup blocks that contain only @llvm.lifetime.end… (authored by rsmith, committed by ). Repository: rC Clang https://review

r338946 - [clang-fuzzer] Remove unused typedef.

2018-08-03 Thread Matt Morehouse via cfe-commits
Author: morehouse Date: Fri Aug 3 18:42:47 2018 New Revision: 338946 URL: http://llvm.org/viewvc/llvm-project?rev=338946&view=rev Log: [clang-fuzzer] Remove unused typedef. Modified: cfe/trunk/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp Modified: cfe/trunk/tools/clang-fuzzer/handle-llvm/

[clang-tools-extra] r338947 - [clangd] Fix fuzzer build.

2018-08-03 Thread Matt Morehouse via cfe-commits
Author: morehouse Date: Fri Aug 3 18:51:10 2018 New Revision: 338947 URL: http://llvm.org/viewvc/llvm-project?rev=338947&view=rev Log: [clangd] Fix fuzzer build. Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

2018-08-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Yay thx! Yeah, that's the best behavior i can imagine here. Repository: rC Clang https://reviews.llvm.org/D50211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

2018-08-03 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. In https://reviews.llvm.org/D48903#1187605, @simark wrote: > If somebody else could run the tests on Windows, it would make me a bit more > confident too. Which tests/targets exactly? If you know Repository: rC Clang https://reviews.llvm.org/D48903 __

[PATCH] D49355: Thread safety analysis: Allow lock upgrading and downgrading

2018-08-03 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. This change broke the acquire+release case. Concretely, in Flutter we have this code: https://github.com/flutter/engine/blob/master/lib/ui/isolate_name_server/isolate_name_server.h#L26. This worked fine previously, but after this change we're getting an error in https:/

[PATCH] D50214: Add inherited attributes before parsed attributes.

2018-08-03 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. For this patch the goal is to have the attributes in the AST in an order that is less surprising to consumers (including out-of-tree). If we change it now, new/revised code/diagnostics will be written to match this order. I agree that ideally, most attributes (except

[PATCH] D50205: [libc++] Add availability markup for aligned new/delete

2018-08-03 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. How does this work when a user provides their own definitions? Does the attribute from the declaration still produce a warning? If so, then I think an in-compiler approach is better. Repository: rCXX libc++ https://reviews.llvm.org/D50205 _

[PATCH] D50291: [C++] Delay checking of constexpr-ness for special members.

2018-08-03 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete updated this revision to Diff 159160. Rakete added a comment. Add missing test cases. :) Repository: rC Clang https://reviews.llvm.org/D50291 Files: include/clang/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp test/CXX/special/class.copy/p10.cpp Index: test/CXX/special/class.copy

[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

2018-08-03 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. In https://reviews.llvm.org/D48903#1188437, @malaperle wrote: > In https://reviews.llvm.org/D48903#1187605, @simark wrote: > > > If somebody else could run the tests on Windows, it would make me a bit > > more confident too. > > > Which tests/targets exactly? If you kn

<    1   2   3