ldionne created this revision.
ldionne added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, christof.
As suggested by Marshall in https://reviews.llvm.org/D49914
Repository:
rCXX libc++
https://reviews.llvm.org/D50008
Files:
lib
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Cool! Always bothered me.
In https://reviews.llvm.org/D49986#1180403, @george.karpenkov wrote:
> I'm a bit confused: does it mean these methods are never called in Clang?
This patch *is* for clang
mclow.lists added a comment.
Getting close here. I'll have a couple more comments later today, so don't
post a new diff quite yet.
Comment at: include/charconv:244
+static _LIBCPP_INLINE_VISIBILITY char const*
+read(char const* __p, char const* __ep, type& __a, type&
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338299: [DebugInfo][OpenCL] Generate correct block literal
debug info for OpenCL (authored by scott.linder, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
On Mon, Jul 30, 2018 at 3:52 PM, Fāng-ruì Sòng wrote:
> Oops.. sorry but now they have been committed..
The commits can still be reverted and I think they should be.
~Aaron
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
On Mon, Jul 30, 2018 at 4:24 PM, Michael Kruse
wrote:
> I think removing trailing space is a good thing. Some editors remove
> any trailing space when saving a file. This shows up in diffs that I
> then have to undo manually.
I've also run into the same issues on occasion. However, this isn't
abo
scott.linder added a comment.
Sorry, I didn't see the additional comments until after I committed. I will
make those changes; is it OK to update this review, or should I create a new
one?
As for choosing limited it was just what the function adding the debug info
checked for as a minimum; what
Author: scott.linder
Date: Mon Jul 30 13:31:11 2018
New Revision: 338299
URL: http://llvm.org/viewvc/llvm-project?rev=338299&view=rev
Log:
[DebugInfo][OpenCL] Generate correct block literal debug info for OpenCL
OpenCL block literal structs have different fields which are now correctly
identified
Author: steveire
Date: Mon Jul 30 13:39:14 2018
New Revision: 338301
URL: http://llvm.org/viewvc/llvm-project?rev=338301&view=rev
Log:
Avoid returning an invalid end source loc
Modified:
cfe/trunk/include/clang/AST/DeclarationName.h
cfe/trunk/lib/AST/DeclarationName.cpp
Modified: cfe/tru
Does this apply to only public headers (include/llvm include/llvm-c
include/clang ...) or everything? (lib/**/*.{cpp,h})?
On Mon, Jul 30, 2018 at 1:36 PM Aaron Ballman wrote:
>
> On Mon, Jul 30, 2018 at 4:24 PM, Michael Kruse
> wrote:
> > I think removing trailing space is a good thing. Some edit
steveire closed this revision.
steveire added a comment.
Committed in SVN revision 338301.
Repository:
rC Clang
https://reviews.llvm.org/D49100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
devnexen updated this revision to Diff 158062.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
Maybe not too terrible for out-of-tree projects. If they use git
mirror, `git rebase` is smart enough to ignore changing lines with
trailing whitespace (if not, there is git rebase
-Xignore-space-at-eol). Some editors are configured with highlighting
trailing spaces and these spaces will turn to ey
mehdi_amini added a comment.
I'm curious: isn't the kind of optimization we should expect LLVM to provide?
Repository:
rL LLVM
https://reviews.llvm.org/D49771
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
echristo added a comment.
In https://reviews.llvm.org/D49930#1181000, @scott.linder wrote:
> Sorry, I didn't see the additional comments until after I committed. I will
> make those changes; is it OK to update this review, or should I create a new
> one?
A new one is great. Just treat this as
lichray marked an inline comment as done.
lichray added inline comments.
Comment at: include/charconv:158
+
+#if !defined(_LIBCPP_COMPILER_MSVC)
+static _LIBCPP_INLINE_VISIBILITY int __width(_Tp __v)
mclow.lists wrote:
> In general, we don't put `_LIBCPP_COMP
Author: lebedevri
Date: Mon Jul 30 14:11:32 2018
New Revision: 338306
URL: http://llvm.org/viewvc/llvm-project?rev=338306&view=rev
Log:
[docs] UndefinedBehaviorSanitizer.rst: {,un}signed-integer-overflow: tune docs
Yes, i erroneously assumed that the "after" was meant,
but i was wrong:
> I really
On Mon, Jul 30, 2018 at 10:37 PM Scott Linder via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: scott.linder
> Date: Mon Jul 30 13:31:11 2018
> New Revision: 338299
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338299&view=rev
> Log:
> [DebugInfo][OpenCL] Generate correct block lit
Author: timshen
Date: Mon Jul 30 14:23:13 2018
New Revision: 338309
URL: http://llvm.org/viewvc/llvm-project?rev=338309&view=rev
Log:
[libcxx] implement ABI for Clang/GCC vector extension, constructors,
copy_from and copy_to.
Summary:
This patch adds a new macro _LIBCPP_HAS_NO_VECTOR_EXTENSION
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338309: [libcxx] implement ABI for Clang/GCC
vector extension, constructors… (authored by timshen, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
Can you point me to such a discussion about trailing whitespace?
It seems to contradict the conclusion in another current thread to not
consider churn for out-of-tree users (for C++ API in this case)
https://lists.llvm.org/pipermail/cfe-dev/2018-July/058579.html
> We have historically taken the
lebedev.ri added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:136-137
+ overflow happens (signed or unsigned).
+ Both of these two issues are handled by ``-fsanitize=implicit-conversion``
+ group of checks.
- ``-fsanitize=unreachable``: If cont
rsmith added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:136-137
+ overflow happens (signed or unsigned).
+ Both of these two issues are handled by ``-fsanitize=implicit-conversion``
+ group of checks.
- ``-fsanitize=unreachable``: If control
Author: george.karpenkov
Date: Mon Jul 30 14:44:15 2018
New Revision: 338312
URL: http://llvm.org/viewvc/llvm-project?rev=338312&view=rev
Log:
[analyzer] Fix crash in RunLoopAutoreleaseChecker on empty children
Differential Revision: https://reviews.llvm.org/D50012
Modified:
cfe/trunk/lib/St
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338312: [analyzer] Fix crash in RunLoopAutoreleaseChecker on
empty children (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://review
timshen updated this revision to Diff 158092.
timshen marked 2 inline comments as done.
timshen edited the summary of this revision.
timshen added a comment.
Update based on comments.
https://reviews.llvm.org/D41412
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/s
timshen added a comment.
A note on test cases: I only used simds ints to test split() and concat(), as
both functions don't specialize on the element type, unlike the constructors.
Comment at: libcxx/include/experimental/simd:1491
- template
+ template
static constexp
On Mon, Jul 30, 2018 at 4:43 PM, Fāng-ruì Sòng wrote:
> Does this apply to only public headers (include/llvm include/llvm-c
> include/clang ...) or everything? (lib/**/*.{cpp,h})?
I've understood it applies to "everything" in that you should not
commit large-scale NFC changes that don't have cons
On Mon, Jul 30, 2018 at 5:36 PM, Michael Kruse
wrote:
> Can you point me to such a discussion about trailing whitespace?
I don't know of one, which is why I am concerned with these commits.
> It seems to contradict the conclusion in another current thread to not
> consider churn for out-of-tree
On 2018-07-30, Aaron Ballman wrote:
On Mon, Jul 30, 2018 at 4:43 PM, Fāng-ruì Sòng wrote:
Does this apply to only public headers (include/llvm include/llvm-c
include/clang ...) or everything? (lib/**/*.{cpp,h})?
I've understood it applies to "everything" in that you should not
commit large-sc
Author: george.karpenkov
Date: Mon Jul 30 15:18:21 2018
New Revision: 338314
URL: http://llvm.org/viewvc/llvm-project?rev=338314&view=rev
Log:
[analyzer] Bugfix for autorelease + main run loop leak checker
Do not warn when the other message-send-expression is correctly wrapped
in a different auto
Author: george.karpenkov
Date: Mon Jul 30 15:18:47 2018
New Revision: 338315
URL: http://llvm.org/viewvc/llvm-project?rev=338315&view=rev
Log:
[analyzer] [NFC] Simplify some visitors by giving a convenient getter from
state to analysis manager
Differential Revision: https://reviews.llvm.org/D497
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338314: [analyzer] Bugfix for autorelease + main run loop
leak checker (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llv
Author: timshen
Date: Mon Jul 30 15:21:22 2018
New Revision: 338316
URL: http://llvm.org/viewvc/llvm-project?rev=338316&view=rev
Log:
Revert "[libcxx] implement ABI for Clang/GCC vector extension,
constructors, copy_from and copy_to."
This reverts commit r338309.
Removed:
libcxx/trunk/test
Author: timshen
Date: Mon Jul 30 15:27:38 2018
New Revision: 338318
URL: http://llvm.org/viewvc/llvm-project?rev=338318&view=rev
Log:
Re-apply "[libcxx] implement ABI for Clang/GCC vector extension,
constructors, copy_from and copy_to."
...with proper guarding #ifdefs for unsupported C++11.
Ad
On Mon, Jul 30, 2018 at 6:17 PM, Fāng-ruì Sòng wrote:
> On 2018-07-30, Aaron Ballman wrote:
>
>> On Mon, Jul 30, 2018 at 4:43 PM, Fāng-ruì Sòng
>> wrote:
>>
>>> Does this apply to only public headers (include/llvm include/llvm-c
>>> include/clang ...) or everything? (lib/**/*.{cpp,h})?
>>>
>>
>>
Author: scott.linder
Date: Mon Jul 30 15:52:07 2018
New Revision: 338321
URL: http://llvm.org/viewvc/llvm-project?rev=338321&view=rev
Log:
Fix use of uninitialized variable in r338299
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL:
http:/
Sorry for the delay, this should be fixed in r338321.
Scott
On 2018-07-30 17:19, Benjamin Kramer wrote:
On Mon, Jul 30, 2018 at 10:37 PM Scott Linder via cfe-commits
wrote:
Author: scott.linder
Date: Mon Jul 30 13:31:11 2018
New Revision: 338299
URL: http://llvm.org/viewvc/llvm-project?rev=
tra abandoned this revision.
tra added a comment.
It appears that the issue that originally prompted this change is due to
suspected bug in glibc triggered by specific details of our internal build.
https://reviews.llvm.org/D49763
___
cfe-commits m
Author: george.karpenkov
Date: Mon Jul 30 16:01:20 2018
New Revision: 338322
URL: http://llvm.org/viewvc/llvm-project?rev=338322&view=rev
Log:
[analyzer] [tests] Style fixes for testing harness.
Modified:
cfe/trunk/utils/analyzer/CmpRuns.py
cfe/trunk/utils/analyzer/SATestBuild.py
Modifie
Author: george.karpenkov
Date: Mon Jul 30 16:01:47 2018
New Revision: 338323
URL: http://llvm.org/viewvc/llvm-project?rev=338323&view=rev
Log:
[analyzer] [tests] Add an option for showing statistics after running tests.
Do not show statistics by default.
Modified:
cfe/trunk/utils/analyzer/Cm
Author: timshen
Date: Mon Jul 30 16:05:40 2018
New Revision: 338325
URL: http://llvm.org/viewvc/llvm-project?rev=338325&view=rev
Log:
[libcxx] fix `>> 42` UB in
Modified:
libcxx/trunk/test/std/experimental/simd/simd.access/default.pass.cpp
Modified: libcxx/trunk/test/std/experimental/simd/s
Author: echristo
Date: Mon Jul 30 16:17:27 2018
New Revision: 338327
URL: http://llvm.org/viewvc/llvm-project?rev=338327&view=rev
Log:
Add a definition for FieldSize that seems to make sense here.
This could be sunk out of the if statements, but fix the warning for now.
Modified:
cfe/trunk/li
Author: echristo
Date: Mon Jul 30 16:21:51 2018
New Revision: 338328
URL: http://llvm.org/viewvc/llvm-project?rev=338328&view=rev
Log:
Revert "Add a definition for FieldSize that seems to make sense here."
This reverts commit r338327, the problem was previously fixed in r338321.
Modified:
cf
Is 0 right for FieldOffset for OpenCL here? Seems a little odd.
-eric
On Mon, Jul 30, 2018 at 3:56 PM Scott Linder via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: scott.linder
> Date: Mon Jul 30 15:52:07 2018
> New Revision: 338321
>
> URL: http://llvm.org/viewvc/llvm-project?rev=
Author: marshall
Date: Mon Jul 30 16:33:48 2018
New Revision: 338332
URL: http://llvm.org/viewvc/llvm-project?rev=338332&view=rev
Log:
Code cleanup - change naked 'throw' expressions to call helpre function
'__throw_future_error'. The behavior change is that if you build libc++ with
exceptions d
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet,
rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware.
Sometimes it's important to do `BugReport->addRange()` in order to know which
part of the expression is
Author: dergachev
Date: Mon Jul 30 16:44:37 2018
New Revision: 338333
URL: http://llvm.org/viewvc/llvm-project?rev=338333&view=rev
Log:
[analyzer] CStringChecker: Remember to highlight the argument expression range.
When emitting a bug report, it is important to highlight which argument of the
ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rC338333: [analyzer] CStringChecker: Remember to highlight the
argument expression range. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50028
Files:
lib/Static
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:681-689
+Optional OtherObject =
+getObjectVal(OtherCtor, Context);
+if (!OtherObject)
+ continue;
+
+// If the CurrentObject is a field of OtherObject, it wi
mgrang created this revision.
mgrang added reviewers: rnk, mstorsjo, ssijaric, haripul, TomTan.
Herald added subscribers: chrib, kristof.beyls.
Repository:
rC Clang
https://reviews.llvm.org/D50029
Files:
include/clang/Basic/TargetInfo.h
test/CodeGen/exceptions-seh-finally.c
test/CodeGen/
mgrang added inline comments.
Comment at: test/CodeGen/exceptions-seh.c:10
+// RUN: %clang_cc1 %s -triple aarch64-windows -fms-extensions -emit-llvm -o - \
+// RUN: | FileCheck %s --check-prefix=X64-GNU
Is it OK to re-use the X64-GNU check prefix here o
rnk added inline comments.
Comment at: test/CodeGen/exceptions-seh.c:10
+// RUN: %clang_cc1 %s -triple aarch64-windows -fms-extensions -emit-llvm -o - \
+// RUN: | FileCheck %s --check-prefix=X64-GNU
mgrang wrote:
> Is it OK to re-use the X64-GNU check
Author: epilk
Date: Mon Jul 30 17:18:30 2018
New Revision: 338338
URL: http://llvm.org/viewvc/llvm-project?rev=338338&view=rev
Log:
[Sema] Relax a failing assert in TemplateArgumentLoc
Any of these template argument kinds can be represented with an expression, so
accept them in this constructor.
Author: dergachev
Date: Mon Jul 30 17:18:35 2018
New Revision: 338339
URL: http://llvm.org/viewvc/llvm-project?rev=338339&view=rev
Log:
[analyzer] Rename test: cxx17-mandatory-elision.cpp -> copy-elision.cpp
It reflects its contents more accurately. No functional change intended.
Added:
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338338: [Sema] Relax a failing assert in TemplateArgumentLoc
(authored by epilk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49766?vs=1577
Author: rsmith
Date: Mon Jul 30 17:47:41 2018
New Revision: 338343
URL: http://llvm.org/viewvc/llvm-project?rev=338343&view=rev
Log:
[coroutines] Fix handling of dependent co_await in StmtProfiler.
Fix "Invalid operator call kind" error (llvm_unreachable) in
DecodeOperatorCall when profiling a de
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338343: [coroutines] Fix handling of dependent co_await in
StmtProfiler. (authored by rsmith, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
mgrang updated this revision to Diff 158147.
mgrang added a comment.
Addressed comments.
https://reviews.llvm.org/D50029
Files:
include/clang/Basic/TargetInfo.h
test/CodeGen/exceptions-seh-finally.c
test/CodeGen/exceptions-seh.c
Index: test/CodeGen/exceptions-seh.c
=
mattd updated this revision to Diff 158144.
mattd added a comment.
- Added a test that creates a directory via __llvm_profile_recursive_mkdir and
verifies the mode.
- I intend to only commit one of the two tests, but wanted to provide a more
specific/detailed test.
- I don't know if we really
rsmith updated this revision to Diff 158149.
rsmith marked 8 inline comments as done.
https://reviews.llvm.org/D49922
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Type.cpp
lib/AST/TypePri
rsmith added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2371
+is retained by the return value of the annotated function
+(or, for a constructor, in the value of the constructed object).
+It is only supported in C++.
aaron.ballman wrote:
> I read
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D50029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle added a comment.
Was there any objection to this patch? It would have been nice to have this
before the branching.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49833
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Quuxplusone added a comment.
@lichray: I'm interested in merging this patch into my libc++ fork, but the
latest update seems to be missing a ton of files. For example
`charconv_test_helpers.h` is included by one of the tests, but does not exist.
Also there's a lot of boilerplate missing: you ou
devnexen added a comment.
ping :)
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
baloghadamsoftware marked an inline comment as not done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:605
+ if (Pos && !Pos->isValid()) {
+// If I do not put a tag here, some invalidation tests will fail
+static Ch
101 - 167 of 167 matches
Mail list logo
