[PATCH] D49573: [CMake] Option to control whether shared/static library is installed

sbc100 added a comment. https://reviews.llvm.org/D49825 seems to fix it. Repository: rCXX libc++ https://reviews.llvm.org/D49573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49825: [CMake] Don't use LIBCXXABI_ENABLE_STATIC option before its declared

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCXXA libc++abi https://reviews.llvm.org/D49825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:89 + Builder.Inliner = createFunctionInliningPass(OptLevel, SizeLevel, false); + Builder.LoopVectorize = true; + Builder.populateFunctionPassManager(FPM); more

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman updated this revision to Diff 157388. emmettneyman added a comment. Fixed some things, made code cleaner Repository: rC Clang https://reviews.llvm.org/D49526 Files: clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp clang/tools/clang-fuzzer/handle-llvm/CMakeLis

[libcxxabi] r337982 - [CMake] Don't use LIBCXXABI_ENABLE_STATIC option before its declared

Author: sbc Date: Wed Jul 25 16:13:00 2018 New Revision: 337982 URL: http://llvm.org/viewvc/llvm-project?rev=337982&view=rev Log: [CMake] Don't use LIBCXXABI_ENABLE_STATIC option before its declared Summary: rL337867 introduced two new cmake_dependent_option options: - LIBCXXABI_INSTALL_STATIC_LI

[PATCH] D49825: [CMake] Don't use LIBCXXABI_ENABLE_STATIC option before its declared

This revision was automatically updated to reflect the committed changes. Closed by commit rL337982: [CMake] Don't use LIBCXXABI_ENABLE_STATIC option before its declared (authored by sbc, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D498

[PATCH] D49826: [analyzer] NFC: Minor code reuse in simplifySVal().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. Satisfies a review comment in https://reviews.llvm.org/D49749. Repository: rC Clang https://reviews

[PATCH] D49749: [analyzer] Admit that we can't simplify the newly produced mixed Loc/NonLoc expressions.

NoQ requested review of this revision. NoQ marked an inline comment as done. NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1300 + Loc::isLocType(S->getRHS()->getType())) { +SVal V = SVB.makeSymbolVal(S); +Cached[S] =

[PATCH] D49526: Updated llvm-proto-fuzzer to execute the compiled code

emmettneyman added inline comments. Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:159 + std::unique_ptr(RTDyldMM)); + builder.setOptLevel(OLvl); + builder.setTargetOptions(InitTargetOptionsFromCodeGenFlags()); emmettneyman wrote: > moreh

[PATCH] D48862: [OpenEmbedded] Fix lib paths for OpenEmbedded targets

mgrang updated this revision to Diff 157391. mgrang added a comment. Rebased patch and fixed unit test on Windows. https://reviews.llvm.org/D48862 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Linux.cpp test/Driver/Inputs/openembedded_aarch64_linux_tree/usr/include/c++/6.3.0

[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

ahatanak updated this revision to Diff 157395. ahatanak marked an inline comment as done. ahatanak added a comment. Document the meaning of enterByrefCleanup's parameters. Repository: rC Clang https://reviews.llvm.org/D49718 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGDecl.cpp lib/Co

[PATCH] D48427: [Analyzer] Iterator Checker Hotfix: Defer deletion of container data until its last iterator is cleaned up

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yep, that'll do, thanks! Sorry for not keeping up with all the incoming reviews. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:536 if (!SR.isLiveRegion(Cont.firs

[PATCH] D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping.

ahatanak updated this revision to Diff 157398. ahatanak added a comment. Add a test case for an interface conforming to a non-escaping protocol. In https://reviews.llvm.org/D49119#1164285, @vsapsai wrote: > Also I had a few ideas for tests when the warning isn't required and it is > absent. But

[PATCH] D49770: [ARM64] [Windows] Follow MS X86_64 C++ ABI when passing structs

ssijaric updated this revision to Diff 157394. ssijaric added a comment. Updated to address Martin's observation. Verified that small structs with default copy constructors and non-trivial destructors are passed in registers on ARM64 Windows. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D49828: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined)

EricWF created this revision. EricWF added reviewers: mclow.lists, ldionne, rsmith, jyknight, echristo. Herald added a subscriber: dberris. Using __int128_t with UBSAN causes link errors unless compiler-rt is providing the runtime library. Specifically ubsan generates calls to __muloti4 but libgc

[libcxx] r337984 - [libc++] Follow-up to r337968: use an explicit cast as suggested by Eric

Author: arphaman Date: Wed Jul 25 16:59:54 2018 New Revision: 337984 URL: http://llvm.org/viewvc/llvm-project?rev=337984&view=rev Log: [libc++] Follow-up to r337968: use an explicit cast as suggested by Eric Modified: libcxx/trunk/src/experimental/filesystem/filesystem_common.h Modified: lib

[PATCH] D49828: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined)

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Bit of a hack, but I'm ok with it. Repository: rCXX libc++ https://reviews.llvm.org/D49828 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:605 + if (Pos && !Pos->isValid()) { +// If I do not put a tag here, some invalidation tests will fail +static CheckerProgramPointTag Tag("InvalidatedIteratorChecker",

[libcxx] r337990 - [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined)

Author: ericwf Date: Wed Jul 25 17:34:50 2018 New Revision: 337990 URL: http://llvm.org/viewvc/llvm-project?rev=337990&view=rev Log: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined) Summary: Using int128_t with UBSAN causes link errors unless compiler-rt is provi

[PATCH] D49828: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is undefined)

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX337990: [libc++] Add hack to allow ubsan to work w/o compiler-rt (__muloti4 is… (authored by EricWF, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D49828 Files: src/experimental

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added a comment. @aaron.ballman @rsmith Any more feedback on this patch? Repository: rC Clang https://reviews.llvm.org/D49511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D49536: [Analyzer] Quick Fix for exponential execution time when simpilifying complex additive expressions

mikhail.ramalho added a comment. I getting the following error when analyzing `test/Analysis/plist-macros.cpp`, usign z3 as constraint manager (`-analyzer-constraints=z3 -DANALYZER_CM_Z3`): /home/mgadelha/llvm/tools/clang/test/Analysis/plist-macros.cpp:640:16: error: CHECK-NEXT: expected stri

[PATCH] D49536: [Analyzer] Quick Fix for exponential execution time when simpilifying complex additive expressions

NoQ added a comment. In https://reviews.llvm.org/D49536#1176128, @mikhail.ramalho wrote: > I getting the following error when analyzing > `test/Analysis/plist-macros.cpp`, usign z3 as constraint manager > (`-analyzer-constraints=z3 -DANALYZER_CM_Z3`): > > /home/mgadelha/llvm/tools/clang/test/

[PATCH] D49228: [analyzer][UninitializedObjectChecker] Void pointer objects are casted back to their dynmic type in note message

NoQ added inline comments. Comment at: test/Analysis/cxx-uninitialized-object-ptr-ref.cpp:290 struct IntDynTypedVoidPointerTest1 { - void *vptr; // expected-note{{uninitialized pointee 'this->vptr'}} + void *vptr; // expected-note{{uninitialized pointee 'this->static_cast(vptr

[PATCH] D49119: [Sema][ObjC] Issue a warning when a method declared in a protocol is non-escaping but the corresponding method in the implementation is escaping.

vsapsai added a comment. In https://reviews.llvm.org/D49119#1176047, @ahatanak wrote: > In https://reviews.llvm.org/D49119#1164285, @vsapsai wrote: > > > Also I had a few ideas for tests when the warning isn't required and it is > > absent. But I'm not sure they are actually valuable. If you are

[PATCH] D48436: [analyzer][UninitializedObjectChecker] Fixed a false negative by no longer filtering out certain constructor calls

NoQ added a comment. Sorry, i'm still lagging with my reviews because there are a lot of them and i have to balance it with doing actual work. I'll hopefully get to this soon. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:681-689 +Optional OtherObj

[libcxx] r337991 - Add print statements to help debugging

Author: ericwf Date: Wed Jul 25 18:10:50 2018 New Revision: 337991 URL: http://llvm.org/viewvc/llvm-project?rev=337991&view=rev Log: Add print statements to help debugging Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp Modi

[PATCH] D49536: [Analyzer] Quick Fix for exponential execution time when simpilifying complex additive expressions

mikhail.ramalho added a comment. > Uhm, dunno, plist/FileCheck tests are annoying. What i usually do to make > sense out of them is update the tested output with the actual output and look > at git diff. From that it's usually obvious what exactly happened (warnings > added, warnings removed, w

[PATCH] D49536: [Analyzer] Quick Fix for exponential execution time when simpilifying complex additive expressions

NoQ added a comment. The "Assuming..." diagnostic piece isn't the same as "Taking true/false branch" diagnostic piece. The former indicates that a constraint is added. The latter indicate how the path flows between program points. The absence of "Assuming..." indicates that Z3 didn't need to ma

[PATCH] D49715: [analyzer] CallEvent: Add partially working methods for obtaining the callee stack frame.

NoQ updated this revision to Diff 157416. NoQ marked 4 inline comments as done. NoQ added a comment. Address comments by editing comments. https://reviews.llvm.org/D49715 Files: include/clang/Analysis/ConstructionContext.h include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h includ

[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rC Clang https://reviews.llvm.org/D49718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

Re: [libcxx] r337960 - [libc++] Use __int128_t to represent file_time_type.

As is the case on most modern platforms, the ability to store a high-res file timestamp is dependent on the filesystem the file is stored on. The HFS+ filesystem (used by default before macOS 10.13) stores timestamps at a 1-second granularity, and APFS (now the default) at a 1 nanosecond granulari

[libcxx] r337998 - Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds.

Author: ericwf Date: Wed Jul 25 20:28:48 2018 New Revision: 337998 URL: http://llvm.org/viewvc/llvm-project?rev=337998&view=rev Log: Workaround OS X 10.11 behavior where stat truncates st_mtimespec to seconds. Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_wri

Re: [libcxx] r337960 - [libc++] Use __int128_t to represent file_time_type.

Thank you for the clarification. On Wed, Jul 25, 2018 at 9:16 PM James Y Knight wrote: > As is the case on most modern platforms, the ability to store a high-res > file timestamp is dependent on the filesystem the file is stored on. > > The HFS+ filesystem (used by default before macOS 10.13) st

[libcxx] r337999 - Fix attribute placement WRT extern C

Author: ericwf Date: Wed Jul 25 20:36:37 2018 New Revision: 337999 URL: http://llvm.org/viewvc/llvm-project?rev=337999&view=rev Log: Fix attribute placement WRT extern C Modified: libcxx/trunk/src/experimental/filesystem/int128_builtins.cpp Modified: libcxx/trunk/src/experimental/filesystem/

[libcxx] r338000 - Correct comment about stat truncating st_mtimespec to seconds

Author: ericwf Date: Wed Jul 25 20:42:25 2018 New Revision: 338000 URL: http://llvm.org/viewvc/llvm-project?rev=338000&view=rev Log: Correct comment about stat truncating st_mtimespec to seconds Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_wr

[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

malaperle created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. That way, as soon as the "initialize" is received by the server, it can start parsing/indexing with a valid compilation database and not have to wait for a an initial 'didCha

[libcxx] r338001 - Cleanup the last_write_time internals

Author: ericwf Date: Wed Jul 25 20:57:26 2018 New Revision: 338001 URL: http://llvm.org/viewvc/llvm-project?rev=338001&view=rev Log: Cleanup the last_write_time internals Modified: libcxx/trunk/src/experimental/filesystem/filesystem_common.h libcxx/trunk/src/experimental/filesystem/operat

[libcxx] r338002 - Be more consistent about which bool value means an error occurred

Author: ericwf Date: Wed Jul 25 21:02:06 2018 New Revision: 338002 URL: http://llvm.org/viewvc/llvm-project?rev=338002&view=rev Log: Be more consistent about which bool value means an error occurred Modified: libcxx/trunk/src/experimental/filesystem/operations.cpp Modified: libcxx/trunk/src/

[PATCH] D49834: [CMake] Don't generate linker script only when shared library isn't statically linked

phosek created this revision. phosek added reviewers: EricWF, ldionne, mclow.lists. Herald added subscribers: cfe-commits, christof, mgorny. Since r337668, we support statically linking dependencies only to shared or static library. However, that change hasn't updated the check whether to generate

[PATCH] D49770: [ARM64] [Windows] Follow MS X86_64 C++ ABI when passing structs

mstorsjo accepted this revision. mstorsjo added a comment. LGTM. Should the same tweak also be done for arm/thumb? Repository: rC Clang https://reviews.llvm.org/D49770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[libcxx] r338005 - Copy LLVM CMake configuration for CMake Policy CMP0068

Author: ericwf Date: Wed Jul 25 22:08:30 2018 New Revision: 338005 URL: http://llvm.org/viewvc/llvm-project?rev=338005&view=rev Log: Copy LLVM CMake configuration for CMake Policy CMP0068 Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: http://llvm.org/viewvc

[libcxx] r338006 - [CMake] Don't generate linker script only when shared library isn't statically linked

Author: phosek Date: Wed Jul 25 22:10:24 2018 New Revision: 338006 URL: http://llvm.org/viewvc/llvm-project?rev=338006&view=rev Log: [CMake] Don't generate linker script only when shared library isn't statically linked Since r337668, we support statically linking dependencies only to shared or s

[PATCH] D49834: [CMake] Don't generate linker script only when shared library isn't statically linked

This revision was automatically updated to reflect the committed changes. Closed by commit rL338006: [CMake] Don't generate linker script only when shared library isn't statically… (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:2582 /// yet; if a cleanup is required for the variable itself, that needs /// to be done externally. +void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr, rjmccall wrote: >

[PATCH] D49718: [CodeGen][ObjC] Make block copy/dispose helper function exception-safe.

rjmccall added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:2582 /// yet; if a cleanup is required for the variable itself, that needs /// to be done externally. +void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr, ahatanak wrote: >

[PATCH] D49063: [libclang 1/8] Add support for ObjCObjectType

yvvan added a comment. I'm mostly fine with your set of patches. Let me double check and we can get it in. https://reviews.llvm.org/D49063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

<    1   2   3