ioeric added a subscriber: malaperle.
ioeric added a comment.
It would make it easier for your reviewers to look at the new changes if
you just reopen this patch and update the diff :)
Repository:
rC Clang
https://reviews.llvm.org/D48903
___
cfe-
mikhail.ramalho added a comment.
It fixes Xerces verification. Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D49749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Jul 25, 2018 at 1:40 AM Eric Liu wrote:
> Please also include a link to the test failure in the commit message or
> this email thread.
>
Sorry, I left the failure on the review thread (
https://reviews.llvm.org/D49724) but forgot to include it in the commit
message. I'll make sure to do t
Thanks Jordan!
On Wed, Jul 25, 2018 at 6:01 PM Jordan Rupprecht
wrote:
> On Wed, Jul 25, 2018 at 1:40 AM Eric Liu wrote:
>
>> Please also include a link to the test failure in the commit message or
>> this email thread.
>>
> Sorry, I left the failure on the review thread (
> https://reviews.llv
simark reopened this revision.
simark added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D48903#1175317, @ioeric wrote:
> It would make it easier for your reviewers to look at the new changes if
> you just reopen this patch and update the diff :)
I tr
simark updated this revision to Diff 157287.
simark added a comment.
Fix tests on Windows
Fix InMemoryFileSystem tests on Windows. The paths returned by the
InMemoryFileSystem directory iterators in the tests mix posix and windows
directory separators. THis is because we do queries with posix-s
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:181
- auto *TypeDecl = ObjRegion->getValueType()->getAsCXXRecordDecl();
- if (TypeDecl->getName() != "basic_string")
-return;
+for (unsigned I = 0, E = FD->getNumParams();
rnkovacs updated this revision to Diff 157286.
rnkovacs marked an inline comment as done.
rnkovacs added a comment.
Tiny bit more re-structuring.
https://reviews.llvm.org/D49656
Files:
lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/A
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:181
- auto *TypeDecl = ObjRegion->getValueType()->getAsCXXRecordDecl();
- if (TypeDecl->getName() != "basic_string")
-return;
+for (unsigned I = 0, E = FD->getNumParams();
olga.chupina added a comment.
I should probably add one more example to explain my point of view.
Suppose we have an indirect call in the program and we need to know all
possible goals for this indirect call. Then we would like to know that one of
the structure fields is a function pointer and i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337937: [CMake] Use LIBCXXABI_LIBDIR_SUFFIX in libc++abi
build (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49765?vs=1
Author: phosek
Date: Wed Jul 25 09:51:00 2018
New Revision: 337937
URL: http://llvm.org/viewvc/llvm-project?rev=337937&view=rev
Log:
[CMake] Use LIBCXXABI_LIBDIR_SUFFIX in libc++abi build
This was changed unintentionally in r335809.
Differential Revision: https://reviews.llvm.org/D49765
Modifie
bricci updated this revision to Diff 157288.
bricci added a comment.
- clang-format on the changes in the .cpp files
Repository:
rC Clang
https://reviews.llvm.org/D49729
Files:
include/clang/AST/Decl.h
include/clang/AST/DeclBase.h
lib/AST/Decl.cpp
lib/AST/DeclBase.cpp
lib/AST/DeclC
bricci updated this revision to Diff 157291.
bricci marked an inline comment as done.
bricci added a comment.
- clang-format on the changes
- removed the unnecessary hasBracesImpl and setBracesImpl
Repository:
rC Clang
https://reviews.llvm.org/D49733
Files:
include/clang/AST/Decl.h
inclu
bricci updated this revision to Diff 157289.
bricci marked 2 inline comments as done.
bricci added a comment.
- ran clang-format on the changes
- removed the unnecessary setPureImpl, isMultiVersionImpl and
setMultiVersionImpl. However unfortunately I think that isDeletedImpl has to
stay because
bricci updated this revision to Diff 157293.
bricci marked an inline comment as done.
bricci added a comment.
- clang-format on the changes
- remove the unnecessary getFamilyImpl and setFamilyImpl
Repository:
rC Clang
https://reviews.llvm.org/D49734
Files:
include/clang/AST/DeclObjC.h
li
Author: abataev
Date: Wed Jul 25 10:27:45 2018
New Revision: 337941
URL: http://llvm.org/viewvc/llvm-project?rev=337941&view=rev
Log:
[OPENMP] Exclude service expressions/statements from the list of
the children.
Special internal helper expressions/statements for the OpenMP directives
should not
sepavloff updated this revision to Diff 157305.
sepavloff added a comment.
Updated patch
Now the information, if the pointer produced by 'new' operator is checked,
is stored in objects used for pointer representation (`Address` and
`AggValueSlot`) rather than globally.
Also the tests were cleane
Thanks!
Just out of curiosity, what is the "omp_outlined" function you're checking for?
Is it implicitly-defined? If it's not user-visible, i.e it doesn't actually
appear in the source code of a program, why should we generate a code coverage
mapping for it at all?
vedant
> On Jul 25, 2018, a
Ah, great. Thanks again!
vedant
> On Jul 25, 2018, at 10:33 AM, Alexey Bataev wrote:
>
> This is visible to the user, the statement under #pragma omp parallel
> directive is outlined as a function.
> -
> Best regards,
> Alexey Bataev
> 25.07.2018 13:31, Vedant Kumar пишет:
>> Thank
rjmccall added a comment.
In https://reviews.llvm.org/D49403#1175350, @olga.chupina wrote:
> I should probably add one more example to explain my point of view.
> Suppose we have an indirect call in the program and we need to know all
> possible goals for this indirect call. Then we would like
rjmccall added inline comments.
Comment at: lib/CodeGen/Address.h:46
+return IsChecked;
+ }
+
`Address` is a pretty low-level type to be changing here. Is this necessary?
Can you find a way to propagate this just in higher-level types like
`AggValueSlot`
arsenm added a comment.
According to cayman manual, these registers do exist so we should probably just
make the feature accepted on r600 as well
Repository:
rC Clang
https://reviews.llvm.org/D49650
___
cfe-commits mailing list
cfe-commits@lists
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:190
+ builder.setMCJITMemoryManager(
+ std::unique_ptr(RTDyldMM));
+ builder.setOptLevel(OLvl);
morehouse wrote:
> emmettneyman wrote:
> > morehouse wrote:
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:190
+ builder.setMCJITMemoryManager(
+ std::unique_ptr(RTDyldMM));
+ builder.setOptLevel(OLvl);
emmettneyman wrote:
> morehouse wrote:
> > emmettneyman wrote:
vsapsai updated this revision to Diff 157311.
vsapsai added a comment.
- Make diagnostics more general, use unit tests.
https://reviews.llvm.org/D49518
Files:
clang/lib/Basic/VirtualFileSystem.cpp
clang/unittests/Basic/VirtualFileSystemTest.cpp
Index: clang/unittests/Basic/VirtualFileSyste
erik.pilkington updated this revision to Diff 157309.
erik.pilkington added a comment.
Implement @rsmith's second suggestion. Thanks!
https://reviews.llvm.org/D49439
Files:
clang/lib/Sema/SemaTemplate.cpp
clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp
Index: clang/test/Sema
erik.pilkington added inline comments.
Comment at: clang/lib/Sema/SemaTemplate.cpp:1899-1907
// Canonicalize the type. This (for instance) replaces references to
// typedef members of the current instantiations with the definitions of
// those typedefs, avoiding tr
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
@rnkovacs Personally I'm fine with moving it out of alpha then.
If all the reports you have seen so far are true positives, then it's *amazing*.
I would even go as far as fil
jvesely added a comment.
In https://reviews.llvm.org/D49650#1175438, @arsenm wrote:
> According to cayman manual, these registers do exist so we should probably
> just make the feature accepted on r600 as well
sure, that's the way it was before r335942. I assumed the removal was
intentional.
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:190
+ builder.setMCJITMemoryManager(
+ std::unique_ptr(RTDyldMM));
+ builder.setOptLevel(OLvl);
morehouse wrote:
> emmettneyman wrote:
> > morehouse wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337944: [clang:sema] de-duplicate getDepthAndIndex helpers
(authored by nickdesaulniers, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49760?vs=157134&id=157314#toc
Repository:
r
ldionne created this revision.
ldionne added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, christof.
The exact same code was replicated 11 times for implementing the basic_istream
input operators (those that don't use numeric_limits).
Author: mstorsjo
Date: Wed Jul 25 11:24:23 2018
New Revision: 337946
URL: http://llvm.org/viewvc/llvm-project?rev=337946&view=rev
Log:
[windows] Fix warning about comparing ints of different signs
This fixes a warning like this:
warning: comparison of integers of different signs:
'std::__1
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:190
+ builder.setMCJITMemoryManager(
+ std::unique_ptr(RTDyldMM));
+ builder.setOptLevel(OLvl);
emmettneyman wrote:
> morehouse wrote:
> > emmettneyman wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337946: [windows] Fix warning about comparing ints of
different signs (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://reviews.ll
Author: mramalho
Date: Wed Jul 25 11:26:50 2018
New Revision: 337948
URL: http://llvm.org/viewvc/llvm-project?rev=337948&view=rev
Log:
[analyzer] Fix compilation when LLVM_ENABLE_MODULES=ON
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/SMTExpr.h
cfe/trunk/include/cla
Author: nickdesaulniers
Date: Wed Jul 25 11:11:01 2018
New Revision: 337944
URL: http://llvm.org/viewvc/llvm-project?rev=337944&view=rev
Log:
[clang:sema] de-duplicate getDepthAndIndex helpers
Summary:
Continuing off of:
https://reviews.llvm.org/D38382
Fixes:
https://bugs.llvm.org/show_bug.cgi?i
rnkovacs created this revision.
rnkovacs added reviewers: NoQ, xazax.hun, george.karpenkov.
Herald added subscribers: mikhail.ramalho, a.sidorin, dkrupp, szepet,
baloghadamsoftware, whisperity.
The `CoreEngine` only gives us a `ReturnStmt` if the last element in the
`CFGBlock` is a `CFGStmt`, ot
BillyONeal added a comment.
In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
> Another problem (that Eric and I discussed last night) is that filesystem is
> part of C++17, and `file_clock` is C++20. So we need a solution for C++17 as
> well.
It seems like we need to fix C++20
vitaut created this revision.
vitaut added a reviewer: EricWF.
Herald added subscribers: ldionne, christof.
This fixes an error when compiling `` with gcc 4.8.5:
.../libcxx/src/experimental/filesystem/filesystem_common.h:137:34:
error: redeclaration ‘T
std::experimental::filesystem::v1::det
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
Nice cleanup! LGTM.
Repository:
rCXX libc++
https://reviews.llvm.org/D49808
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp:208
+
+ static_cast(RTDyldMM)->invalidateInstructionCache();
+
morehouse wrote:
> This cast shouldn't be necessary.
Turns out this line is redundant anyways. `EE
emmettneyman updated this revision to Diff 157335.
emmettneyman added a comment.
- cleaned up code and moved initialization code
- removed fake command line parsing
Repository:
rC Clang
https://reviews.llvm.org/D49526
Files:
clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp
Author: vsapsai
Date: Wed Jul 25 12:16:26 2018
New Revision: 337953
URL: http://llvm.org/viewvc/llvm-project?rev=337953&view=rev
Log:
[Preprocessor] Stop entering included files after hitting a fatal error.
Fixes a problem when we have multiple inclusion cycles and try to
enumerate all possible w
vsapsai added a comment.
Thanks everyone for reviewing the change.
Repository:
rL LLVM
https://reviews.llvm.org/D48786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337953: [Preprocessor] Stop entering included files after
hitting a fatal error. (authored by vsapsai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D48753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mramalho
Date: Wed Jul 25 12:34:48 2018
New Revision: 337954
URL: http://llvm.org/viewvc/llvm-project?rev=337954&view=rev
Log:
[analyzer] Update SMT API documentation and methods
Summary:
Update the documentation of all the classes introduced with the new generic SMT
API, most of them we
Author: ldionne
Date: Wed Jul 25 12:40:01 2018
New Revision: 337955
URL: http://llvm.org/viewvc/llvm-project?rev=337955&view=rev
Log:
[libc++] Factor duplicate code into function templates
Summary:
The exact same code was replicated 11 times for implementing the basic_istream
input operators (tho
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX337955: [libc++] Factor duplicate code into function
templates (authored by ldionne, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49808?vs=157316&id=157340#toc
Repository:
rCX
ldionne added a comment.
In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote:
> In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
>
> > Another problem (that Eric and I discussed last night) is that filesystem
> > is part of C++17, and `file_clock` is C++20. So we need a
rnkovacs added a comment.
I'm not sure how to test this.
I'll need it in https://reviews.llvm.org/D49361 when I update it to use the
changed `checkEndFunction()` callback, and that will kind of test this too.
Repository:
rC Clang
https://reviews.llvm.org/D49811
___
mclow.lists added a comment.
In https://reviews.llvm.org/D49774#1175650, @ldionne wrote:
> In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote:
>
> > In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
> >
> > > Another problem (that Eric and I discussed last night) is that
NoQ accepted this revision.
NoQ added a comment.
Looks great!
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:192
- if (Call.isCalled(CStrFn) || Call.isCalled(DataFn)) {
-SVal RawPtr = Call.getReturnValue();
-if (SymbolRef Sym = RawPtr.getAsSymbol(/*I
BillyONeal added a comment.
In https://reviews.llvm.org/D49774#1175650, @ldionne wrote:
> In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote:
>
> > In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
> >
> > > Another problem (that Eric and I discussed last night) is that f
EricWF added a comment.
In https://reviews.llvm.org/D49774#1175679, @BillyONeal wrote:
> In https://reviews.llvm.org/D49774#1175650, @ldionne wrote:
>
> > In https://reviews.llvm.org/D49774#1175543, @BillyONeal wrote:
> >
> > > In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
> > >
simark added a comment.
Thanks, that's simple and efficient. I'll update
https://reviews.llvm.org/D49267 (to call `reparseOpenFiles` once again) once
this is merged.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49783
___
cfe-co
Author: abataev
Date: Wed Jul 25 13:03:01 2018
New Revision: 337957
URL: http://llvm.org/viewvc/llvm-project?rev=337957&view=rev
Log:
[OPENMP] ThreadId in serialized parallel regions is 0.
The first argument for the parallel outlined functions, called as
serialized parallel regions, should be a p
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp:44
+
+ PassRegistry &Registry = *llvm::PassRegistry::getPassRegistry();
+ initializeCore(Registry);
Unnecessary `llvm::`
Comment a
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yet another great catch!
I guess you could write a test with `debug.AnalysisOrder` (by making its
`checkEndFunction` callback (that you'll have to define) print different things
depending on the re
kcc added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.h:114
+Partial,// Sign the return address of functions that spill LR
+All // Sign the return address of all functions
+ };
what's the purpose of signing LR i
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Urg. That's an old compiler. But this looks OK to me.
Repository:
rCXX libc++
https://reviews.llvm.org/D49813
___
cfe-commits mailing list
cfe
EricWF updated this revision to Diff 157349.
EricWF added a comment.
Update with misc cleanups.
https://reviews.llvm.org/D49774
Files:
include/experimental/filesystem
src/chrono.cpp
src/experimental/filesystem/filesystem_common.h
src/experimental/filesystem/operations.cpp
src/include/
echristo added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:933-938
+ if (TC.supportsDebugInfoOption(A)) {
+Action();
+return true;
+ }
+ reportUnsupportedDebugInfoOption(A, Args, D, TC.getTriple());
+ return false;
I'd probably simpli
erik.pilkington added a comment.
Hi Balaji,
I reduced your testcase a bit more, this looks like the can be a crash on
valid. Can you use the more minimal version in the testcase?
template
struct e {
e(a) {}
};
e c(0);
Also: you should add cfe-commits as a subscriber when creatin
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'm going to go ahead and commit this now. We can address concerns about the
future C++20 spec in follow up commits.
https://reviews.llvm.org/D49774
___
Author: ericwf
Date: Wed Jul 25 13:51:49 2018
New Revision: 337960
URL: http://llvm.org/viewvc/llvm-project?rev=337960&view=rev
Log:
[libc++] Use __int128_t to represent file_time_type.
Summary:
The ``file_time_type`` time point is used to represent the write times for
files.
Its job is to act a
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX337960: [libc++] Use __int128_t to represent
file_time_type. (authored by EricWF, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D49774
Files:
include/experimental/filesystem
s
vitaut added a comment.
@EricWF could you or someone else commit this as I don't have commit access?
Thanks.
Repository:
rCXX libc++
https://reviews.llvm.org/D49813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: ericwf
Date: Wed Jul 25 14:01:45 2018
New Revision: 337962
URL: http://llvm.org/viewvc/llvm-project?rev=337962&view=rev
Log:
Make compile with gcc 4.8.5
Patch by Victor Zverovich.
This fixes an error when compiling `` with gcc 4.8.5:
```
.../libcxx/src/experimental/filesystem/filesyste
EricWF closed this revision.
EricWF added a comment.
r337962.
Thanks.
Repository:
rCXX libc++
https://reviews.llvm.org/D49813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ssijaric added a comment.
Yes, it looks like the comment for the thumb case is applicable here as well.
VC++ on ARM64 passes small structs with a destructor and a default copy
constructor in a register, while clang passes them on the stack. I will
probably address this in a separate patch.
delesley accepted this revision.
delesley added a comment.
This revision is now accepted and ready to land.
Looks good to me. Thanks for the patch, and my apologies for the slow
response. (I'm on a different project now, so I'm afraid thread safety doesn't
always get the attention from me that
rsmith added a comment.
I've not done a full review, but the approach here looks good, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D49729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
This has too much duplication with respect to your previous patch, and even
Phabricator highlights it in yellow.
Repository:
rC Clang
https://reviews.llvm.org
lebedev.ri added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:979-1003
+bool ScalarExprEmitter::IsTopCastPartOfExplictCast() {
+ assert(!CastExprStack.empty());
+ // Walk the current stack of CastExprs in reverse order.
+ // That is, the current CastExpr, which is
Author: arphaman
Date: Wed Jul 25 14:50:44 2018
New Revision: 337968
URL: http://llvm.org/viewvc/llvm-project?rev=337968&view=rev
Log:
[libc++] Follow-up to r337960: specify lambda's return type to avoid
-Wc++11-narrowing warning on Darwin
The internal CI produced the following diagnostic:
error:
ahatanak updated this revision to Diff 157373.
ahatanak added a comment.
Check if destructors are accessible from InitListChecker's constructor. Add
test cases for designated initializer and brace elision.
Repository:
rC Clang
https://reviews.llvm.org/D45898
Files:
lib/Sema/SemaInit.cpp
Author: ericwf
Date: Wed Jul 25 14:53:43 2018
New Revision: 337970
URL: http://llvm.org/viewvc/llvm-project?rev=337970&view=rev
Log:
Fix failing test under C++14
Modified:
libcxx/trunk/src/experimental/filesystem/filesystem_common.h
Modified: libcxx/trunk/src/experimental/filesystem/filesyst
aaronpuchert added a comment.
No problem. Thanks for the review! Would be nice if you or @aaron.ballman could
commit this, as I don't have commit access.
Repository:
rC Clang
https://reviews.llvm.org/D49355
___
cfe-commits mailing list
cfe-commi
Author: ericwf
Date: Wed Jul 25 14:58:37 2018
New Revision: 337971
URL: http://llvm.org/viewvc/llvm-project?rev=337971&view=rev
Log:
Remove test which shouldn't have been committed
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.
rnkovacs updated this revision to Diff 157375.
rnkovacs retitled this revision from "[analyzer][WIP] Detect pointers escaped
after return statement execution in MallocChecker" to "[analyzer] Detect
pointers escaped after return statement execution in MallocChecker".
rnkovacs edited the summary of
Author: ericwf
Date: Wed Jul 25 15:07:36 2018
New Revision: 337974
URL: http://llvm.org/viewvc/llvm-project?rev=337974&view=rev
Log:
Fix GCC build in C++14 w/o c++14 constexpr
Modified:
libcxx/trunk/src/experimental/filesystem/filesystem_common.h
Modified: libcxx/trunk/src/experimental/files
juliehockett added a comment.
ping
https://reviews.llvm.org/D48341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jul 25 15:21:47 2018
New Revision: 337976
URL: http://llvm.org/viewvc/llvm-project?rev=337976&view=rev
Log:
Work around GCC bug in constexpr function
Modified:
libcxx/trunk/test/libcxx/experimental/filesystem/convert_file_time.sh.cpp
Modified:
libcxx/trunk/test/libc
efriedma added a comment.
Herald added a subscriber: jfb.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D45712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChains/Darwin.cpp:2027
+ isAlignedAllocationUnavailable())
CC1Args.push_back("-faligned-alloc-unavailable");
}
Quux
ahatanak updated this revision to Diff 157380.
ahatanak added a comment.
Set the BLOCK_FIELD_IS_WEAK bit of the flag passed to the call to
enterByrefCleanup in EmitAutoVarCleanups and fix test case
test/CodeGenObjC/blocks.m.
Repository:
rC Clang
https://reviews.llvm.org/D49718
Files:
lib
ahatanak added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbc100 added a comment.
FYI, this broke the WebAssembly waterfall, where the library is no longer being
installed: https://wasm-stat.us/builders/linux/builds/34191
There is probably an easy fix, but I thought I'd post here for the record.
Repository:
rCXX libc++
https://reviews.llvm.org/D49
NoQ added a comment.
Devin has recently pointed out that we might have as well reordered CFG
elements to have return statement kick in after automatic destructors, so that
callbacks were called in a different order. I don't see any problems with that
solution, but let's stick to the current sol
devnexen updated this revision to Diff 157381.
https://reviews.llvm.org/D49722
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===
--- test/Analysi
Author: rtrieu
Date: Wed Jul 25 15:52:05 2018
New Revision: 337978
URL: http://llvm.org/viewvc/llvm-project?rev=337978&view=rev
Log:
[ODRHash] Support hashing enums.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/include/clang/AST/ODRHash.h
cfe/trunk/include/clang/Basic/Diagno
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yup, tests for temporaries are great to have as well.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2475-2477
// Check if we are returning freed memory.
if (Sym)
phosek added a comment.
In https://reviews.llvm.org/D42019#1162644, @mcgrathr wrote:
> Is this still live? Should it be different after all the multiarch stuff?
I'm about to revive this and was pondering if maybe we should generalize this
to all targets now that the multiarch runtime bit has l
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:2582
/// yet; if a cleanup is required for the variable itself, that needs
/// to be done externally.
+void CodeGenFunction::enterByrefCleanup(CleanupKind Kind, Address Addr,
Please document t
Author: phosek
Date: Wed Jul 25 15:57:39 2018
New Revision: 337979
URL: http://llvm.org/viewvc/llvm-project?rev=337979&view=rev
Log:
[CMake] Don't install c++abi headers in standalone libc++ build
This is a refinement on r337833. Previously we were installing two
copies of c++abi headers in libc+
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337979: [CMake] Don't install c++abi headers in
standalone libc++ build (authored by phosek, committed by ).
Herald added
sbc100 created this revision.
Herald added subscribers: cfe-commits, ldionne, christof, aheejin, mgorny.
https://reviews.llvm.org/rL337867 introduced two new cmake_dependent_option
options:
- LIBCXXABI_INSTALL_STATIC_LIBRARY
- LIBCXXABI_INSTALL_SHARED_LIBRARY
They depend on LIBCXXABI_ENABLE_STA
101 - 200 of 247 matches
Mail list logo
