ilya-biryukov added a comment.
For the record: this got reverted in https://reviews.llvm.org/rL337850
Repository:
rL LLVM
https://reviews.llvm.org/D49724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
WimLeflere added a comment.
I don't have commit access, can someone else commit this change?
Repository:
rC Clang
https://reviews.llvm.org/D48827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Please also include a link to the test failure in the commit message or
this email thread.
On Tue, Jul 24, 2018 at 10:28 PM Jordan Rupprecht via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rupprecht
> Date: Tue Jul 24 13:28:07 2018
> New Revision: 337850
>
> URL: http://llvm.org/vi
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
This has a shape to similar logrithm function but grows much slower for
large #usages.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49780
F
kbobyrev updated this revision to Diff 157203.
kbobyrev marked 14 inline comments as done.
kbobyrev added a comment.
Address the last round of comments.
Incoming: documentation overhaul.
https://reviews.llvm.org/D49546
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:181
+const auto HighestID = peek();
+DocID ChildrenToAdvance = 0;
+while ((ChildrenToAdvance++ < Children.size()) && !reachedEnd() &&
sammccall wrote:
> I can'
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
This seems to be another case of all other arches being the same while x86_32
is different. The thumb case (with same actual code as x86_64) has a comment
about a corner case where this do
ilya-biryukov added a comment.
Overall LG. I'm sure it's an improvement overall, just wanted to get some
clarifying comments and references, if that's possible.
NIT: a typo in the commit message
s/logrithm/logarithm
Comment at: clangd/Quality.cpp:200
+// f = 12.0
+/
kbobyrev updated this revision to Diff 157206.
kbobyrev added a comment.
Slightly refactored the code, improved documentation. This patch is ready for
review.
https://reviews.llvm.org/D49546
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/Iterator.cpp
cl
ioeric updated this revision to Diff 157207.
ioeric marked 2 inline comments as done.
ioeric added a comment.
Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49780
Files:
clangd/Quality.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/
ioeric added inline comments.
Comment at: clangd/Quality.cpp:200
+// f = 12.0
+// boost = f * sigmoid(m * std::log(References)) - 0.5 * f + 0.59
+// Sample data points: (10, 1.00), (100, 1.41), (1000, 1.82),
ilya-biryukov wrote:
> Made add referen
kbobyrev updated this revision to Diff 157208.
kbobyrev retitled this revision from "[clangd] Implement query iterators for
Dex symbol index" to "[clangd] Proof-of-concept query iterators for Dex symbol
index".
kbobyrev edited the summary of this revision.
kbobyrev added a comment.
Choose better
devnexen added a comment.
Hopefully will try to push it before the freeze just announced, that s my last
change in this area (except potential fixes) :)
Repository:
rC Clang
https://reviews.llvm.org/D49722
___
cfe-commits mailing list
cfe-commit
Author: ericwf
Date: Wed Jul 25 03:17:04 2018
New Revision: 337897
URL: http://llvm.org/viewvc/llvm-project?rev=337897&view=rev
Log:
Fix typos, spelling, and grammar in the FileTimeType design docs.
I'm sure I'll discover more mistakes as I go on...
Modified:
libcxx/trunk/docs/DesignDocs/Fil
krasimir added a comment.
MarcoFalke: do you need someone to submit this for you?
https://reviews.llvm.org/D48098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: balazske
Date: Wed Jul 25 03:21:06 2018
New Revision: 337898
URL: http://llvm.org/viewvc/llvm-project?rev=337898&view=rev
Log:
[ASTImporter] Add support for import of CXXInheritedCtorInitExpr.
Reviewers: a.sidorin, martong
Reviewed By: martong
Subscribers: rnkovacs, a_sidorin, martong,
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337898: [ASTImporter] Add support for import of
CXXInheritedCtorInitExpr. (authored by balazske, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49293?vs=155838&id=157212#toc
Reposit
Author: krasimir
Date: Wed Jul 25 03:21:47 2018
New Revision: 337899
URL: http://llvm.org/viewvc/llvm-project?rev=337899&view=rev
Log:
[clang-format ]Extend IncludeCategories regex documentation
Summary:
Extend the Clang-Format IncludeCategories documentation by adding a link to the
supported re
Author: ericwf
Date: Wed Jul 25 03:22:07 2018
New Revision: 337900
URL: http://llvm.org/viewvc/llvm-project?rev=337900&view=rev
Log:
Fix another typo in the FileTimeType docs
Modified:
libcxx/trunk/docs/DesignDocs/FileTimeType.rst
Modified: libcxx/trunk/docs/DesignDocs/FileTimeType.rst
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337899: [clang-format ]Extend IncludeCategories regex
documentation (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D488
mstorsjo created this revision.
mstorsjo added reviewers: pirama, pcc, compnerd, srhines.
Herald added a reviewer: EricWF.
Herald added a subscriber: ldionne.
This fixes a warning like this:
warning: comparison of integers of different signs:
'std::__1::__libcpp_tls_key' (aka 'long') and '
Author: omtcyfz
Date: Wed Jul 25 03:34:57 2018
New Revision: 337901
URL: http://llvm.org/viewvc/llvm-project?rev=337901&view=rev
Log:
[clangd] Introduce Dex symbol index search tokens
This patch introduces the core building block of the next-generation
Clangd symbol index - Dex. Search tokens are
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337901: [clangd] Introduce Dex symbol index search tokens
(authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49591?vs=15719
whisperity added a comment.
Softly pinging this. Perhaps we could discuss this and get it in before Clang7
rides off into the sunset?
https://reviews.llvm.org/D45094
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
whisperity added a comment.
Akin to https://reviews.llvm.org/D45094, pinging this too. 🙂
https://reviews.llvm.org/D45095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCXX libc++
https://reviews.llvm.org/D49782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: ioeric.
Herald added subscribers: jfb, arphaman, jkorous, MaskRay, javed.absar.
If the contents are the same, the update most likely comes from the
fact that compile commands were invalidated. In that case we want to
avoid rebuil
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clangd/Quality.cpp:194
+ if (References >= 10) {
+// Use a sigmoid style boosting function, which flats out better for large
+// numbe
asavonic updated this revision to Diff 157219.
asavonic added a comment.
Moved a chunk from https://reviews.llvm.org/D49725; added 2 more tests.
Repository:
rC Clang
https://reviews.llvm.org/D49723
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/invalid-kernel-parameters.cl
Index: test/Se
asavonic added a comment.
In https://reviews.llvm.org/D49723#1173352, @Anastasia wrote:
> Btw, has this restriction been removed from CL 2.0?
No, it applies for CL2.0 as well.
Repository:
rC Clang
https://reviews.llvm.org/D49723
___
cfe-commit
asavonic updated this revision to Diff 157222.
asavonic added a comment.
Added a diagnostic note for typedefs; moved unrelated changes to
https://reviews.llvm.org/D49723.
Repository:
rC Clang
https://reviews.llvm.org/D49725
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/invalid-kernel-para
Author: ericwf
Date: Wed Jul 25 04:16:39 2018
New Revision: 337905
URL: http://llvm.org/viewvc/llvm-project?rev=337905&view=rev
Log:
Fix diagnostic test to tolerate Clang diagnosing it as well.
Tuple has tests that ensure we diagnose non-lifetime extended
reference bindings inside tuples construc
Author: ericwf
Date: Wed Jul 25 04:19:13 2018
New Revision: 337906
URL: http://llvm.org/viewvc/llvm-project?rev=337906&view=rev
Log:
Fix dangling reference in test
Modified:
libcxxabi/trunk/test/cxa_bad_cast.pass.cpp
Modified: libcxxabi/trunk/test/cxa_bad_cast.pass.cpp
URL:
http://llvm.org/
asavonic marked 5 inline comments as done.
asavonic added a comment.
In https://reviews.llvm.org/D49725#1173321, @yaxunl wrote:
> This patch also adds check for array of structs. Can you include this in
> title or split to a separate patch?
I'm sorry, this change with arrays should actually go
Nice!
This found one bug in the libc++abi tests (r337906), and started diagnosing
the
dangling tuple reference case that libc++ worked hard to diagnose manually
(r337905).
/Eric
On Mon, Jul 23, 2018 at 6:55 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
>
ioeric updated this revision to Diff 157225.
ioeric added a comment.
s/better/nicely/
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49780
Files:
clangd/Quality.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.cpp
==
Author: ioeric
Date: Wed Jul 25 04:26:35 2018
New Revision: 337907
URL: http://llvm.org/viewvc/llvm-project?rev=337907&view=rev
Log:
[clangd] Use a sigmoid style function for #usages boost in symbol quality.
Summary:
This has a shape to similar logarithm function but grows much slower for
large #
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE337907: [clangd] Use a sigmoid style function for #usages
boost in symbol quality. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49780?vs=157225&id=157226#toc
I thought about adding -fblocks when that thread happened, but since
there's no runtime for them that just works exposing it doesn't seem very
helpful. Maybe we should instead change the warning text to not suggest
-fblocks when building on a non-mac target?
On Mon, Jul 23, 2018 at 5:29 PM Reid Kl
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: arphaman, jkorous, MaskRay.
`global-symbol-builder` help message mentions `-executor=` option, but
doesn't give any example of what the value cou
aaron.ballman added a comment.
The docs do not look correct to me. For instance, I don't see any changes to
the `hasDeclaration()` documentation for the newly supported type. There also
appear to be a bunch of unrelated changes in the generated HTML.
Comment at: clang/docs/Li
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang-tools-extra/clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:153
- const char* Overview =
- "This is an **experimental** tool to genera
devnexen created this revision.
devnexen added reviewers: morehouse, krytarowski.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D49788
Files:
docs/AddressSanitizer.rst
docs/MemorySanitizer.rst
devnexen added a comment.
This is the first time I m involved into a release so I do not know if it s too
early to update those docs but with the freeze incoming, I thought it was worth
before it get forgotten.
Repository:
rC Clang
https://reviews.llvm.org/D49788
bricci created this revision.
bricci added a project: clang.
Herald added a subscriber: cfe-commits.
Factored out from https://reviews.llvm.org/D49729
following @erichkeane comments.
- Add missing classes in the list of classes deriving directly from DeclContext.
- Move the friend declarations to
bricci updated this revision to Diff 157231.
bricci marked 10 inline comments as done.
bricci added a comment.
address @erichkeane comments:
- ran clang-format on changed parts
- made the setters setNumPositiveBits, setNumPositiveBits, setScoped,
setScopedUsingClassTag and setFixed in EnumDecl p
krytarowski added a comment.
Please include NetBSD in UBSan. Also please drop the list of supported
architectures or rephrase it. It works on e.g. NetBSD/vax.
Repository:
rC Clang
https://reviews.llvm.org/D49788
___
cfe-commits mailing list
cfe-
krytarowski added a comment.
Please update the documentation of ThreadSanitizer.rst and include at least
NetBSD/amd64.
Repository:
rC Clang
https://reviews.llvm.org/D49788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
devnexen added a comment.
Ah I forgot NetBSD sorry yes you re right.
Repository:
rC Clang
https://reviews.llvm.org/D49788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krytarowski added a comment.
In SafeStack.rst +NetBSD.
Repository:
rC Clang
https://reviews.llvm.org/D49788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gerazo created this revision.
gerazo added reviewers: a.sidorin, r.stahl.
Herald added a subscriber: cfe-commits.
The previous code which avoided infinite recursion (because of reparsing
declarations in function parameter lists) contained SourceRange dependent code
which had some problems when p
devnexen updated this revision to Diff 157237.
https://reviews.llvm.org/D49788
Files:
docs/AddressSanitizer.rst
docs/MemorySanitizer.rst
docs/SafeStack.rst
docs/ThreadSanitizer.rst
docs/UndefinedBehaviorSanitizer.rst
Index: docs/UndefinedBehaviorSanitizer.rst
=
Author: mramalho
Date: Wed Jul 25 05:49:11 2018
New Revision: 337915
URL: http://llvm.org/viewvc/llvm-project?rev=337915&view=rev
Log:
[analyzer] Moved static Context to class member
Summary:
Although it is a big patch, the changes are simple:
1. There is one `Z3_Context` now, member of the `SMTC
Author: mramalho
Date: Wed Jul 25 05:49:19 2018
New Revision: 337917
URL: http://llvm.org/viewvc/llvm-project?rev=337917&view=rev
Log:
[analyzer] Create generic SMT Expr class
Summary:
New base class for all future SMT Exprs.
No major changes except moving `areEquivalent` and `getFloatSemantics`
Author: mramalho
Date: Wed Jul 25 05:49:15 2018
New Revision: 337916
URL: http://llvm.org/viewvc/llvm-project?rev=337916&view=rev
Log:
[analyzer] Create generic SMT Sort Class
Summary:
New base class for all future SMT sorts.
The only change is that the class implements methods `isBooleanSort()`
Author: mramalho
Date: Wed Jul 25 05:49:23 2018
New Revision: 337918
URL: http://llvm.org/viewvc/llvm-project?rev=337918&view=rev
Log:
[analyzer] Implemented SMT generic API
Summary:
Created new SMT generic API.
Small changes to `Z3ConstraintManager` because of the new generic objects
(`SMTSort
Author: mramalho
Date: Wed Jul 25 05:49:07 2018
New Revision: 337914
URL: http://llvm.org/viewvc/llvm-project?rev=337914&view=rev
Log:
[analyzer] Create generic SMT Context class
Summary:
This patch creates `SMTContext` which will wrap a specific SMT context, through
`SMTSolverContext`.
The tem
Author: mramalho
Date: Wed Jul 25 05:49:29 2018
New Revision: 337919
URL: http://llvm.org/viewvc/llvm-project?rev=337919&view=rev
Log:
[analyzer] Moved non solver specific code from Z3ConstraintManager to
SMTConstraintManager
Summary:
This patch moves a lot of code from `Z3ConstraintManager` to
Author: mramalho
Date: Wed Jul 25 05:49:32 2018
New Revision: 337920
URL: http://llvm.org/viewvc/llvm-project?rev=337920&view=rev
Log:
[analyzer] Try to minimize the number of equivalent bug reports evaluated by
the refutation manager
Summary:
This patch changes how the SMT bug refutation runs i
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337915: [analyzer] Moved static Context to class member
(authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D49236
Files:
lib
Author: mramalho
Date: Wed Jul 25 05:49:37 2018
New Revision: 337921
URL: http://llvm.org/viewvc/llvm-project?rev=337921&view=rev
Log:
[analyzer] Moved code from SMTConstraintManager to SMTSolver
Summary:
This is the second part of D49668, and moves all the code that's not specific
to a Constrai
Author: mramalho
Date: Wed Jul 25 05:49:43 2018
New Revision: 337922
URL: http://llvm.org/viewvc/llvm-project?rev=337922&view=rev
Log:
[analyzer] Removed API used by the Refutation Manager from SMTConstraintManager
and replace by proper calls to SMTSolver
Summary:
Third patch in the refactoring
Author: mramalho
Date: Wed Jul 25 05:49:47 2018
New Revision: 337923
URL: http://llvm.org/viewvc/llvm-project?rev=337923&view=rev
Log:
[analyzer] Use the macro REGISTER_TRAIT_WITH_PROGRAMSTATE in the Z3 backend
Summary:
The macro was manually expanded in the Z3 backend and this patch adds it back
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337919: [analyzer] Moved non solver specific code from
Z3ConstraintManager to… (authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337922: [analyzer] Removed API used by the Refutation
Manager from SMTConstraintManager… (authored by mramalho, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rC337923: [analyzer] Use the macro
REGISTER_TRAIT_WITH_PROGRAMSTATE in the Z3 backend (authored by mramalho,
committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.
ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.
Comment at: clangd/ClangdLSPServer.cpp:430
CDB.clear();
-
-reparseOpenedFiles();
+compileCommandsChangePost(CCChangeData);
}
ilya-biryukov wrote:
> simark wrote:
> >
erichkeane added a comment.
This looks acceptable to me. I'd like to get @rsmith or @rnk to approve the
approach though.
Repository:
rC Clang
https://reviews.llvm.org/D49729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
yvvan created this revision.
yvvan added reviewers: ilya-biryukov, bkramer, akyrtzi, malaperle.
Updated clone for https://reviews.llvm.org/D48116 by Nikolai, now also adds the
clang driver flag and the test for it.
If clang has plugins they are also affected by this filtering.
Depending on the i
bricci added a comment.
It might be better to wait just after the upcoming release branch in any case
since even though it is all NFC this causes a bit of churn.
Repository:
rC Clang
https://reviews.llvm.org/D49729
___
cfe-commits mailing list
cf
javed.absar added a comment.
Maybe you can provide some more context to this patch (why you need this, or
point to some document), if possible.
Comment at: include/clang/Frontend/CodeGenOptions.h:111
+ enum SignReturnAddressScope { None, Partial, All };
+
P
ldionne added a comment.
In https://reviews.llvm.org/D49774#1174588, @EricWF wrote:
> In https://reviews.llvm.org/D49774#1174565, @mclow.lists wrote:
>
> > I haven't reviewed this closely, but you might want to look at
> > http://wg21.link/P0355, where we added a `file_clock` and `file_time` typ
jkorous planned changes to this revision.
jkorous added a comment.
Hi Sam, we are still discussing internally how to fit clangd and XPC together.
Please bear with us and ignore our patches until we decide.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48559
Author: ldionne
Date: Wed Jul 25 06:40:49 2018
New Revision: 337925
URL: http://llvm.org/viewvc/llvm-project?rev=337925&view=rev
Log:
[NFC] Fix grammatical mistakes in libc++ FileTimeType design docs
Modified:
libcxx/trunk/docs/DesignDocs/FileTimeType.rst
Modified: libcxx/trunk/docs/DesignDo
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
At equality check of fields without name the index of fields is compared.
At determining the index of a field all fields of the parent context
should be loaded from external source t
krytarowski accepted this revision.
krytarowski added a comment.
This revision is now accepted and ready to land.
Please improve the commit description and reflect with reality.
https://reviews.llvm.org/D49788
___
cfe-commits mailing list
cfe-commit
Author: devnexen
Date: Wed Jul 25 06:55:06 2018
New Revision: 337926
URL: http://llvm.org/viewvc/llvm-project?rev=337926&view=rev
Log:
[Docs] Update supported oses for safestack, ubsan, asan, tsan and msan
Adding oses others than Linux.
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/t
devnexen closed this revision.
devnexen added a comment.
Exited too early fro the editor ,.. did not write all the lines but commited
with https://reviews.llvm.org/rC337926
https://reviews.llvm.org/D49788
___
cfe-commits mailing list
cfe-commits@li
krasimir created this revision.
Herald added subscribers: cfe-commits, acoomans.
This patch makes clang-format indent the subsequent lines created by breaking a
long javadoc annotated line.
Repository:
rC Clang
https://reviews.llvm.org/D49797
Files:
lib/Format/BreakableToken.cpp
lib/Form
ioeric added a comment.
Implementation is in a good shape. I only have nits ;)
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:18
+namespace clangd {
+namespace dex {
+
Please put all local classes and helpers in an anonymous namespace.
==
Author: devnexen
Date: Wed Jul 25 07:27:14 2018
New Revision: 337927
URL: http://llvm.org/viewvc/llvm-project?rev=337927&view=rev
Log:
Fix tsan doc
Modified:
cfe/trunk/docs/ThreadSanitizer.rst
Modified: cfe/trunk/docs/ThreadSanitizer.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/do
mclow.lists added a comment.
In https://reviews.llvm.org/D49774#1175062, @ldionne wrote:
> In https://reviews.llvm.org/D49774#1174588, @EricWF wrote:
>
> > In https://reviews.llvm.org/D49774#1174565, @mclow.lists wrote:
> >
> > > I haven't reviewed this closely, but you might want to look at
> >
kbobyrev updated this revision to Diff 157263.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Addressed two comments, added an example of running the tool over a number of
source files without providing `compile_commands.json`; added a note about
collecting files from heade
Author: abataev
Date: Wed Jul 25 07:40:26 2018
New Revision: 337928
URL: http://llvm.org/viewvc/llvm-project?rev=337928&view=rev
Log:
[OPENMP] Fix PR38256: Fix locations of the artificial conditional op.
Fixed the source locations of the conditional op so that they don'r
crash coverage pass.
Add
ioeric added inline comments.
Comment at: clangd/TUScheduler.cpp:357
+
+bool CanReuseAST = InputsAreTheSame && OldPreamble == NewPreamble;
{
nit: `(OldPreamble == NewPreamble)`
Do you intend to compare the shared pointer instead of the values?
===
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
Repository:
rC Clang
https://reviews.llvm.org/D49798
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
ilya-biryukov updated this revision to Diff 157269.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Use log instead of vlog
- Add parens around &&
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49783
Files:
clangd/TUScheduler.cpp
test/clangd
LukeCheeseman updated this revision to Diff 157266.
LukeCheeseman edited the summary of this revision.
https://reviews.llvm.org/D49793
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/TargetInfo.cpp
lib/
ilya-biryukov added inline comments.
Comment at: clangd/TUScheduler.cpp:357
+
+bool CanReuseAST = InputsAreTheSame && OldPreamble == NewPreamble;
{
ioeric wrote:
> nit: `(OldPreamble == NewPreamble)`
>
> Do you intend to compare the shared pointer inste
IdrissRio created this revision.
IdrissRio added reviewers: aaron.ballman, hokein, alexfh.
Herald added a subscriber: cfe-commits.
Hello, i would like to suggest a fix for one of the checks in clang-tidy. The
bug was reported in https://bugs.llvm.org/show_bug.cgi?id=28406 where you can
find more
rnkovacs updated this revision to Diff 157278.
rnkovacs marked 2 inline comments as done.
rnkovacs added a comment.
Fix note for function pointers & handle argument counting in member operator
calls.
I also refactored the code a little, because after moving things from
`checkPreCall` to `checkPo
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:207-208
+
+for (unsigned I = 0, E = FD->getNumParams(); I != E; ++I) {
+ QualType ParamTy = FD->getParamDecl(I)->getType();
+ if (!ParamTy->isReferenceType() ||
-
mclow.lists added a comment.
Herald added subscribers: bixia, jlebar.
In general, this looks good to me.
I suggested a lot of test improvements, but not very much to the code.
Needs the same kind of namespace changes in the tests as in
https://reviews.llvm.org/D41376, but that's a minor thing.
xazax.hun added a comment.
Small comments inline.
Comment at: lib/StaticAnalyzer/Checkers/InnerPointerChecker.cpp:181
- auto *TypeDecl = ObjRegion->getValueType()->getAsCXXRecordDecl();
- if (TypeDecl->getName() != "basic_string")
-return;
+for (unsigned I = 0, E =
mclow.lists added a comment.
Herald added subscribers: bixia, jlebar.
A few nits, a bit of things moving underneath you, but this looks good.
Need to add more stuff to the tests ;-)
Comment at: libcxx/include/experimental/simd:1421
template
-_Tp hmin(const simd<_Tp, _Abi>&);
ldionne added a comment.
In https://reviews.llvm.org/D49774#1175131, @mclow.lists wrote:
> In https://reviews.llvm.org/D49774#1175062, @ldionne wrote:
>
> > In https://reviews.llvm.org/D49774#1174588, @EricWF wrote:
> >
> > > In https://reviews.llvm.org/D49774#1174565, @mclow.lists wrote:
> > >
>
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Comment at: clangd/TUScheduler.cpp:360
std::lock_guard Lock(Mutex);
+ OldPreamble.reset();
if (NewPreamble)
ilya-biryukov wrote:
> ioer
simark created this revision.
simark added reviewers: malaperle, ilya-biryukov, bkramer.
This is a new version of https://reviews.llvm.org/D48903, which has been
reverted. @ioeric fixed
the issues caused by this patch downstream, so he told me it was good to
go again. I also fixed the test fail
simark added a comment.
I uploaded a new version of this patch here:
https://reviews.llvm.org/D49804
Repository:
rC Clang
https://reviews.llvm.org/D48903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
It would make it easier for your reviewers to look at the new changes if
you just reopen this patch and update the diff :)
On Wed, Jul 25, 2018 at 5:49 PM Simon Marchi via Phabricator <
revi...@reviews.llvm.org> wrote:
> simark added a comment.
>
> I uploaded a new version of this patch here:
> h
1 - 100 of 247 matches
Mail list logo
