sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Index/IndexDataConsumer.h:48
/// \returns true to continue indexing, or false to abort.
- virtual bool handleMacroOccurence(const Iden
Author: jolesiak
Date: Mon Jul 9 00:08:45 2018
New Revision: 336521
URL: http://llvm.org/viewvc/llvm-project?rev=336521&view=rev
Log:
[clang-format/ObjC] Put ObjC method arguments into one line when they fit
Reapply D47195:
Currently BreakBeforeParameter is set to true everytime message receiver
sammccall added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:309
+ llvm::SmallString<128> USR;
+ if (index::generateUSRForDecl(ND, USR))
why this change? I think this makes us run generateUSR much more often (once
per non-unique reference in
jtbandes added a comment.
Friendly ping!
Repository:
rC Clang
https://reviews.llvm.org/D48266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michaelwu created this revision.
This patch adds support to the clang-c API for identifying ObjCObjects in
CXTypes, enumerating type args and protocols on ObjCObjectTypes, and retrieving
the base type of ObjCObjectTypes. Currently only ObjCInterfaceTypes are
exposed, which do not have type args
michaelwu updated this revision to Diff 154540.
michaelwu added a comment.
Replaced tabs with spaces.
https://reviews.llvm.org/D49063
Files:
include/clang-c/Index.h
test/Index/objc-typeargs-protocols.m
test/Index/print-type.m
tools/c-index-test/c-index-test.c
tools/libclang/CXType.cpp
ilya-biryukov added a comment.
In https://reviews.llvm.org/D48903#1154846, @simark wrote:
> With the `InMemoryFileSystem`, this now returns a non-real path. The result
> is that we fill `RealPathName` with that non-real path. I see two options
> here:
>
> 1. Either the FileManager is wrong to
ilya-biryukov added inline comments.
Comment at: lib/Basic/VirtualFileSystem.cpp:488
+ }
+ StringRef getName() const { return Stat.getName(); }
InMemoryNodeKind getKind() const { return Kind; }
Given that this method is inconsistent with `getStatus()` and se
ioeric updated this revision to Diff 154543.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- addressed review comments.
Repository:
rC Clang
https://reviews.llvm.org/D48961
Files:
include/clang/Index/IndexSymbol.h
include/clang/Index/IndexingAction.h
lib/Index/IndexS
Author: r.stahl
Date: Mon Jul 9 01:40:17 2018
New Revision: 336523
URL: http://llvm.org/viewvc/llvm-project?rev=336523&view=rev
Log:
[ASTImporter] import FunctionDecl end locations
Summary: On constructors that do not take the end source location, it was not
imported. Fixes test from D47698 / r
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336523: [ASTImporter] import FunctionDecl end locations
(authored by r.stahl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48941?vs=154215&id=154549#toc
Repository:
rC Clang
ht
michaelwu created this revision.
This patch adds support to the libclang API for identifying ObjCTypeParams in
CXTypes.
This patch depends on https://reviews.llvm.org/D49063 since both patches add
new values to CXTypeKind.
Repository:
rC Clang
https://reviews.llvm.org/D49066
Files:
incl
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336524: [Index] Add indexing support for MACROs. (authored
by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48961?vs=154543&id=154550#toc
Repository:
rC Clang
https://re
Author: ioeric
Date: Mon Jul 9 01:44:05 2018
New Revision: 336524
URL: http://llvm.org/viewvc/llvm-project?rev=336524&view=rev
Log:
[Index] Add indexing support for MACROs.
Reviewers: akyrtzi, arphaman, sammccall
Reviewed By: sammccall
Subscribers: malaperle, sammccall, cfe-commits
Differenti
ilya-biryukov added a comment.
In https://reviews.llvm.org/D48946#1152764, @sammccall wrote:
> This seems like it might be a nontrivial performance hit (it's going to
> result in `stat`ing all these files, right?).
> Agreed it's important for correctness, it's possible someone wants the
> perf
ilya-biryukov updated this revision to Diff 154551.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
Herald added a subscriber: omtcyfz.
- Fix a comment
Repository:
rC Clang
https://reviews.llvm.org/D48946
Files:
lib/Frontend/PrecompiledPreamble.cpp
Index: l
arichardson added a comment.
This broke the build of FreeBSD for me due to the declaration of
__builtin_return_address(unsigned int) in
https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Base.h#L1281:
In file included from
/exports/users/alr48/sources/freebsd-x86/sys/contrib/edk2/I
ilya-biryukov updated this revision to Diff 154552.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Remove Name matcher, use Field(&...::Name) instead
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48947
Files:
unittests/clangd/ClangdTests.cpp
Author: aheejin
Date: Mon Jul 9 01:54:42 2018
New Revision: 336526
URL: http://llvm.org/viewvc/llvm-project?rev=336526&view=rev
Log:
[Index] Add clangLex to LINK_LIBS
Without this, builds with `-DSHARED_LIB=ON` fail.
Modified:
cfe/trunk/lib/Index/CMakeLists.txt
Modified: cfe/trunk/lib/Inde
Author: r.stahl
Date: Mon Jul 9 02:02:53 2018
New Revision: 336527
URL: http://llvm.org/viewvc/llvm-project?rev=336527&view=rev
Log:
[ASTImporter] fix test failure corrected by fixed func end locs
fix to rC336523 / D48941
Modified:
cfe/trunk/test/Import/attr/test.cpp
Modified: cfe/trunk/t
Author: ibiryukov
Date: Mon Jul 9 02:07:01 2018
New Revision: 336528
URL: http://llvm.org/viewvc/llvm-project?rev=336528&view=rev
Log:
[Preamble] Check system dependencies in preamble too
Summary:
PrecompiledPreamble hasn't checked if the system dependencies changed
before. This resulted in inva
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336528: [Preamble] Check system dependencies in preamble too
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48946
Files:
charlie added a comment.
Would you please merge this patch into master & include it in daily build as
soon as possible? My project really need this fix. Thanks a lot.
https://reviews.llvm.org/D27651
___
cfe-commits mailing list
cfe-commits@lists.
Author: ibiryukov
Date: Mon Jul 9 02:10:22 2018
New Revision: 336530
URL: http://llvm.org/viewvc/llvm-project?rev=336530&view=rev
Log:
[clangd] Added a test for preambles and -isystem
Summary:
Checks that preambles are properly invalidated when headers from
-isystem paths change.
Reviewers: sam
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336530: [clangd] Added a test for preambles and -isystem
(authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48947?vs=1545
Author: ioeric
Date: Mon Jul 9 02:17:25 2018
New Revision: 336532
URL: http://llvm.org/viewvc/llvm-project?rev=336532&view=rev
Log:
Try to fix build bot after r336524
Modified:
cfe/trunk/test/Index/Core/index-macros.c
Modified: cfe/trunk/test/Index/Core/index-macros.c
URL:
http://llvm.org/
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp:32-40
+namespace clang {
+namespace ento {
+template<> struct ProgramStateTrait
+ : public ProgramStatePartialTrait {
+ static void *GDMIndex() {
+static int Index = 0;
rnkovacs updated this revision to Diff 154556.
rnkovacs marked 5 inline comments as done.
rnkovacs added a comment.
Thanks very much for your review!
https://reviews.llvm.org/D49057
Files:
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
test/Analysis/dangling-internal-buffer.c
ioeric updated this revision to Diff 154559.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49028
Files:
clangd/index/SymbolCollector.cpp
clangd/index/SymbolCollector.h
unittests
ioeric added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:360
+
+ llvm::SmallString<128> USR;
+ if (index::generateUSRForMacro(Name.getName(), MI.getDefinitionLoc(), SM,
sammccall wrote:
> as above, can we avoid generating the USR for every ref
arsenm updated this revision to Diff 154561.
arsenm added a comment.
Add sema test for numbered address spaces
https://reviews.llvm.org/D47154
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/BuiltinsAMDGPU.def
include/clang/Basic/TargetInfo.h
lib/AST/ASTContext.cpp
lib/Basic
arsenm added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:3500
+if (auto *PtrTy = dyn_cast(PTy)) {
+ if (PtrTy->getAddressSpace() !=
+ ArgValue->getType()->getPointerAddressSpace()) {
Anastasia wrote:
> arsenm wrote:
> > An
ilya-biryukov updated this revision to Diff 154562.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Add a test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48940
Files:
clangd/TUScheduler.cpp
clangd/TUScheduler.h
unittests/clangd/TUSched
ilya-biryukov added a comment.
In https://reviews.llvm.org/D48940#1152750, @sammccall wrote:
> Possible test: add a file with complicated preamble (billion laughs?) and
> immediately schedule 5 preamble actions. They should all get a non-null
> preamble and the pointers should all be the same.
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336538: [clangd] Wait for first preamble before code
completion (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48940?vs=154562&id=154563#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336538: [clangd] Wait for first preamble before code
completion (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48940
Fil
Author: ibiryukov
Date: Mon Jul 9 03:45:33 2018
New Revision: 336538
URL: http://llvm.org/viewvc/llvm-project?rev=336538&view=rev
Log:
[clangd] Wait for first preamble before code completion
Summary:
To avoid doing extra work of processing headers in the preamble
mutilple times in parallel.
Rev
arichardson created this revision.
arichardson added reviewers: EricWF, rsmith.
Herald added subscribers: cfe-commits, ldionne, christof.
This is not guaranteed to work since the characters after '__has_include('
have special lexing rules that can't possibly be applied when
__has_include is genera
opaparo created this revision.
opaparo added a reviewer: delena.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D49068
Files:
include/clang/Basic/Builtins.def
Index: include/clang/Basic/Builtins.def
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM. Checking the full operands wouldn't hurt though.
Repository:
rC Clang
https://reviews.llvm.org/D46871
___
cfe-commits mailing list
cfe-c
ilya-biryukov updated this revision to Diff 154569.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Fix a comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48943
Files:
clangd/ClangdUnit.cpp
clangd/CodeCompletionStrings.cpp
Index: cla
Author: ibiryukov
Date: Mon Jul 9 04:33:31 2018
New Revision: 336540
URL: http://llvm.org/viewvc/llvm-project?rev=336540&view=rev
Log:
[clangd] Do not write comments into Preamble PCH
Summary:
To avoid wasting time deserializing them on code completion and
further reparses.
We do not use the co
Author: ibiryukov
Date: Mon Jul 9 04:33:23 2018
New Revision: 336539
URL: http://llvm.org/viewvc/llvm-project?rev=336539&view=rev
Log:
[PCH] Add an option to not write comments into PCH
Summary:
Will be used in clangd, see the follow-up change.
Clangd does not use comments read from PCH to avoid
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336539: [PCH] Add an option to not write comments into PCH
(authored by ibiryukov, committed by ).
Herald added a subscriber: omtcyfz.
Changed prior to commit:
https://reviews.llvm.org/D48942?vs=154115&
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336540: [clangd] Do not write comments into Preamble PCH
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48943?vs=154569&id=154572#toc
Repository:
rCTE Cl
Lekensteyn added a comment.
Hi, thank you for the patch. First a disclaimer, I am not familiar with this
RPC API at all.
This would be the first user of pkg-config here. I am not sure if this would be
the best fix. Usually you cannot (easily) recompile libc and override it, but
for external li
kristof.beyls created this revision.
Herald added subscribers: cfe-commits, aheejin, dschuff.
This is part of implementing a technique to mitigate against Spectre v1,
similar in spirit to what has been proposed by Chandler for X86_64 at
http://lists.llvm.org/pipermail/llvm-dev/2018-March/122085.ht
baloghadamsoftware created this revision.
baloghadamsoftware added reviewers: NoQ, dcoughlin.
Herald added subscribers: mikhail.ramalho, a.sidorin, szepet.
Herald added a reviewer: george.karpenkov.
Currently, the default (range-based) constrain manager supports symbolic
expressions of the format
baloghadamsoftware added a comment.
All existing tests pass. I could not find the appropriate test file so I
created a new one, but this is probably not the correct way.
https://reviews.llvm.org/D49074
___
cfe-commits mailing list
cfe-commits@lists
baloghadamsoftware added a comment.
This seems to solve https://bugs.llvm.org/show_bug.cgi?id=32911.
https://reviews.llvm.org/D49074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martong updated this revision to Diff 154582.
martong marked 6 inline comments as done.
martong added a comment.
Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D47632
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/ASTStructuralEquivalence.h
include/clan
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:161
+ ToD->IdentifierNamespace = FromD->IdentifierNamespace;
+ if (FromD->hasAttrs())
+for (const Attr *FromAttr : FromD->getAttrs())
a_sidorin wrote:
> Should we move the below
mgorny added a comment.
In https://reviews.llvm.org/D47817#1155637, @Lekensteyn wrote:
> Hi, thank you for the patch. First a disclaimer, I am not familiar with this
> RPC API at all.
Me neither. I'm only familiar with this particular issue because it's what
we're hitting a lot recently.
> T
kosarev created this revision.
kosarev added reviewers: SjoerdMeijer, jgreenhalgh, rengolin.
kosarev added a project: clang.
Herald added a reviewer: javed.absar.
This patch fixes definitions of vld and vst NEON intrinsics so that we only
define them if half-precision arithmetic is supported on t
kosarev added a comment.
Ping.
https://reviews.llvm.org/D48829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane added a comment.
I'm curious why that file is declaring the builtin like that? The declaration
doesn't seem like it is ever useful, builtins are available without any
includes/etc as far back as I could go on all 3 compilers that I validated
against.
Additionally, I believe that th
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, omtcyfz, jkorous, MaskRay, ioeric,
mgorny.
The library has graduated from clangd to llvm/Support.
This is a mechanical change to move to the new API and remove the old one.
Main API
Lekensteyn added a comment.
In https://reviews.llvm.org/D47817#1155717, @mgorny wrote:
> > This would be the first user of pkg-config here. I am not sure if this
> > would be the best fix. Usually you cannot (easily) recompile libc and
> > override it, but for external libs such as libtirpc thi
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
lebedev.ri updated this revision to Diff 154591.
lebedev.ri retitled this revision from "[private][clang] Implicit Cast
Sanitizer - integer truncation - clang part" to "[clang][ubsan] Implicit Cast
Sanitizer - integer truncation - clang part".
lebedev.ri edited the summary of this revision.
leb
Author: sammccall
Date: Mon Jul 9 07:25:59 2018
New Revision: 336549
URL: http://llvm.org/viewvc/llvm-project?rev=336549&view=rev
Log:
[clangd] Remove JSON library in favor of llvm/Support/JSON
Summary:
The library has graduated from clangd to llvm/Support.
This is a mechanical change to move to
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336549: [clangd] Remove JSON library in favor of
llvm/Support/JSON (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49077?vs=154597&id=154600#toc
Repository:
Author: malaperle
Date: Mon Jul 9 07:34:07 2018
New Revision: 336550
URL: http://llvm.org/viewvc/llvm-project?rev=336550&view=rev
Log:
[clangd] Mark "Document Symbols" as implemented in the docs
Summary: Signed-off-by: Marc-Andre Laperle
Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, cf
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336550: [clangd] Mark "Document Symbols" as
implemented in the docs (authored by malaperle, committed by ).
Herald added a
simark marked 6 inline comments as done.
simark added inline comments.
Comment at: lib/Basic/VirtualFileSystem.cpp:488
+ }
+ StringRef getName() const { return Stat.getName(); }
InMemoryNodeKind getKind() const { return Kind; }
ilya-biryukov wrote:
> Given t
michaelwu created this revision.
This patch adds support to the libclang API for identifying AttributedTypes in
CXTypes and reading the modified type that the type points to. Currently
AttributedTypes are skipped. This patch continues to skip AttributedTypes by
default, but adds a parsing optio
erichkeane marked 4 inline comments as done.
erichkeane added a comment.
In https://reviews.llvm.org/D47474#1154858, @lebedev.ri wrote:
> Some drive-by nits.
> General observation: this is kinda large.
> I would //personally// split split off the codegen part into a second patch.
Thanks for t
erichkeane updated this revision to Diff 154610.
erichkeane marked an inline comment as done.
erichkeane added a comment.
@lebedev.ri 's comments, plus a rebase.
https://reviews.llvm.org/D47474
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
i
michaelwu created this revision.
This patch adds a clang-c API for querying the nullability of an AttributedType.
The test here also tests https://reviews.llvm.org/D49081
Repository:
rC Clang
https://reviews.llvm.org/D49082
Files:
include/clang-c/Index.h
test/Index/nullability.c
tools
yaxunl created this revision.
yaxunl added reviewers: tra, rjmccall.
HIP generates one fat binary for all devices after linking. However, for each
compilation
unit a ctor function is emitted which register the same fat binary. Measures
need to be
taken to make sure the fat binary is only registe
mgorny added a comment.
In https://reviews.llvm.org/D47817#1155788, @Lekensteyn wrote:
> In https://reviews.llvm.org/D47817#1155717, @mgorny wrote:
>
> > > This would be the first user of pkg-config here. I am not sure if this
> > > would be the best fix. Usually you cannot (easily) recompile li
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: tools/libclang/CIndex.cpp:3892-3922
CXEvalResult clang_Cursor_Evaluate(CXCursor C) {
- const Decl *D = getCursorDecl(C);
- if (D) {
-const Ex
Author: ioeric
Date: Mon Jul 9 08:31:07 2018
New Revision: 336553
URL: http://llvm.org/viewvc/llvm-project?rev=336553&view=rev
Log:
[clangd] Support indexing MACROs.
Summary: This is not enabled in the global-symbol-builder or dynamic index yet.
Reviewers: sammccall
Reviewed By: sammccall
Sub
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336553: [clangd] Support indexing MACROs. (authored by
ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49028?vs=154559&id=154615#toc
Repository:
rCTE Clang Tools Extra
h
erik.pilkington created this revision.
erik.pilkington added reviewers: rjmccall, rsmith.
Herald added a subscriber: dexonsmith.
Previously, clang marked a decl as invalid without emitting a diagnostic. This
lead to an assert in CodeGen for the attached test case.
rdar://41806724
Thanks for tak
russellmcc added a comment.
Bump!
Thanks again for your time.
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
simark marked an inline comment as done.
simark added a comment.
In https://reviews.llvm.org/D48903#1155403, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D48903#1154846, @simark wrote:
>
> > With the `InMemoryFileSystem`, this now returns a non-real path. The
> > result is that we fill `
simark updated this revision to Diff 154631.
simark added a comment.
- Use FileSystem::getRealPath in FileManager::getFile
Repository:
rC Clang
https://reviews.llvm.org/D48903
Files:
lib/Basic/FileManager.cpp
lib/Basic/VirtualFileSystem.cpp
unittests/Basic/VirtualFileSystemTest.cpp
u
tks2103 added a comment.
ping @modocache @GorNishanov
Repository:
rC Clang
https://reviews.llvm.org/D48981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
In https://reviews.llvm.org/D48989#1153957, @starsid wrote:
> In https://reviews.llvm.org/D48989#1153773, @compnerd wrote:
>
> > However, please add a test to ensure that the paths are mapped when
> > invoking the assembler
>
>
> I added the tests to check the mapping
george.karpenkov added a comment.
@baloghadamsoftware @dkrupp @xazax.hun Interesting. What do you think about
instead using Z3 cross-check functionality recently added, to solve this and
all other similar problems instead?
https://reviews.llvm.org/D49074
Author: abataev
Date: Mon Jul 9 10:43:58 2018
New Revision: 336567
URL: http://llvm.org/viewvc/llvm-project?rev=336567&view=rev
Log:
[OPENMP, NVPTX] Do not globalize local variables in parallel regions.
In generic data-sharing mode we are allowed to not globalize local
variables that escape thei
mclow.lists added a comment.
Looks good; a bunch of minor things.
Remember to target c++17.
You need to indulge your OCD when writing the tests.
Comment at: libcxx/include/__config:1329
+#if !defined(_LIBCPP_COMPILER_CLANG) && !defined(_LIBCPP_COMPILER_GCC)
+#define _LIBCPP_H
arichardson created this revision.
arichardson added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
The characters after '__has_include(' have special lexing rules that can't
possibly be applied when __has_include is generated by a macro. Instead of
wrapping __has_include in another m
mclow.lists added a comment.
A few comments; more to come after the earlier patches land.
Comment at: libcxx/include/experimental/simd:1429
+struct deduce<_Tp, _Np, __simd_abi<__kind, __old_size>...> {
+ using type = __simd_abi<__kind, _Np>;
+};
Is this delibe
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Let's discuss alternatives first.
https://reviews.llvm.org/D49074
___
cfe-commits mailing list
cfe-commits@lists.ll
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: tools/libclang/CIndex.cpp:3892-3922
CXEvalResult clang_Cursor_Evaluate(CXCursor C) {
- const Decl *D = getCursorDecl(C);
- if (D) {
-const Expr *expr = nullptr;
-if (auto *Var = dyn_
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D48685
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
simark updated this revision to Diff 154662.
simark added a comment.
- Change InMemoryNode::getName to InMemoryNode::getFileName, to reduce the risk
of mis-using it. Make the Stat field protected, make the subclasses' toString
access it directly.
Repository:
rC Clang
https://reviews.llvm.or
Author: stefanp
Date: Mon Jul 9 11:50:40 2018
New Revision: 336579
URL: http://llvm.org/viewvc/llvm-project?rev=336579&view=rev
Log:
[Power9] Add __float128 builtins for Round To Odd
Add a number of builtins for __float128 Round To Odd.
This is the Clang portion of the builtins work.
Differenti
This revision was automatically updated to reflect the committed changes.
Closed by commit rC336579: [Power9] Add __float128 builtins for Round To Odd
(authored by stefanp, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D47548
Files:
in
Author: ioeric
Date: Mon Jul 9 11:54:51 2018
New Revision: 336581
URL: http://llvm.org/viewvc/llvm-project?rev=336581&view=rev
Log:
[clangd] Make sure macro information exists before increasing usage count.
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: clang-t
starsid updated this revision to Diff 154669.
starsid marked an inline comment as done.
starsid added a comment.
Test improvements
Repository:
rC Clang
https://reviews.llvm.org/D48989
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Clang.cpp
test/Driver/debug-prefix-map.S
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336583: [Builtins][Attributes][X86] Tag all X86 builtins
with their required vector… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: ioeric
Date: Mon Jul 9 12:02:41 2018
New Revision: 336584
URL: http://llvm.org/viewvc/llvm-project?rev=336584&view=rev
Log:
[Index] Ignore noop #undef's when handling macro occurrences.
Modified:
cfe/trunk/lib/Index/IndexingAction.cpp
Modified: cfe/trunk/lib/Index/IndexingAction.cpp
khuttun abandoned this revision.
khuttun added a comment.
Abandoning this. The false positive rate would be too high for this checker.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46317
___
cfe-commits mailing list
cfe-commits@lis
vsapsai updated this revision to Diff 154678.
vsapsai added a comment.
- Allow allocator `construct` to return a value, not just have return type
`void`.
https://reviews.llvm.org/D48753
Files:
libcxx/include/memory
libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_ite
EricWF commandeered this revision.
EricWF edited reviewers, added: lebedev.ri; removed: EricWF.
EricWF added a comment.
Hijacking with permission.
Repository:
rL LLVM
https://reviews.llvm.org/D45179
___
cfe-commits mailing list
cfe-commits@lists.
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D48786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Mon Jul 9 12:41:28 2018
New Revision: 336590
URL: http://llvm.org/viewvc/llvm-project?rev=336590&view=rev
Log:
[libclang] evalute compound statement cursors before trying to evaluate
the cursor like a declaration
This change fixes a bug in libclang in which it tries to eva
1 - 100 of 169 matches
Mail list logo
