[PATCH] D45454: Add llvm_gcov_flush to be called outside a shared library

2018-06-29 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 153576. chh marked an inline comment as done. https://reviews.llvm.org/D45454 Files: lib/profile/GCDAProfiling.c test/profile/Inputs/instrprof-dlopen-dlclose-main.c Index: test/profile/Inputs/instrprof-dlopen-dlclose-main.c =

[PATCH] D45454: Add llvm_gcov_flush to be called outside a shared library

2018-06-29 Thread David Li via Phabricator via cfe-commits
davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D45454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D45454: Add llvm_gcov_flush to be called outside a shared library

2018-06-29 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCRT336019: [profile] Add llvm_gcov_flush to be called outside a shared library (authored by chh, committed by ). Herald added a subscriber: Sanitizers. Repository: rCRT Compiler Runtime https://reviews.

r336020 - Spurious commit just to help Richard, because git is weird.

2018-06-29 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Fri Jun 29 14:58:24 2018 New Revision: 336020 URL: http://llvm.org/viewvc/llvm-project?rev=336020&view=rev Log: Spurious commit just to help Richard, because git is weird. Modified: cfe/trunk/test/Modules/codegen.test Modified: cfe/trunk/test/Modules/codegen.test URL:

r336021 - PR33924: merge local declarations that have linkage of some kind within

2018-06-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jun 29 14:58:50 2018 New Revision: 336021 URL: http://llvm.org/viewvc/llvm-project?rev=336021&view=rev Log: PR33924: merge local declarations that have linkage of some kind within merged function definitions; also merge functions with deduced return types. This seems like

[PATCH] D48794: [AArch64] Implement execute-only support.

2018-06-29 Thread Ivan Lozano via Phabricator via cfe-commits
ivanlozano created this revision. ivanlozano added reviewers: srhines, eugenis, peter.smith, echristo. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, kristof.beyls. This implements execute-only support for AArch64 targets, similar to the ARM execute-only support. R

r336023 - [analyzer] [tests] Allow the tested project to specify it's own analyzer wrapper

2018-06-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jun 29 15:05:32 2018 New Revision: 336023 URL: http://llvm.org/viewvc/llvm-project?rev=336023&view=rev Log: [analyzer] [tests] Allow the tested project to specify it's own analyzer wrapper Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trun

r336022 - [analyzer] [tests] Fix 80 column violation in SATestBuild.py

2018-06-29 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Fri Jun 29 15:05:13 2018 New Revision: 336022 URL: http://llvm.org/viewvc/llvm-project?rev=336022&view=rev Log: [analyzer] [tests] Fix 80 column violation in SATestBuild.py Modified: cfe/trunk/utils/analyzer/SATestBuild.py Modified: cfe/trunk/utils/analyzer/SAT

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-29 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks right to me (other than the missing `constexpr` in C++14 onwards). Though this is subtle enough that I suspect the only way to know for sure is to try it. https://reviews.llvm.org/D4803

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-29 Thread Justin Lebar via Phabricator via cfe-commits
jlebar added a comment. > Looks right to me (other than the missing constexpr in C++14 onwards). Though > this is subtle enough that I suspect the only way to know for sure is to try > it. Thanks a lot, Richard. FTR the missing constexpr is in https://reviews.llvm.org/D48151. https://review

[PATCH] D48036: [CUDA] Make min/max shims host+device.

2018-06-29 Thread Justin Lebar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336025: [CUDA] Make min/max shims host+device. (authored by jlebar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48036?vs=150790&id=153593#

r336026 - [CUDA] Make __host__/__device__ min/max overloads constexpr in C++14.

2018-06-29 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Fri Jun 29 15:28:09 2018 New Revision: 336026 URL: http://llvm.org/viewvc/llvm-project?rev=336026&view=rev Log: [CUDA] Make __host__/__device__ min/max overloads constexpr in C++14. Summary: Tests in a separate change to the test-suite. Reviewers: rsmith, tra Subscribers: l

r336025 - [CUDA] Make min/max shims host+device.

2018-06-29 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Fri Jun 29 15:27:56 2018 New Revision: 336025 URL: http://llvm.org/viewvc/llvm-project?rev=336025&view=rev Log: [CUDA] Make min/max shims host+device. Summary: Fixes PR37753: min/max can't be called from __host__ __device__ functions in C++14 mode. Testcase in a separate tes

[PATCH] D48151: [CUDA] Make __host__/__device__ min/max overloads constexpr in C++14.

2018-06-29 Thread Justin Lebar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336026: [CUDA] Make __host__/__device__ min/max overloads constexpr in C++14. (authored by jlebar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D48395: Added PublicOnly flag

2018-06-29 Thread Annie Cherkaev via Phabricator via cfe-commits
anniecherk updated this revision to Diff 153597. anniecherk added a comment. Herald added a subscriber: eraman. - addressed Julie's comments - updated logic to consider both access specifier & linkage - added tests for each type of linkage https://reviews.llvm.org/D48395 Files: clang-tools-ex

[PATCH] D48694: [libc++abi] Limit libc++ header search to specified paths

2018-06-29 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D48694#1146232, @EricWF wrote: > LGTM, but I'm a bit confused. You seem to argue that no system places C++ > headers on the default search paths, but also that it would be a problem if > such a system did. > Why wouldn't the conclusion be tr

[PATCH] D48152: [CUDA] Add tests that, in C++14 mode, min/max are constexpr.

2018-06-29 Thread Justin Lebar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336030: [CUDA] Add tests that, in C++14 mode, min/max are constexpr. (authored by jlebar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D48152 Files: test-suite/trunk/External/CUDA/al

[PATCH] D48037: [CUDA] Add tests to ensure that std::min/max can be called from __host__ __device__ functions.

2018-06-29 Thread Justin Lebar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336029: [CUDA] Add tests to ensure that std::min/max can be called from __host__… (authored by jlebar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D48037 Files: test-suite/trunk/Ext

r336031 - Add protocol redefinition to the current scope/context

2018-06-29 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Fri Jun 29 17:49:27 2018 New Revision: 336031 URL: http://llvm.org/viewvc/llvm-project?rev=336031&view=rev Log: Add protocol redefinition to the current scope/context Not doing so causes the AST writter to assert since the decl in question never gets emitted. This is fine when

[PATCH] D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context

2018-06-29 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC336031: Add protocol redefinition to the current scope/context (authored by bruno, committed by ). Repository: rL LLVM https://reviews.llvm.org/D47297 Files: lib/Sema/SemaDeclObjC.cpp test/Modules

[PATCH] D47297: [Modules][ObjC] Add protocol redefinition to the current scope/context

2018-06-29 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336031: Add protocol redefinition to the current scope/context (authored by bruno, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D47297?vs=14

[PATCH] D48694: [libc++abi] Limit libc++ header search to specified paths

2018-06-29 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. > For whether it makes sense to search for includes in the system path, that > boils down to @ldionne's question of whether building libc++abi against a > system-installed libc++ is supported. I actually don't know the answer to > that myself ... @dexonsmith and @EricW

[PATCH] D48694: [libc++abi] Limit libc++ header search to specified paths

2018-06-29 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D48694#1148718, @EricWF wrote: > > For whether it makes sense to search for includes in the system path, that > > boils down to @ldionne's question of whether building libc++abi against a > > system-installed libc++ is supported. I actually d

[libcxxabi] r336032 - [libc++abi] Limit libc++ header search to specified paths

2018-06-29 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Fri Jun 29 18:04:50 2018 New Revision: 336032 URL: http://llvm.org/viewvc/llvm-project?rev=336032&view=rev Log: [libc++abi] Limit libc++ header search to specified paths Right now, when libc++abi is locating libc++ headers, it specifies several search locations, but it also

[PATCH] D48694: [libc++abi] Limit libc++ header search to specified paths

2018-06-29 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL336032: [libc++abi] Limit libc++ header search to specified paths (authored by smeenai, committed by ). Herald added a sub

[libcxxabi] r336034 - [libc++abi] Look for __config instead of vector

2018-06-29 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Fri Jun 29 18:25:47 2018 New Revision: 336034 URL: http://llvm.org/viewvc/llvm-project?rev=336034&view=rev Log: [libc++abi] Look for __config instead of vector vector is a generic C++ header, whereas __config is libc++-specific, so we can look for it instead to guarantee we'

r336036 - [X86] Remove masking from the avx512 rotate builtins. Use a select builtin instead.

2018-06-29 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri Jun 29 18:32:14 2018 New Revision: 336036 URL: http://llvm.org/viewvc/llvm-project?rev=336036&view=rev Log: [X86] Remove masking from the avx512 rotate builtins. Use a select builtin instead. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/lib/

[PATCH] D48027: [analyzer] Improve `CallDescription` to handle c++ method.

2018-06-29 Thread Henry Wong via Phabricator via cfe-commits
MTC added a comment. kindly ping! Repository: rC Clang https://reviews.llvm.org/D48027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2018-06-29 Thread Erik Nyquist via Phabricator via cfe-commits
enyquist added a comment. @klimek having gotten that out of the way, I do occasionally drink too much and have sudden urges to re-implement things from scratch. Close it if you need to, since I can't commit to anything, but it it happens to be still open on one of those nights, who knows, m

r336037 - Driver: Don't mix system tools with devtoolset tools on RHEL

2018-06-29 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Fri Jun 29 19:55:54 2018 New Revision: 336037 URL: http://llvm.org/viewvc/llvm-project?rev=336037&view=rev Log: Driver: Don't mix system tools with devtoolset tools on RHEL Summary: On RHEL, devtoolset provides a more up-to-date toolchain than the base install, and we want

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

2018-06-29 Thread Tom Stellard via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336037: Driver: Don't mix system tools with devtoolset tools on RHEL (authored by tstellar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D34

r336039 - Driver: Add an explicit target to testcase from r336037

2018-06-29 Thread Tom Stellard via cfe-commits
Author: tstellar Date: Fri Jun 29 20:50:10 2018 New Revision: 336039 URL: http://llvm.org/viewvc/llvm-project?rev=336039&view=rev Log: Driver: Add an explicit target to testcase from r336037 Modified: cfe/trunk/test/Driver/linux-ld.c Modified: cfe/trunk/test/Driver/linux-ld.c URL: http://ll

[PATCH] D47846: [clangd] Implementation of textDocument/documentSymbol

2018-06-29 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle updated this revision to Diff 153611. malaperle added a comment. Fix handling of externs, definition vs declaration and call more common code. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D47846 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

2018-06-29 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. I want to point out that this code (not -necessarily- this patch, but where it lives) needs to be rewritten. There is no prohibition on users specializing `allocator_traits` for their allocators, and yet libc++'s vector depends on the existence of `allocator_traits

[PATCH] D48159: [clangd] Implement hover for "auto" and "decltype"

2018-06-29 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle updated this revision to Diff 153612. malaperle added a comment. Add comment about AutoTypeLoc work-around. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48159 Files: clangd/XRefs.cpp unittests/clangd/TestTU.cpp unittests/clangd/TestTU.h unittests/clangd/XRef

r336042 - [X86] Correct the width of mask arguments in intrinsic headers and tests.

2018-06-29 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri Jun 29 23:05:17 2018 New Revision: 336042 URL: http://llvm.org/viewvc/llvm-project?rev=336042&view=rev Log: [X86] Correct the width of mask arguments in intrinsic headers and tests. All of these found by grepping through IR from the builtin tests for extra trunc and zex

<    1   2