[PATCH] D48367: [modules] Fix 37878; Autoload subdirectory modulemaps with specific LangOpts

bruno added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:285 // directory. -loadSubdirectoryModuleMaps(SearchDirs[Idx]); +if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2) + loadSubdirectoryModuleMaps(SearchDirs[Idx]);

Re: r335084 - Append new attributes to the end of an AttributeList.

I just revert if to have further discussions (r335516) Michael 2018-06-25 14:58 GMT-05:00 Eric Christopher : > > > On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits > wrote: >> >> On 23 June 2018 at 22:34, Michael Kruse via cfe-commits >> wrote: >>> >>> Hi, >>> >>> multiple comment

r335516 - Revert "Append new attributes to the end of an AttributeList."

Author: meinersbur Date: Mon Jun 25 13:06:13 2018 New Revision: 335516 URL: http://llvm.org/viewvc/llvm-project?rev=335516&view=rev Log: Revert "Append new attributes to the end of an AttributeList." This reverts commit r335084 as requested by David Jones and Eric Christopher because of differenc

[PATCH] D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android

cryptoad created this revision. cryptoad added reviewers: eugenis, pirama, srhines. I am not sure anyone has tried to compile an application with sanitizers on Android with `-static-libsan`, and a recent NDK, but it fails with: .../i686-linux-android/bin/ld.gold: error: cannot find -lpthread

[PATCH] D44143: [clang-tidy] Create properly seeded random generator check

boga95 updated this revision to Diff 152778. boga95 marked 3 inline comments as done. boga95 added a comment. Add std::srand check to C++ tests. Format patch. https://reviews.llvm.org/D44143 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/cert/ProperlyS

[PATCH] D48100: Append new attributes to the end of an AttributeList.

Meinersbur added inline comments. Comment at: test/Sema/attr-micromips.c:9 -__attribute__((micromips,mips16)) void foo5(); // expected-error {{'micromips' and 'mips16' attributes are not compatible}} \ +__attribute__((micromips,mips16)) void foo5(); // expected-error {{'mips

[PATCH] D48100: Append new attributes to the end of an AttributeList.

erichkeane added a comment. In https://reviews.llvm.org/D48100#1142842, @rsmith wrote: > This patch appears to have at least caused us to process attributes too many > times in some cases. For example: > > __attribute__((noreturn,noinline,unused)) void f(); > > > before your patch gives this w

[PATCH] D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM This has always been the case. Repository: rC Clang https://reviews.llvm.org/D48570 ___ cfe-commits mailing list cfe-commits@lists.llvm

[libcxx] r335533 - Creating release candidate final from release_601 branch

Author: tstellar Date: Mon Jun 25 14:50:10 2018 New Revision: 335533 URL: http://llvm.org/viewvc/llvm-project?rev=335533&view=rev Log: Creating release candidate final from release_601 branch Added: libcxx/tags/RELEASE_601/final/ (props changed) - copied from r335532, libcxx/branches/

[libcxxabi] r335534 - Creating release candidate final from release_601 branch

Author: tstellar Date: Mon Jun 25 14:50:14 2018 New Revision: 335534 URL: http://llvm.org/viewvc/llvm-project?rev=335534&view=rev Log: Creating release candidate final from release_601 branch Added: libcxxabi/tags/RELEASE_601/final/ - copied from r335533, libcxxabi/branches/release_60/

[libunwind] r335540 - Creating release candidate final from release_601 branch

Author: tstellar Date: Mon Jun 25 14:50:42 2018 New Revision: 335540 URL: http://llvm.org/viewvc/llvm-project?rev=335540&view=rev Log: Creating release candidate final from release_601 branch Added: libunwind/tags/RELEASE_601/final/ - copied from r335539, libunwind/branches/release_60/

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

ahatanak added a comment. The original comment said "call sized device delete even though host has preferable non-sized version", but it seems that the non-sized host version 'T::operator delete(void*)' is being called in the IR, not the sized device version of delete. Is that a bug in overload

[PATCH] D48571: improve diagnostics for missing 'template' keyword

rsmith created this revision. rsmith added a reviewer: dblaikie. Herald added a subscriber: eraman. We track when we see a name-shaped expression followed by a `<` token that we parse as a comparison. Then: - if we see a token sequence that cannot possibly be an expression but can be a template

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

ahatanak added a comment. I mean ToT clang (without my patch applied) seems to select the non-sized host version 'T::operator delete(void*)'. Repository: rC Clang https://reviews.llvm.org/D47757 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: r335022 - Revert r335019 "Update NRVO logic to support early return (Attempt 2)"

Whenever possible, do include context for why a patch is being reverted in the commit message - buildbot links, but also potentially describing/copy-pasting inline whatever the problem(s) are. This makes it easier for people tracking the state of upstream to know whether they may need to pull in th

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian marked 2 inline comments as done. yunlian added a comment. ping? https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

jlebar added a comment. In https://reviews.llvm.org/D47757#1142886, @ahatanak wrote: > I mean ToT clang (without my patch applied) seems to select the non-sized > host version 'T::operator delete(void*)'. OK, if this is just making an error out of something which previously silently didn't wo

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

ahatanak added a comment. Yes, that is the case. It doesn't change overloading resolution, it is just producing a diagnostic. Repository: rC Clang https://reviews.llvm.org/D47757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

r335542 - Warning for framework include violation from Headers to PrivateHeaders

Author: bruno Date: Mon Jun 25 15:24:17 2018 New Revision: 335542 URL: http://llvm.org/viewvc/llvm-project?rev=335542&view=rev Log: Warning for framework include violation from Headers to PrivateHeaders Framework vendors usually layout their framework headers in the following way: Foo.framework/

[PATCH] D48574: OpenBSD driver needs ld.lld in sanitiser context

devnexen created this revision. devnexen added a reviewer: dberris. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. - Base GNU ld is pretty old and does not support --dynamic-list flag. - For conveniency we can add it automatically when compile wit

r335543 - Fix tests from r335542 to use %hmaptool

Author: bruno Date: Mon Jun 25 15:25:48 2018 New Revision: 335543 URL: http://llvm.org/viewvc/llvm-project?rev=335543&view=rev Log: Fix tests from r335542 to use %hmaptool Modified: cfe/trunk/test/Modules/framework-public-includes-private.m Modified: cfe/trunk/test/Modules/framework-public-i

[PATCH] D47301: Warning for framework include violation from Headers to PrivateHeaders

bruno closed this revision. bruno added a comment. Committed r335542 https://reviews.llvm.org/D47301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47341: [Sema] Fix infinite typo correction loop.

vsapsai added a comment. Ping. https://reviews.llvm.org/D47341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added a comment. Ping. https://reviews.llvm.org/D48342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 152794. https://reviews.llvm.org/D44788 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/lto-dwo.c Index: test/Driver/lto-dwo.c === --- /dev/null +++ test/Driver/lto-dwo.c @@ -0,0 +1

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android

srhines accepted this revision. srhines added a comment. Agree. This is the first time anyone is linking against static sanitizers on Android, so this is just something that we missed updating in the past. Repository: rC Clang https://reviews.llvm.org/D48570 __

[PATCH] D48100: Append new attributes to the end of an AttributeList.

Meinersbur added a comment. In https://reviews.llvm.org/D48100#1142866, @erichkeane wrote: > I'm currently attempting to remove the AttributeList's linked-listness. Thank you. This should also resolve the non-optimal asymptotic execution time to append new attributes at the end of the list.

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

This revision was automatically updated to reflect the committed changes. Closed by commit rL335546: Add an option to support debug fission on implicit ThinLTO. (authored by yunlian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4478

Re: [PATCH] D45454: Make __gcov_flush visible outside a shared library

I don't have an objection having another interface which is just a simple wrapper to __gcov_flush but with default visibility. Also clearly document its usage and behavior. David On Mon, Jun 25, 2018 at 10:12 AM, Chih-Hung Hsieh via Phabricator via llvm-commits wrote: > chh added a comment. > >

r335549 - [MachineOutliner] NFC - simplify -moutline/-mno-outline logic

Author: paquette Date: Mon Jun 25 16:20:18 2018 New Revision: 335549 URL: http://llvm.org/viewvc/llvm-project?rev=335549&view=rev Log: [MachineOutliner] NFC - simplify -moutline/-mno-outline logic It's a bit cleaner to use `hasFlag` instead of nested ifs. This just refactors the -moutline/-mno-ou

r335546 - Add an option to support debug fission on implicit ThinLTO.

Author: yunlian Date: Mon Jun 25 16:05:27 2018 New Revision: 335546 URL: http://llvm.org/viewvc/llvm-project?rev=335546&view=rev Log: Add an option to support debug fission on implicit ThinLTO. Summary: This adds an option -gsplit-dwarf=. LLVM can create .dwo files in the given directory during

[PATCH] D48524: [ODRHash] Do not put elaborated types in the TypeMap

rtrieu added a comment. Running this, I see that it causes a regression in one of the other ODR Hash tests. Specifically, the diagnostics on line 1150 & 1151 of test/Modules/odr_hash.cpp are not seen. Was that an expected side-effect of this patch? Repository: rC Clang https://reviews.ll

[PATCH] D48459: Respect CMAKE_SYSROOT and CMAKE_CROSSCOMPILING when searching for libxml2.

smeenai added a comment. Actually, I would imagine that if you're cross-compiling or using a custom sysroot, you should probably also specify CMAKE_FIND_ROOT_PATH and set CMAKE_FIND_ROOT_PATH_MODE_PACKAGE to ONLY, to limit all these searches to the desired directories? (I'm actually playing ar

r335555 - [analyzer] Fix invalidation on C++ const methods with arrow syntax.

Author: dergachev Date: Mon Jun 25 16:43:45 2018 New Revision: 33 URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev Log: [analyzer] Fix invalidation on C++ const methods with arrow syntax. Conservative evaluation of a C++ method call would invalidate the object, as long as the meth

[PATCH] D48460: [analyzer] Fix invalidation on C++ const methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rC33: [analyzer] Fix invalidation on C++ const methods with arrow syntax. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D48460?vs=152391&id=152805#toc Repo

[PATCH] D48205: [analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1241 if (const llvm::APSInt *I = - SVB.getKnownValue(State, nonloc::SymbolVal(S))) + SVB.getKnownValue(State, SVB.makeSymbolVal(S))) return Loc::isLocTyp

[PATCH] D48205: [analyzer] Assert that nonloc::SymbolVal always wraps a non-Loc-type symbol.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1241 if (const llvm::APSInt *I = - SVB.getKnownValue(State, nonloc::SymbolVal(S))) + SVB.getKnownValue(State, SVB.makeSymbolVal(S))) return Loc::isLocTyp

[PATCH] D47953: [builtin] Add bitfield support for __builtin_dump_struct

dblaikie added a comment. This doesn't seem to build for me - so hard to debug/probe it: llvm/src/tools/clang/lib/CodeGen/CGBuiltin.cpp:1264:65: error: no viable conversion from 'clang::QualType' to 'llvm::Type *' CGF.CGM.getDataLayout().getTypeSizeInBits(CanonicalType),

r335559 - [analyzer] Track null and undef values through expressions with cleanups.

Author: dergachev Date: Mon Jun 25 16:55:07 2018 New Revision: 335559 URL: http://llvm.org/viewvc/llvm-project?rev=335559&view=rev Log: [analyzer] Track null and undef values through expressions with cleanups. ExprWithCleanups wraps full-expressions that require temporary destructors and highligh

[PATCH] D48204: [analyzer] Make getDerefExpr() skip cleanups.

This revision was automatically updated to reflect the committed changes. Closed by commit rC335559: [analyzer] Track null and undef values through expressions with cleanups. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D48204?vs=151450&id=152810#toc

[PATCH] D48459: Respect CMAKE_SYSROOT and CMAKE_CROSSCOMPILING when searching for libxml2.

smeenai added a comment. Ah, the documentation is confusing, but CMAKE_FIND_ROOT_PATH and CMAKE_FIND_ROOT_PATH_MODE_PACKAGE only have an effect when using the config mode of find_package, whereas this invocation is using the module mode. That's a bummer, and definitely makes custom sysroots and

[PATCH] D48459: Respect CMAKE_SYSROOT and CMAKE_CROSSCOMPILING when searching for libxml2.

smeenai added a comment. Okay, upon playing with this further, the following seems to do what I want (for a custom sysroot), and seems to be a pretty common pattern as well: set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY) set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY) set(CMAKE_FIND_ROOT_PATH_MOD

Re: r335084 - Append new attributes to the end of an AttributeList.

(Sorry for the late reply...) On Mon, Jun 25, 2018 at 2:45 PM Michael Kruse via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I just revert if to have further discussions (r335516) > > Michael > > 2018-06-25 14:58 GMT-05:00 Eric Christopher : > > > > > > On Mon, Jun 25, 2018 at 12:21 PM Rich

r335564 - [X86] Redefine avx512 packed fpclass intrinsics to return a vXi1 mask and implement the mask input argument using an 'and' IR instruction.

Author: ctopper Date: Mon Jun 25 17:44:02 2018 New Revision: 335564 URL: http://llvm.org/viewvc/llvm-project?rev=335564&view=rev Log: [X86] Redefine avx512 packed fpclass intrinsics to return a vXi1 mask and implement the mask input argument using an 'and' IR instruction. Additional IR is emitte

r335569 - Implement CFI for indirect calls via a member function pointer.

Author: pcc Date: Mon Jun 25 19:15:47 2018 New Revision: 335569 URL: http://llvm.org/viewvc/llvm-project?rev=335569&view=rev Log: Implement CFI for indirect calls via a member function pointer. Similarly to CFI on virtual and indirect calls, this implementation tries to use program type informati

[PATCH] D47567: Implement CFI for indirect calls via a member function pointer.

This revision was automatically updated to reflect the committed changes. Closed by commit rC335569: Implement CFI for indirect calls via a member function pointer. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D47567?vs=151272&id=152819#toc Repository:

r335571 - Modernize a function, NFC.

Author: vedantk Date: Mon Jun 25 19:50:01 2018 New Revision: 335571 URL: http://llvm.org/viewvc/llvm-project?rev=335571&view=rev Log: Modernize a function, NFC. Modified: cfe/trunk/lib/Sema/SemaLambda.cpp Modified: cfe/trunk/lib/Sema/SemaLambda.cpp URL: http://llvm.org/viewvc/llvm-project/c

r335572 - [ubsan] Relax nullability-return for blocks with deduced types

Author: vedantk Date: Mon Jun 25 19:50:04 2018 New Revision: 335572 URL: http://llvm.org/viewvc/llvm-project?rev=335572&view=rev Log: [ubsan] Relax nullability-return for blocks with deduced types When the return type of an ObjC-style block literals is deduced, pick the candidate type with the st

r335577 - Fix an ambiguous overload issue pointed out by MSVC

Author: vedantk Date: Mon Jun 25 20:53:06 2018 New Revision: 335577 URL: http://llvm.org/viewvc/llvm-project?rev=335577&view=rev Log: Fix an ambiguous overload issue pointed out by MSVC Log: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11390 Modified: cfe/trunk/include/clang

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank updated this revision to Diff 152842. Repository: rC Clang https://reviews.llvm.org/D45719 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added inline comments. Comment at: unittests/Format/FormatTest.cpp:4359 + "return 3;\n" + " }).as("");\n" + "}"); klimek wrote: > ank wrote: > > klimek wrote: > > > ank wrote: > > > > klimek wrote: > > > > > What

<    1   2