t.p.northover added a comment.
I'm fine with the ABI changes, but I'm not very convinced by the
"NaturalAlignment" name.
Far from being a privileged alignment kind, it seems to take account of a
pretty arbitrary set of modifiers. In fact, I can't help wondering if what's
really happened is tha
r.stahl created this revision.
r.stahl added reviewers: xazax.hun, NoQ, dcoughlin.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, rnkovacs,
szepet.
Herald added a reviewer: george.karpenkov.
In the provided test case the PathDiagnostic compare function was not able to
find a
tiena2cva added a comment.
I am waiting for this feature. Any update?
Repository:
rL LLVM
https://reviews.llvm.org/D28462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
r.stahl added a comment.
In https://reviews.llvm.org/D30691#879838, @xazax.hun wrote:
> In https://reviews.llvm.org/D30691#878830, @r.stahl wrote:
>
> > For my purposes I replaced the return statement of the
> > compareCrossTUSourceLocs function with:
> >
> > return XL.getFileID() < YL.getFile
r.stahl updated this revision to Diff 152436.
r.stahl marked 5 inline comments as done.
r.stahl added a comment.
addressed review comment, but there is nothing like FullSourceRange to improve
everything
Repository:
rC Clang
https://reviews.llvm.org/D47698
Files:
lib/AST/ASTImporter.cpp
Rakete updated this revision to Diff 152441.
Rakete added a comment.
done :)
Could you commit it please, @rsmith ?
https://reviews.llvm.org/D39679
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/references.cpp
Index: test/SemaCXX/references.cpp
===
martong added reviewers: balazske, xazax.hun.
martong added subscribers: balazske, xazax.hun.
martong added a comment.
Adding @balazske and @xazax.hun as reviewers. I think if it gets one more
approve then we could merge. I'd like to speed up the things here ... we can't
expect Aleksei to revie
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov.
Previously, the strings matched LSP completion pretty closely.
The completion label was a single string, for instance. This made
implementing completion itse
Author: d0k
Date: Fri Jun 22 02:46:40 2018
New Revision: 335330
URL: http://llvm.org/viewvc/llvm-project?rev=335330&view=rev
Log:
[hmaptool] Turn %hmaptool into a proper substitution
This is still super ugly, but at least it doesn't require working
directories to just line up perfectly for python
hans marked 4 inline comments as done.
hans added a comment.
In https://reviews.llvm.org/D48426#1140057, @dblaikie wrote:
> In https://reviews.llvm.org/D48426#1139823, @rnk wrote:
>
> > `LangOpts.ModulesCodegen` is very related in spirit to this, but I think we
> > need a distinct option because
hans updated this revision to Diff 152444.
hans marked 2 inline comments as done.
hans added a comment.
Addressing review comments.
https://reviews.llvm.org/D48426
Files:
include/clang/AST/ExternalASTSource.h
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
include
ioeric added a comment.
Looks great! Thanks for doing this!
The algorithm looks pretty efficient. It might still make sense to collect some
performance numbers for real files with potentially large #include tree (we
have plenty of those in our internal codebase :)
Comment at
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/SourceCode.h:60
+/// Splits the qualified name of ND. The scope doesn't contain unwritten scopes
+/// like inline namespaces.
ioeric updated this revision to Diff 152447.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Add printQualifiedName in AST.h
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48425
Files:
clangd/AST.cpp
clangd/AST.h
clangd/CodeComplete.cpp
clangd/Protoco
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE335334: [clangd] Expose qualified symbol names in
CompletionItem (C++ structure only… (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48425?vs=152447&id=152448#
Author: ioeric
Date: Fri Jun 22 03:46:59 2018
New Revision: 335334
URL: http://llvm.org/viewvc/llvm-project?rev=335334&view=rev
Log:
[clangd] Expose qualified symbol names in CompletionItem (C++ structure only,
no json).
Summary:
The qualified name can be used to match a completion item to its c
Author: jolesiak
Date: Fri Jun 22 04:57:55 2018
New Revision: 335338
URL: http://llvm.org/viewvc/llvm-project?rev=335338&view=rev
Log:
[clang-format] Add AlwaysBreakBeforeMultilineString tests
Summary: Followup to D47393.
Reviewers: stephanemoore
Reviewed By: stephanemoore
Subscribers: benhami
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335338: [clang-format] Add AlwaysBreakBeforeMultilineString
tests (authored by jolesiak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48432?vs=152298&id=152455#toc
Repository:
r
Author: gbuella
Date: Fri Jun 22 04:59:16 2018
New Revision: 335339
URL: http://llvm.org/viewvc/llvm-project?rev=335339&view=rev
Log:
[X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR
Summary:
Lowering some vector comparision builtins to fcmp IR instructions.
This ignores the sign
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335339: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to
native llvm IR (authored by GBuella, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45616?vs=152060&id=152456#toc
Reposito
thakis added inline comments.
Comment at: test/CodeGen/pch-dllexport.cpp:41
+
+void use() { baz(); }
+
There still isn't a non-dllexported-but-referenced inline function in here as
far as I can see. Am I just missing it?
https://reviews.llvm.org/D48426
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:8966
+
+const RISCVInterruptAttr *Attr = FD->getAttr();
+if (!Attr)
You can use `const auto *` here instead of repeating the type.
Anastasia added a comment.
In https://reviews.llvm.org/D48419#1139799, @yaxunl wrote:
> In https://reviews.llvm.org/D48419#1139749, @Anastasia wrote:
>
> > In https://reviews.llvm.org/D48419#1139601, @yaxunl wrote:
> >
> > > Did you notice the bug that C++ silently allows implicit casting of a
>
balazske added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:1534
+}
+TEST_P(ASTImporterTestBase, ImportSourceLocs) {
+ Decl *FromTU = getTuDecl(
This test causes every case for expansion (macro, macro arg) to be executed at
import?
Repositor
thakis added a comment.
This code is live when reading pchs, correct? Does this have any measurable
perf impact on deserializing pchs for, say, Cocoa.h or Windows.h?
Repository:
rC Clang
https://reviews.llvm.org/D47698
___
cfe-commits mailing li
paulsemel added a comment.
First thanks all for reviewing !
Basically, what's happening is that it works good with non-packed structures.
Here is an example for packed structure (with unsigned signed short):
c
struct lol {
unsigned short a:3;
unsigned short b:2;
unsig
hans added a comment.
I hit a snag while building some more Chromium targets. For class templates
with explicit instantiation decls in the PCH file and explicit instantiation
definitions in a .cc file, the function definition will be marked as coming
from the PCH, even though it wasn't defined
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/CodeCompletionStrings.cpp:122
+ // Typed-text chunk is the actual name. Text before it is qualifiers.
+ if (Qualifiers)
+*Qualifiers
Author: cryptoad
Date: Fri Jun 22 07:31:30 2018
New Revision: 335352
URL: http://llvm.org/viewvc/llvm-project?rev=335352&view=rev
Log:
[Driver] Make scudo compatible with -fsanitize-minimal-runtime
Summary:
This is the clang side of the change, there is a compiler-rt counterpart.
Scudo works wit
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335352: [Driver] Make scudo compatible with
-fsanitize-minimal-runtime (authored by cryptoad, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48373?vs=152171&id=152476#toc
Repository
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D48455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
r.stahl added a comment.
In https://reviews.llvm.org/D47698#1140629, @thakis wrote:
> This code is live when reading pchs, correct? Does this have any measurable
> perf impact on deserializing pchs for, say, Cocoa.h or Windows.h?
I don't know for sure, but it should be used - yes. I have not m
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thank!
https://reviews.llvm.org/D48419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
sammccall updated this revision to Diff 152479.
sammccall marked 9 inline comments as done.
sammccall added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48441
Files:
clangd/CMakeLists.txt
clangd/ClangdServer.cpp
clangd/ClangdUnit.cpp
martong added a comment.
In https://reviews.llvm.org/D47698#1140629, @thakis wrote:
> This code is live when reading pchs, correct? Does this have any measurable
> perf impact on deserializing pchs for, say, Cocoa.h or Windows.h?
No. The deserialization of a PCH is handled in a completely inde
GBuella created this revision.
GBuella added reviewers: craig.topper, uriel.k, RKSimon, andrew.w.kaylor,
spatel, scanon, efriedma.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D48487
Files:
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.
RKSimon added a comment.
I haven't used the AVX512 versions, but I do know plenty of cases that rely on
the 'use the second op if there is a NAN or both zeros' special cases in the
SSE version of these FMIN/FMAX intrinsics.
The Intel docs state:
> If the values being compared are both 0.0s (of
Author: stulova
Date: Fri Jun 22 08:45:08 2018
New Revision: 335358
URL: http://llvm.org/viewvc/llvm-project?rev=335358&view=rev
Log:
[Sema] Updated note for address spaces to print the type.
This allows to reuse the same diagnostic for OpenCL or CUDA.
Modified:
cfe/trunk/include/clang/Basi
a.sidorin added a comment.
Hi Rafael,
I apologize for the delay in review and hope to get ASTImporter patches
reviewed on this weekend.
Comment at: lib/AST/ASTImporter.cpp:7054
+
// Map the FileID for to the "to" source manager.
FileID ToID;
'for to' =>
a.sidorin added a comment.
Hi Rafael,
I think the patch is great. But, honestly, I have never dealt with
SourceLocation machinery closely, so some things are a bit unclear to me.
Comment at: lib/AST/ASTImporter.cpp:7058
+const SrcMgr::ExpansionInfo &FromEx = FromSLoc.getE
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clangd/CodeCompletionStrings.cpp:122
+ // Typed-text chunk is the actual name. Text before it is qualifiers.
+ if (Qualifiers)
+*Qualifiers = std::move(*Signature);
Author: sammccall
Date: Fri Jun 22 09:11:35 2018
New Revision: 335360
URL: http://llvm.org/viewvc/llvm-project?rev=335360&view=rev
Log:
[clangd] More precise representation of symbol names/labels in the index.
Summary:
Previously, the strings matched LSP completion pretty closely.
The completion
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE335360: [clangd] More precise representation of symbol
names/labels in the index. (authored by sammccall, committed by ).
Changed prior to commit:
https://r
Author: stulova
Date: Fri Jun 22 09:20:21 2018
New Revision: 335362
URL: http://llvm.org/viewvc/llvm-project?rev=335362&view=rev
Log:
[OpenCL] Fixed parsing of address spaces for C++.
Added address space tokens to C++ parsing code to be able
to parse declarations that start from an address space
Thanks Ben!
On Fri, Jun 22, 2018 at 2:51 AM Benjamin Kramer via cfe-commits
wrote:
>
> Author: d0k
> Date: Fri Jun 22 02:46:40 2018
> New Revision: 335330
>
> URL: http://llvm.org/viewvc/llvm-project?rev=335330&view=rev
> Log:
> [hmaptool] Turn %hmaptool into a proper substitution
>
> This is stil
Author: steven_wu
Date: Fri Jun 22 09:51:17 2018
New Revision: 335366
URL: http://llvm.org/viewvc/llvm-project?rev=335366&view=rev
Log:
Add const qualifier on FieldChainInfoComparator::operator()
libcxx has user defined warning to check for non const call operator.
Silence the warning by adding t
sbc100 updated this revision to Diff 152505.
sbc100 added a comment.
- feedback
Repository:
rC Clang
https://reviews.llvm.org/D48443
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/no-prototype.c
Index: test/CodeGen/no-prototype.c
sbc100 added a comment.
OK, I made this target specific. I think this is cleaner now.
Repository:
rC Clang
https://reviews.llvm.org/D48443
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
greened added a comment.
In https://reviews.llvm.org/D48487#1140703, @RKSimon wrote:
> I haven't used the AVX512 versions, but I do know plenty of cases that rely
> on the 'use the second op if there is a NAN or both zeros' special cases in
> the SSE version of these FMIN/FMAX intrinsics.
Yes
ioeric created this revision.
ioeric added reviewers: sammccall, djasper.
Herald added a subscriber: cfe-commits.
Tools that reformat code often call `getStyle` to decide the format style
to use on a certain source file. In practice, "file" style is widely used. As a
result, many tools hardcode "f
ashi1 created this revision.
ashi1 added a reviewer: yaxunl.
ashi1 added projects: clang, AMDGPU.
Herald added a subscriber: cfe-commits.
We need to use oclc_daz_opt_on.amdgcn.bc bitcode when option
fcuda-flush-denormal-to-zero is enabled for HIP.
Repository:
rC Clang
https://reviews.llvm.or
Author: erichkeane
Date: Fri Jun 22 10:34:44 2018
New Revision: 335372
URL: http://llvm.org/viewvc/llvm-project?rev=335372&view=rev
Log:
[NFC] Fix AttributeList allocated_size for ParsedType.
This if/elseif structure seems to be missing this case.
Previously, this would report a size of 1 pointer
b-sumner added a comment.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
scchan added a comment.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D48493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apazos added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:8966
+
+const RISCVInterruptAttr *Attr = FD->getAttr();
+if (!Attr)
aaron.ballman wrote:
> You can use `const auto *` here instead of repeating the type.
Thanks Aaron, will do the cleanu
yaxunl added a comment.
I think we should have a lit test for linked bitcode files.
Comment at: lib/Driver/ToolChains/HIP.cpp:78
+std::string OCLC_daz_opt;
+if (Args.hasArg(options::OPT_fcuda_flush_denormals_to_zero))
+ OCLC_daz_opt = "oclc_daz_opt_on.amdgcn.bc";
-
Author: bruno
Date: Fri Jun 22 11:05:17 2018
New Revision: 335375
URL: http://llvm.org/viewvc/llvm-project?rev=335375&view=rev
Log:
Re-apply: Warning for framework headers using double quote includes
Introduce -Wquoted-include-in-framework-header, which should fire a warning
whenever a quote incl
bsdjhb created this revision.
bsdjhb added a reviewer: dim.
Herald added subscribers: atanasyan, krytarowski, arichardson.
FreeBSD defaults to mips3 for all MIPS ABIs with GCC as that is the
minimum MIPS architecture FreeBSD supports. Use mips3 for MIPS64 and
mips2 for MIPS32 to match.
Reposito
leonardchan updated this revision to Diff 152525.
leonardchan added a comment.
- Add test case for fix where 0.0r would resolve as -1 when creating a fixed
point literal.
Repository:
rC Clang
https://reviews.llvm.org/D48456
Files:
include/clang/AST/ASTContext.h
include/clang/AST/Operati
Why not enable it by default, or put it in -Wall at least? We don't like
off-by-default warnings :-)
On Fri, Jun 22, 2018 at 2:09 PM Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bruno
> Date: Fri Jun 22 11:05:17 2018
> New Revision: 335375
>
> URL: http://llv
Author: abataev
Date: Fri Jun 22 12:10:38 2018
New Revision: 335377
URL: http://llvm.org/viewvc/llvm-project?rev=335377&view=rev
Log:
[OPENMP, NVPTX] Fix reduction of the big data types/structures.
If the shuffle is required for the reduced structures/big data type,
current code may cause compile
sbc100 created this revision.
Herald added subscribers: cfe-commits, aheejin, mgorny.
Repository:
rC Clang
https://reviews.llvm.org/D48503
Files:
tools/clang-fuzzer/handle-llvm/CMakeLists.txt
Index: tools/clang-fuzzer/handle-llvm/CMakeLists.txt
=
sbc100 added a comment.
I think this broke the BUILD_SHARED_LIBS=1 build:
https://reviews.llvm.org/D48503
Repository:
rC Clang
https://reviews.llvm.org/D48106
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I think this should work great for us, and hopefully helps other downstream
users too.
(@djasper: the plan is to introduce a new style name for our tweaked version of
`"file"`, and make
Author: sbc
Date: Fri Jun 22 12:44:48 2018
New Revision: 335380
URL: http://llvm.org/viewvc/llvm-project?rev=335380&view=rev
Log:
Fix BUILD_SHARED_LIBS=1 build of libclangHandleLLVM
Differential Revision: https://reviews.llvm.org/D48503
Modified:
cfe/trunk/tools/clang-fuzzer/handle-llvm/CMak
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335380: Fix BUILD_SHARED_LIBS=1 build of libclangHandleLLVM
(authored by sbc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48503?vs=152531&id=152535#toc
Repository:
rC Clang
ht
Author: rsmith
Date: Fri Jun 22 12:50:19 2018
New Revision: 335381
URL: http://llvm.org/viewvc/llvm-project?rev=335381&view=rev
Log:
Restore pre-r335182 behavior for naming inherited constructors as
members of dependent contexts.
This permits cases where the names before and after the '::' in a
d
NoQ added a comment.
Aha, yeah, i see. It only invalidates the current stack frame, and additionally
it's impossible to bring the reference into the current stack frame by
reference, because, well, it's already a reference and you can't mutate a
reference.
Ok then!
Repository:
rC Clang
ht
malaperle updated this revision to Diff 152536.
malaperle added a comment.
Rebased.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47847
Files:
unittests/clangd/FindSymbolsTests.cpp
Index: unittests/clangd/FindSymbolsTests.cpp
Hi Nico,
> Why not enable it by default, or put it in -Wall at least? We don't like
> off-by-default warnings :-)
Thanks for double checking. There's an explanation/discussion in the
review: https://reviews.llvm.org/D47157, let me know if you have
additional questions.
Cheers,
--
Bruno Cardos
Author: d0k
Date: Fri Jun 22 13:03:32 2018
New Revision: 335382
URL: http://llvm.org/viewvc/llvm-project?rev=335382&view=rev
Log:
Reinstate quotes around the path to python that I accidentaly removed in r335330
This broke users with spaces in the path, like C:\Program Files\Python
Modified:
Author: tobiasvk
Date: Fri Jun 22 13:23:21 2018
New Revision: 335385
URL: http://llvm.org/viewvc/llvm-project?rev=335385&view=rev
Log:
Re-land "[LTO] Enable module summary emission by default for regular LTO"
Since we are now producing a summary also for regular LTO builds, we
need to run the Nam
bruno added a comment.
Ping!
https://reviews.llvm.org/D47301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: emmettneyman
Date: Fri Jun 22 11:05:00 2018
New Revision: 335374
URL: http://llvm.org/viewvc/llvm-project?rev=335374&view=rev
Log:
Implemented proto to LLVM conversion and LLVM fuzz target
Differential Revision: https://reviews.llvm.org/D48106
Added:
cfe/trunk/tools/clang-fuzzer/Examp
sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.
I haven't thought through all the possibilities related to
`!FD->doesThisDeclarationHaveABody()`, but overall this looks good.
Repository:
rC Clang
https://reviews.llvm.org/D48443
___
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for working on this!
Repository:
rC Clang
https://reviews.llvm.org/D47290
___
cfe-commits mailing list
cfe-commits@lists.llvm
smeenai added inline comments.
Comment at: lib/CodeGen/CGCXXABI.h:248
+llvm_unreachable("Only needed for the Microsoft ABI");
+ }
rjmccall wrote:
> Should you just generalize the existing method to only take a VarDecl* so it
> can be used for either kind
smeenai added inline comments.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if (CGM.getTriple().isWindowsMSVCEnv
bviyer created this revision.
bviyer added reviewers: rsmith, arphaman.
There was a crash when qualtype is null in the function
Sema::ActOnCXXNestedNameSpecifierDecltype. If it is null then just return
without processing it further.
Repository:
rC Clang
https://reviews.llvm.org/D48506
File
bsdjhb created this revision.
bsdjhb added a reviewer: dim.
Herald added subscribers: atanasyan, krytarowski, arichardson, sdardis.
FreeBSD's mips64 builds O32 binaries for /usr/lib32 by default and
thus needs to be able to link O32 binaries which requires an explicit
linker emulation. Go ahead a
Author: jfb
Date: Fri Jun 22 14:54:40 2018
New Revision: 335393
URL: http://llvm.org/viewvc/llvm-project?rev=335393&view=rev
Log:
[Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin
Summary:
Pick D42933 back up, and make NSInteger/NSUInteger with %zu/%zi specifiers on
Darwin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335393: [Sema] -Wformat-pedantic only for
NSInteger/NSUInteger %zu/%zi on Darwin (authored by jfb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
sbc100 added a comment.
Without the check for `doesThisDeclarationHaveABody()` the attribute will also
be added to `baz` which is IIRC is not what we want since the C notions of
"prototypeless" only applies to forward declarations I think.
Repository:
rC Clang
https://reviews.llvm.org/D484
vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
Looks good to me. The only problem is I'm not entirely sure this warning will
interact with real code the way I expect it to. We'll need to keep an eye on it
and tweak if necessary.
https:
rjmccall added inline comments.
Comment at: lib/CodeGen/CGObjCMac.cpp:7457-7460
CGObjCNonFragileABIMac::GetEHType(QualType T) {
// There's a particular fixed type info for 'id'.
if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
+if (CGM.getTriple().isWindowsMSVCEn
apazos updated this revision to Diff 152560.
apazos added a comment.
Addressed review comments.
https://reviews.llvm.org/D48412
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAtt
NoQ added a comment.
Ok, code makes sense to me now!
I think we still need a few new tests to cover the corner cases.
In https://reviews.llvm.org/D35110#1135306, @baloghadamsoftware wrote:
> I added extra assertion into the test for the difference. Interestingly, it
> also works if I assert `n
brad created this revision.
brad added reviewers: sdardis, atanasyan.
Herald added a subscriber: srhines.
Enable IAS by default for OpenBSD / FreeBSD mips64/mips64el.
Repository:
rC Clang
https://reviews.llvm.org/D48515
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/openbsd.c
Index:
phosek updated this revision to Diff 152578.
Repository:
rC Clang
https://reviews.llvm.org/D48208
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
clang/lib/Driver/ToolChains/Fuchsia.cpp
clang/test/Driver/fuchsia.cpp
Index: clang/test/Driver/fuchsia.cpp
==
brad updated this revision to Diff 152580.
brad added a comment.
Sorry wrong revision of the diff.
https://reviews.llvm.org/D48515
Files:
lib/Driver/ToolChains/Gnu.cpp
test/Driver/openbsd.c
Index: test/Driver/openbsd.c
===
--
Author: phosek
Date: Fri Jun 22 20:15:07 2018
New Revision: 335410
URL: http://llvm.org/viewvc/llvm-project?rev=335410&view=rev
Log:
[Fuchsia] Enable static libc++, libc++abi, libunwind
This is needed for building Fuchsia drivers.
Differential Revision: https://reviews.llvm.org/D48208
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335410: [Fuchsia] Enable static libc++, libc++abi, libunwind
(authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48208?vs=152
92 matches
Mail list logo
