Hi Richard,
After this patch check-all fails for me with:
llvm-project/libcxx/utils/libcxx/test/config.py", line 467, in
configure_features
int(macros['__cpp_deduction_guides']) < 201611:
ValueError: invalid literal for int() with base 10: '201703L'
On Wed, Jun 13, 2018 at 5:44 PM Richard Sm
Looks like a bug / faulty assumption in the libc++ test suite. Should be
easy to fix, but I'm not sure how pervasive the issue is. I'll take a look
in the morning. If this is blocking anything in the mean time, feel free to
revert this (or fix libc++ yourself).
On Sun, 17 Jun 2018, 01:40 Vitaly Bu
dexonsmith added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:12236
+/// Look for '&&' in the righ or left hand of a '||' expr
+static void DiagnoseLogicalAndInLogicalOr(Sema &Self, SourceLocation OpLoc,
- Please add a period at the end of the sentence.
-
Author: rsmith
Date: Sun Jun 17 12:58:45 2018
New Revision: 334917
URL: http://llvm.org/viewvc/llvm-project?rev=334917&view=rev
Log:
Fix libcxx tests after clang r334677.
Feature test macro versions may have a trailing L.
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/t
Fixed in r334917.
On 17 June 2018 at 02:51, Richard Smith wrote:
> Looks like a bug / faulty assumption in the libc++ test suite. Should be
> easy to fix, but I'm not sure how pervasive the issue is. I'll take a look
> in the morning. If this is blocking anything in the mean time, feel free to
>
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM with that one comment.
Comment at: lib/CodeGen/CGBuiltin.cpp:10070
+
+assert(CC < 0x20 && "condition code should be validated by sema checking");
+
-
Higuoxing marked 9 inline comments as done.
Higuoxing added inline comments.
Comment at: test/Sema/parentheses.c:20
+#define NESTING_VOID(cond) ( (void)(cond) )
+#define NESTING_VOID_WRAPPER(op0, op1, x, y, z) ( (void)(x op0 y op1 z) )
+
dexonsmith wrote:
> - You
Higuoxing updated this revision to Diff 151654.
Higuoxing marked an inline comment as done.
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
===
--- test/Sema/p
Higuoxing added inline comments.
Comment at: test/Sema/parentheses.c:114
+ NON_NESTING_VOID_0(i && i || i); // expected-warning {{'&&' within '||'}} \
+ // expected-note {{place parentheses around
the '&&' expression to silence this warning}}
+
jtbandes created this revision.
Add a flag `-fno-digraphs` to disable digraphs in the lexer, similar to
`-fno-operator-names` which disables alternative names for C++ operators.
Repository:
rC Clang
https://reviews.llvm.org/D48266
Files:
include/clang/Driver/Options.td
lib/Driver/ToolCh
klimek added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:678
// Indent with tabs only when there's at least one full tab.
-if (FirstTabWidth + Style.TabWidth <= Spaces) {
+if (Style.TabWidth <= Spaces) {
Spaces -= FirstTabWidth;
-
rsmith added inline comments.
Comment at: include/clang/Driver/Options.td:1337-1338
Flags<[CC1Option]>, Group;
+def fno_digraphs : Flag<["-"], "fno-digraphs">, Group,
Flags<[CC1Option]>,
+ HelpText<"Disallow alternative token representations '<:', ':>', '<%', '%>',
'%:'">
Author: vitalybuka
Date: Sun Jun 17 23:24:29 2018
New Revision: 334924
URL: http://llvm.org/viewvc/llvm-project?rev=334924&view=rev
Log:
Fix libcxx tests after clang r334677.
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
Modified: libcxxabi/trunk/test/libcxxabi/test/config.py
URL:
Thanks!
also r334924
On Sun, Jun 17, 2018 at 1:03 PM Richard Smith wrote:
> Fixed in r334917.
>
> On 17 June 2018 at 02:51, Richard Smith wrote:
>
>> Looks like a bug / faulty assumption in the libc++ test suite. Should be
>> easy to fix, but I'm not sure how pervasive the issue is. I'll take a
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeCompletionStrings.cpp:172
// get this declaration, so we don't show documentation in that case.
if (Result.Kind != CodeCompletionResult
Author: vitalybuka
Date: Sun Jun 17 23:43:55 2018
New Revision: 334926
URL: http://llvm.org/viewvc/llvm-project?rev=334926&view=rev
Log:
Fix libcxxabi tests after clang r334924
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
Modified: libcxxabi/trunk/test/libcxxabi/test/config.py
URL
16 matches
Mail list logo
