[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF added a comment. In https://reviews.llvm.org/D45015#1121874, @ahatanak wrote: > I see, thank you. > > clang front-end currently fails to issue a warning or error when an aligned > allocation/deallocation functions are required but not available in a few > cases (e.g., delete called from

r334057 - [X86] Add builtins for vector element insert and extract for different 128 and 256 bit vector types. Use them to implement the extract and insert intrinsics.

Author: ctopper Date: Tue Jun 5 17:24:55 2018 New Revision: 334057 URL: http://llvm.org/viewvc/llvm-project?rev=334057&view=rev Log: [X86] Add builtins for vector element insert and extract for different 128 and 256 bit vector types. Use them to implement the extract and insert intrinsics. Prev

[PATCH] D47376: [CUDA][HIP] Do not offload for -M

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. I'm not sure this is the right thing to do. What if user explicitly wants device-side dependencies and runs `clang --cuda-device-only -M` ? This patch makes it impossible. I'd rather tell

[PATCH] D47376: [CUDA][HIP] Do not offload for -M

tra added a comment. Just to make it clear, I'm not against making a sensible default choice, but rather want to make sure that it is possible to override it if the user needs to. https://reviews.llvm.org/D47376 ___ cfe-commits mailing list cfe-co

[PATCH] D47802: Allow std::vector to move construct its allocator

EricWF added a comment. @fidget324 Thanks for the patch! Unfortunatly I didn't know you were planning on contributing a fix, so I went ahead and fixed it myself in r334053. Repository: rCXX libc++ https://reviews.llvm.org/D47802 ___ cfe-commits

r334059 - Implement bittest intrinsics generically for non-x86 platforms

Author: rnk Date: Tue Jun 5 18:35:08 2018 New Revision: 334059 URL: http://llvm.org/viewvc/llvm-project?rev=334059&view=rev Log: Implement bittest intrinsics generically for non-x86 platforms I tested these locally on an x86 machine by disabling the inline asm codepath and confirming that it doe

r334060 - Fix std::tuple errors

Author: rnk Date: Tue Jun 5 18:44:10 2018 New Revision: 334060 URL: http://llvm.org/viewvc/llvm-project?rev=334060&view=rev Log: Fix std::tuple errors Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tr

[PATCH] D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease

rnk added a comment. In https://reviews.llvm.org/D47672#1122013, @ethanhs wrote: > In https://reviews.llvm.org/D47672#1121181, @rnk wrote: > > > > > > > > > They are a hint to the processor that this is a short critical section, and > > it is likely that the entire critical section can be entere

[PATCH] D47671: [analyzer] Implement copy elision.

NoQ added a comment. In https://reviews.llvm.org/D47671#1122994, @george.karpenkov wrote: > From my understanding, that's just how c++17 is defined, and that's unrelated > to what compiler implementation is used. Yeah, but this patch is specifically about supporting the pre-C++17 AST, where c

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

ahatanak added a comment. In https://reviews.llvm.org/D45015#1123097, @EricWF wrote: > In https://reviews.llvm.org/D45015#1121874, @ahatanak wrote: > > > I see, thank you. > > > > clang front-end currently fails to issue a warning or error when an aligned > > allocation/deallocation functions ar

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

EricWF added a comment. In https://reviews.llvm.org/D45015#1123164, @ahatanak wrote: > In https://reviews.llvm.org/D45015#1123097, @EricWF wrote: > > > In https://reviews.llvm.org/D45015#1121874, @ahatanak wrote: > > > > > I see, thank you. > > > > > > clang front-end currently fails to issue a w

[PATCH] D46806: Remove unused code from __functional_base. NFC.

Quuxplusone updated this revision to Diff 150067. Quuxplusone edited the summary of this revision. Quuxplusone added a comment. Also, `` doesn't need a full definition of `std::tuple`; just the forward declaration in `<__tuple>` will suffice. Repository: rCXX libc++ https://reviews.llvm.org/

[PATCH] D47360: Implement as a copy of .

Quuxplusone planned changes to this revision. Quuxplusone added a comment. Once the dependencies (https://reviews.llvm.org/D47111 and https://reviews.llvm.org/D47358) are merged, I need to update the unit tests in this patch to reflect the unit tests that were committed. Right now, the unit tes

r334061 - [X86] Move the vec_set/vec_ext builtins for 64-bit elements to BuiltinsX86_64.def.

Author: ctopper Date: Tue Jun 5 21:51:52 2018 New Revision: 334061 URL: http://llvm.org/viewvc/llvm-project?rev=334061&view=rev Log: [X86] Move the vec_set/vec_ext builtins for 64-bit elements to BuiltinsX86_64.def. The instructions these correspond to and the intrinsics that use them are only

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

This revision was automatically updated to reflect the committed changes. Closed by commit rC334062: [Sema] Fix parsing of anonymous union in language linkage specification (authored by jkorous, committed by ). Changed prior to commit: https://reviews.llvm.org/D45884?vs=143736&id=150069#toc Re

r334062 - [Sema] Fix parsing of anonymous union in language linkage specification

Author: jkorous Date: Tue Jun 5 22:16:34 2018 New Revision: 334062 URL: http://llvm.org/viewvc/llvm-project?rev=334062&view=rev Log: [Sema] Fix parsing of anonymous union in language linkage specification C++17 [dcl.link]p4: A linkage specification does not establish a scope. C++17 [class.union

r334063 - [Fuchsia] Include install-distribution-stripped in bootstrap targets

Author: phosek Date: Tue Jun 5 22:18:39 2018 New Revision: 334063 URL: http://llvm.org/viewvc/llvm-project?rev=334063&view=rev Log: [Fuchsia] Include install-distribution-stripped in bootstrap targets This enables the use of install-distribution-stripped target in the 2-stage builds. Differenti

[PATCH] D47758: [Fuchsia] Include install-distribution-stripped in bootstrap targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL334063: [Fuchsia] Include install-distribution-stripped in bootstrap targets (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D47802: Allow std::vector to move construct its allocator

fidget324 abandoned this revision. fidget324 added a comment. That's fine. Your patch was much more thorough, anyways. Repository: rCXX libc++ https://reviews.llvm.org/D47802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D47757: [Sema] Diagnose unavailable aligned deallocation functions called from deleting destructors.

EricWF added a comment. I think we should sink the `DiagnoseUnavailableAlignedAllocation` into `DiagnoseUseOfDecl`, and then adds call's in the few places they're needed. Most paths we care about already pass through there. Comment at: include/clang/Sema/Sema.h:5169 + void

r334065 - [Analyzer] Fix Z3ConstraintManager crash (PR37646)

Author: vlad.tsyrklevich Date: Tue Jun 5 23:09:02 2018 New Revision: 334065 URL: http://llvm.org/viewvc/llvm-project?rev=334065&view=rev Log: [Analyzer] Fix Z3ConstraintManager crash (PR37646) Summary: Fix another Z3ConstraintManager crash, use fixAPSInt() to extend a boolean APSInt. Reviewers:

[PATCH] D47617: [Analyzer] Fix Z3ConstraintManager crash (PR37646)

This revision was automatically updated to reflect the committed changes. Closed by commit rC334065: [Analyzer] Fix Z3ConstraintManager crash (PR37646) (authored by vlad.tsyrklevich, committed by ). Changed prior to commit: https://reviews.llvm.org/D47617?vs=149796&id=150074#toc Repository:

r334067 - [Analyzer][Z3] Test fixes for Z3 constraint manager

Author: vlad.tsyrklevich Date: Tue Jun 5 23:25:51 2018 New Revision: 334067 URL: http://llvm.org/viewvc/llvm-project?rev=334067&view=rev Log: [Analyzer][Z3] Test fixes for Z3 constraint manager Summary: Since Z3 tests have been not been running [1] some tests needed to be updated. I also added a

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

This revision was automatically updated to reflect the committed changes. Closed by commit rL334067: [Analyzer][Z3] Test fixes for Z3 constraint manager (authored by vlad.tsyrklevich, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D47726

[PATCH] D47726: [Analyzer][Z3] Test fixes for Z3 constraint manager

This revision was automatically updated to reflect the committed changes. Closed by commit rC334067: [Analyzer][Z3] Test fixes for Z3 constraint manager (authored by vlad.tsyrklevich, committed by ). Changed prior to commit: https://reviews.llvm.org/D47726?vs=149786&id=150076#toc Repository:

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

mstorsjo accepted this revision. mstorsjo added a comment. Sounds sensible to me; I've tested the patch in the setup that showed the issue this original patch tried to fix, and it seems to work fine there. https://reviews.llvm.org/D38680 ___ cfe-co

[libcxx] r334069 - Remove unused code from __functional_base. NFC.

Author: ericwf Date: Tue Jun 5 23:42:27 2018 New Revision: 334069 URL: http://llvm.org/viewvc/llvm-project?rev=334069&view=rev Log: Remove unused code from __functional_base. NFC. Patch from Arthur O'Dwyer. `__user_alloc_construct_impl` is used by , but this `__user_alloc_construct` is never us

[PATCH] D46806: Remove unused code from __functional_base. NFC.

EricWF closed this revision. EricWF added a comment. r334069 Repository: rCXX libc++ https://reviews.llvm.org/D46806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47804: [CUDA] Replace 'nv_weak' attributes in CUDA headers with 'weak'.

Hahnfeld accepted this revision. Hahnfeld added a subscriber: fwyzard. Hahnfeld added a comment. Works for me, I'll abandon https://reviews.llvm.org/D47201 if you prefer this. https://reviews.llvm.org/D47804 ___ cfe-commits mailing list cfe-commits@

[PATCH] D47201: [CUDA] Implement nv_weak attribute for functions

Hahnfeld abandoned this revision. Hahnfeld added a comment. See https://reviews.llvm.org/D47804 Repository: rC Clang https://reviews.llvm.org/D47201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D47804: [CUDA] Replace 'nv_weak' attributes in CUDA headers with 'weak'.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well, for what little it's worth. :-) https://reviews.llvm.org/D47804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

<    1   2