Author: theraven
Date: Tue May 22 00:22:50 2018
New Revision: 332955
URL: http://llvm.org/viewvc/llvm-project?rev=332955&view=rev
Log:
Add cctype include.
This appears to leak in already on libc++ platforms, but is breaking on
some other targets.
Modified:
cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
Ka-Ka added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+char c = Str[i];
+if (isalpha(c) || isnumber(c))
+ StringName += c;
The isnumber() function was added to cctype.h by Apple. I don't think it can be
used in llvm.
A
gaijiading added a comment.
In https://reviews.llvm.org/D46230#1106086, @echristo wrote:
> Well, that's ridiculous. We should really fix this a better way in the future.
>
> That said, would you add a testcase for this please so we don't regress if we
> fix it? :)
>
> -eric
Thanks Eric for the
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, klimek.
Currently, we only handle the first callback from sema code completion
and ignore results from potential following callbacks. This causes
causes loss of
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+char c = Str[i];
+if (isalpha(c) || isnumber(c))
+ StringName += c;
Ka-Ka wrote:
> The isnumber() function was added to cctype.h by Apple. I don't think it can
>
On Tue, May 22, 2018 at 10:31 AM, David Chisnall via Phabricator via
cfe-commits wrote:
> theraven added inline comments.
>
>
>
> Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
> +char c = Str[i];
> +if (isalpha(c) || isnumber(c))
> + StringName += c;
> --
Author: ioeric
Date: Tue May 22 01:33:30 2018
New Revision: 332959
URL: http://llvm.org/viewvc/llvm-project?rev=332959&view=rev
Log:
[clangd] Correctly handle IWYU prama with verbatim #include header.
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
clang-tools-extra/t
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:457
Result.StartsNestedNameSpecifier = false;
+ // FIXME: the same result can be added multiple times as the callback can
+ // be called more than once. We may want to deduplicate identical
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, klimek.
This assumes that .inc files are supposed to be included via headers
that include them.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D47099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:457
Result.StartsNestedNameSpecifier = false;
+ // FIXME: the same result can be added multiple times as the callback can
+ // be called more than once. We may want to deduplicate identical
result
GBuella added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+char c = Str[i];
+if (isalpha(c) || isnumber(c))
+ StringName += c;
theraven wrote:
> Ka-Ka wrote:
> > The isnumber() function was added to cctype.h by Apple. I do
GBuella added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:1056
+char c = Str[i];
+if (isalpha(c) || isnumber(c))
+ StringName += c;
GBuella wrote:
> theraven wrote:
> > Ka-Ka wrote:
> > > The isnumber() function was added to cc
martong updated this revision to Diff 147966.
martong marked an inline comment as done.
martong added a comment.
Use isExplicitInstantiationOrSpecialization
Repository:
rC Clang
https://reviews.llvm.org/D47058
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unit
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:4305
+// Add to the DC only if it was an explicit specialization/instantiation.
+if (D2->getTemplateSpecializationKind() != TSK_ImplicitInstantiation) {
+ LexicalDC->addDeclInternal(D2);
-
dcederman updated this revision to Diff 147965.
dcederman added a comment.
Also use the leon arch for the Myriad processors.
https://reviews.llvm.org/D47138
Files:
lib/Driver/ToolChains/Arch/Sparc.cpp
Index: lib/Driver/ToolChains/Arch/Sparc.cpp
==
dcederman added a comment.
In https://reviews.llvm.org/D47138#1106509, @jyknight wrote:
> Separately, I think it'd be a good idea to refactor to put this info into the
> SparcCPUInfo struct, so that it's harder for them to get out of sync.
I did not find a good way to access the SparcCPUInfo s
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:457
Result.StartsNestedNameSpecifier = false;
+ // FIXME: the same result can be added multiple times as the callback can
+ // be called more than once. We may want to deduplicate identical
yvvan added inline comments.
Comment at: lib/Sema/CodeCompleteConsumer.cpp:559
+const char *Begin =
+SemaRef.SourceMgr.getCharacterData(FixIt.RemoveRange.getBegin());
+const char *End =
ilya-biryukov wrote:
> Unfortunately, that might
asavonic created this revision.
Herald added a subscriber: mgorny.
This patch allows clang to use a VirtualFileSystem represented by a
shared library. This VFS will be used on top of the real file system.
Library specified -ivfsoverlay-lib by must export
`clang::vfs::FileSystem *__clang_create_vf
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
Found by oss-fuzz:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8212
Repository:
rC Clang
https://reviews.llvm.org/D47191
Files:
lib/Format/ContinuationIndenter.cpp
Index: lib/Format/ContinuationInden
Author: krasimir
Date: Tue May 22 02:46:55 2018
New Revision: 332961
URL: http://llvm.org/viewvc/llvm-project?rev=332961&view=rev
Log:
[clang-format] Fix crash in getLengthToMatchingParen
Summary:
Found by oss-fuzz:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8212
Reviewers: bkramer
S
lebedev.ri added a comment.
No test?
Repository:
rL LLVM
https://reviews.llvm.org/D47191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332961: [clang-format] Fix crash in getLengthToMatchingParen
(authored by krasimir, committed by ).
Herald added a subscri
asavonic updated this revision to Diff 147974.
asavonic added a comment.
Add license header.
https://reviews.llvm.org/D47190
Files:
include/clang/Driver/Options.td
include/clang/Lex/HeaderSearchOptions.h
lib/Frontend/CompilerInvocation.cpp
unittests/Frontend/CMakeLists.txt
unittests/F
ilya-biryukov added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:4109
+ if (CodeCompleter->includeFixIts()) {
+const SourceRange OpRange(OpLoc, OpLoc.getLocWithOffset(IsArrow ? 2 : 1));
+CompletionSucceded =
yvvan wrote:
> ilya-biryukov wro
yvvan added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:4109
+ if (CodeCompleter->includeFixIts()) {
+const SourceRange OpRange(OpLoc, OpLoc.getLocWithOffset(IsArrow ? 2 : 1));
+CompletionSucceded =
ilya-biryukov wrote:
> yvvan wrote:
> >
Author: theraven
Date: Tue May 22 03:13:17 2018
New Revision: 332966
URL: http://llvm.org/viewvc/llvm-project?rev=332966&view=rev
Log:
[objc-gnustep2] Use unsigned char to avoid potential UB in isalnum.
Suggested by Gabor Buella.
Modified:
cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
Modified: cfe/t
Author: theraven
Date: Tue May 22 03:13:14 2018
New Revision: 332965
URL: http://llvm.org/viewvc/llvm-project?rev=332965&view=rev
Log:
[objc-gnu] Fix test.
The test was implicitly capturing the local filesystem layout.
Patch by Hans Wennborg!
Modified:
cfe/trunk/test/CodeGenObjC/gnu-init.m
Author: theraven
Date: Tue May 22 03:13:11 2018
New Revision: 332964
URL: http://llvm.org/viewvc/llvm-project?rev=332964&view=rev
Log:
[objc-gnustep2] Use isalnum instead of a less efficient and nonportable
equivalent.
Patch by Hans Wennborg!
Modified:
cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
M
ilya-biryukov added a comment.
In https://reviews.llvm.org/D47065#1104730, @ioeric wrote:
> Should we also change the behavior in dynamic index?
Dynamic index already uses whatever AST provides (which is `ParseAllComments =
true` since https://reviews.llvm.org/D46002)
Repository:
rCTE Clan
mprobst created this revision.
mprobst added a reviewer: krasimir.
Herald added subscribers: cfe-commits, klimek.
`is` type annotations can occur at any nesting level. For example:
function x() {
return function y(): a is B { ... };
}
Breaking before the `is` above breaks TypeScript pars
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332968: clang-format: [JS] do not wrap before any `is`.
(authored by mprobst, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47193?vs=147978&id=147979#toc
Repository:
rC Clang
ht
Author: mprobst
Date: Tue May 22 03:39:07 2018
New Revision: 332968
URL: http://llvm.org/viewvc/llvm-project?rev=332968&view=rev
Log:
clang-format: [JS] do not wrap before any `is`.
Summary:
`is` type annotations can occur at any nesting level. For example:
function x() {
return functi
Author: aemerson
Date: Tue May 22 04:18:58 2018
New Revision: 332973
URL: http://llvm.org/viewvc/llvm-project?rev=332973&view=rev
Log:
Revert "CodeGen, Driver: Start using direct split dwarf emission in clang."
This reverts commit r332885 as it broke several greendragon buildbots.
Removed:
c
Author: aemerson
Date: Tue May 22 04:18:49 2018
New Revision: 332972
URL: http://llvm.org/viewvc/llvm-project?rev=332972&view=rev
Log:
Revert "Fix another make_unique ambiguity."
This reverts commit r332906 as a dependency to revert r332885.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
M
Author: aemerson
Date: Tue May 22 04:18:43 2018
New Revision: 332971
URL: http://llvm.org/viewvc/llvm-project?rev=332971&view=rev
Log:
Revert "Add missing x86-registered-target."
This reverts commit r332911, as a dependency to revert r332885.
Modified:
cfe/trunk/test/Misc/cc1as-split-dwarf.s
> On 21 May 2018, at 21:31, Peter Collingbourne via cfe-commits
> wrote:
>
> Author: pcc
> Date: Mon May 21 13:31:59 2018
> New Revision: 332885
>
> URL: http://llvm.org/viewvc/llvm-project?rev=332885&view=rev
> Log:
> CodeGen, Driver: Start using direct split dwarf emission in clang.
>
> Fixe
Author: krasimir
Date: Tue May 22 04:44:03 2018
New Revision: 332974
URL: http://llvm.org/viewvc/llvm-project?rev=332974&view=rev
Log:
[clang-format] Add a test case for crash
Modified:
cfe/trunk/unittests/Format/FormatTest.cpp
Modified: cfe/trunk/unittests/Format/FormatTest.cpp
URL:
http:/
krasimir added a comment.
Added a test in https://reviews.llvm.org/rL332974.
Didn't add a test case and didn't wait for review. Sorry about that!
Repository:
rL LLVM
https://reviews.llvm.org/D47191
___
cfe-commits mailing list
cfe-commits@lists.
GBuella updated this revision to Diff 147984.
https://reviews.llvm.org/D46541
Files:
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGen/target-features-error-2.c
test/CodeGen/target-features-error.c
Index: test/CodeGen/target-features
GBuella added a comment.
In https://reviews.llvm.org/D46541#1106743, @craig.topper wrote:
> I think you can pass StringRef(F).substr(1). That won't create a temporary
> string. It will just create a StringRef pointing into the middle of an
> existing std::string stored in the parsed attributes.
Prazek added a comment.
@rjmccall do you have any thoughts on the best way to solve it?
Repository:
rL LLVM
https://reviews.llvm.org/D47108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332975 (authored by bwyma, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.llvm.org/D45438?vs=146612&id=147988#toc
Repository:
rC Clang
https://review
lichray added a comment.
In https://reviews.llvm.org/D41347#1099842, @mclow.lists wrote:
> Sorry this took so long. Please update `test/libcxx/double_include.sh.cpp`
> and commit.
Are you sure? `double_include.sh.cpp` doesn't seem to be testing any
intermediate headers.
Repository:
rCXX
lichray added inline comments.
Comment at: include/charconv:89
+_LIBCPP_BEGIN_NAMESPACE_STD
+
+enum class _LIBCPP_ENUM_VIS chars_format
mclow.lists wrote:
> lichray wrote:
> > EricWF wrote:
> > > We need to hide these names when `_LIBCPP_STD_VER < 17`, since we'r
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: ibiryukov
Date: Tue May 22 06:10:09 2018
New Revision: 332976
URL: http://llvm.org/viewvc/llvm-project?rev=332976&view=rev
Log:
[clangd] Remove ignored Preamble::CanReuse call from completion
Summary:
Now that the clients who relied on stats for files from preamble are
gone.
Reviewers: i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332976: [clangd] Remove ignored Preamble::CanReuse call from
completion (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47
jolesiak created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rC Clang
https://reviews.llvm.org/D47195
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
===
Author: ibiryukov
Date: Tue May 22 06:29:37 2018
New Revision: 332978
URL: http://llvm.org/viewvc/llvm-project?rev=332978&view=rev
Log:
[clangd] Fix a typo. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp
URL:
http://ll
martong added inline comments.
Comment at: lib/AST/ASTImporter.cpp:1962
TagDecl *Definition = D->getDefinition();
- if (Definition && Definition != D) {
+ if (!D->isImplicit() && Definition && Definition != D) {
Decl *ImportedDef = Importer.Import(Definition);
-
martong updated this revision to Diff 147994.
martong marked an inline comment as done.
martong added a comment.
- Add new test case for simple CXXRecordDecl
- Add comment about ClassTemplateSpecializationDecl implicit CXXRecordDecl
Repository:
rC Clang
https://reviews.llvm.org/D47057
Files:
scanon requested changes to this revision.
scanon added a comment.
This revision now requires changes to proceed.
IIRC the optimization of divide-by-power-of-two --> multiply-by-inverse does
not occur at -O0, so it would be better to multiply by 2^(-fbits) instead.
Repository:
rC Clang
https
avt77 created this revision.
avt77 added reviewers: RKSimon, simon.f.whittaker, mgorny, russell.gallop,
efriedma, rsmith, mzolotukhin, davezarzycki, vsk.
Herald added a subscriber: mgrang.
I introduce the new infrastructure supporting recursive timers in Clang. This
patch is based on https://rev
GBuella added a comment.
What does "imm" mean anyways?
Repository:
rC Clang
https://reviews.llvm.org/D47182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yaxunl
Date: Tue May 22 07:36:26 2018
New Revision: 332982
URL: http://llvm.org/viewvc/llvm-project?rev=332982&view=rev
Log:
Call CreateTempMemWithoutCast for ActiveFlag
Introduced CreateMemTempWithoutCast and CreateTemporaryAllocaWithoutCast to
emit alloca
without casting to default add
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332982: Call CreateTempMemWithoutCast for ActiveFlag
(authored by yaxunl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47099
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGCleanup.c
ilya-biryukov updated this revision to Diff 148006.
ilya-biryukov added a comment.
Herald added a subscriber: mgorny.
- Move helpers tha switch header and source into separate files.
- Also uprank items coming from the matching headers
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.o
krasimir added inline comments.
Comment at: unittests/Format/FormatTestObjC.cpp:815
+
+ // No line break before closing receiver's scope.
+ verifyFormat("[[obj a:42] a:42\n"
What's the receiver's scope in this comment referring to?
Also, how would the old test
ilya-biryukov added a comment.
I've added an initial version of testing for the matching header and wanted to
get feedback before proceeding further with tests and other changes.
A few things that bug me so far:
- We need to match headers of items from the index, not only from the Sema
results
Author: spatel
Date: Tue May 22 08:11:59 2018
New Revision: 332988
URL: http://llvm.org/viewvc/llvm-project?rev=332988&view=rev
Log:
[CodeGen] add tests for abs builtins; NFC
Added:
cfe/trunk/test/CodeGen/builtin-abs.c
Added: cfe/trunk/test/CodeGen/builtin-abs.c
URL:
http://llvm.org/viewvc/
Author: bwyma
Date: Tue May 22 05:41:19 2018
New Revision: 332975
URL: http://llvm.org/viewvc/llvm-project?rev=332975&view=rev
Log:
[CodeView] Enable debugging of captured variables within C++ lambdas
This change will help Visual Studio resolve forward references to C++ lambda
routines used by c
ioeric added a comment.
OK, it turned out that there are a few things that I overlooked:
1. Top-N Ranking would be broken among different callbacks. We would need to
keep a single `TopN` for all callbacks.
2. Due to 1), materialization of TopN candidates would happen after all
callbacks have fi
GBuella updated this revision to Diff 148011.
https://reviews.llvm.org/D47142
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
lib/Headers/CMakeLists.txt
lib/Headers/cpuid.h
lib/Headers/invpcidintrin.h
lib
craig.topper added a comment.
First there was mmintrin.h which covered MMX instructions. Then xmmintrin.h
came along to support SSE1 and implicitly included mmintrin.h. The emmintrin.h
to support SSE2 and implicitly included xmmintrin.h. This repeated for each new
version of SSE. With each head
martong updated this revision to Diff 148013.
martong marked 5 inline comments as done.
martong added a comment.
- Addressing Aleksei's comments
Repository:
rC Clang
https://reviews.llvm.org/D46950
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
unittests/AST/DeclMatch
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
Please address @krasimir's comments, but looks good to me.
Repository:
rC Clang
https://reviews.llvm.org/D47195
___
cfe-commits mail
Author: spatel
Date: Tue May 22 08:36:50 2018
New Revision: 332989
URL: http://llvm.org/viewvc/llvm-project?rev=332989&view=rev
Log:
[CodeGen] produce the LLVM canonical form of abs
We chose the 'slt' form as canonical in IR with:
rL332819
...so we should generate that form directly for efficienc
jolesiak added inline comments.
Comment at: unittests/Format/FormatTestObjC.cpp:815
+
+ // No line break before closing receiver's scope.
+ verifyFormat("[[obj a:42] a:42\n"
krasimir wrote:
> What's the receiver's scope in this comment referring to?
> Also, how
Hahnfeld created this revision.
Hahnfeld added reviewers: aaron.ballman, rjmccall.
Herald added a subscriber: cfe-commits.
I found these checks to be missing, just add some simple cases.
Repository:
rC Clang
https://reviews.llvm.org/D47200
Files:
test/Sema/attr-weak.c
Index: test/Sema/at
Hahnfeld created this revision.
Hahnfeld added a reviewer: tra.
Herald added a subscriber: cfe-commits.
This is needed for relocatable device code with CUDA 9 and later.
Before this patch, linking two or more object files resulted in
"Multiple definition" errors for a group of functions from
cuda_
spatel created this revision.
spatel added reviewers: craig.topper, efriedma, lebedev.ri.
Herald added a subscriber: mcrosier.
The clang builtins have the same semantics as the stdlib functions.
The stdlib functions are defined in section 7.20.6.1 of the C standard with:
"If the result cannot be
krasimir added inline comments.
Comment at: unittests/Format/FormatTestObjC.cpp:815
+
+ // No line break before closing receiver's scope.
+ verifyFormat("[[obj a:42] a:42\n"
jolesiak wrote:
> krasimir wrote:
> > What's the receiver's scope in this comment refer
gramanas abandoned this revision.
gramanas added a comment.
Duplicate of https://reviews.llvm.org/D47097
Repository:
rC Clang
https://reviews.llvm.org/D47161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D47200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: yaxunl
Date: Tue May 22 09:13:07 2018
New Revision: 332991
URL: http://llvm.org/viewvc/llvm-project?rev=332991&view=rev
Log:
Revert r332982 Call CreateTempMemWithoutCast for ActiveFlag
Due to regression on arm.
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/lib/CodeGen/CGCl
yaxunl added a comment.
I revert it since it caused regression on arm and some other arch's.
Script:
--
/home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-linux/stage1/bin/clang
-cc1 -internal-isystem
/home/ssglocal/clang-cmake-x86_64-avx2-linux/clang-cmake-x86_64-avx2-
Author: marshall
Date: Tue May 22 09:20:28 2018
New Revision: 332996
URL: http://llvm.org/viewvc/llvm-project?rev=332996&view=rev
Log:
Change the names of two private methods: allocate -> __vallocate and deallocate
-> __vdeallocate. NFC. This change triggered by
https://gcc.gnu.org/bugzilla/show
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rC Clang
https://reviews.llvm.org/D46950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
lebedev.ri added a comment.
That is what happens for "hand-rolled" `abs`, https://godbolt.org/g/6dbgXD
I *think* this makes sense, since **IIRC** LLVM only supports twos-complement
platforms.
But all these attributes are currently beyond me, so i won't click the accept
button :)
https://review
leonardchan updated this revision to Diff 148025.
Repository:
rC Clang
https://reviews.llvm.org/D46084
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Basic/DiagnosticCommonKinds.td
include/clang/Basic/Specifiers.h
incl
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
Comment at: lib/AST/ASTImporter.cpp:1962
TagDecl *Definition = D->getDefinition();
- if (Definition && Definition != D) {
+ if (!D->isImplicit() /
leonardchan marked 2 inline comments as done.
leonardchan added inline comments.
Comment at: lib/Index/USRGeneration.cpp:731
+
+ if (c == '~') {
+switch (BT->getKind()) {
jakehehrlich wrote:
> You can make the 'c' a Twine instead. That will let you i
spatel added a comment.
In https://reviews.llvm.org/D47202#1108016, @lebedev.ri wrote:
> That is what happens for "hand-rolled" `abs`, https://godbolt.org/g/6dbgXD
> I *think* this makes sense, since **IIRC** LLVM only supports
> twos-complement platforms.
> But all these attributes are curren
a.sidorin added a comment.
Hi Gabor,
Could you add a test for TSK_Undeclared as well?
Repository:
rC Clang
https://reviews.llvm.org/D47058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
jolesiak created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rC Clang
https://reviews.llvm.org/D47205
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
==
jolesiak added inline comments.
Comment at: unittests/Format/FormatTestObjC.cpp:815
+
+ // No line break before closing receiver's scope.
+ verifyFormat("[[obj a:42] a:42\n"
krasimir wrote:
> jolesiak wrote:
> > krasimir wrote:
> > > What's the receiver's scope
Author: jolesiak
Date: Tue May 22 09:44:42 2018
New Revision: 332998
URL: http://llvm.org/viewvc/llvm-project?rev=332998&view=rev
Log:
Revert "[clang-format] Fix putting ObjC message arguments in one line for
multiline receiver"
Summary: Reverts D46879
Reviewers: benhamilton
Reviewed By: benha
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332998: Revert "[clang-format] Fix putting ObjC message
arguments in one line for… (authored by jolesiak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47205?vs=148030&id=148032#toc
gramanas updated this revision to Diff 148034.
gramanas added a comment.
Move ApplyDebugLocation before CreateMemTemp
Repository:
rC Clang
https://reviews.llvm.org/D47097
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGen/debug-info-preserve-scope.c
Index: test/CodeGen/debug-info-preserve-scop
vsk added inline comments.
Comment at: test/CodeGen/debug-info-preserve-scope.c:10
+
+// CHECK: alloca i32 {{.*}} !dbg ![[dbgLocForStore:[0-9]+]]
+// CHECK: store i32 {{.*}} !dbg ![[dbgLocForStore:[0-9]+]]
In these two check lines, you're capturing the variable d
jolesiak updated this revision to Diff 148038.
jolesiak added a comment.
Rebase.
Repository:
rC Clang
https://reviews.llvm.org/D47195
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp
Index: unittests/Format/FormatTestObjC.cpp
==
benhamilton added a comment.
Can you update the diff description to reflect that it includes the original
change?
Repository:
rC Clang
https://reviews.llvm.org/D47195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
adr26 updated this revision to Diff 148044.
adr26 added a comment.
Update to change MSInheritanceAttr to always be attached to the latest
non-injected class name decl, as suggested by Reid.
https://reviews.llvm.org/D46664
Files:
include/clang/AST/DeclCXX.h
lib/AST/MicrosoftMangle.cpp
lib
krasimir added inline comments.
Comment at: unittests/Format/FormatTestObjC.cpp:815
+
+ // No line break before closing receiver's scope.
+ verifyFormat("[[obj a:42] a:42\n"
jolesiak wrote:
> krasimir wrote:
> > jolesiak wrote:
> > > krasimir wrote:
> > > > Wha
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D47182#1107900, @craig.topper wrote:
> Eventually this was determined to not be very scalable to remember which
> header file contained what intrinsics and you have to ch
probinson added a comment.
I take it this was accidental? If there are weaknesses in our documentation
for how to use Phabricator, please let us know. I know it is not always
straightforward (I had a number of issues when I tried to start using it).
Repository:
rC Clang
https://reviews.ll
Anastasia added inline comments.
Comment at: include/clang/Basic/BuiltinsAMDGPU.def:49
+
+// FIXME: Need to disallow constant address space.
BUILTIN(__builtin_amdgcn_div_scale, "dddbb*", "n")
Do you plan to provide the support for it later? Or if else perhaps we
1 - 100 of 176 matches
Mail list logo
