r332909 - [X86] Remove a builtin that should have been removed in r332882.

Author: ctopper Date: Mon May 21 15:10:02 2018 New Revision: 332909 URL: http://llvm.org/viewvc/llvm-project?rev=332909&view=rev Log: [X86] Remove a builtin that should have been removed in r332882. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/test/CodeGen/builtins-x8

r332911 - Add missing x86-registered-target.

Author: pcc Date: Mon May 21 15:14:02 2018 New Revision: 332911 URL: http://llvm.org/viewvc/llvm-project?rev=332911&view=rev Log: Add missing x86-registered-target. Modified: cfe/trunk/test/Misc/cc1as-split-dwarf.s Modified: cfe/trunk/test/Misc/cc1as-split-dwarf.s URL: http://llvm.org/viewv

[PATCH] D46791: Make -gsplit-dwarf generally available

jakehehrlich added a comment. Yeah I haven't heard back from Lexan nor have I tried reproducing such a build myself and if we're that close to not relaying on this sort of hack I'd much rather wait on this than risk breaking someone for the sake of a stopgap for such a short period of time. @ec

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

george.karpenkov added a comment. @NoQ I'm really wary of magic numbers. - We should expose it through an analyzer-config flag. We already do so for the budget. - We should probably have both positive and negative tests. What scenarios _stop_ working after the threshold is decreased? [point 1 i

[PATCH] D46963: [Fixed Point Arithmetic] Test for All Builtin Operations

leonardchan updated this revision to Diff 147888. leonardchan added a comment. formatting Repository: rC Clang https://reviews.llvm.org/D46963 Files: lib/AST/ASTContext.cpp lib/CodeGen/CGExprScalar.cpp test/Frontend/fixed_point_all_builtin_operations.c Index: test/Frontend/fixed_point

[PATCH] D46791: Make -gsplit-dwarf generally available

pcc added a comment. There were a bunch of them but the last one was https://reviews.llvm.org/D47093 which has already landed :) Probably all that needs to happen on this change is to replace the isLinux() check with isELF(). https://reviews.llvm.org/D46791

[PATCH] D46791: Make -gsplit-dwarf generally available

echristo added a comment. In https://reviews.llvm.org/D46791#1107168, @pcc wrote: > There were a bunch of them but the last one was > https://reviews.llvm.org/D47093 which has already landed :) > > Probably all that needs to happen on this change is to replace the isLinux() > check with isELF()

[PATCH] D47164: Add missing include for cstdint to Visibility.h

teemperor created this revision. We use uint8_t in this header, so we need to include cstdint. Repository: rC Clang https://reviews.llvm.org/D47164 Files: include/clang/Basic/Visibility.h Index: include/clang/Basic/Visibility.h

[PATCH] D47164: Add missing include for cstdint to Visibility.h

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL332913: Add missing include for cstdint to Visibility.h (authored by teemperor, committed by ). Herald added a subscriber:

r332913 - Add missing include for cstdint to Visibility.h

Author: teemperor Date: Mon May 21 15:27:22 2018 New Revision: 332913 URL: http://llvm.org/viewvc/llvm-project?rev=332913&view=rev Log: Add missing include for cstdint to Visibility.h Summary: We use uint8_t in this header, so we need to include cstdint. Subscribers: cfe-commits Differential Re

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny updated this revision to Diff 147887. jdenny marked 2 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. Made a stab at the suggested changes. https://reviews.llvm.org/D46919 Files: include/clang-c/Index.h include/clang/AST/PrettyPrinter.h

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > The deprecated enumerator is also referenced by > > `tools/c-index-test/c-index-test.c` > > > This test prompted me to keep the IncludeTagDefiniti

[PATCH] D47135: [analyzer][WIP] A checker for dangling string pointers in C++

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DanglingStringPointerChecker.cpp:29 + +class DanglingStringPointerChecker : public Checker { + CallDescription CStrFn; "string" is a bit ambiguous, if this checker is specifically fo

[PATCH] D47135: [analyzer][WIP] A checker for dangling string pointers in C++

xbolva00 added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DanglingStringPointerChecker.cpp:29 + +class DanglingStringPointerChecker : public Checker { + CallDescription CStrFn; george.karpenkov wrote: > "string" is a bit ambiguous, if this checker

[PATCH] D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type

jakehehrlich added a comment. LGTM with a couple additions. Comment at: lib/CodeGen/CodeGenTypes.cpp:448 +case BuiltinType::ULongAccum: ResultType = llvm::IntegerType::get(getLLVMContext(), static_cast(Context.getTypeSize(T)));

[PATCH] D47157: Warning for framework headers using double quote includes

bruno added a comment. > See also PR22165. Nice, seems related to this indeed. Are you aware of any development along those lines in clang-tidy? We would like this to be part of clang and be used as part of the normal compiler workflow, it can surely be as well part of any clang-tidy related

[PATCH] D47166: use zeroinitializer for (trailing zero portion of) large array initializers more reliably

rsmith created this revision. rsmith added reviewers: rjmccall, sepavloff. Clang has two different ways it emits array constants (from `InitListExpr`s and from `APValue`s), and both had some ability to emit `zeroinitializer`, but neither was able to catch all cases where we could use `zeroinitia

[PATCH] D47157: Warning for framework headers using double quote includes

Eugene.Zelenko added a comment. >>> The warning is off by default. >> >> We typically do not add off-by-default warnings because experience has shown >> the rarely get enabled in practice. Can you explain a bit more about why >> this one is off by default? > > Right. I believe this is going to

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

rsmith added a comment. I've done some more investigation, and I now think this patch is merely working around deficiencies elsewhere. See https://reviews.llvm.org/D47166, which aims to fix those deficiencies more directly. Repository: rC Clang https://reviews.llvm.org/D46241 ___

[PATCH] D47155: [analyzer] Reduce simplifySVal complexity threshold further.

george.karpenkov added a comment. Also we should make sure that all recursive transformations on expressions represented as DAGs should be memoized. Repository: rC Clang https://reviews.llvm.org/D47155 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D46485: Add python tool to dump and construct header maps

dexonsmith added a comment. Removing the binary header map files is a clear win, but I'd like someone else to approve this. Comment at: test/Preprocessor/headermap-rel2.c:1-2 // This uses a headermap with this entry: // someheader.h -> Product/someheader.h --

[PATCH] D46485: Add python tool to dump and construct header maps

bruno updated this revision to Diff 147901. bruno added a comment. Remove more outdated comments https://reviews.llvm.org/D46485 Files: CMakeLists.txt test/CMakeLists.txt test/Modules/crash-vfs-headermaps.m test/Preprocessor/Inputs/headermap-rel/foo.hmap test/Preprocessor/Inputs/heade

[PATCH] D46979: [Fixed Point Arithmetic] Test for Conversion Between Valid Builtin Types

leonardchan updated this revision to Diff 147902. leonardchan added a comment. formatting Repository: rC Clang https://reviews.llvm.org/D46979 Files: include/clang/AST/OperationKinds.def lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp li

[PATCH] D46439: [Sema] Fix incorrect packed aligned structure layout

rsmith added a comment. In https://reviews.llvm.org/D46439#1106929, @probinson wrote: > This wouldn't be another layout/ABI breakage, would it? Yes, albeit for what I'd expect to be an extremely rare case. Repository: rC Clang https://reviews.llvm.org/D46439

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

rsmith added a comment. In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > The deprecated enumerator is also referenced by > > `tools/c-index-test/c-index-test.c` > > > This test prompted me to keep the IncludeTagDefiniti

[PATCH] D47099: Disable casting of alloca for ActiveFlag

yaxunl updated this revision to Diff 147914. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by John's comments. https://reviews.llvm.org/D47099 Files: lib/CodeGen/CGCall.cpp lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h tes

[PATCH] D46919: [libclang] Deprecate CXPrintingPolicy_IncludeTagDefinition

jdenny added a comment. In https://reviews.llvm.org/D46919#1107296, @rsmith wrote: > In https://reviews.llvm.org/D46919#1101268, @jdenny wrote: > > > In https://reviews.llvm.org/D46919#1100493, @rsmith wrote: > > > > > The deprecated enumerator is also referenced by > > > `tools/c-index-test/c-i

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, echristo, DavidKreitzer. Intel documents the 128-bit versions as being in emmintrin.h and the 256-bit version as being in immintrin.h. This patch makes a new __emmtrin_f16c.h to hold the 128-bit versions to be in

[PATCH] D47175: [DOXYGEN] Formatting changes for better intrinsics documentation rendering

kromanova created this revision. Herald added a subscriber: cfe-commits. Below are a few doxygen intrisics documentation changes requested by our documentation team: (1) I added some \see cross-references to a few select intrinsics that are related (and have the same or very similar semantics).

[PATCH] D47174: [X86] Move 128-bit f16c intrinsics to __emmintrin_f16c.h include from emmintrin.h. Move 256-bit f16c intrinsics back to f16cintrin.h

craig.topper added inline comments. Comment at: lib/Headers/immintrin.h:72 -/* The 256-bit versions of functions in f16cintrin.h. - Intel documents these as being in immintrin.h, and Interesting this to note here, the 256-bit f16c intrinsics were being guarde

[libcxx] r332927 - Deduction guides for the container adaptors - queue, stack, and priority_queue

Author: marshall Date: Mon May 21 18:57:53 2018 New Revision: 332927 URL: http://llvm.org/viewvc/llvm-project?rev=332927&view=rev Log: Deduction guides for the container adaptors - queue, stack, and priority_queue Added: libcxx/trunk/test/std/containers/container.adaptors/queue/queue.cons/de

r332929 - [X86] Prevent inclusion of __wmmintrin_aes.h and __wmmintrin_pclmul.h without including wmmintrin.h

Author: ctopper Date: Mon May 21 19:02:13 2018 New Revision: 332929 URL: http://llvm.org/viewvc/llvm-project?rev=332929&view=rev Log: [X86] Prevent inclusion of __wmmintrin_aes.h and __wmmintrin_pclmul.h without including wmmintrin.h Modified: cfe/trunk/lib/Headers/__wmmintrin_aes.h cfe/

[libcxx] r332931 - Missed the tests for the deduction guides for prority_queue

Author: marshall Date: Mon May 21 19:19:38 2018 New Revision: 332931 URL: http://llvm.org/viewvc/llvm-project?rev=332931&view=rev Log: Missed the tests for the deduction guides for prority_queue Added: libcxx/trunk/test/std/containers/container.adaptors/priority.queue/priqueue.cons/deduct.fa

[PATCH] D47103: Implement strip.invariant.group

amharc added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:778 + bool mayBeDynamicClass() const { +return !isCompleteDefinition() || isDynamicClass(); xbolva00 wrote: > maybeDynamicClass? > > https://github.com/llvm-mirror/llvm/search?utf

[PATCH] D47182: [X86] Move all Intel defined intrinsic includes into immintrin.h

craig.topper created this revision. craig.topper added reviewers: DavidKreitzer, echristo, RKSimon, rnk. This matches the Intel documentation which shows them available by importing immintrin.h. x86intrin.h also includes immintrin.h so anyone including x86intrin.h will still get them. This is d

<    1   2