[PATCH] D46665: [Itanium] Emit type info names with external linkage.

2018-05-16 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D46665#1102348, @rsmith wrote: > In https://reviews.llvm.org/D46665#1102290, @rjmccall wrote: > > > I believe static and dynamic linkers — at least on ELF and Mach-O — will > > always drop weak symbols for strong ones. Now, I think that isn'

[PATCH] D45900: CodeGen: Fix invalid bitcast for lifetime.start/end

2018-05-16 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D45900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D46452: [sanitizer] Don't add --export-dynamic for Myriad

2018-05-16 Thread Walter Lee via Phabricator via cfe-commits
waltl updated this revision to Diff 147233. waltl added a comment. Address CR comments Repository: rL LLVM https://reviews.llvm.org/D46452 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp Index: clang/lib/Driver/ToolChains/CommonArgs.cpp =

[PATCH] D46820: Fix __uuidof handling on non-type template parameter in C++17

2018-05-16 Thread Taiju Tsuiki via Phabricator via cfe-commits
tzik updated this revision to Diff 147238. Repository: rC Clang https://reviews.llvm.org/D46820 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/ms-uuid.cpp Index: test/SemaCXX/ms-uuid.cpp === --- test/SemaCXX/ms-uuid.cpp +++ t

[PATCH] D46820: Fix __uuidof handling on non-type template parameter in C++17

2018-05-16 Thread Taiju Tsuiki via Phabricator via cfe-commits
tzik marked an inline comment as done. tzik added inline comments. Comment at: test/SemaCXX/PR24986.cpp:12 + f<&__uuidof(0)>(); +} thakis wrote: > Maybe this test could be in test/SemaCXX/ms-uuid.cpp instead? OK, moved there. Repository: rC Clang https://re

[libcxx] r332571 - [libcxx] [test] Remove unused local typedef in test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp

2018-05-16 Thread Billy Robert O'Neal III via cfe-commits
Author: bion Date: Wed May 16 21:59:34 2018 New Revision: 332571 URL: http://llvm.org/viewvc/llvm-project?rev=332571&view=rev Log: [libcxx] [test] Remove unused local typedef in test/std/numerics/rand/rand.eng/rand.eng.lcong/default.pass.cpp Modified: libcxx/trunk/test/std/numerics/rand/rand

[PATCH] D46929: Fix a mangling failure on clang-cl C++17

2018-05-16 Thread Taiju Tsuiki via Phabricator via cfe-commits
tzik updated this revision to Diff 147244. Repository: rC Clang https://reviews.llvm.org/D46929 Files: lib/AST/VTableBuilder.cpp lib/CodeGen/CGCXX.cpp lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/PR37481.cpp Index: test/CodeGenCXX/PR37481.cpp ===

[PATCH] D46929: Fix a mangling failure on clang-cl C++17

2018-05-16 Thread Taiju Tsuiki via Phabricator via cfe-commits
tzik added a comment. In https://reviews.llvm.org/D46929#1101780, @rnk wrote: > I searched around, and I noticed that `VTableContext::getMethodVTableIndex` > has the same implied contract that the caller must always provide a canonical > declaration or things will break. It looks like it has th

[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

2018-05-16 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris created this revision. dberris added reviewers: dblaikie, echristo. This is related to http://llvm.org/PR32274. When building with XRay, always depend on a C++ standard library. We're doing this to automate the linking of the C++ ABI functionality that the modes use by default. In partic

r332576 - Fix rL332458: [AST] Added a helper to extract a user-friendly text of a comment.

2018-05-16 Thread Clement Courbet via cfe-commits
Author: courbet Date: Wed May 16 23:46:15 2018 New Revision: 332576 URL: http://llvm.org/viewvc/llvm-project?rev=332576&view=rev Log: Fix rL332458: [AST] Added a helper to extract a user-friendly text of a comment. Older gcc versions do not support raw string literals within macros. Modified:

<    1   2   3