[PATCH] D45463: [AST] Print correct tag decl for tag specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rC332281: [AST] Print correct tag decl for tag specifier (authored by jdenny, committed by ). Changed prior to commit: https://reviews.llvm.org/D45463?vs=146351&id=146658#toc Repository: rL LLVM https

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

This revision was automatically updated to reflect the committed changes. jdenny marked an inline comment as done. Closed by commit rL332281: [AST] Print correct tag decl for tag specifier (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[libcxx] r332282 - Update XFAIL so apple-clang-9.0 is the last version not implementing Core 2094.

Author: vsapsai Date: Mon May 14 12:45:24 2018 New Revision: 332282 URL: http://llvm.org/viewvc/llvm-project?rev=332282&view=rev Log: Update XFAIL so apple-clang-9.0 is the last version not implementing Core 2094. The test is passing with apple-clang-9.1. rdar://problem/40222003 Modified: l

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

thakis accepted this revision. thakis added inline comments. This revision is now accepted and ready to land. Comment at: test/Index/complete-and-plugins.c:3 + +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns

r332284 - [clang-format] Move #include related style to libToolingCore

Author: ioeric Date: Mon May 14 12:51:33 2018 New Revision: 332284 URL: http://llvm.org/viewvc/llvm-project?rev=332284&view=rev Log: [clang-format] Move #include related style to libToolingCore Summary: This will be shared by include insertion/deletion library. Reviewers: ilya-biryukov Reviewed

[PATCH] D46758: [clang-format] Move #include related style to libToolingCore

This revision was automatically updated to reflect the committed changes. Closed by commit rL332284: [clang-format] Move #include related style to libToolingCore (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46758 F

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

ioeric updated this revision to Diff 14. ioeric added a comment. - Merged with origin/master - Make copy instead of taking references to ensure lifetime. Repository: rC Clang https://reviews.llvm.org/D46496 Files: include/clang/Format/Format.h include/clang/Tooling/Core/HeaderInclude

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

jdenny updated this revision to Diff 146668. jdenny added a comment. Rebased. Ping. https://reviews.llvm.org/D45465 Files: lib/AST/DeclPrinter.cpp test/Misc/ast-print-enum-decl.c test/Misc/ast-print-record-decl.c test/Sema/ast-print.c test/SemaCXX/ast-print.cpp Index: test/SemaCXX/a

r332286 - PR37450: Fix bug that disabled some type checks for variables with deduced types.

Author: rsmith Date: Mon May 14 13:15:04 2018 New Revision: 332286 URL: http://llvm.org/viewvc/llvm-project?rev=332286&view=rev Log: PR37450: Fix bug that disabled some type checks for variables with deduced types. Also improve diagnostic for the case where a type is non-literal because it's a

[PATCH] D46496: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332287: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews

r332287 - [Tooling] Pull #include manipulation code from clangFormat into libToolingCore.

Author: ioeric Date: Mon May 14 13:17:53 2018 New Revision: 332287 URL: http://llvm.org/viewvc/llvm-project?rev=332287&view=rev Log: [Tooling] Pull #include manipulation code from clangFormat into libToolingCore. Summary: Also pull #include related style out of FormatStyle as tooling::IncludeSty

r332288 - Remove the fixit for the diagnostics regarding capturing autoreleasing variables in a block

Author: george.karpenkov Date: Mon May 14 13:29:16 2018 New Revision: 332288 URL: http://llvm.org/viewvc/llvm-project?rev=332288&view=rev Log: Remove the fixit for the diagnostics regarding capturing autoreleasing variables in a block The fixit is actively harmful, as it encourages developers to

[PATCH] D46846: [Attr] Fix printing attrs for enum forward decl at file scope

jdenny created this revision. jdenny added reviewers: aaron.ballman, rsmith, hfinkel. For example, given: enum __attribute__((deprecated)) T *p; -ast-print produced: enum T *p; The trouble was that the EnumDecl node was suppressed, as revealed by -ast-dump. The suppression of the EnumDecl

[PATCH] D46497: [clangd] Populate #include insertions as additional edits in completion items.

ioeric updated this revision to Diff 146675. ioeric marked 7 inline comments as done. ioeric added a comment. - Addressed review comments. - Merged with origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46497 Files: clangd/ClangdServer.cpp clangd/CodeComplete.cpp

[PATCH] D45927: [clang-tidy] [modernize-use-auto] Correct way to calculate a type name length for multi-token types

zinovy.nis updated this revision to Diff 146677. zinovy.nis added a comment. - Fix for templated type names. Thanks AlexanderK for pointing. https://reviews.llvm.org/D45927 Files: clang-tidy/modernize/UseAutoCheck.cpp docs/clang-tidy/checks/modernize-use-auto.rst test/clang-tidy/modernize

r332291 - Fix regression in r332076.

Author: rsmith Date: Mon May 14 13:52:48 2018 New Revision: 332291 URL: http://llvm.org/viewvc/llvm-project?rev=332291&view=rev Log: Fix regression in r332076. If the name after 'template' is an unresolved using declaration (not containing 'typename'), then we don't yet know if it's a valid templ

r332294 - Fix test fail on some buildbots, caused by r332281.

Author: jdenny Date: Mon May 14 14:06:04 2018 New Revision: 332294 URL: http://llvm.org/viewvc/llvm-project?rev=332294&view=rev Log: Fix test fail on some buildbots, caused by r332281. Modified: cfe/trunk/test/Misc/ast-print-record-decl.c Modified: cfe/trunk/test/Misc/ast-print-record-decl.c

[PATCH] D46446: [c++17] Fix assertion on synthesizing deduction guides after a fatal error.

vsapsai added a comment. Ping. https://reviews.llvm.org/D46446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46846: [Attr] Fix printing attrs for enum forward decl at file scope

rsmith added a comment. Clang's current behavior is observably wrong in MS compatibility mode. For example: namespace N { enum E *p; exterm E e; // ok, finds E injected into scope by previous declaration } N::E e; // error, no E in N! namespace N { extern E e; // error, no E

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

rsmith added inline comments. Comment at: lib/AST/DeclPrinter.cpp:393-397 if (!BaseType.isNull() && isa(BaseType)) BaseType = cast(BaseType)->getNamedType(); if (!BaseType.isNull() && isa(BaseType) && - cast(BaseType)->getDecl() == Decls[0]) { +

r332300 - [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well

Author: george.karpenkov Date: Mon May 14 14:39:54 2018 New Revision: 332300 URL: http://llvm.org/viewvc/llvm-project?rev=332300&view=rev Log: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well A common pattern is that the code in the block does not write into the varia

[PATCH] D46446: [c++17] Fix assertion on synthesizing deduction guides after a fatal error.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D46446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D46772: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well

This revision was automatically updated to reflect the committed changes. Closed by commit rC332300: [analyzer] Extend the ObjCAutoreleaseWriteChecker to warn on captures as well (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https:/

[PATCH] D46187: [Analyzer] getRegisteredCheckers(): handle debug checkers too.

NoQ added a comment. In https://reviews.llvm.org/D46187#1089087, @lebedev.ri wrote: > > I believe we could also benefit from a method of extracting the analyzer's > > `clang -cc1` run-line from clang-tidy. This would allow arbitrary debugging > > over a single analyzer invocation. > > I'm not r

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 146698. yunlian edited the summary of this revision. yunlian added a comment. Herald added subscribers: JDevlieghere, aprantl. Use the option -gsplit-dwarf to make it more consistent. https://reviews.llvm.org/D44788 Files: include/clang/Driver/Options.td

[PATCH] D44934: [analyzer] Improve the modeling of `memset()`.

NoQ added a comment. Thank you! Looks good overall. Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1013-1014 + + // Get the offset and the base region to figure out whether the offset of + // buffer is 0. + RegionOffset Offset = MR->getAsOffset(); ---

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! I'll commit again. https://reviews.llvm.org/D45177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D45177: CStringChecker, check strlcpy/strlcat

This revision was automatically updated to reflect the committed changes. Closed by commit rC332303: [analyzer] Re-apply r331096 "CStringChecker: Add support for BSD strlcpy()...". (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D45177 Files: lib/Static

r332303 - [analyzer] Re-apply r331096 "CStringChecker: Add support for BSD strlcpy()...".

Author: dergachev Date: Mon May 14 15:32:24 2018 New Revision: 332303 URL: http://llvm.org/viewvc/llvm-project?rev=332303&view=rev Log: [analyzer] Re-apply r331096 "CStringChecker: Add support for BSD strlcpy()...". Fixed after revert in r331401. Patch by David Carlier! Differential Revision: h

[PATCH] D46845: [libcxx][c++17] P0083R5: Splicing Maps and Sets

rsmith added a comment. How do you deal with the fact that node handles for map-like types need to be able to mutate a const member of a `pair` in-place? Are you assuming/hoping the compiler won't do bad things to the program as a result, or is there some reason why it would be unlikely to do s

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

jdenny updated this revision to Diff 146709. jdenny marked 2 inline comments as done. jdenny added a comment. Made the suggested change. Thanks! https://reviews.llvm.org/D45465 Files: lib/AST/DeclPrinter.cpp test/Misc/ast-print-enum-decl.c test/Misc/ast-print-record-decl.c test/Sema/as

r332307 - [c++17] Fix assertion on synthesizing deduction guides after a fatal error.

Author: vsapsai Date: Mon May 14 15:49:44 2018 New Revision: 332307 URL: http://llvm.org/viewvc/llvm-project?rev=332307&view=rev Log: [c++17] Fix assertion on synthesizing deduction guides after a fatal error. After a fatal error Sema::InstantiatingTemplate doesn't allow further instantiation and

[PATCH] D46446: [c++17] Fix assertion on synthesizing deduction guides after a fatal error.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332307: [c++17] Fix assertion on synthesizing deduction guides after a fatal error. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D46446: [c++17] Fix assertion on synthesizing deduction guides after a fatal error.

vsapsai added a comment. Thanks for the review. Repository: rL LLVM https://reviews.llvm.org/D46446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks. It strikes me that this will still lead to inconsistencies. For example, I expect this: struct A { struct B *a, *b; struct B *c, *d; }; ... to print as: struct A {

[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

pfultz2 updated this revision to Diff 146719. pfultz2 added a comment. Rebased https://reviews.llvm.org/D46159 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D46834: [Sema][Cxx17] Error message for C++17 static_assert(pred) without string literal

rsmith added a comment. This would violate our guidelines for diagnostic messages; see https://clang.llvm.org/docs/InternalsManual.html#the-format-string In particular: "Take advantage of location information. The user will be able to see the line and location of the caret, so you don’t need to

r332310 - Enable control flow pruning of float overflow warnings.

Author: rtrieu Date: Mon May 14 16:21:48 2018 New Revision: 332310 URL: http://llvm.org/viewvc/llvm-project?rev=332310&view=rev Log: Enable control flow pruning of float overflow warnings. Like other conversion warnings, allow float overflow warnings to be disabled in known dead paths of template

[PATCH] D46823: [analyzer] const init: handle non-explicit cases more accurately

NoQ added a comment. Yay thanks! I think some cornercases would need to be dealt with. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1650 + +// If there is a list, but no init, it must be zero. +if (i >= InitList->getNumInits()) N

[PATCH] D46822: [RISCV] Add driver for riscv32-unknown-elf baremetal target

efriedma added a comment. Could you include some documentation for how to construct a baremetal environment like the one this code expects? It's not clear what exactly you expect to be installed where. Repository: rC Clang https://reviews.llvm.org/D46822

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

jdenny added a comment. In https://reviews.llvm.org/D45465#1098710, @rsmith wrote: > Looks good, thanks. Thanks. > It strikes me that this will still lead to inconsistencies. For example, I > expect this: > > struct A { struct B *a, *b; struct B *c, *d; }; > > > ... to print as: > > s

[PATCH] D46485: Add python tool to dump and construct header maps

bruno added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D46485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r332314 - [AST] Fix printing tag decl groups in decl contexts

Author: jdenny Date: Mon May 14 17:44:14 2018 New Revision: 332314 URL: http://llvm.org/viewvc/llvm-project?rev=332314&view=rev Log: [AST] Fix printing tag decl groups in decl contexts For example, given: struct T1 { struct T2 *p0; }; -ast-print produced: struct T1 { struct T2;

[PATCH] D45465: [AST] Fix printing tag decl groups in decl contexts

This revision was automatically updated to reflect the committed changes. Closed by commit rL332314: [AST] Fix printing tag decl groups in decl contexts (authored by jdenny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45465?vs=1467

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

kent08ian added a comment. In https://reviews.llvm.org/D10833#970906, @milianw wrote: > still looks good to me. can someone else please review and commit this? Any updates on this? This feature will be very helpful. :) Repository: rC Clang https://reviews.llvm.org/D10833 ___

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

Quuxplusone added a comment. In https://reviews.llvm.org/D45766#1097797, @ksu.shadura wrote: > Thank you for the test example! I got your point, but I wanted to ask if it > should be like this for commutative operations? > In our case it is actually matrix, and subtraction of matrices is not >

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

shiva0217 updated this revision to Diff 146737. shiva0217 added a comment. Rebase patch to https://reviews.llvm.org/D45465 Repository: rL LLVM https://reviews.llvm.org/D44888 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-features.c Inde

[PATCH] D44888: [RISCV] Default enable linker relaxation and add -mrelax, -mno-relax flags

shiva0217 added inline comments. Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:130 + // which may override the defaults. + handleTargetFeaturesGroup(Args, Features, options::OPT_m_riscv_Features_Group); } kito-cheng wrote: > This part should move to the b

r332322 - [X86] Revert part of r332266: Use __builtin_convertvector to replace some of the avx512 truncate builtins.

Author: ctopper Date: Mon May 14 20:17:52 2018 New Revision: 332322 URL: http://llvm.org/viewvc/llvm-project?rev=332322&view=rev Log: [X86] Revert part of r332266: Use __builtin_convertvector to replace some of the avx512 truncate builtins. The masking doesn't work right in the backend for the o

[libclc] r332324 - rootn: Use denormal path only

Author: jvesely Date: Mon May 14 21:22:43 2018 New Revision: 332324 URL: http://llvm.org/viewvc/llvm-project?rev=332324&view=rev Log: rootn: Use denormal path only It's OK to either flush to 0 or return denormal result if the device does not support denormals. See sec 7.2 and 7.5.3 of OCL specs U

[PATCH] D46834: [Sema][Cxx17] Error message for C++17 static_assert(pred) without string literal

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. The code looks correct to me, although I have a few suggestions inline. When you resubmit, please include full context (e.g., `git diff -U99`). Jan and I discussed this

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

xazax.hun added inline comments. Comment at: include/clang/CrossTU/CrossTranslationUnit.h:117 - /// This function loads a function definition from an external AST - ///file. + /// \brief This function loads a definition from an external AST file. /// -

[PATCH] D46862: Optionally add code completion results for arrow instead of dot (libclang)

yvvan created this revision. yvvan added reviewers: ilya-biryukov, klimek, bkramer, arphaman. Follow up for https://reviews.llvm.org/D41537 - libclang part is extracted into this review https://reviews.llvm.org/D46862 Files: include/clang-c/Index.h test/Index/complete-arrow-dot.cpp tools

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan updated this revision to Diff 146749. yvvan marked 2 inline comments as done. yvvan added a comment. Only C++ part, libclang part has moved to https://reviews.llvm.org/D46862 https://reviews.llvm.org/D41537 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/CodeCompl

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:4118 + : diag::err_typecheck_member_reference_suggestion; + Diag(OpLoc, DiagID) << ConvertedBaseType << IsArrow + << Base->getSourceRange() << FixIt;

[PATCH] D46863: [X86] Use __builtin_convertvector to implement some of the packed integer to packed flow conversion intrinsics.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. I believe this is safe assuming default rounding mode. The conversion might be inexact, but it can never overflow the FP type so this shouldn't be undefined behavior for the uitofp/sitofp instructions. We already

[PATCH] D46398: [ASTImporterTest] Fix potential use-after-free

a.sidorin closed this revision. a.sidorin added a comment. Closed with https://reviews.llvm.org/rC332256. Repository: rC Clang https://reviews.llvm.org/D46398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

<    1   2