aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/fuchsia-restrict-system-includes.rst:32
+ A string containing a semi-colon separated list of allowed include
filenames.
+ The default is an empty string, which allows all includes.
julie
chandlerc added a comment.
Sorry folks, but you can't just take patches to libstdc++ and apply them to
libc++.
These libraries have different licenses, and so the author of the patch
(Jonathan Wakely in this case) need's to *explicitly* contribute that patch to
libc++ under libc++'s license. (
ioeric added a comment.
Thanks for adding the tests!
Comment at: include/clang/AST/RawCommentList.h:138
+ /// the overload with ASTContext in the rest of the code.
+ std::string getFormattedText(const SourceManager &SourceMgr,
+ DiagnosticsEngine
xbolva00 added a comment.
Ping @jwakely
Repository:
rCXX libc++
https://reviews.llvm.org/D46593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 146004.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D46176
Files:
include/clang/Basic/SourceManager.h
lib/Basic/SourceManager.cpp
lib/Format/Format.cpp
l
Author: ioeric
Date: Wed May 9 14:35:52 2018
New Revision: 331923
URL: http://llvm.org/viewvc/llvm-project?rev=331923&view=rev
Log:
Add SourceManagerForFile helper which sets up SourceManager and dependencies
for a single file with code snippet
Summary: This can be used to create a virtual envi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331923: Add SourceManagerForFile helper which sets up
SourceManager and dependencies… (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.l
Author: manojgupta
Date: Wed May 9 14:41:18 2018
New Revision: 331925
URL: http://llvm.org/viewvc/llvm-project?rev=331925&view=rev
Log:
[Clang] Implement function attribute no_stack_protector.
Summary:
This attribute tells clang to skip this function from stack protector
when -stack-protector op
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331925: [Clang] Implement function attribute
no_stack_protector. (authored by manojgupta, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46300?vs=145988&id=146008#toc
Repository:
ioeric updated this revision to Diff 146012.
ioeric added a comment.
- Merged with origin/master
Repository:
rC Clang
https://reviews.llvm.org/D46496
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/HeaderIncludes.h
lib/Format/Format.cpp
lib/Tooling/Core/CMakeLists.txt
Author: manojgupta
Date: Wed May 9 15:05:53 2018
New Revision: 331928
URL: http://llvm.org/viewvc/llvm-project?rev=331928&view=rev
Log:
Update pragma-attribute-supported-attributes-list.test.
Update the test to include the new attribute NoStackProtector
to fix the build fails.
Modified:
cfe
HI,
ASan says there is a use-after-free after this change:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/5410/steps/check-clang%20asan/logs/stdio
MSan also sees a problem, but ASan's is likely closer to the root cause:
http://lab.llvm.org:8011/builders/sanitizer-x86_64
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExprConstant.cpp:1413
+ } else if (!Init->isEvaluatable(CE.CGM.getContext())) {
+return false;
+ } else if (InitTy->hasPointerRepresentation()) {
sepavloff wrote:
> rsmith wrote:
> > sepavloff wrote:
Author: juliehockett
Date: Wed May 9 15:25:42 2018
New Revision: 331930
URL: http://llvm.org/viewvc/llvm-project?rev=331930&view=rev
Log:
[clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module
Adding a check to restrict system includes to a whitelist. Given a list
of includes that ar
Author: juliehockett
Date: Wed May 9 15:25:43 2018
New Revision: 331931
URL: http://llvm.org/viewvc/llvm-project?rev=331931&view=rev
Log:
Revert "[tools] Updating PPCallbacks::InclusionDirective calls"
This reverts commit r331905, since it's dependent on reverted r331905.
Modified:
clang-to
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE331930: [clang-tidy] Adding RestrictSystemIncludes check
to Fuchsia module (authored by juliehockett, committed by ).
R
Author: juliehockett
Date: Wed May 9 15:25:47 2018
New Revision: 331932
URL: http://llvm.org/viewvc/llvm-project?rev=331932&view=rev
Log:
Revert "[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective"
This reverts commit r331904 because of a memory leak.
Modified:
cfe/trunk/i
Reverted, found the memory leak and will put up a patch to fix it & reland
in a bit. Thanks!
On Wed, May 9, 2018 at 3:13 PM Evgenii Stepanov
wrote:
> HI,
>
> ASan says there is a use-after-free after this change:
>
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/5410/
adr26 created this revision.
adr26 added a reviewer: rnk.
adr26 added a project: clang.
Herald added a subscriber: cfe-commits.
Ensure latest MPT decl has a MSInheritanceAttr when instantiating templates, to
avoid null MSInheritanceAttr deref in CXXRecordDecl::getMSInheritanceModel().
See PR#373
Author: juliehockett
Date: Wed May 9 15:28:18 2018
New Revision: 331934
URL: http://llvm.org/viewvc/llvm-project?rev=331934&view=rev
Log:
Revert "[clang-tidy] Adding RestrictSystemIncludes check to Fuchsia module"
This reverts commit r331930, which was landed by accident.
Removed:
clang-too
juliehockett reopened this revision.
juliehockett added a comment.
Sorry, branches got crossed. Reverted and reopened.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
rnk updated this revision to Diff 146025.
rnk added a comment.
- don't expose CCEK, use a bool
https://reviews.llvm.org/D43320
Files:
clang/include/clang/AST/Expr.h
clang/lib/AST/ExprConstant.cpp
clang/lib/Sema/SemaOverload.cpp
clang/test/SemaCXX/dllimport-constexpr.cpp
clang/test/Sem
rnk added inline comments.
Comment at: clang/include/clang/AST/Expr.h:670-672
+ /// Evaluate an expression that is required to be a core constant expression.
+ bool EvaluateAsCoreConstExpr(EvalResult &Result, QualType ParamType,
+ CCEKind CCE, cons
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331938: [CUDA] Added -f[no-]cuda-short-ptr option (authored
by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46148?vs=144419&id=146027#
Author: tra
Date: Wed May 9 16:10:09 2018
New Revision: 331938
URL: http://llvm.org/viewvc/llvm-project?rev=331938&view=rev
Log:
[CUDA] Added -f[no-]cuda-short-ptr option
The option enables use of 32-bit pointers for accessing
const/local/shared memory. The feature is disabled by default.
Diffe
jwakely added a comment.
@chandlerc thanks for catching this.
As the original author I agree to contribute this patch to libc++ under the
terms of the MIT and the University of Illinois licences, and under the terms
of "Apache 2 with LLVM exception" if necessary in future.
This permission appl
EricWF created this revision.
EricWF added reviewers: rsmith, rjmccall, majnemer, vsapsai.
The Itanium ABI requires that the type info for pointer-to-incomplete types to
have internal linkage, so that it doesn't interfere with the type info once
completed. Currently it also marks the type info
chandlerc added a comment.
In https://reviews.llvm.org/D46593#1093758, @jwakely wrote:
> @chandlerc thanks for catching this.
>
> As the original author I agree to contribute this patch to libc++ under the
> terms of the MIT and the University of Illinois licences, and under the terms
> of "Apa
rsmith added inline comments.
Comment at: clang/include/clang/AST/Expr.h:670-672
+ /// Evaluate an expression that is required to be a core constant expression.
+ bool EvaluateAsCoreConstExpr(EvalResult &Result, QualType ParamType,
+ CCEKind CCE, c
juliehockett updated this revision to Diff 146032.
juliehockett added a comment.
Reverted because of memory leak in PPCallbacksTest, this fixes it.
https://reviews.llvm.org/D46614
Files:
include/clang/Lex/PPCallbacks.h
include/clang/Lex/PreprocessingRecord.h
lib/CodeGen/MacroPPCallbacks.c
EricWF updated this revision to Diff 146034.
EricWF added a comment.
- Correct copy-paste error.
https://reviews.llvm.org/D46665
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/rtti-linkage.cpp
Index: test/CodeGenCXX/rtti-linkage.cpp
===
rsmith added inline comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3033
+ return {llvm::GlobalValue::InternalLinkage,
+ llvm::GlobalValue::LinkOnceODRLinkage};
+return {llvm::GlobalValue::InternalLinkage,
Shouldn't this be based on the
Author: ctopper
Date: Wed May 9 17:05:13 2018
New Revision: 331943
URL: http://llvm.org/viewvc/llvm-project?rev=331943&view=rev
Log:
[Builtins] Improve the IR emitted for MSVC compatible rotr/rotl builtins to
match what the middle and backends understand
Previously we emitted something like
ro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331943: [Builtins] Improve the IR emitted for MSVC
compatible rotr/rotl builtins to… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
mikerice created this revision.
mikerice added reviewers: Anastasia, ABataev, erichkeane, cfe-commits.
Herald added subscribers: guansong, yaxunl.
Compiler crashes when omp simd is used in an OpenCL file:
clang -c -fopenmp omp_simd.cl
__kernel void test(__global int *data, int size) {
#pragma
Author: xbolva00
Date: Wed May 9 11:57:17 2018
New Revision: 331910
URL: http://llvm.org/viewvc/llvm-project?rev=331910&view=rev
Log:
Allow copy elision in path concatenation
Summary:
Just port of libstdc++'s fix to libc++ fs:
https://github.com/gcc-mirror/gcc/commit/e6ac4004fe49d785c63bf87aec4
rnk updated this revision to Diff 146039.
rnk added a comment.
- getting closer
https://reviews.llvm.org/D43320
Files:
clang/include/clang/AST/Expr.h
clang/lib/AST/ExprConstant.cpp
clang/lib/Sema/SemaOverload.cpp
clang/test/SemaCXX/dllimport-constexpr.cpp
clang/test/SemaCXX/dllimport-
rnk added inline comments.
Comment at: clang/include/clang/AST/Expr.h:662
+ /// Indicates how the constant expression will be used.
+ enum ConstExprUsage { EvaluateForCodeGen, EvaluateForMangling };
+
I expect we could come up with a better name, but is this cl
rnk added a comment.
Is it possible to fix this in assignInheritanceModel instead? I'd imagine we'd
get the most recent decl. If that's not the issue, maybe you're fixing the bug
in the right spot, but we need to find out where other class template
attributes are moved from instantiation to rea
ABataev added a comment.
1. Is this allowed to use OpenMP for OpenCL programs at all?
2. If it is allowed, I think it would be better to set the TypeSourceInfo for
the artificial variable
Repository:
rC Clang
https://reviews.llvm.org/D46667
___
ABataev added a comment.
BTW, the test itself does not check anything.
Repository:
rC Clang
https://reviews.llvm.org/D46667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 146042.
ioeric added a comment.
- Merged with origin/master
Repository:
rC Clang
https://reviews.llvm.org/D46496
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/HeaderIncludes.h
lib/Format/Format.cpp
lib/Tooling/Core/CMakeLists.txt
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/AST/ExprConstant.cpp:1871-1902
if (!CheckConstantExpression(Info, DiagLoc, EltTy,
Value.getArrayInitializ
EricWF marked an inline comment as done.
EricWF added a comment.
@rsmith What should the visibility of the type name be in cases where the type
info is hidden?
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3033
+ return {llvm::GlobalValue::InternalLinkage,
+ llvm
ioeric added a comment.
In https://reviews.llvm.org/D46497#1089755, @sammccall wrote:
> I'm concerned about the scope of this patch - it does too many things and
> touches too many files for me to feel comfortable that I understand it well
> enough to review.
> Is it possible to split it up? (
ioeric updated this revision to Diff 146045.
ioeric marked 15 inline comments as done.
ioeric added a comment.
- Merged with origin/master
- Address review comments.
- Revert unintended change.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdLSPServer
ioeric updated this revision to Diff 146046.
ioeric added a comment.
- Minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, MaskRay, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46670
Files:
clangd/ClangdLSPServer.cpp
clangd/SourceCode.cpp
clangd/SourceCode.h
Index: c
EricWF updated this revision to Diff 146053.
EricWF marked an inline comment as done.
EricWF added a comment.
Address @rsmith's inline comments.
- Calculate the linkage for the type name using the linkage for the type.
- Promote the type name visibility for the incomplete class types as well as
jfb added a comment.
In https://reviews.llvm.org/D42933#1093503, @smeenai wrote:
> Yeah, I think we all agree now that a portability warning isn't really
> tractable. Note that even for the warnings that motivated this diff, they
> should have only fired if `size_t` and NSInteger had separate t
rjmccall added inline comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3098
+InfoLinkage = getTypeInfoLinkage(CGM, Ty);
+NameLinkage = getTypeInfoLinkage(CGM, Ty, /*ForName*/ true);
+ }
I think we could probably just have the function return both inst
rjmccall added inline comments.
Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3098
+InfoLinkage = getTypeInfoLinkage(CGM, Ty);
+NameLinkage = getTypeInfoLinkage(CGM, Ty, /*ForName*/ true);
+ }
rjmccall wrote:
> I think we could probably just have the functio
mikerice added a comment.
1. It probably makes sense to allow omp simd with OpenCL. Some people here
have been successfully using it anyway.
2. I can give that a try.
The test just tests that the compiler doesn't segfault. What would you prefer
instead, something that checks the AST or the co
apazos added a comment.
Thanks for updating the patch, @spetrovic.
Can we have this committed?
This patch has shown to produce code size improvements for a number of targets
(Mips, X86, ARM, RISC-V).
https://reviews.llvm.org/D39053
___
cfe-commits
asb added a comment.
Just wanted to explicitly say that I'm happy the updated patch reflects the
changes to docs and comments I requested. @hfinkel - are you happy for this to
land now?
https://reviews.llvm.org/D39053
___
cfe-commits mailing list
EricWF updated this revision to Diff 146065.
EricWF marked 3 inline comments as done.
EricWF added a comment.
Address @rjmccall's comments.
https://reviews.llvm.org/D46665
Files:
lib/CodeGen/ItaniumCXXABI.cpp
test/CodeGenCXX/rtti-linkage.cpp
Index: test/CodeGenCXX/rtti-linkage.cpp
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks really good, thanks.
https://reviews.llvm.org/D46665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
EricWF added a comment.
@rjmccall Thank you for the quick review!
https://reviews.llvm.org/D46665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed May 9 22:25:15 2018
New Revision: 331957
URL: http://llvm.org/viewvc/llvm-project?rev=331957&view=rev
Log:
[Itanium] Emit type info names with external linkage.
Summary:
The Itanium ABI requires that the type info for pointer-to-incomplete types to
have internal linkage
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331957: [Itanium] Emit type info names with external
linkage. (authored by EricWF, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46665?vs=146065&id=146069#toc
Repository:
rC Clan
Author: ctopper
Date: Wed May 9 22:43:43 2018
New Revision: 331958
URL: http://llvm.org/viewvc/llvm-project?rev=331958&view=rev
Log:
[X86] Change the implementation of scalar masked load/store intrinsics to not
use a 512-bit intermediate vector.
This is unnecessary for AVX512VL supporting CPUs
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46675
Files:
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/Headers.cpp
clang
101 - 162 of 162 matches
Mail list logo
