[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

lebedev.ri added a comment. Also, please upload the correct patch, from the root of the repo, not from the directory of the file. Repository: rC Clang https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D46393: Remove explicit cfg-temporary-dtors=true

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Just curious - did these flags bother you? Cause we never really care about cleaning up run lines after flipping the flag, so we have a lot of such stale flags in our tests. We could start

[PATCH] D46050: [Frontend] Avoid running plugins during code completion parse

thakis added inline comments. Comment at: test/Frontend/plugins.c:7 + +// RUN: c-index-test -code-completion-at=%s:6:1 -load %llvmshlibdir/PrintFunctionNames%pluginext -add-plugin print-fns %s | FileCheck -check-prefix=CHECK-COMPLETION-WITHOUT-PLUGINS %s +// REQUIRES: plugins,

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

lebedev.ri added a comment. Test? Repository: rC Clang https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

pfultz2 added inline comments. Comment at: clang-tidy/ClangTidyOptions.h:80-82 + /// \brief Turns on experimental alpha checkers from the static analyzer. + llvm::Optional AllowEnablingAlphaChecks; + alexfh wrote: > Since this will only be configurable via a fl

[PATCH] D46159: [clang-tidy] Add a flag to enable alpha checkers

pfultz2 updated this revision to Diff 145072. pfultz2 added a comment. Rename flag to `AllowEnablingAnalyzerAlphaCheckers`. https://reviews.llvm.org/D46159 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h clang-tidy/tool/ClangTidyMain.cpp t

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

vsk requested changes to this revision. vsk added a comment. This revision now requires changes to proceed. Toolchain vendors aren't currently required to provide default blacklists for every sanitizer clang supports. We don't ship a default ubsan blacklist on macOS, so this patch would break ub

[PATCH] D46049: [OpenCL] Add constant address space to __func__ in AST

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks! https://reviews.llvm.org/D46049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice updated this revision to Diff 145073. cmtice added a comment. Tried to upload the diff from the correct location. https://reviews.llvm.org/D46403 Files: lib/Driver/SanitizerArgs.cpp Index: lib/Driver/SanitizerArgs.cpp ==

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

delena added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3098 + case AtomicExpr::AO__atomic_fetch_umax: +IsMinMax = true; +Form = Arithmetic; jfb wrote: > Should `__sync_fetch_and_min` and others also set `IsMinMax`? __sync_fetch_and_min is no

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

cmtice added a comment. Ok, I'll work on making this CFI-specific and adding a test case. https://reviews.llvm.org/D46403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

vsk added a comment. In https://reviews.llvm.org/D46403#1086923, @cmtice wrote: > Ok, I'll work on making this CFI-specific and adding a test case. Sounds good, thanks! I'd suggest modifying test/Driver/fsanitize-blacklist.c for your purposes. It should be possible to pair an empty resource di

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny updated this revision to Diff 145078. jdenny edited the summary of this revision. jdenny added a comment. Rebased. Added example to summary. Ping. https://reviews.llvm.org/D45093 Files: include/clang/AST/ASTContext.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Sema/Se

[PATCH] D45835: Add new driver mode for dumping compiler options

aaron.ballman updated this revision to Diff 145077. aaron.ballman added a comment. Updated to remove the contentious parts, though I still hope to add those back in. https://reviews.llvm.org/D45835 Files: include/clang/Basic/Features.def include/clang/Driver/CC1Options.td include/clang/F

[PATCH] D46406: [docs] Fix typos in the Clang User's Manual.

jgalenson created this revision. jgalenson added reviewers: hans, sylvestre.ledru. Repository: rC Clang https://reviews.llvm.org/D46406 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs/UsersManual.rst +++ d

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222 + [MatchedDecl](std::string const &s) { +return s == MatchedDecl->getName(); + })) { benhamilton wrote: > `s` is a reg

[PATCH] D45931: [ASTMatchers] Don't garble the profiling output when multiple TU's are processed

lebedev.ri added a comment. In https://reviews.llvm.org/D45931#1086665, @alexfh wrote: > In https://reviews.llvm.org/D45931#1084503, @lebedev.ri wrote: > > > In https://reviews.llvm.org/D45931#1083192, @lebedev.ri wrote: > > > > > Thank you for looking at this. > > > > > > In https://reviews.llvm

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:1002 + return EmitFinalDestCopy( + E->getType(), CGF.MakeNaturalAlignAddrLValue(Select, E->getType())); +} rjmccall wrote: > Is there something in Sema actually validating that the comparis

r331482 - [CodeGenFunction] Use the StringRef::split function that takes a char separator instead of StringRef separator. NFC

Author: ctopper Date: Thu May 3 14:01:33 2018 New Revision: 331482 URL: http://llvm.org/viewvc/llvm-project?rev=331482&view=rev Log: [CodeGenFunction] Use the StringRef::split function that takes a char separator instead of StringRef separator. NFC The char separator version should be a little

r331483 - [X86] Make __builtin_ia32_directstore_u32 and __builtin_ia32_movdir64b 'nothrow'

Author: ctopper Date: Thu May 3 14:01:35 2018 New Revision: 331483 URL: http://llvm.org/viewvc/llvm-project?rev=331483&view=rev Log: [X86] Make __builtin_ia32_directstore_u32 and __builtin_ia32_movdir64b 'nothrow' These builtins snuck in while I was in the middle of adding nothrow to the other

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny updated this revision to Diff 145092. jdenny removed a reviewer: jbcoe. jdenny added a comment. Rebased. Ping. https://reviews.llvm.org/D45463 Files: include/clang-c/Index.h include/clang/AST/PrettyPrinter.h lib/AST/DeclPrinter.cpp lib/AST/TypePrinter.cpp test/Misc/ast-print-e

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

EricWF marked 12 inline comments as done. EricWF added a comment. Ping. https://reviews.llvm.org/D45131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45470: Emit an error when mixing and

jfb added a comment. This isn't bad, so I'd go with it, but separately I imagine that we could implement the suggestion in http://wg21.link/p0943 and expose it even before C++20? Not sure we do this much, but I'd argue that before that fix stdatomic.h is just useless anyways, so it's a fine bre

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:1002 + return EmitFinalDestCopy( + E->getType(), CGF.MakeNaturalAlignAddrLValue(Select, E->getType())); +} EricWF wrote: > rjmccall wrote: > > Is there something in Sema actually validating

[PATCH] D46286: [Driver] Don't warn about unused inputs in config files

mstorsjo added a comment. @sepavloff - does the additional change to this one also look fine to you? https://reviews.llvm.org/D46286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46363: Follow-up to r331378. Update tests to allow to use C atomics in C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rL331484: Follow-up to r331378. Update tests to allow to use C atomics in C++. (authored by vsapsai, committed by ). Herald added subscribers: llvm-commits, delcypher. Changed prior to commit: https://rev

[PATCH] D46363: Follow-up to r331378. Update tests to allow to use C atomics in C++.

vsapsai added a comment. Thanks for the quick review. Repository: rL LLVM https://reviews.llvm.org/D46363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45470: Emit an error when mixing and

vsapsai added a comment. In https://reviews.llvm.org/D45470#1087026, @jfb wrote: > This isn't bad, so I'd go with it, but separately I imagine that we could > implement the suggestion in http://wg21.link/p0943 and expose it even before > C++20? Not sure we do this much, but I'd argue that befor

[PATCH] D46410: [Target] Diagnose mismatch in required CPU for always_inline functions

craig.topper created this revision. craig.topper added reviewers: echristo, erichkeane. If an always inline function requests a different CPU than its caller we should probably error. If the callee CPU has features that the caller CPU doesn't we would already error for the feature mismatch, but

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

rsmith added inline comments. Comment at: include/clang/AST/TypeLoc.h:1992-1993 + unsigned getExtraLocalDataAlignment() const { +static_assert(alignof(TransformTraitTypeLoc) >= alignof(TypeSourceInfo *), + "not enough alignment for tail-allocated data"); +

[PATCH] D46386: Adding __atomic_fetch_min/max intrinsics to clang

rjmccall added a comment. Given that these are overloaded builtins, why are there separate builtins for `min` and `umin`? If this is a Clang extension, it needs to be documented in our extensions documentation. The documentation should describe the exact ordering semantics, to the extent we w

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

rsmith added a comment. > TagSpecifierAs expands sizeof(PrintingPolicy) from 8 to 16 bytes. My concern > is the comments on PrintingPolicy about how PrintingPolicy is intended to be > small. My guess it that 16 bytes is still small enough, but perhaps Richard > Smith, who wrote that comment, kn

[PATCH] D45860: [Coroutines] Catch exceptions in await_resume

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D46241: [CodeGen] Recognize more cases of zero initialization

rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:1413 + } else if (!Init->isEvaluatable(CE.CGM.getContext())) { +return false; + } else if (InitTy->hasPointerRepresentation()) { sepavloff wrote: > rjmccall wrote: > > Aren't the null-

[PATCH] D45679: [clang-tidy] Add a helper function isModified, that checks whether an expression is modified within a statement.

shuaiwang updated this revision to Diff 145121. shuaiwang marked 4 inline comments as done. shuaiwang added a comment. Addressed review comments, notably added check for DeclRefExpr to volatile variables. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45679 Files: clang-tidy

[PATCH] D45679: [clang-tidy] Add a helper function isModified, that checks whether an expression is modified within a statement.

shuaiwang added inline comments. Comment at: clang-tidy/utils/ExprMutationAnalyzer.cpp:82-83 +const auto *E = RefNodes.getNodeAs("expr"); +if (findMutation(E)) + return E; + } aaron.ballman wrote: > Why does this not return the result of `findMutati

[PATCH] D46410: [Target] Diagnose mismatch in required CPU for always_inline functions

echristo added a comment. I like the idea of a front end warning, but had believed that a subset of cpu features should be allowed to be inlined into something that's a superset and it sounds like you don't agree? Your thoughts here? -eric https://reviews.llvm.org/D46410 __

r331496 - [analyzer] NFC: Remove unused parameteer of StoreManager::CastRetrievedVal().

Author: dergachev Date: Thu May 3 17:53:41 2018 New Revision: 331496 URL: http://llvm.org/viewvc/llvm-project?rev=331496&view=rev Log: [analyzer] NFC: Remove unused parameteer of StoreManager::CastRetrievedVal(). Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h

[PATCH] D46410: [Target] Diagnose mismatch in required CPU for always_inline functions

craig.topper added a comment. From the backend codegen perspective it would be fine if the callees instruction features were a subset. So it really depends on why the user wrote the different arch on the callee in the first place. If they did it because of one of the various tuning flags in the

[PATCH] D46415: [analyzer] pr36458: Fix retrieved value cast for symbolic void pointers.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, baloghadamsoftware. Through C cast magic it's possible to put a raw void pointer into a variable of non-void pointer type. It is fine - gene

Re: [libcxxabi] r331150 - Move _LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS macro to build system

Yes, it did. Thanks! -- Maxim Kuvyrkov www.linaro.org > On May 3, 2018, at 3:48 PM, Nico Weber wrote: > > r331450 should hopefully fix this. > > On Tue, May 1, 2018 at 8:55 AM, Nico Weber wrote: > tzik, can you take a look what's up on those bots? > > On Tue, May 1, 2018, 5:48 AM Maxim Ku

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:258-260 +Report->addNote(NoteBuf, +PathDiagnosticLocation::create(FieldChain.getEndOfChain(), + Context.get

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny added a comment. In https://reviews.llvm.org/D45463#1087174, @rsmith wrote: > > TagSpecifierAs expands sizeof(PrintingPolicy) from 8 to 16 bytes. My > > concern is the comments on PrintingPolicy about how PrintingPolicy is > > intended to be small. My guess it that 16 bytes is still smal

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

aaron.ballman added inline comments. Comment at: lib/AST/DeclPrinter.cpp:180-181 if (isFirst) { - if(TD) -SubPolicy.IncludeTagDefinition = true; + if (TD) +SubPolicy.TagSpecifierAs = TD; SubPolicy.SuppressSpecifiers = false;

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

rsmith added inline comments. Comment at: lib/AST/DeclPrinter.cpp:180-181 if (isFirst) { - if(TD) -SubPolicy.IncludeTagDefinition = true; + if (TD) +SubPolicy.TagSpecifierAs = TD; SubPolicy.SuppressSpecifiers = false; aaron.b

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

rsmith added inline comments. Comment at: lib/AST/DeclPrinter.cpp:180-181 if (isFirst) { - if(TD) -SubPolicy.IncludeTagDefinition = true; + if (TD) +SubPolicy.TagSpecifierAs = TD; SubPolicy.SuppressSpecifiers = false; rsmith

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard marked 3 inline comments as done. Wizard added inline comments. Comment at: test/clang-tidy/objc-property-declaration.m:24 @property(assign, nonatomic) int enableGLAcceleration; +@property(assign, nonatomic) int ID; @end benhamilton wrote: > Please add a

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard updated this revision to Diff 145145. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration-custom.m test/clang-tidy/objc-property-

[PATCH] D45463: [AST] Print correct tag decl for tag specifier

jdenny added inline comments. Comment at: lib/AST/DeclPrinter.cpp:180-181 if (isFirst) { - if(TD) -SubPolicy.IncludeTagDefinition = true; + if (TD) +SubPolicy.TagSpecifierAs = TD; SubPolicy.SuppressSpecifiers = false; rsmith

[PATCH] D46286: [Driver] Don't warn about unused inputs in config files

sepavloff accepted this revision. sepavloff added a comment. With additional changes the fix is OK. LGTM. https://reviews.llvm.org/D46286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

EricWF planned changes to this revision. EricWF marked 7 inline comments as done. EricWF added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5262-5266 +AST_MATCHER(Type, unaryTransformType) { + if (const auto *T = Node.getAs()) +return T->getNumArgs()

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8931 + /*ConstArg*/ true, false, false, false, false); + auto *CopyCtor = cast_or_null(SMI.getMethod()); + Sorry, I didn't realize you'd go off and write this code manu

r331504 - [Driver] Don't warn about unused inputs in config files

Author: mstorsjo Date: Thu May 3 23:05:58 2018 New Revision: 331504 URL: http://llvm.org/viewvc/llvm-project?rev=331504&view=rev Log: [Driver] Don't warn about unused inputs in config files This avoids warnings about unused linker parameters, just like other flags are ignored if they're from con

[PATCH] D46286: [Driver] Don't warn about unused inputs in config files

This revision was automatically updated to reflect the committed changes. Closed by commit rC331504: [Driver] Don't warn about unused inputs in config files (authored by mstorsjo, committed by ). Repository: rC Clang https://reviews.llvm.org/D46286 Files: lib/Driver/Driver.cpp test/Driver

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:8931 + /*ConstArg*/ true, false, false, false, false); + auto *CopyCtor = cast_or_null(SMI.getMethod()); + rjmccall wrote: > Sorry, I didn't realize you'd go off and writ

[PATCH] D46180: [clang-format] Refactor #include insertion/deletion functionality into a class.

ioeric added a comment. Friendly ping. Repository: rC Clang https://reviews.llvm.org/D46180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41537: Optionally add code completion results for arrow instead of dot

yvvan added a comment. Ping https://reviews.llvm.org/D41537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45815: [libclang] Allow skipping function bodies in preamble only

nik added a comment. Do I miss something? I've uploaded a new diff/version and state is still "(X) Requested Changes to Prior Diff". Waiting for review. Repository: rC Clang https://reviews.llvm.org/D45815 ___ cfe-commits mailing list cfe-commi

<    1   2