a.sidorin added a comment.
Confirming LGTM, no objections. Thank you!
Repository:
rC Clang
https://reviews.llvm.org/D46019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jinlin updated this revision to Diff 143964.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D46071
Files:
lib/CodeGen/ModuleBuilder.cpp
Index: lib/CodeGen/ModuleBuilder.cpp
===
--- lib/Co
jinlin updated this revision to Diff 143965.
https://reviews.llvm.org/D46071
Files:
docs/LangRef.rst
include/llvm/Bitcode/LLVMBitCodes.h
include/llvm/IR/Module.h
lib/AsmParser/LLLexer.cpp
lib/AsmParser/LLParser.cpp
lib/AsmParser/LLToken.h
lib/Bitcode/Reader/BitcodeReader.cpp
lib/B
rjmccall added a comment.
Yeah, if there are actually differences in the set of keywords, that's a
totally reasonable thing to handle in the lexer.
Comment at: include/clang/Basic/TokenKinds.def:255
+// KEYNOOPENCL - This is a keyword that is not supported in OpenCL C
+//
jinlin updated this revision to Diff 143967.
https://reviews.llvm.org/D46071
Files:
docs/LangRef.rst
include/llvm/Bitcode/LLVMBitCodes.h
include/llvm/IR/Module.h
lib/AsmParser/LLLexer.cpp
lib/AsmParser/LLParser.cpp
lib/AsmParser/LLToken.h
lib/Bitcode/Reader/BitcodeReader.cpp
lib/B
jinlin updated this revision to Diff 143966.
https://reviews.llvm.org/D46071
Files:
docs/LangRef.rst
include/llvm/Bitcode/LLVMBitCodes.h
include/llvm/IR/Module.h
lib/AsmParser/LLLexer.cpp
lib/AsmParser/LLParser.cpp
lib/AsmParser/LLToken.h
lib/Bitcode/Reader/BitcodeReader.cpp
lib/B
jinlin created this revision.
jinlin added a reviewer: hfinkel.
Herald added a subscriber: cfe-commits.
The target device information needs to be passed to the LLVM backend when the
OMP backend outlining is enabled. For example, for multiple target devices, the
target compilation has to generate
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, mgorny.
Herald added a reviewer: EricWF.
This is necessary in order to get a working C++ compiler on Darwin
since Clang expects libc++ headers to be part of the toolchain.
Repository:
rC Cla
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CtorUninitializedMemberChecker.cpp:72
+ const FieldDecl *getEndOfChain() const { return Chain.back()->getDecl(); }
+ template void toString(SmallString &Buf) const;
+ friend struct FieldChainInfoComparat
Author: phosek
Date: Wed Apr 25 11:30:55 2018
New Revision: 330855
URL: http://llvm.org/viewvc/llvm-project?rev=330855&view=rev
Log:
[CMake] Enable libc++ for Fuchsia toolchain on Darwin
This is necessary in order to get a working C++ compiler on Darwin
since Clang expects libc++ headers to be pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330855: [CMake] Enable libc++ for Fuchsia toolchain on
Darwin (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46075?vs=143970&id=143974#toc
Repository:
rC Clan
sepavloff added a comment.
In https://reviews.llvm.org/D45964#1077217, @mstorsjo wrote:
> Added an isEmpty() method.
This variant is more readable.
> Btw, did you see https://bugs.llvm.org/show_bug.cgi?id=37196? That one feels
> quite a bit more convolved so I don't really know (so far) how t
phosek added a comment.
In https://reviews.llvm.org/D45639#1068086, @compnerd wrote:
> I'm not sure I understand this. The proper location for libc++ on the darwin
> layout is in the SDK, not relative to the driver. The default behaviour is
> similar to cross-compiling, and with a (derived) S
ioeric added inline comments.
Comment at: include/clang/AST/RawCommentList.h:118
+ /// // Parts of it might be indented.
+ /// /* The comments styles might be mixed. */
+ /// into
I'm trying to understand how these cases and RawComment work.
For t
thakis added a comment.
> because the headers that are part of Clang toolchain are incompatible with
> the system library
Do you have details on this? This isn't supposed to be the case as far as I
know. We link chrome/mac against system libc++ with the bundled headers, and it
at least seems t
smeenai added a comment.
In https://reviews.llvm.org/D45639#1078494, @thakis wrote:
> > because the headers that are part of Clang toolchain are incompatible with
> > the system library
>
> Do you have details on this? This isn't supposed to be the case as far as I
> know. We link chrome/mac ag
ABataev added a comment.
Hmm, I don't think this is correct. I think it is against the OpenMP standard.
According to OpenMP 4.5:
When an original variable is mapped to a device data environment and the
associated 19 corresponding variable is not present in the device data
environment, a new corr
GorNishanov added a comment.
Thank you for doing this. It looks very elegant, but, it is a little bit wrong.
It creates two different initial_suspend objects.
Run this example:
https://wandbox.org/permlink/Q1Zd2NUlolmw9YmX
You will observe that in trunk we are getting the output:
0x216808c:
Author: efriedma
Date: Wed Apr 25 12:14:05 2018
New Revision: 330861
URL: http://llvm.org/viewvc/llvm-project?rev=330861&view=rev
Log:
[TargetInfo] Sort target features before passing them to the backend
Passing the features in random order will lead to unpredictable results
when some of the feat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330861: [TargetInfo] Sort target features before passing
them to the backend (authored by efriedma, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
phosek added a comment.
In https://reviews.llvm.org/D45639#1078494, @thakis wrote:
> > because the headers that are part of Clang toolchain are incompatible with
> > the system library
>
> Do you have details on this? This isn't supposed to be the case as far as I
> know. We link chrome/mac aga
martong added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:1556
+ // Converting code texts into TUs
+ std::transform(Codes.begin(), Codes.end(), std::back_inserter(FromTUs),
+ [this](StringRef Code) {
Instead of having 4 `FromT
AlexeySotkin added a comment.
In https://reviews.llvm.org/D46015#1078317, @stuart wrote:
> In https://reviews.llvm.org/D46015#1078260, @AlexeySotkin wrote:
>
> > In https://reviews.llvm.org/D46015#1078235, @stuart wrote:
> >
> > > In https://reviews.llvm.org/D46015#1078217, @AlexeySotkin wrote:
>
efriedma added a comment.
I agree this needs an RFC; I don't understand how you plan to use this
information.
Repository:
rOMP OpenMP
https://reviews.llvm.org/D46071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
rjmccall added a comment.
Are you asking for a code review or a design review of the ABI? The second
would be much easier to do from a design document.
Comment at: lib/CodeGen/CGObjCGNU.cpp:502
+for (const auto *I : Methods)
+ if (I->getImplementationControl() == Obj
On Wed, Apr 25, 2018 at 3:37 PM, Richard Smith wrote:
> On 24 April 2018 at 19:42, Faisal Vali via cfe-commits
> wrote:
>>
>> Author: faisalv
>> Date: Tue Apr 24 19:42:26 2018
>> New Revision: 330794
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=330794&view=rev
>> Log:
>> [c++2a] [concepts]
pfultz2 created this revision.
pfultz2 added reviewers: NoQ, xazax.hun, dkrupp, whisperity.
pfultz2 added a project: clang.
Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet.
Herald added a reviewer: george.karpenkov.
This expands checking for more expressions. This will check und
pfultz2 abandoned this revision.
pfultz2 added a comment.
So I submitted my change to the ConversionChecker, instead.
Repository:
rC Clang
https://reviews.llvm.org/D46066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: mstorsjo
Date: Wed Apr 25 14:23:59 2018
New Revision: 330871
URL: http://llvm.org/viewvc/llvm-project?rev=330871&view=rev
Log:
[Driver] Fix implicit config files from prefixed symlinks
If -no-canonical-prefixes isn't used, the clang executable name used
is the one of the actual executable
Author: mstorsjo
Date: Wed Apr 25 14:24:04 2018
New Revision: 330872
URL: http://llvm.org/viewvc/llvm-project?rev=330872&view=rev
Log:
[test] Add a testcase for MinGW sysroot detections from SVN r330244. NFC.
Differential Revision: https://reviews.llvm.org/D45985
Added:
cfe/trunk/test/Driver
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330872: [test] Add a testcase for MinGW sysroot detections
from SVN r330244. NFC. (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330871: [Driver] Fix implicit config files from prefixed
symlinks (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45964
Author: danalbert
Date: Wed Apr 25 14:26:06 2018
New Revision: 330873
URL: http://llvm.org/viewvc/llvm-project?rev=330873&view=rev
Log:
[Driver] Reland "Android triples are not aliases for other triples."
Fixed directory separators in tests to be compatible with both
Windows and !Windows.
This r
leonardchan created this revision.
leonardchan added reviewers: phosek, mcgrathr.
leonardchan added a project: clang.
This diff includes changes for supporting the following types.
// Primary fixed point types
signed short _Accum s_short_accum;
signed _Accum s_accum;
signed long _Accum s_
juliehockett updated this revision to Diff 144011.
juliehockett marked 17 inline comments as done.
juliehockett added a comment.
Reorganizing and streamlining, particularly in decoupling the reader from the
reduce process and redesigning a bit to allow for more flexible reducing.
Currently imple
Author: dergachev
Date: Wed Apr 25 14:51:26 2018
New Revision: 330876
URL: http://llvm.org/viewvc/llvm-project?rev=330876&view=rev
Log:
[analyzer] Enable analysis of WebKit "unified sources".
Normally the analyzer begins path-sensitive analysis from functions within
the main file, even though the
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330876: [analyzer] Enable analysis of WebKit "unified
sources". (authored by dergachev, committed by ).
Repository:
rC
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330876: [analyzer] Enable analysis of WebKit "unified
sources". (authored by dergachev, committed by ).
Herald added a sub
Author: arphaman
Date: Wed Apr 25 15:23:26 2018
New Revision: 330878
URL: http://llvm.org/viewvc/llvm-project?rev=330878&view=rev
Log:
[driver][darwin] Do not infer -simulator environment for OS version env vars
with non-simulator SDKs
rdar://37955008
Modified:
cfe/trunk/lib/Driver/ToolChain
juliehockett marked 5 inline comments as done.
juliehockett added inline comments.
Comment at: clang-doc/BitcodeReader.h:59
+
+ void storeData(llvm::SmallVectorImpl &Field, llvm::StringRef Blob);
+ void storeData(bool &Field, llvm::StringRef Blob);
sammccall wr
lebedev.ri added inline comments.
Comment at: clang-doc/BitcodeWriter.h:129
// Check that the static size is large-enough.
assert(Record.capacity() > BitCodeConstants::RecordSize);
}
juliehockett wrote:
> lebedev.ri wrote:
> > lebedev.ri wrote:
> > >
Author: apazos
Date: Wed Apr 25 15:42:38 2018
New Revision: 330880
URL: http://llvm.org/viewvc/llvm-project?rev=330880&view=rev
Log:
[RISCV] More validations on the input value of -march=
Supporting additional rules for parsing ISA string.
- RISC-V ISA strings must be lowercase.
E.g.: rv32IMC is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330880: [RISCV] More validations on the input value of
-march= (authored by apazos, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45284?vs=1
Author: rsmith
Date: Wed Apr 25 15:58:55 2018
New Revision: 330881
URL: http://llvm.org/viewvc/llvm-project?rev=330881&view=rev
Log:
Fix crash on qualified template name instantiation if the template name has no
template argument list.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
cfe/tru
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330882: [analyzer] Fix a crash on lifetime extension through
aggregate initialization. (authored by dergachev, committed b
Author: dergachev
Date: Wed Apr 25 16:02:06 2018
New Revision: 330882
URL: http://llvm.org/viewvc/llvm-project?rev=330882&view=rev
Log:
[analyzer] Fix a crash on lifetime extension through aggregate initialization.
If 'A' is a C++ aggregate with a reference field of type 'C', in code like
A a =
Author: vsapsai
Date: Wed Apr 25 16:38:41 2018
New Revision: 330885
URL: http://llvm.org/viewvc/llvm-project?rev=330885&view=rev
Log:
[libcxx] func.wrap.func.con: Unset function before destroying anything
Be defensive against a reentrant std::function::operator=(nullptr_t), in case
the held funct
Author: rnk
Date: Wed Apr 25 16:38:54 2018
New Revision: 330886
URL: http://llvm.org/viewvc/llvm-project?rev=330886&view=rev
Log:
Include to get std::isdigit, fixes MSVC STL build
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/RISCV.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Arch/RISCV.c
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX330885: [libcxx] func.wrap.func.con: Unset function before
destroying anything (authored by vsapsai, committed by ).
Ch
Author: rtrieu
Date: Wed Apr 25 16:50:55 2018
New Revision: 330887
URL: http://llvm.org/viewvc/llvm-project?rev=330887&view=rev
Log:
Switch to Clang's isDigit function.
std::isdigit can be overloaded, causing the template deduction to fail. Use
Clang's isDigit function which to avoid this. Swit
cryptoad added inline comments.
Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:89
set(RUNTIMES_${target}-fuchsia_CMAKE_SYSROOT ${FUCHSIA_${target}_SYSROOT}
CACHE PATH "")
- set(RUNTIMES_${target}-fuchsia_CMAKE_SYSTEM_NAME Fuchsia CACHE STRING "")
- set(RUNTIMES_${targe
Author: faisalv
Date: Wed Apr 25 17:42:40 2018
New Revision: 330888
URL: http://llvm.org/viewvc/llvm-project?rev=330888&view=rev
Log:
Revert rC330794 and some dependent tiny bug fixes
See Richard's humbling feedback here:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180423/226482.h
Author: faisalv
Date: Wed Apr 25 18:05:05 2018
New Revision: 330889
URL: http://llvm.org/viewvc/llvm-project?rev=330889&view=rev
Log:
Fix a merge conflict that was inadvertently introduced in r330888
- during the reversion of r330794
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Modified: c
Author: rsmith
Date: Wed Apr 25 18:08:00 2018
New Revision: 330890
URL: http://llvm.org/viewvc/llvm-project?rev=330890&view=rev
Log:
Factor out common code for diagnosing missing template arguments.
In passing, add 'concept' to the list of template kinds in diagnostics.
Modified:
cfe/trunk/i
Author: rsmith
Date: Wed Apr 25 18:16:08 2018
New Revision: 330891
URL: http://llvm.org/viewvc/llvm-project?rev=330891&view=rev
Log:
Revert addition of 'concept' to diagnostics in r330890.
Matches revert in r330888 of r330794.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
On 23 April 2018 at 20:07, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Apr 23, 2018 at 8:23 PM, Richard Smith
> wrote:
>
>> On 23 April 2018 at 16:23, David Blaikie via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> On Mon, Apr 23, 2018 at 4:12 PM John M
Author: rsmith
Date: Wed Apr 25 19:10:22 2018
New Revision: 330894
URL: http://llvm.org/viewvc/llvm-project?rev=330894&view=rev
Log:
Diagnose missing template arguments for a variable template even when there is
a preceding 'template' keyword.
We only diagnose in the dependent case (wherein we us
Author: tstellar
Date: Wed Apr 25 21:20:20 2018
New Revision: 330906
URL: http://llvm.org/viewvc/llvm-project?rev=330906&view=rev
Log:
Creating release directory for release_601.
Added:
libcxx/tags/RELEASE_601/
___
cfe-commits mailing list
cfe-comm
Author: tstellar
Date: Wed Apr 25 21:20:31 2018
New Revision: 330909
URL: http://llvm.org/viewvc/llvm-project?rev=330909&view=rev
Log:
Creating release candidate rc1 from release_601 branch
Added:
libcxxabi/tags/RELEASE_601/rc1/
- copied from r330908, libcxxabi/branches/release_60/
___
Author: tstellar
Date: Wed Apr 25 21:20:28 2018
New Revision: 330908
URL: http://llvm.org/viewvc/llvm-project?rev=330908&view=rev
Log:
Creating release directory for release_601.
Added:
libcxxabi/tags/RELEASE_601/
___
cfe-commits mailing list
cfe-c
Author: tstellar
Date: Wed Apr 25 21:20:26 2018
New Revision: 330907
URL: http://llvm.org/viewvc/llvm-project?rev=330907&view=rev
Log:
Creating release candidate rc1 from release_601 branch
Added:
libcxx/tags/RELEASE_601/rc1/ (props changed)
- copied from r330906, libcxx/branches/rele
Author: tstellar
Date: Wed Apr 25 21:21:02 2018
New Revision: 330920
URL: http://llvm.org/viewvc/llvm-project?rev=330920&view=rev
Log:
Creating release directory for release_601.
Added:
libunwind/tags/RELEASE_601/
___
cfe-commits mailing list
cfe-c
Author: tstellar
Date: Wed Apr 25 21:21:05 2018
New Revision: 330921
URL: http://llvm.org/viewvc/llvm-project?rev=330921&view=rev
Log:
Creating release candidate rc1 from release_601 branch
Added:
libunwind/tags/RELEASE_601/rc1/
- copied from r330920, libunwind/branches/release_60/
___
On Wed, Apr 25, 2018 at 7:10 PM, Richard Smith
wrote:
> On 23 April 2018 at 20:07, John McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>>
>> The issue there is that -Wnoisy-in-tests is likely to be useful as a
>> cancellation of -Wno-noisy-in-tests, which (as David suggests) migh
Author: ctopper
Date: Wed Apr 25 22:38:39 2018
New Revision: 330923
URL: http://llvm.org/viewvc/llvm-project?rev=330923&view=rev
Log:
[X86] Add support for _mm512_mullox_epi64 and _mm512_mask_mullox_epi64
intrinsics to match icc.
On AVX512F targets we'll produce an emulated sequence using 3 pmul
zinovy.nis updated this revision to Diff 144066.
zinovy.nis added a comment.
- Optimized `containsEscapedCharacters` not to re-create `bitset`
(implicitly in `StringRef::find_first_of`) for each literal.
- Merged 2 passes for testing for allowed chars into a single one.
https://reviews.llvm.org
Author: sepavloff
Date: Wed Apr 25 23:28:47 2018
New Revision: 330926
URL: http://llvm.org/viewvc/llvm-project?rev=330926&view=rev
Log:
[ConfigFiles] Update argument strings when merging argrument lists
Implementation of `InputArgList` assumes its field `ArgStrings` contains
strings for each argu
101 - 167 of 167 matches
Mail list logo
