[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RHSExpr->getSourceRange(); + S.Diag(OpLoc, IsBuiltin ? diag::warn_self_assignment_b

[clang-tools-extra] r330637 - [clangd] Implementation of workspace/symbol request

Author: malaperle Date: Mon Apr 23 13:00:52 2018 New Revision: 330637 URL: http://llvm.org/viewvc/llvm-project?rev=330637&view=rev Log: [clangd] Implementation of workspace/symbol request Summary: This is a basic implementation of the "workspace/symbol" request which is used to find symbols by a

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE330637: [clangd] Implementation of workspace/symbol request (authored by malaperle, committed by ). Changed prior to commit: https://reviews.llvm.org/D44882?vs=143220&id=143626#toc Repository: rCTE

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RHSExpr->getSourceRange(); + S.Diag(OpLoc, IsBuiltin ? diag::warn_self_assignment

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RH

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella created this revision. GBuella added a reviewer: craig.topper. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/B

[PATCH] D45985: [test] Add a testcase for MinGW sysroot detections from SVN r330244. NFC.

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd, martell. After having a look at some similar tests, adding a proper testcase for this feature didn't turn out to be all that bad after all. Repository: rC Clang https://reviews.llvm.org/D45985 Files: test/Driver/ming

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3069 + if (hasAggregateEvaluationKind(type) && + getContext().isParamDestroyedInCallee(type)) { +EHScopeStack::stable_iterator cleanup = I wonder if this is something we should be taking

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rsmith added a comment. In https://reviews.llvm.org/D45382#1060452, @ahatanak wrote: > In https://reviews.llvm.org/D45382#1060163, @rjmccall wrote: > > > Hmm. I'm not actually sure *why* it's not okay to forward callee-cleanup > > arguments. Do we just not have the necessary logic to disable t

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella updated this revision to Diff 143639. GBuella added a comment. Rebased the patch. Added pconfig to Icelake Server. https://reviews.llvm.org/D44387 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/C

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

craig.topper added inline comments. Comment at: docs/ClangCommandLineReference.rst:2465 +.. option:: -mmovdiri, -mno-movdiri + Please alphabetize this correctly. Comment at: include/clang/Basic/BuiltinsX86.def:1896 +TARGET_BUILTIN(__builtin_i

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

GBuella updated this revision to Diff 143640. https://reviews.llvm.org/D44387 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/CodeGen/CGBuiltin.cpp lib/Headers/CMakeLists.txt lib/Headers/cpuid.h lib/H

[PATCH] D45505: [GCC] Match a GCC version with a patch suffix without a third version component

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D45505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[libclc] r330649 - log10: Use sw implementation from amd builtins

Author: jvesely Date: Mon Apr 23 14:10:42 2018 New Revision: 330649 URL: http://llvm.org/viewvc/llvm-project?rev=330649&view=rev Log: log10: Use sw implementation from amd builtins Add missing table. Fixes log10d CTS on carrizo. Signed-off-by: Jan Vesely Acked-by: Aaron Watry Tested-by: Aaron W

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143642. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/He

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

probinson added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144 +// includes the full path. +if (SM.getFilename(IL).contains("UnifiedSource")) { + StringRef Name = SM.getFilename(SL); george.karpenk

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143644. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/He

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri updated this revision to Diff 143645. lebedev.ri added a comment. Add negative tests, too. Repository: rC Clang https://reviews.llvm.org/D45766 Files: docs/ReleaseNotes.rst include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144 +// includes the full path. +if (SM.getFilename(IL).contains("UnifiedSource")) { + StringRef Name = SM.getFilename(SL); probinson wrote: > g

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

GBuella updated this revision to Diff 143647. https://reviews.llvm.org/D45984 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/He

r330651 - [Sema] Add -Wno-self-assign-overloaded

Author: lebedevri Date: Mon Apr 23 14:35:21 2018 New Revision: 330651 URL: http://llvm.org/viewvc/llvm-project?rev=330651&view=rev Log: [Sema] Add -Wno-self-assign-overloaded Summary: It seems there isn't much enthusiasm for `-wtest` D45685. This is more conservative version, which i had in the

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

This revision was automatically updated to reflect the committed changes. Closed by commit rL330651: [Sema] Add -Wno-self-assign-overloaded (authored by lebedevri, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45766?vs=143645&id=1436

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

lebedev.ri added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11527-11528 - S.Diag(OpLoc, diag::warn_self_assignment) - << LHSDeclRef->getType() - << LHSExpr->getSourceRange() << RHSExpr->getSourceRange(); + S.Diag(OpLoc, IsBuiltin ? diag::warn_self_assignment

[PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

lebedev.ri added a comment. @brooksmoses The simple `-Wno-self-assign-overloaded` variant (https://reviews.llvm.org/D45766) has landed, so the issue should be resolved? Not sure what to do with this differential, should i abandon it until there is more interest for such functionality? Reposit

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

FWIW I don't fundamentalyl object to also having something like -wtest. Probably needs a better name though (unfortunately the double-negative gets confusing... - like you want to describe the set of diagnostics that should not be used in test code, so that as a group might be "-Wnon-test" but then

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie added a subscriber: lebedev.ri. dblaikie added a comment. FWIW I don't fundamentalyl object to also having something like -wtest. Probably needs a better name though (unfortunately the double-negative gets confusing... - like you want to describe the set of diagnostics that should not be

r330654 - [Docs] Regenerate command line documentation.

Author: ctopper Date: Mon Apr 23 14:41:06 2018 New Revision: 330654 URL: http://llvm.org/viewvc/llvm-project?rev=330654&view=rev Log: [Docs] Regenerate command line documentation. Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst UR

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

ahatanak added a comment. x. Comment at: lib/CodeGen/CGCall.cpp:3069 + if (hasAggregateEvaluationKind(type) && + getContext().isParamDestroyedInCallee(type)) { +EHScopeStack::stable_iterator cleanup = rjmccall wrote: > I wonder if this is something we

[PATCH] D45839: [analyzer] Add support for WebKit "unified sources".

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:144 +// includes the full path. +if (SM.getFilename(IL).contains("UnifiedSource")) { + StringRef Name = SM.getFilename(SL); NoQ wrote: > probins

[PATCH] D45984: [X86] directstore and movdir64b intrinsics

craig.topper added inline comments. Comment at: lib/Headers/movdirintrin.h:39 +// Move quadword as direct store +static __inline__ void +__attribute__((__always_inline__, __nodebug__, __target__("movdiri"))) Sorry, the X86_64 preprocessor check should have staye

[libcxx] r330655 - Re-commit r330627 "[libcxx] implement declarations based on P0214R7."

Author: timshen Date: Mon Apr 23 14:54:06 2018 New Revision: 330655 URL: http://llvm.org/viewvc/llvm-project?rev=330655&view=rev Log: Re-commit r330627 "[libcxx] implement declarations based on P0214R7." There are 3 changes: * Renamed genertor.pass.cpp to generator.pass.cpp * Removed nothing_to

r330656 - [AST] strcmp/memcmp always compares unsigned chars.

Author: d0k Date: Mon Apr 23 15:04:34 2018 New Revision: 330656 URL: http://llvm.org/viewvc/llvm-project?rev=330656&view=rev Log: [AST] strcmp/memcmp always compares unsigned chars. This makes it return the right result in a couple of edge cases. The wide versions always do the comparison on the

[PATCH] D45382: [CodeGen] Avoid destructing a struct type that has already been destructed by a delegated constructor

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3069 + if (hasAggregateEvaluationKind(type) && + getContext().isParamDestroyedInCallee(type)) { +EHScopeStack::stable_iterator cleanup = ahatanak wrote: > rjmccall wrote: > > I wonder if

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

rjmccall added a comment. In https://reviews.llvm.org/D45766#1076090, @dblaikie wrote: > FWIW I don't fundamentalyl object to also having something like -wtest. > Probably needs a better name though (unfortunately the double-negative gets > confusing... - like you want to describe the set of di

r330657 - [X86] Move __builtin_ia32_movnti64 andd __builtin_ia32_rdrand64_step to BuiltinsX86_64.def to make them unavailable in 32-bit mode.

Author: ctopper Date: Mon Apr 23 15:18:34 2018 New Revision: 330657 URL: http://llvm.org/viewvc/llvm-project?rev=330657&view=rev Log: [X86] Move __builtin_ia32_movnti64 andd __builtin_ia32_rdrand64_step to BuiltinsX86_64.def to make them unavailable in 32-bit mode. Modified: cfe/trunk/includ

r330658 - [X86] Move the 32-bit versions of rdfsbase/rdgsbase/wrfsbase/wrgsbase to BuiltinsX86_64.def.

Author: ctopper Date: Mon Apr 23 15:18:36 2018 New Revision: 330658 URL: http://llvm.org/viewvc/llvm-project?rev=330658&view=rev Log: [X86] Move the 32-bit versions of rdfsbase/rdgsbase/wrfsbase/wrgsbase to BuiltinsX86_64.def. The 32-bit refers to their input/output type, but the instructions ar

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

Wawha added a comment. Hi djasper, Here a project where there is lambda and allman style for them : https://github.com/boostorg/hof/blob/develop/example/in.cpp https://github.com/boostorg/hof/blob/develop/example/sequence.cpp Example of code: // Function to find an iterator using a contain

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

dblaikie added a comment. Is there anything else in the "-w" namespace other than the literal "-w" so far? I mean, I could imagine it might make more sense to default these warnings off & users can turn them on for non-test code, potentially? So "-Wnon-test" might make sense. Repository: rL L

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

Is there anything else in the "-w" namespace other than the literal "-w" so far? I mean, I could imagine it might make more sense to default these warnings off & users can turn them on for non-test code, potentially? So "-Wnon-test" might make sense. On Mon, Apr 23, 2018 at 3:22 PM John McCall vi

[PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

rjmccall added a comment. In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: > Is there anything else in the "-w" namespace other than the literal "-w" so > far? No. This would be novel. > I mean, I could imagine it might make more sense to default these warnings > off & users can

[PATCH] D45470: Emit an error when mixing and

vsapsai added a comment. Herald added a subscriber: jkorous. Ping. https://reviews.llvm.org/D45470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < revi...@reviews.llvm.org> wrote: > rjmccall added a comment. > > In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: > > > Is there anything else in the "-w" namespace other than the literal "-w" > so > > far? > > > No. This w

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai added a comment. Herald added a subscriber: jkorous. Ping. https://reviews.llvm.org/D34331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45093: [AST] Fix -ast-print for _Bool when have diagnostics

jdenny updated this revision to Diff 143667. jdenny added a comment. Rebased. https://reviews.llvm.org/D45093 Files: include/clang/AST/ASTContext.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Sema/Sema.cpp lib/Sema/SemaChecking.cpp lib/Sema/SemaCodeComplete.cpp lib/Sema/

[PATCH] D45456: [Attr] Print enum attributes at correct position

jdenny added a comment. Ping. In case it's not clear: this patch doesn't depend on other patches, but others depend on it. https://reviews.llvm.org/D45456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie wrote: > On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < > revi...@reviews.llvm.org> wrote: > >> rjmccall added a comment. >> >> In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: >> >> > Is there anything else in the "-w" nam

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: > On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie wrote: > >> On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> rjmccall added a comment. >>> >>> In https://reviews.llvm.org/D45766#1076176, @

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

alekseyshl created this revision. alekseyshl added a reviewer: eugenis. To complement https://reviews.llvm.org/D45840 Repository: rC Clang https://reviews.llvm.org/D45996 Files: docs/HardwareAssistedAddressSanitizerDesign.rst Index: docs/HardwareAssistedAddressSanitizerDesign.rst ===

[PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

rsmith added a comment. I would feel a lot more comfortable adding a `-wtest` flag if we had more than one warning that it would control. If there's really only one warning out of >600 that qualifies for this treatment, I really don't think we have a good argument to introduce a new feature her

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

vsapsai added a comment. For the record, DR154: Anonymous unions in unnamed namespaces is relevant here. Comment at: Sema/SemaDecl.cpp:4654-4656 + while (OwnerScope->getDeclKind() == Decl::LinkageSpec) { +

[PATCH] D45997: [CMake] Pass additional CMake flags in Fuchsia cache files

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. This allows passing additional CMake flags to builtins and runtimes build through Fuchsia cache files. We now also set build type and enable assertions for bu

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On 23 April 2018 at 16:23, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: > >> On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie >> wrote: >> >>> On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < >>> revi...@review

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

rsmith added inline comments. Comment at: Sema/SemaDecl.cpp:4654-4656 + while (OwnerScope->getDeclKind() == Decl::LinkageSpec) { +OwnerScope = OwnerScope->getParent(); + } vsapsai wrote: > Looks like `DeclContext::isTransparentContext()` might b

r330671 - Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM

Author: dblaikie Date: Mon Apr 23 17:59:22 2018 New Revision: 330671 URL: http://llvm.org/viewvc/llvm-project?rev=330671&view=rev Log: Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/

[PATCH] D45996: [HWASan] Update HWASan assembly snippet in the docs

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 143674. apazos added a comment. Hi Alex, the refactoring will be simple and can be done later when we need it, all the pieces are already parsed (type, name, major, minor) and are in strings, we will only need to convert to the preferred type (enum, int, etc

r330674 - Make add_clang_tool() formatting a bit more consistent.

Author: nico Date: Mon Apr 23 18:30:44 2018 New Revision: 330674 URL: http://llvm.org/viewvc/llvm-project?rev=330674&view=rev Log: Make add_clang_tool() formatting a bit more consistent. Modified: cfe/trunk/tools/clang-rename/CMakeLists.txt Modified: cfe/trunk/tools/clang-rename/CMakeLists.t

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 8:23 PM, Richard Smith wrote: > On 23 April 2018 at 16:23, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: >> >>> On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie >>> wrote: >>> On Mon, Apr 2

r330681 - [X86] Remove '#ifdef __x86_64__' around mask_set1_epi64 intrinsics.

Author: ctopper Date: Mon Apr 23 20:36:08 2018 New Revision: 330681 URL: http://llvm.org/viewvc/llvm-project?rev=330681&view=rev Log: [X86] Remove '#ifdef __x86_64__' around mask_set1_epi64 intrinsics. The unmasked versions already didn't have this restrction. I don't think gcc or icc limit thes

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprAgg.cpp:1002 + return EmitFinalDestCopy( + E->getType(), CGF.MakeNaturalAlignAddrLValue(Select, E->getType())); +} Is there something in Sema actually validating that the comparison types is tri

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tidy/modernize/RawStringLiteralCheck.cpp:70-72 + if (Bytes.find_if([](char C) { +return static_cast(C) > 0x7Fu; + }) != StringRef::npos) aaron.ballman w

[PATCH] D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals

zinovy.nis updated this revision to Diff 143679. zinovy.nis marked an inline comment as done. zinovy.nis added a comment. - Use clang::isASCII instead of home-brewed code. https://reviews.llvm.org/D45932 Files: clang-tidy/modernize/RawStringLiteralCheck.cpp test/clang-tidy/modernize-raw-str

<    1   2