Should we have two versions of `__gcov_flush`?
One version is visible outside a .so file,
we use dlsym to find and call it to dump
profile data of .so files, like Android.
One version is hidden and must be called from another
wrapper function in a .so file. An application that
wants to flush .so
Author: tstellar
Date: Wed Apr 11 15:29:35 2018
New Revision: 329854
URL: http://llvm.org/viewvc/llvm-project?rev=329854&view=rev
Log:
Driver: Add gcc search path for RHEL devtoolset-7
Reviewers: bruno
Reviewed By: bruno
Subscribers: bruno, cfe-commits
Differential Revision: https://reviews.l
NoQ added a comment.
We've found a crash on our internal buildbot, would you like to have a look?:
**`$ cat repro.c`**
int foo(int x, int y) {
short a = x - 1U;
return a - y;
}
**`$ clang -cc1 -analyze -analyzer-checker=core repro.c`**
Assertion failed: (APSIntType(LInt) == BV.ge
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329854: Driver: Add gcc search path for RHEL devtoolset-7
(authored by tstellar, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44130
Files:
vsapsai added a comment.
Another approach is `__has_feature` but I don't think it is applicable in this
case.
Is there a way right now to detect that aligned allocation is supported by
clang, regardless of link time? Asking to make sure we are consistent.
Repository:
rC Clang
https://revie
EricWF added a comment.
In https://reviews.llvm.org/D45015#1064922, @vsapsai wrote:
> Another approach is `__has_feature` but I don't think it is applicable in
> this case.
>
> Is there a way right now to detect that aligned allocation is supported by
> clang, regardless of link time? Asking to
flyingforyou created this revision.
flyingforyou added a reviewer: SjoerdMeijer.
Herald added subscribers: kristof.beyls, javed.absar.
This matches what GCC does.
https://github.com/gcc-mirror/gcc/blob/master/gcc/config/aarch64/aarch64-c.c
https://reviews.llvm.org/D45544
Files:
lib/Basic/Targ
Author: compnerd
Date: Wed Apr 11 16:47:25 2018
New Revision: 329866
URL: http://llvm.org/viewvc/llvm-project?rev=329866&view=rev
Log:
Lex: make `clang::Preprocessor::macros` work on MSVC
The order of argument construction is reversed on MS ABI on Windows.
When `macros` was invoked, the `end` cal
phosek added a comment.
ping?
Repository:
rCXX libc++
https://reviews.llvm.org/D45529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rtrieu
Date: Wed Apr 11 19:26:49 2018
New Revision: 329869
URL: http://llvm.org/viewvc/llvm-project?rev=329869&view=rev
Log:
[ODRHash] Skip more types hashing TypedefType
To get the underlying type for TypedefType's, also skip ElaboratedType's.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
DHowett-MSFT added a comment.
Hi! Is there anything else holding up this patch? Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D45305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
malaperle added a comment.
In https://reviews.llvm.org/D44882#1064196, @sammccall wrote:
> (BTW @hokein has https://reviews.llvm.org/D45513 to add row/col to the index,
> which will allow all the file-reading stuff to be cleaned up, but no need to
> wait on that since it's all working now).
L
malaperle updated this revision to Diff 142112.
malaperle marked 2 inline comments as done.
malaperle added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44882
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
smeenai added a comment.
This LGTM given that Eric accepted your previous change. I'm happy to accept it
in a day or two if he hasn't gotten the chance to take a look by then.
Comment at: libcxx/CMakeLists.txt:101
+if (FUCHSIA)
+ set(ABI_VERSION_DEFAULT 2)
+else()
---
Author: zinovy.nis
Date: Wed Apr 11 22:41:24 2018
New Revision: 329873
URL: http://llvm.org/viewvc/llvm-project?rev=329873&view=rev
Log:
[clang-tidy] [modernize-use-auto] Get only a length of token, not the token
itself
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseAutoCheck.cpp
Author: zinovy.nis
Date: Wed Apr 11 22:45:16 2018
New Revision: 329875
URL: http://llvm.org/viewvc/llvm-project?rev=329875&view=rev
Log:
[Documentation] Fix options order for Release Notes in modernize-use-auto.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-auto.rst
Author: ahatanak
Date: Wed Apr 11 23:01:41 2018
New Revision: 329879
URL: http://llvm.org/viewvc/llvm-project?rev=329879&view=rev
Log:
[Sema][ObjC] Ensure that the return type of an ObjC method is a complete
type.
Copy the code in ActOnStartOfFunctionDef that checks a function's return
type to Ac
TimF added a comment.
In https://reviews.llvm.org/D28462#1064789, @enyquist wrote:
> As far as I know, there are no updates required from me for this pull
> request-- I rebased on the main trunk recently, and will do it again tonight
> to be sure. So it should be compiling/working just fine.
>
cpplearner added a comment.
I do not have commit access. Could someone commit the change for me?
https://reviews.llvm.org/D45403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: theraven
Date: Wed Apr 11 23:46:15 2018
New Revision: 329882
URL: http://llvm.org/viewvc/llvm-project?rev=329882&view=rev
Log:
ObjCGNU: Fix empty v3 protocols being emitted two fields short
Summary:
Protocols that were being referenced but could not be fully realized were being
emitted w
Author: zinovy.nis
Date: Wed Apr 11 23:45:47 2018
New Revision: 329881
URL: http://llvm.org/viewvc/llvm-project?rev=329881&view=rev
Log:
[clang-tidy] [modernize-use-auto] Fix test
modernize-use-auto-new-remove-stars.cpp after improvement
'tooling::fixit::getText' considers a length of "int *" t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329882: ObjCGNU: Fix empty v3 protocols being emitted two
fields short (authored by theraven, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45305
Files:
lib/CodeGen/CGObjCGNU.cpp
v.g.vassilev added inline comments.
Comment at: test/CXX/except/except.spec/libc-empty-except.cpp:27
+#else
+#include "mm_malloc.h"
+#include "stdlib.h"
Maybe we should reverse the includes here as we discussed offline.
https://reviews.llvm.org/D43871
__
baloghadamsoftware updated this revision to Diff 141955.
baloghadamsoftware added a comment.
Herald added a reviewer: george.karpenkov.
Rebased to the newly committed SValbuilder rearranger patch
https://reviews.llvm.org/D35110
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
test/
ilya-biryukov added inline comments.
Comment at: clangd/GlobalCompilationDatabase.cpp:24
+ // Parsing as Objective C++ is friendly to more cases.
+ if (llvm::sys::path::extension(File) == ".h")
+Argv.push_back("-xobjective-c++-header");
sammccall wrote:
> i
Author: hokein
Date: Wed Apr 11 01:13:07 2018
New Revision: 329784
URL: http://llvm.org/viewvc/llvm-project?rev=329784&view=rev
Log:
[Tooling] Optimize memory usage in InMemoryToolResults.
Avoid storing duplicated "std::string"s.
clangd's global-symbol-builder takes 20+GB memory running across L
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329784: [Tooling] Optimize memory usage in
InMemoryToolResults. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45479?vs=141842&id=141956#toc
Repository:
rC Cl
sammccall updated this revision to Diff 141957.
sammccall added a comment.
Herald added a subscriber: mgorny.
Add test, shave required yaks
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45442
Files:
clangd/GlobalCompilationDatabase.cpp
clangd/GlobalCompilationDatabase.h
sammccall added a comment.
Added a unit test, and cleaned up a couple of things to make it pass:
- GlobalCompilationDatabase.h wasn't self-contained due to incomplete types
- testPath() isn't very usable with subdirectories on windows
Comment at: clangd/GlobalCompilationDataba
dberris updated this revision to Diff 141958.
dberris marked an inline comment as done.
dberris added a comment.
Herald added a subscriber: mgorny.
- Rebase
- Address comments to use a bitmask/bitset for instrumentation bundle
https://reviews.llvm.org/D44970
Files:
clang/include/clang/Basic/X
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a subscriber: klimek.
"-std c++11" is not valid in compiler, we have to use "-std=c++11".
Test in vscode with this patch, code completion for header works as expected.
Repository:
rC Clang
https://reviews.llvm.org
dim added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D45406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D45512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: MaskRay, ioeric, jkorous-apple, ilya-biryukov, klimek.
LSP is using Line & column as symbol position, clangd needs to transfer file
offset to Line & column when sending results back to LSP client, which is
Author: hokein
Date: Wed Apr 11 02:18:18 2018
New Revision: 329786
URL: http://llvm.org/viewvc/llvm-project?rev=329786&view=rev
Log:
[Tooling] Correct the "-std" compile command option.
Summary:
"-std c++11" is not valid in compiler, we have to use "-std=c++11".
Test in vscode with this patch, c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329786: [Tooling] Correct the "-std" compile
command option. (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D45512
Files:
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/TokenAnnotator.cpp:773
case tok::r_brace:
- // Lines can start with '}'.
- if (Tok->Previous)
+ // Lines can start with '
rsmith added inline comments.
Comment at: lib/Sema/SemaExceptionSpec.cpp:312
+OldProto->getReturnType(), OldProto->getParamTypes(),
+OldProto->getExtProtoInfo().withExceptionSpec(EST_DynamicNone)));
+return false;
Updating the old function's t
sammccall added a comment.
Is this patch still relevant after haojian's string deduplication?
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:53
+/// Combines occurrences of the same symbols across translation units.
+class SymbolMerger {
miyuki added a comment.
ping
https://reviews.llvm.org/D45255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jdemeule updated this revision to Diff 141969.
jdemeule marked 3 inline comments as done.
jdemeule added a comment.
Sort replacements before converting them to AtomicChange.
https://reviews.llvm.org/D43764
Files:
clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacem
JonasToth updated this revision to Diff 141970.
JonasToth added a comment.
- remove shifting exception for standarized bitmask types
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45414
Files:
clang-tidy/hicpp/SignedBitwiseCheck.cpp
docs/ReleaseNotes.rst
test/clang-tidy/h
sammccall added inline comments.
Comment at: clangd/index/Index.h:27
struct SymbolLocation {
+ struct Position {
+// Line position in a document (zero-based).
There are 4 of these per symbol, if we can keep line + character to 32 bits we
save 16 bytes per
JonasToth closed this revision.
JonasToth added a comment.
Commit in https://reviews.llvm.org/rCTE329789
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good to me, thank you
Repository:
rC Clang
https://reviews.llvm.org/D45406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
avt77 added a comment.
In https://reviews.llvm.org/D43578#1062950, @thakis wrote:
> @davezarzycki remarks in https://reviews.llvm.org/D45485 that this breaks the
> shared build. The proposed fix there is to make several of clang's modules
> depend on LLVM's IR library ("Core"). This seems weird
szepet marked an inline comment as done.
szepet added a comment.
Hello Aleksei,
Thanks for carrying the ASTImporter improvements (in general)! I will rebase it
and upload for sure, but probably just next week. (After EuroLLVM.)
https://reviews.llvm.org/D38845
___
baloghadamsoftware added a comment.
Thank you for your thorough review, I will do the fixes next week, after the
Euro LLVM.
https://reviews.llvm.org/D33537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
rsmith added inline comments.
Comment at: include/clang/AST/ComparisonCategories.h:68
+ /// \brief A map containing the comparison category values built from the
+ /// standard library. The key is a value of ComparisonCategoryValue.
+ llvm::DenseMap Objects;
W
GBuella added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:188
setFeatureEnabledImpl(Features, "mpx", true);
if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX
setFeatureEnabledImpl(Features, "sgx", true);
craig.
On Wed, Apr 11, 2018 at 10:16 AM Haojian Wu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hokein
> Date: Wed Apr 11 01:13:07 2018
> New Revision: 329784
> ...
>
> ==
> --- cfe/trunk/include/clang/Tooling/E
Anastasia updated this revision to Diff 141975.
Anastasia edited the summary of this revision.
Anastasia added a comment.
Changed to `-cl-std=c++` since it's explicitly defined in spec. We could reuse
`OpenCLVersion` in `LangOpts` but I think it might be cleaner to add separate
`OpenCLCPlusPlusV
Anastasia added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:434
+llvm_unreachable("Unsupported OpenCL C++ version");
+ Builder.defineMacro("__CL_CPP_VERSION_1_0__", "100");
+} else {
There is no such macro in the spec it seems,
russell.gallop added a comment.
We also see an assertion failure prior to the revert. At r329738:
$ cat test.cpp
template struct A {
template using rebind_alloc = _Other;
};
template struct _Wrap_alloc {
template
using rebind_alloc = typename A<_Alloc>::template rebind_all
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, I'd been wondering about that...
Comment at: clangd/index/SymbolCollector.cpp:36
+ return *T;
+return ND;
+ }
uber-nit: these three ret
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329795: [PowerPC] Option for secure plt mode (authored by
spetrovic, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44921?vs=140060&id=141976
Author: spetrovic
Date: Wed Apr 11 05:24:44 2018
New Revision: 329795
URL: http://llvm.org/viewvc/llvm-project?rev=329795&view=rev
Log:
[PowerPC] Option for secure plt mode
This patch enables option for secure plt mode in
clang (-msecure-plt).
Differential Revision: https://reviews.llvm.org/D449
Author: jonastoth
Date: Wed Apr 11 03:22:25 2018
New Revision: 329790
URL: http://llvm.org/viewvc/llvm-project?rev=329790&view=rev
Log:
[clang-tidy] fix buildbots from hicpp-signed-bitwise
The applied patch to diagnose assignment operators introduced
breakage on some architectures. This patch tri
Author: jonastoth
Date: Wed Apr 11 02:53:08 2018
New Revision: 329789
URL: http://llvm.org/viewvc/llvm-project?rev=329789&view=rev
Log:
[clang-tidy] add missing assignment operations in hicpp-signed-bitwise
This patch resolves the bug https://bugs.llvm.org/show_bug.cgi?id=36963.
- implement miss
aheejin updated this revision to Diff 141979.
aheejin added a comment.
- Change personality function name to a unique one
Repository:
rC Clang
https://reviews.llvm.org/D44931
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGCleanup.h
lib/CodeGen/CGException.cpp
kosarev created this revision.
kosarev added reviewers: t.p.northover, rengolin, SjoerdMeijer.
kosarev added a project: clang.
Herald added a subscriber: javed.absar.
https://reviews.llvm.org/D45515
Files:
include/clang/Basic/arm_neon.td
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/arm-neon-direc
On Wed, Apr 11, 2018 at 6:18 AM, Andrew V. Tischenko via Phabricator via
cfe-commits wrote:
> avt77 added a comment.
>
> In https://reviews.llvm.org/D43578#1062950, @thakis wrote:
>
> > @davezarzycki remarks in https://reviews.llvm.org/D45485 that this
> breaks the shared build. The proposed fix
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D45363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
aheejin updated this revision to Diff 141983.
aheejin added a comment.
- Rebase
Repository:
rC Clang
https://reviews.llvm.org/D44931
Files:
lib/CodeGen/CGCXXABI.h
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGCleanup.h
lib/CodeGen/CGException.cpp
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeG
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Sorry about the delay Marc-André - I got stuck on "how to test ClangdLSPServer"
and then distracted!
But this looks great.
Comment at: clangd/ClangdLSPServer.cpp:101
+
sammccall added a comment.
(BTW @hokein has https://reviews.llvm.org/D45513 to add row/col to the index,
which will allow all the file-reading stuff to be cleaned up, but no need to
wait on that since it's all working now).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44882
HsiangKai updated this revision to Diff 141989.
HsiangKai added a comment.
Update the test case for inlined functions. The inlined label will attach to
DISubprogram(..., labels: !n)
Repository:
rC Clang
https://reviews.llvm.org/D45045
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDeb
alexfh added a comment.
In https://reviews.llvm.org/D45405#1063890, @zinovy.nis wrote:
> Roman, I see you've fixed them. Thanks a lot!
> I did not face with these errors on MSVS'201 so had no chance to fix early.
No stress, but as Roman said, please watch the bots after committing a patch:
h
MTC added a comment.
In https://reviews.llvm.org/D45491#1063364, @george.karpenkov wrote:
> @MTC what happens for
>
> this.j = 0;
> for (int i=0; i<100; i++)
> this.j++;
>
>
> ?
@george.karpenkov `this`'s value will remain unchanged, `j` will be
invalidated.
1 void clang_analyz
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you, that's much better!
I'd also appreciate, if you could document the options this check supports in
its .rst document (separately from this patch).
A few more comments inli
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks good to me.
https://reviews.llvm.org/D45515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: jkorous
Date: Wed Apr 11 06:36:29 2018
New Revision: 329804
URL: http://llvm.org/viewvc/llvm-project?rev=329804&view=rev
Log:
[Sema] Fix built-in decrement operator overload resolution
C++ [over.built] p4:
"For every pair (T, VQ), where T is an arithmetic type other than bool, and VQ
is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329804: [Sema] Fix built-in decrement operator overload
resolution (authored by jkorous, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44988
MTC marked 2 inline comments as done.
MTC added inline comments.
Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1024-1027
+ // 'this' pointer is not an lvalue, we should not invalidate it.
+ if (CXXThisRegion::classof(baseR))
+return;
+
NoQ wrote:
> I
lebedev.ri updated this revision to Diff 141997.
lebedev.ri added a reviewer: alexfh.
lebedev.ri added a comment.
After a quick IRC chat with @aaron.ballman, it was discovered that there has
been a big misunderstanding:
we don't need to ignore/exempt *all* the variables declared in macros, we
zinovy.nis added a comment.
The build was broken by someone else's commit then. From my side there was
a warning only I fixed immediately.
ср, 11 апр. 2018 г. в 16:26, Alexander Kornienko via Phabricator <
revi...@reviews.llvm.org>:
> alexfh added a comment.
>
> In https://reviews.llvm.org/D454
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some minor nits, LGTM!
Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:28
+// Do not count decomposition declarations (C++17's structure
rnkovacs created this revision.
rnkovacs added reviewers: george.karpenkov, NoQ, dcoughlin.
Herald added subscribers: a.sidorin, szepet, baloghadamsoftware, whisperity,
fhahn.
This is a prototype of a bug reporter visitor that invalidates bug reports by
re-checking constraints of certain states
lebedev.ri updated this revision to Diff 142003.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.
- Drop stale comment
- Switch to pre{in,de}crement
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44602
Files:
clang-tidy/readability/FunctionSizeCheck.cp
While you're here... ++ should not be available for bool in C++17 onwards.
:)
On Wed, 11 Apr 2018, 14:39 Jan Korous via cfe-commits, <
cfe-commits@lists.llvm.org> wrote:
> Author: jkorous
> Date: Wed Apr 11 06:36:29 2018
> New Revision: 329804
>
> URL: http://llvm.org/viewvc/llvm-project?rev=3298
Author: mcrosier
Date: Wed Apr 11 07:20:37 2018
New Revision: 329810
URL: http://llvm.org/viewvc/llvm-project?rev=329810&view=rev
Log:
[Driver] Don't forward -m[no-]unaligned-access options to GCC when
assembling/linking
Differential Revision: https://reviews.llvm.org/D45092
Modified:
cfe/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329810: [Driver] Don't forward -m[no-]unaligned-access
options to GCC when… (authored by mcrosier, committed by ).
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/
avt77 added a comment.
In https://reviews.llvm.org/D43578#1064113, @russell.gallop wrote:
> We also see an assertion failure prior to the revert. At r329738:
Yes, you're right - thaks again for this test case.
Repository:
rL LLVM
https://reviews.llvm.org/D43578
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329813: [clang-apply-replacements] Convert
tooling::Replacements to tooling… (authored by malcolm.parsons, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revie
Author: malcolm.parsons
Date: Wed Apr 11 07:39:17 2018
New Revision: 329813
URL: http://llvm.org/viewvc/llvm-project?rev=329813&view=rev
Log:
[clang-apply-replacements] Convert tooling::Replacements to
tooling::AtomicChange for conflict resolving of changes, code cleanup, and code
formatting.
S
Author: kosarev
Date: Wed Apr 11 07:43:11 2018
New Revision: 329814
URL: http://llvm.org/viewvc/llvm-project?rev=329814&view=rev
Log:
[NEON] Support vfma_n and vfms_n intrinsics
Differential Revision: https://reviews.llvm.org/D45483
Modified:
cfe/trunk/include/clang/Basic/arm_neon.td
cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rC329814: [NEON] Support vfma_n and vfms_n intrinsics
(authored by kosarev, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D45483
Files:
include/clang/Basic/arm_neon.td
test/CodeGen/aa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329814: [NEON] Support vfma_n and vfms_n intrinsics
(authored by kosarev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45483?vs=141828&id=1
Author: klimek
Date: Wed Apr 11 07:51:54 2018
New Revision: 329816
URL: http://llvm.org/viewvc/llvm-project?rev=329816&view=rev
Log:
Fix bugs around handling C++11 attributes.
Previously, we would format:
int a() { ... }
[[unused]] int b() { ... }
as...
int a() {} [[unused] int b() {}
Now w
benhamilton created this revision.
benhamilton added reviewers: djasper, jolesiak.
Herald added subscribers: cfe-commits, klimek.
This diff improves the Objective-C guessing heuristic by
replacing the hard-coded list of a subset of Objective-C @keywords
with a general check which supports all @key
smeenai created this revision.
smeenai added reviewers: compnerd, majnemer, rnk.
When we enter a __finally block, the CGF's CurCodeDecl will be null
(because CodeGenFunction::StartFunction is given an empty GlobalDecl for
a __finally block), and so the dyn_cast here will result in an assertion
fai
smeenai added inline comments.
Comment at: test/CodeGen/exceptions-seh-finally.c:281
+// CHECK-LABEL: define internal void @"?fin$0@0@finally_with_func@@"({{[^)]*}})
+// CHECK: call void @cleanup_with_func(i8* getelementptr inbounds ([18 x i8],
[18 x i8]* @"??_C@_0BC@COAGBPGM@fi
MTC updated this revision to Diff 142026.
MTC marked 2 inline comments as done.
MTC added a comment.
- Move the `CXXThisRegion`'s check to `LoopWidening.cpp`
- Use `isa(R)` instead of `CXXThisRegion::classof(R)`.
Repository:
rC Clang
https://reviews.llvm.org/D45491
Files:
lib/StaticAnalyze
davidxl added a comment.
The behavior will change if the shared libraries are not 'dlopen'ed but loaded
at program startup time.
https://reviews.llvm.org/D45454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
aprantl added a comment.
What's your use-case for this?
Comment at: test/CodeGen/no-ident-version.c:4
+// CHECK-NOT: llvm.ident
+// CHECK-NOT: producer:
+int main(void) {}
You'll also want to check for something positive, otherwise this test will
succeed even
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Comment at: test/CodeGen/exceptions-seh-finally.c:281
+// CHECK-LABEL: define internal void @"?fin$0@0@finally_with_func@@"({{[^)]*}})
+// CHECK: call void @cleanup_w
benhamilton created this revision.
benhamilton added reviewers: djasper, jolesiak.
Herald added subscribers: cfe-commits, klimek.
Previously, `clang-format` would break Objective-C
category extensions after the opening parenthesis to avoid
breaking the protocol list:
% echo "@interface
Author: dim
Date: Wed Apr 11 10:21:52 2018
New Revision: 329827
URL: http://llvm.org/viewvc/llvm-project?rev=329827&view=rev
Log:
Document -std= values for different languages
Summary:
After a remark on a FreeBSD mailing list that the clang man page did
not have any list of possible values for th
phosek created this revision.
phosek added reviewers: EricWF, beanz.
Herald added subscribers: cfe-commits, christof, mgorny.
This is neeeded since the CMake value is used for the SOVERSION.
Repository:
rCXX libc++
https://reviews.llvm.org/D45529
Files:
libcxx/CMakeLists.txt
Index: libcx
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329827: Document -std= values for different languages
(authored by dim, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45406?vs=141529&id=142
1 - 100 of 127 matches
Mail list logo
