[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel added a comment. Ok, I found the problem. In fact the size of `long` is 4 bytes on your machine, but 8 bytes on mine. This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],` fail. Do you know a smart way to do it without dealing with type sizes ? Repository: rC Clan

[PATCH] D44093: [BUILTINS] structure pretty printer

lebedev.ri added inline comments. Comment at: test/CodeGen/dump-struct-builtin.c:1 +// RUN: %clang_cc1 -emit-llvm %s -o - | FileCheck %s + This should be ``` // RUN: %clang_cc1 -triple=x86_64-pc-linux-gnu -emit-llvm %s -o - | FileCheck %s ``` or something Repo

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson added a comment. In https://reviews.llvm.org/D44093#1063679, @paulsemel wrote: > Ok, I found the problem. In fact the size of `long` is 4 bytes on your > machine, but 8 bytes on mine. > This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],` > fail. > Do you know

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson added a comment. In https://reviews.llvm.org/D44093#1063679, @paulsemel wrote: > Ok, I found the problem. In fact the size of `long` is 4 bytes on your > machine, but 8 bytes on mine. > This makes this `// CHECK: [[LOAD1:%[0-9]+]] = load i64, i64* [[RES1]],` > fail. > Do you know

[PATCH] D45500: [MinGW] Look for libc++ headers in a triplet prefixed path as well

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Driver/ToolChains/MinGW.cpp:459 addSystemInclude(DriverArgs, CC1Args, + Base + Arch + llvm::sys::path::get_separator() + +

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel added a comment. Thanks a lot for your help, updating the patch ! Repository: rC Clang https://reviews.llvm.org/D44093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r329762 - Introduce a new builtin, __builtin_dump_struct, that is useful for dumping structure contents at runtime in circumstances where debuggers may not be easily available (such as in kernel work)

Author: aaronballman Date: Tue Apr 10 14:58:13 2018 New Revision: 329762 URL: http://llvm.org/viewvc/llvm-project?rev=329762&view=rev Log: Introduce a new builtin, __builtin_dump_struct, that is useful for dumping structure contents at runtime in circumstances where debuggers may not be easily a

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman closed this revision. aaron.ballman added a comment. I see we all found the solution at the same time. Yay teamwork! :-D I've committed (with the test fixed up) in r329762. Repository: rC Clang https://reviews.llvm.org/D44093 ___ c

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added a comment. In https://reviews.llvm.org/D44093#1063658, @paulsemel wrote: > Sorry about it, I also have the warning on my machine, but not the error you > get... > Those test are actually working on my different linux machines, that's > really weird. > This one is actually

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 141920. paulsemel added a comment. Added triple option to CodeGen test so that it matches with the correct architecture Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp lib/Se

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

rnk added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:3889 + if (Context.getTargetInfo().getCXXABI().isMicrosoft() && + hasFunctionProto(D) && isFunctionOrMethodVariadic(D)) { Why is this warning dependent on the ABI? GCC has a similar warning:

[PATCH] D45454: Make __gcov_flush visible outside a shared library

chh added a comment. If we use the unit test case, call `__gcov_flush` from the main function, and dump static variables in GCDAProfiling.c, we can see that `__gcov_flush` is resolved to the same copy for func.shared, func2.shared, and main. However, when `__gcov_flush` is called from main and fro

r329766 - [AST] Fix some Clang-tidy modernize-use-auto and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Apr 10 15:54:42 2018 New Revision: 329766 URL: http://llvm.org/viewvc/llvm-project?rev=329766&view=rev Log: [AST] Fix some Clang-tidy modernize-use-auto and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/ExprCXX.h

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

EricWF added inline comments. Comment at: libcxx/CMakeLists.txt:100 "LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY;LIBCXX_INSTALL_LIBRARY" OFF) -set(LIBCXX_ABI_VERSION 1 CACHE STRING "ABI version of libc++.") +if (FUCHSIA) + set(ABI_VERSION_DEFAULT 2) I don't thin

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

phosek updated this revision to Diff 141933. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D45304 Files: libcxx/include/__config Index: libcxx/include/__config === --- libcxx/include

[PATCH] D45061: [NVPTX, CUDA] Use custom feature detection to handle NVPTX target builtins.

tra updated this revision to Diff 141932. tra added a comment. @echristo convinced me that this functionality can be implemented without growing a target-specific hook for custom interpretation of constraints used in TARGET_BUILTIN. Instead, we can hide unwieldy feature lists behind a macro. h

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Comment at: libcxx/include/__config:39 #ifndef _LIBCPP_ABI_VERSION +#ifdef __Fuchsia__ +#define _LIBCPP_ABI_VERSION 2 Please indent these nested `#ifd

[PATCH] D45060: Allow target to handle required features for TARGET_BUILTINs.

tra abandoned this revision. tra marked an inline comment as done. tra added a comment. I've figured out a manageable way to enforce constraints without this change. https://reviews.llvm.org/D45060 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D45061: [NVPTX, CUDA] Improved feature constraints on NVPTX target builtins.

echristo accepted this revision. echristo added a comment. Guessing that SM_60 (etc) are defines? Anyhow LGTM. I'm not sure you can split up the satom part of the patch, but if you can that'd be great. -eric https://reviews.llvm.org/D45061 ___ cf

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

phosek updated this revision to Diff 141935. phosek marked an inline comment as done. Repository: rCXX libc++ https://reviews.llvm.org/D45304 Files: libcxx/include/__config Index: libcxx/include/__config === --- libcxx/include

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 141938. Wizard added a comment. move check to readability-identifier-naming Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming-objc.m

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Eugene.Zelenko added a comment. How about doing same for //objc-property-declaration//? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added a comment. In https://reviews.llvm.org/D45392#1063164, @alexfh wrote: > In https://reviews.llvm.org/D45392#1061960, @Wizard wrote: > > > In https://reviews.llvm.org/D45392#1061433, @alexfh wrote: > > > > > I wonder whether the readability-identifier-naming check could be > > > exten

[libcxx] r329770 - [libcxx] Set ABI version 2 as default for Fuchsia

Author: phosek Date: Tue Apr 10 18:06:28 2018 New Revision: 329770 URL: http://llvm.org/viewvc/llvm-project?rev=329770&view=rev Log: [libcxx] Set ABI version 2 as default for Fuchsia This avoids the need for a custom generated config file which is desired because the custom config files differs p

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL329770: [libcxx] Set ABI version 2 as default for Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45304?vs=141935

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Sure. Comment at: clang/lib/Driver/XRayArgs.cpp:168 - for (const auto&AttrFile : AttrListFiles) { + for (const auto &AttrFile : AttrListFiles) { SmallString<64>

[PATCH] D44970: [XRay][clang] Add flag to choose instrumentation bundles

echristo added inline comments. Comment at: clang/include/clang/Frontend/CodeGenOptions.h:110 + enum XRayInstrumentationPointBundle { +XRay_All, // Always emit all the instrumentation points. dberris wrote: > pelikan wrote: > > To me, this feel

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

dberris updated this revision to Diff 141940. dberris marked an inline comment as done. dberris added a comment. Revert unnecessary one-liner change. https://reviews.llvm.org/D45474 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/XRayArgs.h clang/lib/Driver/ToolCha

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

This revision was automatically updated to reflect the committed changes. Closed by commit rL329772: [XRay][clang+compiler-rt] Support build-time mode selection (authored by dberris, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D45474?v

r329772 - [XRay][clang+compiler-rt] Support build-time mode selection

Author: dberris Date: Tue Apr 10 18:28:25 2018 New Revision: 329772 URL: http://llvm.org/viewvc/llvm-project?rev=329772&view=rev Log: [XRay][clang+compiler-rt] Support build-time mode selection Summary: This patch implements the `-fxray-modes=` flag which allows users building with XRay instrumen

r329773 - [XRay][clang] Only enable test for supported platforms

Author: dberris Date: Tue Apr 10 18:47:40 2018 New Revision: 329773 URL: http://llvm.org/viewvc/llvm-project?rev=329773&view=rev Log: [XRay][clang] Only enable test for supported platforms This is a follow-up to D45474. Modified: cfe/trunk/test/Driver/XRay/xray-mode-flags.cpp Modified: cfe/

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

BillyONeal accepted this revision. BillyONeal added a comment. This revision is now accepted and ready to land. It actually looks like I accidentally committed this back in January so I'm going to close this :) https://reviews.llvm.org/D41748 ___ c

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

EricWF added inline comments. Comment at: include/clang/AST/ComparisonCategories.h:155-158 + const ComparisonCategoryInfo &getInfo(ComparisonCategoryKind Kind) const { +assert(HasData && "comparison category information not yet built"); +return Data[static_cast(Kind)]; +

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

NoQ added a comment. I mean, like, if we try to work with the existing AST then we're stuck with a prvalue expression that represents an lvalue and will be assigned a `Loc` value, which is pretty weird anyway. Getting rid of the ParentMap in favor of providing enough context (eg. in the CFG or

Re: [PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

Roman, I see you've fixed them. Thanks a lot! I did not face with these errors on MSVS'201 so had no chance to fix early. ср, 11 апр. 2018 г. в 0:02, Roman Lebedev via Phabricator < revi...@reviews.llvm.org>: > lebedev.ri added a comment. > > This change had two different problems. > Please wat

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

zinovy.nis added a subscriber: angelgarcia. zinovy.nis added a comment. Roman, I see you've fixed them. Thanks a lot! I did not face with these errors on MSVS'201 so had no chance to fix early. ср, 11 апр. 2018 г. в 0:02, Roman Lebedev via Phabricator < revi...@reviews.llvm.org>: > lebedev.ri a

r329775 - [X86] Replace 512-bit masked pmaddubsw and pmaddwd intrinsic with unmasked intrinsic and a select.

Author: ctopper Date: Tue Apr 10 21:55:10 2018 New Revision: 329775 URL: http://llvm.org/viewvc/llvm-project?rev=329775&view=rev Log: [X86] Replace 512-bit masked pmaddubsw and pmaddwd intrinsic with unmasked intrinsic and a select. This makes it consistent with the 128/256-bit functions. Somed

r329777 - [X86] Fix typo in intrinsic header file __mask16->__mmask16 from r329775.

Author: ctopper Date: Tue Apr 10 22:17:14 2018 New Revision: 329777 URL: http://llvm.org/viewvc/llvm-project?rev=329777&view=rev Log: [X86] Fix typo in intrinsic header file __mask16->__mmask16 from r329775. Modified: cfe/trunk/lib/Headers/avx512bwintrin.h Modified: cfe/trunk/lib/Headers/avx

[PATCH] D44878: Adding fuzzer flags support to OpenBSD driver

devnexen added a comment. Hope it s good enough now :-) https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44878: Adding fuzzer flags support to OpenBSD driver

dberris added a comment. ACK -- let me land now. :) https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45511: [CMake][Fuchsia] Don't specify libc++ ABI version for Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. This is now set automatically in libc++ config header. Repository: rC Clang https://reviews.llvm.org/D45511 Files: cla

r329779 - Adding fuzzer flags support to OpenBSD driver

Author: dberris Date: Tue Apr 10 22:40:47 2018 New Revision: 329779 URL: http://llvm.org/viewvc/llvm-project?rev=329779&view=rev Log: Adding fuzzer flags support to OpenBSD driver Summary: - Following-up the sanitizer's part commit https://reviews.llvm.org/rCRT329631, we enable fuzzer flags. Re

[PATCH] D44878: Adding fuzzer flags support to OpenBSD driver

This revision was automatically updated to reflect the committed changes. Closed by commit rC329779: Adding fuzzer flags support to OpenBSD driver (authored by dberris, committed by ). Repository: rC Clang https://reviews.llvm.org/D44878 Files: lib/Driver/ToolChains/OpenBSD.cpp Index: lib

r329780 - [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

Author: baloghadamsoftware Date: Tue Apr 10 23:21:12 2018 New Revision: 329780 URL: http://llvm.org/viewvc/llvm-project?rev=329780&view=rev Log: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option) Since the range-based constraint manager (default) is weak in h

[PATCH] D41938: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer Option)

This revision was automatically updated to reflect the committed changes. Closed by commit rL329780: [Analyzer] SValBuilder Comparison Rearrangement (with Restrictions and Analyzer… (authored by baloghadamsoftware, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D45500: [MinGW] Look for libc++ headers in a triplet prefixed path as well

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:459 addSystemInclude(DriverArgs, CC1Args, + Base + Arch + llvm::sys::path::get_separator() + + "include" + llvm::sys::path::get_separator() + -

<    1   2   3