[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

aaron.ballman added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92 + if (N.getNodeAs("std_type")) +diag(Location, "shifting a value of the standardized bitmask types"); + else JonasToth wrote: > aaron.ballman wrote: > > How about: "

[PATCH] D45004: [clang-format] Always indent wrapped Objective-C selector names

benhamilton updated this revision to Diff 141872. benhamilton added a comment. - Unconditionally indent wrapped ObjC selector names. - Partially revert r242484, as it was causing double-indenting (the tests still pass with it reverted, so I suspect it's no longer necessary). Repository: rC Cl

[PATCH] D45004: [clang-format] Always indent wrapped Objective-C selector names

benhamilton added a comment. > Ok, you know the ObjC community much better than I do. If you think that > adding the indentation for ObjC irrespective of the option works for most > people, I am happy to go with it. OK, I went ahead and implemented unconditional indenting of wrapped ObjC selec

[PATCH] D45005: [clang-format] Set IndentWrappedObjCMethodNames to Always in google style

benhamilton abandoned this revision. benhamilton added a comment. Abandoned in favor of unconditionally indenting wrapped ObjC selectors in https://reviews.llvm.org/D45004. Repository: rC Clang https://reviews.llvm.org/D45005 ___ cfe-commits mai

[clang-tools-extra] r329720 - [clang-tidy] Adding alias for anon namespaces in header (fuchsia module)

Author: juliehockett Date: Tue Apr 10 09:53:51 2018 New Revision: 329720 URL: http://llvm.org/viewvc/llvm-project?rev=329720&view=rev Log: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module) Adding alias to google-build-namespaces to the Fuchsia module (checks for anonymous n

[PATCH] D45447: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module)

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE329720: [clang-tidy] Adding alias for anon namespaces in header (fuchsia module) (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D45447?vs=141679&id=141874

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

Also, the standard for the static analyzer is not lower than it is for the compiler. The static analyzer tries to catch a much larger class of bugs, but it also tries very hard to make all the warnings it emits count. There’s a really common problem in the static analysis field where users try a s

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

JonasToth added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92 + if (N.getNodeAs("std_type")) +diag(Location, "shifting a value of the standardized bitmask types"); + else aaron.ballman wrote: > JonasToth wrote: > > aaron.ballman wr

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

On Tue, Apr 10, 2018 at 9:59 AM John McCall wrote: > Also, the standard for the static analyzer is not lower than it is for the > compiler. > > The static analyzer tries to catch a much larger class of bugs, but it > also tries very hard to make all the warnings it emits count. There’s a > really

[PATCH] D44988: [Sema] Fix decrement availability for built-in types

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. https://reviews.llvm.org/D44988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added a comment. Tuesday ping! I just need someone to commit this for me. Repository: rC Clang https://reviews.llvm.org/D43322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

JonasToth added inline comments. Comment at: clang-tidy/zircon/HumanReadableStatusCheck.cpp:68 +SourceRange FmtStringRange; +for (const auto *Arg : D->arguments()) { + if (const auto *ICE = dyn_cast(Arg)) { Did you consider using `forEachArgumentWith

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/zircon-human-readable-status.rst:6 + +Suggests fix for printf-family functions with a zx_status_t argument to convert +status argument to a human-readable string (zx_status_t is a Zircon kernel -

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

On Tue, Apr 10, 2018 at 12:59 PM, John McCall wrote: > Also, the standard for the static analyzer is not lower than it is for the > compiler. > > The static analyzer tries to catch a much larger class of bugs, but it > also tries very hard to make all the warnings it emits count. There’s a > real

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

Do you think they’re bad precedent? Do you have a replacement for that approach to warning about those problems? Because they certainly were precedent for -Wfallthrough, and they certainly catch a class of bugs at least as large and important as that warning, and they certainly have exactly the sam

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel added a comment. In https://reviews.llvm.org/D44093#1063122, @arichardson wrote: > I'm also often restricted to using printf for debugging so this looks really > useful! > > However, before committing this I feel like the test should also verify that > the format strings that are gene

[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness

JonasToth added a comment. > It'll be good idea to have option to apply this check for pointer/references > only, or include built-in types/enums. Agreed. I aim at a `mark handles const`(default on), `mark values const`(default on for objects), `mark pointer (const int * >> const <<) const` (d

[PATCH] D45414: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

aaron.ballman added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:92 + if (N.getNodeAs("std_type")) +diag(Location, "shifting a value of the standardized bitmask types"); + else JonasToth wrote: > aaron.ballman wrote: > > JonasToth wr

[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D45444#1063291, @JonasToth wrote: > > It'll be good idea to have option to apply this check for > > pointer/references only, or include built-in types/enums. > > Agreed. I aim at a `mark handles const`(default on), `mark values > const

[clang-tools-extra] r329725 - [clangd] Use operator<< to prevent printers issues in Gtest

Author: malaperle Date: Tue Apr 10 10:34:46 2018 New Revision: 329725 URL: http://llvm.org/viewvc/llvm-project?rev=329725&view=rev Log: [clangd] Use operator<< to prevent printers issues in Gtest Summary: It is possible that there will be two different instantiations of the printer template for a

[PATCH] D45422: [Driver] Allow drivers to add multiple libc++ include paths

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D45422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle added a comment. Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

This revision was automatically updated to reflect the committed changes. Closed by commit rL329725: [clangd] Use operator<< to prevent printers issues in Gtest (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44764

[PATCH] D44975: Change DEBUG() macro to LLVM_DEBUG()

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D44975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D44976: Change DEBUG() macro to LLVM_DEBUG() in clang-tools-extra

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. Could you help me with revert of the committed patch? I'll do all necessary changes but I don't know how I can revert the patch. Repository: rL LLVM https://reviews.llvm.org/D43578 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D44093: [BUILTINS] structure pretty printer

arichardson accepted this revision. arichardson added a comment. > So, for the moment, we are only handling basic types. That said, for the enum > in C, we will print according to the type of the enum. > In the future versions, I really want to be able to print the name of the > enum so that th

[PATCH] D45417: [analyzer] Don't crash on printing ConcreteInt of size >64 bits

george.karpenkov added a comment. > I have removed the FIXME at all 👍 Repository: rC Clang https://reviews.llvm.org/D45417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D45234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D43578: -ftime-report switch support in Clang

avt77 reopened this revision. avt77 added a comment. This revision is now accepted and ready to land. Obviously, this patch was not ready for commit that's why I reopen the revison. But I don't know how to revert the patch from trunk: please, help me. Repository: rL LLVM https://reviews.llvm.

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel added a comment. I don't really know what's the procedure right now.. What should I do once you both accepted the patch ? :) Repository: rC Clang https://reviews.llvm.org/D44093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

On Tue, Apr 10, 2018 at 10:20 AM John McCall wrote: > Do you think they’re bad precedent? Somewhat, yes - though -Wparens is perhaps conflating a few cases too. I think the argument for the -Wparens for precedence is probably pretty good. But the argument for -Wparens for conditional assignmen

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

tra created this revision. tra added a reviewer: jlebar. Herald added a subscriber: sanjoy. Currently we always include PTX into the fatbin along with the GPU code. It about doubles the size of the GPU binary we need to carry in the executable. These options allow control inclusion of PTX into GPU

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added a comment. In https://reviews.llvm.org/D44093#1063340, @paulsemel wrote: > I don't really know what's the procedure right now.. What should I do once > you both accepted the patch ? :) You're good to commit the patch and address the concerns raised by @arichardson in a fol

[PATCH] D45383: Limit types of builtins that can be redeclared.

erichkeane updated this revision to Diff 141876. erichkeane retitled this revision from "Strip reference from a va_list object in C when merging parameter types." to "Limit types of builtins that can be redeclared.". erichkeane edited the summary of this revision. erichkeane added a comment. Eli

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

george.karpenkov added a comment. @MTC what happens for this.j = 0; for (int i=0; i<100; i++) this.j++; ? Repository: rC Clang https://reviews.llvm.org/D45491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D43578: -ftime-report switch support in Clang

davezarzycki added a comment. A revert in practice just means undoing the changes. For example, while both `git` and `svn` have `revert` subcommands, you can also just take the original diff/patch, pipe it into `patch -R`, and if there are no conflicts, commit the result. Repository: rL LLV

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

a.sidorin added a comment. Maybe we should just remove the condition and leave a FIXME? Repository: rC Clang https://reviews.llvm.org/D45416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D45403: Make [[maybe_unused]] work with static data members

cpplearner added a comment. In https://reviews.llvm.org/D45403#1062276, @aaron.ballman wrote: > I don't think we're currently diagnosing static data members of classes as > being unused in the first place; are there plans to implement that > functionality so that someone might want to write the

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Where do we document the default values for these flags? Like, how is a user supposed to figure out whether the default is to include ptx or not? https://reviews.llvm.org/D45495 _

[clang-tools-extra] r329730 - [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

Author: zinovy.nis Date: Tue Apr 10 11:05:24 2018 New Revision: 329730 URL: http://llvm.org/viewvc/llvm-project?rev=329730&view=rev Log: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto' The threshold option is 'MinTypeNameLength' with defa

[PATCH] D45383: Limit types of builtins that can be redeclared.

efriedma added inline comments. Comment at: test/Sema/builtin-redecl.cpp:9 +// Overloading a builtin is acceptable in C++. +void __builtin_va_copy(double d); +#endif We don't want to allow this; in particular, for builtins with custom type-checking, we have no w

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

This revision was automatically updated to reflect the committed changes. Closed by commit rL329730: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length… (authored by zinovy.nis, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

elram added a comment. Herald added subscribers: llvm-commits, delcypher. This patch breaks cross-compiling the builtins for i686, with COMPILER_RT_DEFAULT_TARGET_ONLY=YES. CC is set to clang -target i686-linux-musl -m32 -march=i686 But no supported target is detected by cmake and nothing get

[PATCH] D45416: [analyzer] ExprEngine: model GCC inline asm rvalue cast outputs

NoQ added a comment. In https://reviews.llvm.org/D45416#1062901, @a.sidorin wrote: > > The ultimate solution would probably be to add a fake cloned asm statement > > to the CFG (instead of the real asm statement) that would point to the > > correct output child-expression(s) that are untouched

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

tra updated this revision to Diff 141882. tra added a comment. Documented new options in ClangCommandLineReference.rst https://reviews.llvm.org/D45495 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Cuda.cpp clang/test/Dr

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

tra added a comment. In https://reviews.llvm.org/D45495#1063370, @jlebar wrote: > Where do we document the default values for these flags? Like, how is a user > supposed to figure out whether the default is to include ptx or not? I've updated docs/ClangCommandLineReference.rst. https://revi

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

jlebar added a comment. lgtm! https://reviews.llvm.org/D45495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45403: Make [[maybe_unused]] work with static data members

cpplearner updated this revision to Diff 141880. cpplearner added a comment. Removed `ExpectedForMaybeUnused` from AttributeList.h, and removed the entry for `ExpectedForMaybeUnused` from the `warn_attribute_wrong_decl_type` table definition. https://reviews.llvm.org/D45403 Files: include/c

[PATCH] D44155: Fix support for try_acquire_capability

aaron.ballman added a comment. Ping. https://reviews.llvm.org/D44155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43750: Allow writing calling convention attributes on function types

aaron.ballman added a comment. Ping. https://reviews.llvm.org/D43750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. In https://reviews.llvm.org/D43578#1063365, @davezarzycki wrote: > A revert in practice just means undoing the changes. For example, while both > `git` and `svn` have `revert` subcommands, you can also just take the > original diff/patch, pipe it into `patch -R`, and if t

[PATCH] D45491: [analyzer] Do not invalidate the `this` pointer.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/RegionStore.cpp:1024-1027 + // 'this' pointer is not an lvalue, we should not invalidate it. + if (CXXThisRegion::classof(baseR)) +return; + I don't think this run-time check belongs here. The f

r329735 - [Parser] Fix assertion-on-invalid for unexpected typename.

Author: vsapsai Date: Tue Apr 10 11:29:47 2018 New Revision: 329735 URL: http://llvm.org/viewvc/llvm-project?rev=329735&view=rev Log: [Parser] Fix assertion-on-invalid for unexpected typename. In `ParseDeclarationSpecifiers` for the code class A typename A; we were able to annotate token `k

[PATCH] D44449: [Parser] Fix assertion-on-invalid for unexpected typename.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329735: [Parser] Fix assertion-on-invalid for unexpected typename. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D9

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel added a comment. In https://reviews.llvm.org/D44093#1063348, @aaron.ballman wrote: > In https://reviews.llvm.org/D44093#1063340, @paulsemel wrote: > > > I don't really know what's the procedure right now.. What should I do once > > you both accepted the patch ? :) > > > You're good to

Re: [PATCH] D45165: Use llvm::sys::fs::real_path() in clang.

Thanks Nico! On Tue, Apr 10, 2018 at 6:39 AM, Nico Weber via Phabricator wrote: > thakis added a comment. > > r329698, thanks! > > > https://reviews.llvm.org/D45165 > > > -- Bruno Cardoso Lopes http://www.brunocardoso.cc ___ cfe-commits mailing list

[PATCH] D45495: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

This revision was automatically updated to reflect the committed changes. Closed by commit rC329737: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option. (authored by tra, committed by ). Changed prior to commit: https://reviews.llvm.org/D45495?vs=141882&id=141887#toc Repository: rC Clang

r329737 - [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option.

Author: tra Date: Tue Apr 10 11:38:22 2018 New Revision: 329737 URL: http://llvm.org/viewvc/llvm-project?rev=329737&view=rev Log: [CUDA] Added --[no-]cuda-include-ptx=sm_XX|all option. Currently we always include PTX into the fatbin along with the GPU code.It about doubles the size of the GPU bin

[PATCH] D43578: -ftime-report switch support in Clang

efriedma added a comment. > while both git and svn have revert subcommands This is kind of misleading; yes, both git and svn have subcommands named "revert", but "svn revert" doesn't have the right meaning. You have to use "svn merge" to revert a committed change. Repository: rL LLVM http

r329738 - [X86] Add test case for llvm change r329734

Author: ctopper Date: Tue Apr 10 11:43:44 2018 New Revision: 329738 URL: http://llvm.org/viewvc/llvm-project?rev=329738&view=rev Log: [X86] Add test case for llvm change r329734 This test ensures the popfd instruction in MS inline assembly can properly find a clobber name for the dirflag registe

[PATCH] D45444: [clang-tidy] WIP: implement new check for const-correctness

lebedev.ri added a comment. Thank you for working on this check! Comment at: clang-tidy/cppcoreguidelines/ConstCheck.h:60 + + std::unordered_map ValueCanBeConst; + std::unordered_map HandleCanBeConst; I'm guessing these should be `llvm::DenseMap`. Repositor

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added a comment. Can you rebase the patch? The patch did not apply cleanly for me against trunk (the contents of the check function are appearing in `CheckARMBuiltinExclusiveCall()`). (Also, one tiny nit about escaped characters that can be fixed at the same time.) ===

[PATCH] D43578: -ftime-report switch support in Clang

thakis added a comment. Reverted: $ svn merge -c -329714 . - Reverse-merging r329714 into '.': Atest/Frontend/ftime-report-template-decl.cpp - Recording mergeinfo for reverse merge of r329714 into '.': U . $ svn merge -c -329693 . - Reverse-merging r329693 into '.': Utest/Frontend

r329739 - Revert r329684 (and follow-ups 329693, 329714). See discussion on https://reviews.llvm.org/D43578.

Author: nico Date: Tue Apr 10 11:53:28 2018 New Revision: 329739 URL: http://llvm.org/viewvc/llvm-project?rev=329739&view=rev Log: Revert r329684 (and follow-ups 329693, 329714). See discussion on https://reviews.llvm.org/D43578. Modified: cfe/trunk/include/clang/Frontend/FrontendAction.h

[clang-tools-extra] r329740 - [clang-tidy] [modernize-use-auto] Fix members initialization order

Author: zinovy.nis Date: Tue Apr 10 11:56:29 2018 New Revision: 329740 URL: http://llvm.org/viewvc/llvm-project?rev=329740&view=rev Log: [clang-tidy] [modernize-use-auto] Fix members initialization order Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseAutoCheck.cpp Modified: clang

[PATCH] D45056: [X86] Split up -march=icelake to -client & -server

This revision was automatically updated to reflect the committed changes. Closed by commit rL329741: [X86] Split up -march=icelake to -client & -server (authored by GBuella, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45056?vs=1409

[PATCH] D43578: -ftime-report switch support in Clang

avt77 added a comment. In https://reviews.llvm.org/D43578#1063462, @thakis wrote: > Reverted: Many thanks for your help! Repository: rL LLVM https://reviews.llvm.org/D43578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D45403: Make [[maybe_unused]] work with static data members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D45403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 141890. paulsemel added a comment. Patch rebased. Minor fix for single quotes escaping. Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaChecking.cpp test/CodeGe

r329741 - [X86] Split up -march=icelake to -client & -server

Author: gbuella Date: Tue Apr 10 11:58:26 2018 New Revision: 329741 URL: http://llvm.org/viewvc/llvm-project?rev=329741&view=rev Log: [X86] Split up -march=icelake to -client & -server Reviewers: craig.topper, zvi, echristo Reviewed By: craig.topper Differential Revision: https://reviews.llvm.o

[PATCH] D45498: [clang-format] Don't insert space between ObjC class and lightweight generic

benhamilton created this revision. benhamilton added reviewers: djasper, jolesiak. Herald added subscribers: cfe-commits, klimek. In https://reviews.llvm.org/D45185, I added clang-format parser support for Objective-C generics. However, I didn't touch the whitespace logic, so they got the same sp

r329748 - [Driver] Allow drivers to add multiple libc++ include paths

Author: phosek Date: Tue Apr 10 12:55:55 2018 New Revision: 329748 URL: http://llvm.org/viewvc/llvm-project?rev=329748&view=rev Log: [Driver] Allow drivers to add multiple libc++ include paths This allows toolchain drivers to add multiple libc++ include paths akin to libstdc++. This is useful in

[PATCH] D45422: [Driver] Allow drivers to add multiple libc++ include paths

This revision was automatically updated to reflect the committed changes. Closed by commit rL329748: [Driver] Allow drivers to add multiple libc++ include paths (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45422

[PATCH] D45499: [Driver] Handle the default case

phosek created this revision. phosek added reviewers: rnk, rsmith, dlj. Herald added a subscriber: cfe-commits. This was omitted in https://reviews.llvm.org/D45422 resulting in a warning. Repository: rC Clang https://reviews.llvm.org/D45499 Files: clang/lib/Driver/ToolChains/NaCl.cpp Ind

[clang-tools-extra] r329749 - [clang-tidy][Fuchsia]: don't forget to actually link to Google Module.

Author: lebedevri Date: Tue Apr 10 13:07:02 2018 New Revision: 329749 URL: http://llvm.org/viewvc/llvm-project?rev=329749&view=rev Log: [clang-tidy][Fuchsia]: don't forget to actually link to Google Module. Fixes build for me: [1/7] Linking CXX shared library lib/libclangTidyFuchsiaModule.so.7sv

[clang-tools-extra] r329750 - [clang-tidy][modernize]: don't forget to actually link to Tooling.

Author: lebedevri Date: Tue Apr 10 13:07:06 2018 New Revision: 329750 URL: http://llvm.org/viewvc/llvm-project?rev=329750&view=rev Log: [clang-tidy][modernize]: don't forget to actually link to Tooling. Fixes build for me: [1/5] Linking CXX shared library lib/libclangTidyModernizeModule.so.7svn

r329751 - [OPENMP] Additional attributes for the pointer parameters.

Author: abataev Date: Tue Apr 10 13:10:53 2018 New Revision: 329751 URL: http://llvm.org/viewvc/llvm-project?rev=329751&view=rev Log: [OPENMP] Additional attributes for the pointer parameters. Added attributes for better optimization of the OpenMP code. Modified: cfe/trunk/lib/CodeGen/CGOpen

[PATCH] D45500: [MinGW] Look for libc++ headers in a triplet prefixed path as well

mstorsjo created this revision. mstorsjo added reviewers: martell, rnk, compnerd, mati865. Herald added a reviewer: EricWF. This makes it consistent with libstdc++ and the other default include directories. If these headers are found in both locations and one isn't a symlink to the other, this

[PATCH] D43578: -ftime-report switch support in Clang

davezarzycki added a comment. Hi @efriedma – Sorry about that. I haven't directly used `svn` in years thanks to the `git svn` bridge. Repository: rL LLVM https://reviews.llvm.org/D43578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

r329754 - [Driver] Handle the default case missed in r329748.

Author: mcrosier Date: Tue Apr 10 13:30:16 2018 New Revision: 329754 URL: http://llvm.org/viewvc/llvm-project?rev=329754&view=rev Log: [Driver] Handle the default case missed in r329748. Differential Revision: https://reviews.llvm.org/D45499 Modified: cfe/trunk/lib/Driver/ToolChains/NaCl.cpp

[PATCH] D45499: [Driver] Handle the default case

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC329754: [Driver] Handle the default case missed in r329748. (authored by mcrosier, committed by ). Changed prior to commi

[PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

aaron.ballman added a comment. Thank you for working on this! Comment at: include/clang/AST/ComparisonCategories.h:78 + const DeclRefExpr *getResultValue(ComparisonCategoryResult ValueKind) const { +const auto *DR = getResultValueUnsafe(ValueKind); +assert(DR && --

[PATCH] D45383: Limit types of builtins that can be redeclared.

erichkeane updated this revision to Diff 141900. erichkeane marked an inline comment as done. erichkeane added a comment. Restrict overloads as well. https://reviews.llvm.org/D45383 Files: include/clang/AST/ASTContext.h include/clang/Basic/Builtins.h include/clang/Basic/DiagnosticSemaKind

[PATCH] D43817: [x86] wbnoinvd intrinsic

GBuella updated this revision to Diff 141904. GBuella added a comment. Rebased the patch. https://reviews.llvm.org/D43817 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h l

[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

mstorsjo created this revision. mstorsjo added reviewers: martell, rnk, compnerd, mati865, ismail, yaron.keren. If found, prefer this over looking for a similar gcc later in the system path. This implements what @martell suggested in https://reviews.llvm.org/D45152 in a much neater way. Tests s

[PATCH] D44093: [BUILTINS] structure pretty printer

aaron.ballman added a comment. Thank you for rebasing, but the patch does not pass tests locally for me. I get the following results (testing on Windows x64 with MSVC 2017 in a Debug build): 63> TEST 'Clang :: CodeGen/dump-struct-builtin.c' FAILED 63>Scr

[PATCH] D43817: [x86] wbnoinvd intrinsic

craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:188 setFeatureEnabledImpl(Features, "mpx", true); if (Kind != CK_SkylakeServer) // SKX inherits all SKL features, except SGX setFeatureEnabledImpl(Features, "sgx", true); N

[PATCH] D45505: [WIP] [GCC] Match a GCC version with a patch suffix without a third version component

mstorsjo created this revision. mstorsjo added reviewers: chandlerc, martell, ismail, rnk, compnerd, mati865, yaron.keren. Previously it would only accept a string as a GCC version if it had either two components and no suffix, or three components with an optional suffix. Debian and ubuntu prov

[clang-tools-extra] r329756 - [clang-tidy] Unbreak run-clang-tidy.cpp test (modernize-use-auto.MinTypeNameLength)

Author: lebedevri Date: Tue Apr 10 13:59:27 2018 New Revision: 329756 URL: http://llvm.org/viewvc/llvm-project?rev=329756&view=rev Log: [clang-tidy] Unbreak run-clang-tidy.cpp test (modernize-use-auto.MinTypeNameLength) Again, refs. D45405, rL329730. Modified: clang-tools-extra/trunk/test/c

[PATCH] D45405: [clang-tidy] [modernize-use-auto] Add a threshold for minimal type name length to be replaced with 'auto'

lebedev.ri added a comment. This change had two different problems. Please watch the bots? Repository: rL LLVM https://reviews.llvm.org/D45405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D45504: [MinGW] Look for a cross sysroot relative to the clang binary

mstorsjo updated this revision to Diff 141909. mstorsjo added a comment. Fixed the hardcoded triplet suffix, previously I erroneously had a "-gcc" suffix there. https://reviews.llvm.org/D45504 Files: lib/Driver/ToolChains/MinGW.cpp lib/Driver/ToolChains/MinGW.h Index: lib/Driver/ToolChai

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added inline comments. Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:31 +!(isa(VD) || isa(VD)) && +!VD->getLocation().isMacroID()) + Info.Variables++; aaron.ballman wrote: > This isn't the restriction I was envisioning.

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri updated this revision to Diff 141912. lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. - Update - Ignore GNU Statement Expressions too. - Slightly reword docs. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44602 Files: clang-tidy/readabilit

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel added a comment. Sorry about it, I also have the warning on my machine, but not the error you get... Those test are actually working on my different linux machines, that's really weird. This one is actually really weird, because I could find manually the missing pattern in your output

r329758 - Handle the default case

Author: phosek Date: Tue Apr 10 14:19:05 2018 New Revision: 329758 URL: http://llvm.org/viewvc/llvm-project?rev=329758&view=rev Log: Handle the default case This was omitted in D45422 resulting in a warning. Differential Revision: https://reviews.llvm.org/D45499 Modified: cfe/trunk/lib/Driv

[PATCH] D44093: [BUILTINS] structure pretty printer

paulsemel updated this revision to Diff 141913. paulsemel added a comment. Fixed printf warning generated in tests/CodeGen. Repository: rC Clang https://reviews.llvm.org/D44093 Files: include/clang/Basic/Builtins.def lib/CodeGen/CGBuiltin.cpp lib/Sema/SemaChecking.cpp test/CodeGen/du

[clang-tools-extra] r329759 - [clang-tidy] Add a `android-comparison-in-temp-failure-retry` check

Author: gbiv Date: Tue Apr 10 14:22:22 2018 New Revision: 329759 URL: http://llvm.org/viewvc/llvm-project?rev=329759&view=rev Log: [clang-tidy] Add a `android-comparison-in-temp-failure-retry` check This check attempts to catch buggy uses of the `TEMP_FAILURE_RETRY` macro, which is provided by bo

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

This revision was automatically updated to reflect the committed changes. Closed by commit rL329759: [clang-tidy] Add a `android-comparison-in-temp-failure-retry` check (authored by gbiv, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://reviews.l

r329760 - Revert "Handle the default case"

Author: phosek Date: Tue Apr 10 14:29:18 2018 New Revision: 329760 URL: http://llvm.org/viewvc/llvm-project?rev=329760&view=rev Log: Revert "Handle the default case" This reverts commit r329758. Modified: cfe/trunk/lib/Driver/ToolChains/NaCl.cpp Modified: cfe/trunk/lib/Driver/ToolChains/NaC

<    1   2   3   >