Re: [PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

FWIW - I had some thoughts on this a while back: https://reviews.llvm.org/D4313 On Mon, Apr 9, 2018 at 4:54 AM Roman Lebedev via Phabricator via llvm-commits wrote: > lebedev.ri added a comment. > > In https://reviews.llvm.org/D43779#1061444, @alexfh wrote: > > > In https://reviews.llvm.org/D437

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

dblaikie added subscribers: lebedev.ri, dblaikie. dblaikie added a comment. FWIW - I had some thoughts on this a while back: https://reviews.llvm.org/D4313 Repository: rL LLVM https://reviews.llvm.org/D43779 ___ cfe-commits mailing list cfe-commi

LLVM buildmaster will restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv added a comment. Thanks! I plan to commit this tomorrow, to give time for any last-minute comments. Thanks again to everyone for the review. :) https://reviews.llvm.org/D45059 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

george.burgess.iv updated this revision to Diff 141768. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. Address feedback https://reviews.llvm.org/D45059 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/andr

[libclc] r329647 - hypot: Port from amd builtins

Author: jvesely Date: Mon Apr 9 17:11:58 2018 New Revision: 329647 URL: http://llvm.org/viewvc/llvm-project?rev=329647&view=rev Log: hypot: Port from amd builtins v2: Fix whitespace errors Use only subnormal path. Passes CTS on carrizo and turks. Signed-off-by: Jan Vesely Reviewer: Aaron Watry

[PATCH] D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a checker to the Fuchsia module to flag instances of attempting to log the system's numerical

[PATCH] D45470: Emit an error when mixing and

vsapsai created this revision. vsapsai added reviewers: rsmith, EricWF, mclow.lists. Herald added subscribers: christof, jkorous-apple. Atomics in C and C++ are incompatible at the moment and mixing the headers can result in confusing error messages. Emit an error explicitly telling about the inc

r329652 - [AST] Attempt to fix buildbot warnings + appease MSVC; NFCI

Author: gbiv Date: Mon Apr 9 18:11:26 2018 New Revision: 329652 URL: http://llvm.org/viewvc/llvm-project?rev=329652&view=rev Log: [AST] Attempt to fix buildbot warnings + appease MSVC; NFCI GCC 4.8.4 on a bot was warning about `ArgPassingKind` not fitting in `ArgPassingRestrictions`, which appea

[PATCH] D45470: Emit an error when mixing and

vsapsai added a comment. In addition to the currently proposed approach #if ... #error ... #endif // header content I also tried #if ... #error ... #else // header content #endif It allows to have fewer error messages but can be more surprising. It can look like the only pro

Re: r329652 - [AST] Attempt to fix buildbot warnings + appease MSVC; NFCI

Thanks! > On Apr 9, 2018, at 6:11 PM, George Burgess IV via cfe-commits > wrote: > > Author: gbiv > Date: Mon Apr 9 18:11:26 2018 > New Revision: 329652 > > URL: http://llvm.org/viewvc/llvm-project?rev=329652&view=rev > Log: > [AST] Attempt to fix buildbot warnings + appease MSVC; NFCI > > G

[PATCH] D45449: [CUDA] Document recent changes

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Overall LGTM. We could use specific instructions for what exactly one needs to do in order to use relocatable device code in practice. Could be a separate patch. Repository: rC Clang https://re

[libcxx] r329665 - [libcxx] [test] Use the correct type from strlen. Include correct header.

Author: bion Date: Mon Apr 9 20:04:07 2018 New Revision: 329665 URL: http://llvm.org/viewvc/llvm-project?rev=329665&view=rev Log: [libcxx] [test] Use the correct type from strlen. Include correct header. Modified: libcxx/trunk/test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstre

[PATCH] D45016: [libcxx] [test] Avoid MSVC truncation warnings.

STL_MSFT added a comment. Ping? https://reviews.llvm.org/D45016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

ahatanak updated this revision to Diff 141788. ahatanak marked an inline comment as done. ahatanak set the repository for this revision to rC Clang. ahatanak added a comment. Use pair as the key. Repository: rC Clang https://reviews.llvm.org/D42776 Files: clang/include/clang/AST/APValue.h

r329671 - [ExprConstant] Use an AST node and a version number as a key to create

Author: ahatanak Date: Mon Apr 9 22:15:01 2018 New Revision: 329671 URL: http://llvm.org/viewvc/llvm-project?rev=329671&view=rev Log: [ExprConstant] Use an AST node and a version number as a key to create an APValue and retrieve it from map Temporaries. The version number is needed when a single

[PATCH] D42776: [Sema] Fix an assertion failure in constant expression evaluation of calls to functions with default arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL329671: [ExprConstant] Use an AST node and a version number as a key to create (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D44878: libFuzzer OpenBSD support

devnexen added a comment. Thanks ! anybody who can land it for me I ll be grateful. https://reviews.llvm.org/D44878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32577: CMake: Replace open-coded find_package

tstellar updated this revision to Diff 141793. tstellar added a comment. Herald added a subscriber: cfe-commits. Rebased this patch on ToT. Repository: rC Clang https://reviews.llvm.org/D32577 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D45474: [XRay][clang+compiler-rt] Support build-time mode selection

dberris created this revision. dberris added reviewers: echristo, eizan, chandlerc. Herald added subscribers: mgrang, mgorny. This patch implements the `-fxray-modes=` flag which allows users building with XRay instrumentation to decide which modes to pre-package into the binary being linked. The

<    1   2   3