r328238 - Set dso_local on vtables.

Author: rafael Date: Thu Mar 22 13:33:01 2018 New Revision: 328238 URL: http://llvm.org/viewvc/llvm-project?rev=328238&view=rev Log: Set dso_local on vtables. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp cfe/trunk/test/CodeGenCXX/dllexport.cpp Modified: cfe/trunk/lib/CodeGen/Itanium

[PATCH] D44796: Set dso_local on vtables

espindola accepted this revision. espindola added a comment. 328238 https://reviews.llvm.org/D44796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Please add a test for the driver functionality. Repository: rC Clang https://reviews.llvm.org/D44801 ___ cfe-commits mailing list cfe-commits@

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

eugenis added inline comments. Comment at: test/Driver/asan.c:12 -// RUN: %clang -O2 -target aarch64-unknown-linux -fsanitize=hwaddress %s -S -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-HWASAN -// RUN: %clang -O3 -target aarch64-unknown-linux -fsanitize=hwaddress %s -S

[PATCH] D44805: Set dso_local on __ImageBase

espindola created this revision. espindola added reviewers: echristo, rnk. https://reviews.llvm.org/D44805 Files: lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/dllexport.cpp Index: test/CodeGenCXX/dllexport.cpp === --- test/C

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

probinson added a comment. In https://reviews.llvm.org/D44788#1046093, @dblaikie wrote: > In implicit ThinLTO, the object files are only temporary. > > Sort of similar to using -gsplit-dwarf when compiling straight to an > executable (without using -c): "clang++ x.cpp y.cpp -o a.out" - where >

[PATCH] D44805: Set dso_local on __ImageBase

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44798: [libFuzzer] Use OptForFuzzing attribute with -fsanitize=fuzzer.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/test/fuzzer/lit.cfg:88 + +config.substitutions.append(('%no_opt_cpp_compiler', + generate_compiler_cmd(is_cpp=True, fuzzer_enabled=Tr

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai updated this revision to Diff 139506. vsapsai added a comment. - Replace `function::operator=(nullptr);` with `*this = nullptr;` https://reviews.llvm.org/D34331 Files: libcxx/include/__functional_03 libcxx/include/functional libcxx/test/libcxx/utilities/function.objects/func.wrap

r328242 - Revert "Set dso_local on vtables."

Author: rafael Date: Thu Mar 22 14:14:16 2018 New Revision: 328242 URL: http://llvm.org/viewvc/llvm-project?rev=328242&view=rev Log: Revert "Set dso_local on vtables." This reverts commit r328238. Looks like it broke some buildbots. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp cfe/

Re: [PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

The only data we have is that where .o files go, .dwo files go beside them. How to generalize this to other situations isn't really obvious to me - even for a.out (do you put all the .dwo files next to a.out? in the same directory? if the names collide, where then? etc). Interestingly GCC for "g++

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

dblaikie added a comment. The only data we have is that where .o files go, .dwo files go beside them. How to generalize this to other situations isn't really obvious to me - even for a.out (do you put all the .dwo files next to a.out? in the same directory? if the names collide, where then? etc).

r328243 - Fix test failure on Windows caused by different underlying enumeration type rules

Author: ericwf Date: Thu Mar 22 14:17:07 2018 New Revision: 328243 URL: http://llvm.org/viewvc/llvm-project?rev=328243&view=rev Log: Fix test failure on Windows caused by different underlying enumeration type rules Modified: cfe/trunk/test/SemaCXX/builtin-operator-new-delete.cpp Modified: c

[libcxx] r328245 - Use DoNotOptimize to prevent new/delete elision.

Author: ericwf Date: Thu Mar 22 14:28:09 2018 New Revision: 328245 URL: http://llvm.org/viewvc/llvm-project?rev=328245&view=rev Log: Use DoNotOptimize to prevent new/delete elision. The new/delete tests, in particular those which test replacement functions, often fail when the optimizer is enable

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC328247: [analyzer] Make symbol_iterator iterate over SVal's symbolic base. (authored by dergachev, committed by ). Reposi

r328247 - [analyzer] Make symbol_iterator iterate over SVal's symbolic base.

Author: dergachev Date: Thu Mar 22 14:30:58 2018 New Revision: 328247 URL: http://llvm.org/viewvc/llvm-project?rev=328247&view=rev Log: [analyzer] Make symbol_iterator iterate over SVal's symbolic base. If a memory region (or an SVal that represents a pointer to that memory region) is a (direct o

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

alekseyshl added inline comments. Comment at: test/Driver/asan.c:12 -// RUN: %clang -O2 -target aarch64-unknown-linux -fsanitize=hwaddress %s -S -emit-llvm -o - | FileCheck %s --check-prefix=CHECK-HWASAN -// RUN: %clang -O3 -target aarch64-unknown-linux -fsanitize=hwaddress %s -

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

alekseyshl updated this revision to Diff 139513. alekseyshl added a comment. - Revert triple change in asan.cc test Repository: rC Clang https://reviews.llvm.org/D44745 Files: lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Linux.cpp test/Driver/Inputs/resource_dir/lib/linux/libclan

r328248 - [CFG] [analyzer] Add C++17-specific variable and return construction contexts.

Author: dergachev Date: Thu Mar 22 14:37:39 2018 New Revision: 328248 URL: http://llvm.org/viewvc/llvm-project?rev=328248&view=rev Log: [CFG] [analyzer] Add C++17-specific variable and return construction contexts. In C++17 copy elision is mandatory for variable and return value constructors (as

[PATCH] D44597: [CFG] [analyzer] Add C++17-specific variable and return value construction contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328248: [CFG] [analyzer] Add C++17-specific variable and return construction contexts. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r328249 - [CFG] [analyzer] NFC: Move construction context allocation into a helper method.

Author: dergachev Date: Thu Mar 22 14:40:24 2018 New Revision: 328249 URL: http://llvm.org/viewvc/llvm-project?rev=328249&view=rev Log: [CFG] [analyzer] NFC: Move construction context allocation into a helper method. Improve readability of ConstructionContext::createFromLayers(). Differential Re

[PATCH] D44725: [CFG] [analyzer] NFC: Move construction context allocation into a helper method.

This revision was automatically updated to reflect the committed changes. Closed by commit rC328249: [CFG] [analyzer] NFC: Move construction context allocation into a helper method. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44725 Files: include/c

[PATCH] D44498: Sink PrettyDeclStackTrace down to the AST library

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Hi Jordan, Thanks for improving this. LGTM Repository: rC Clang https://reviews.llvm.org/D44498 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D44755: [analyzer] Suppress more C++17-related crashes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL328253: [analyzer] Remove an assertion that doesn't hold in C++17. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D447

r328253 - [analyzer] Remove an assertion that doesn't hold in C++17.

Author: dergachev Date: Thu Mar 22 14:54:48 2018 New Revision: 328253 URL: http://llvm.org/viewvc/llvm-project?rev=328253&view=rev Log: [analyzer] Remove an assertion that doesn't hold in C++17. Function return values can be constructed directly in variables or passed directly into return stateme

r328255 - [CFG] [analyzer] Add C++17-specific ctor-initializer construction contexts.

Author: dergachev Date: Thu Mar 22 15:02:38 2018 New Revision: 328255 URL: http://llvm.org/viewvc/llvm-project?rev=328255&view=rev Log: [CFG] [analyzer] Add C++17-specific ctor-initializer construction contexts. CXXCtorInitializer-based constructors are also affected by the C++17 mandatory copy e

[PATCH] D44763: [CFG] [analyzer] Add C++17-specific constructor-initializer construction contexts.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL328255: [CFG] [analyzer] Add C++17-specific ctor-initializer construction contexts. (authored by dergachev, committed by )

[PATCH] D44763: [CFG] [analyzer] Add C++17-specific constructor-initializer construction contexts.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC328255: [CFG] [analyzer] Add C++17-specific ctor-initializer construction contexts. (authored by dergachev, committed by )

r328258 - [analyzer] Enable temporary object destructor inlining by default.

Author: dergachev Date: Thu Mar 22 15:05:53 2018 New Revision: 328258 URL: http://llvm.org/viewvc/llvm-project?rev=328258&view=rev Log: [analyzer] Enable temporary object destructor inlining by default. When a temporary is constructed with a proper construction context, it should be safe to inlin

[PATCH] D44721: [analyzer] Enable c++-temp-dtor-inlining by default?

This revision was automatically updated to reflect the committed changes. Closed by commit rL328258: [analyzer] Enable temporary object destructor inlining by default. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

rnk requested changes to this revision. rnk added a comment. This revision now requires changes to proceed. Use `llvm::sys::Process::GetArgumentVector`, which already does wildcard expansion from what I can see. It works with Unicode command lines and isn't affected by locale. Repository: rC

[PATCH] D44652: [vfs] Don't bail out after a missing -ivfsoverlay file

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. One minor suggestion but otherwise LGTM Comment at: lib/Frontend/CompilerInvocation.cpp:3083 +} else { Diags.Report(diag::err_invalid_vfs_overlay) << File; } --

[libcxx] r328261 - Workaround GCC bug PR78489 - SFINAE order is not respected.

Author: ericwf Date: Thu Mar 22 15:32:55 2018 New Revision: 328261 URL: http://llvm.org/viewvc/llvm-project?rev=328261&view=rev Log: Workaround GCC bug PR78489 - SFINAE order is not respected. This patch works around variant test failures which are new to GCC 8. GCC 8 either doesn't perform SFINA

r328263 - Add a test.

Author: rafael Date: Thu Mar 22 15:57:48 2018 New Revision: 328263 URL: http://llvm.org/viewvc/llvm-project?rev=328263&view=rev Log: Add a test. This would have found the regression in r328238. Added: cfe/trunk/test/CodeGenCXX/rtti-hidden.cpp Added: cfe/trunk/test/CodeGenCXX/rtti-hidden.cpp

[libcxx] r328264 - [libcxx] [test] Strip trailing whitespace. NFC.

Author: stl_msft Date: Thu Mar 22 15:59:02 2018 New Revision: 328264 URL: http://llvm.org/viewvc/llvm-project?rev=328264&view=rev Log: [libcxx] [test] Strip trailing whitespace. NFC. Modified: libcxx/trunk/test/libcxx/strings/basic.string/string.modifiers/clear_and_shrink_db1.pass.cpp li

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

alexfh added a comment. In https://reviews.llvm.org/D44778#1046251, @rnk wrote: > Use `llvm::sys::Process::GetArgumentVector`, which already does wildcard > expansion from what I can see. It works with Unicode command lines and isn't > affected by locale. I vaguely remember that windows conso

[libcxx] r328265 - Avoid Clang error about throwing _LIBCPP_ASSERT in noexcept function.

Author: ericwf Date: Thu Mar 22 16:01:08 2018 New Revision: 328265 URL: http://llvm.org/viewvc/llvm-project?rev=328265&view=rev Log: Avoid Clang error about throwing _LIBCPP_ASSERT in noexcept function. This fixes a couple of tests which produced a warning that a 'throw' occurred in a noexcept fu

r328266 - Set dso_local on __ImageBase.

Author: rafael Date: Thu Mar 22 16:02:19 2018 New Revision: 328266 URL: http://llvm.org/viewvc/llvm-project?rev=328266&view=rev Log: Set dso_local on __ImageBase. Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp cfe/trunk/test/CodeGenCXX/dllexport.cpp Modified: cfe/trunk/lib/CodeGen/M

[PATCH] D44805: Set dso_local on __ImageBase

espindola closed this revision. espindola added a comment. 328266 https://reviews.llvm.org/D44805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44778: [clang-format] Wildcard expansion on Windows.

alexfh added a comment. In https://reviews.llvm.org/D44778#1046301, @alexfh wrote: > In https://reviews.llvm.org/D44778#1046251, @rnk wrote: > > > Use `llvm::sys::Process::GetArgumentVector`, which already does wildcard > > expansion from what I can see. It works with Unicode command lines and

[libcxx] r328268 - Add temporary printouts to test to help debug failures.

Author: ericwf Date: Thu Mar 22 16:14:20 2018 New Revision: 328268 URL: http://llvm.org/viewvc/llvm-project?rev=328268&view=rev Log: Add temporary printouts to test to help debug failures. Some debian libc++ bots started having failures in the locale tests due to what I assume is a change in the

[clang-tools-extra] r328270 - [clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework"

Author: juliehockett Date: Thu Mar 22 16:34:46 2018 New Revision: 328270 URL: http://llvm.org/viewvc/llvm-project?rev=328270&view=rev Log: [clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework" Fixed windows release build tests. Added: clang-tools-extra/trunk/clang-doc/BitcodeWr

[PATCH] D44745: [HWASan] Port HWASan to Linux x86-64 (clang)

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. OK, sure, If you feel so strongly about this. Repository: rC Clang https://reviews.llvm.org/D44745 ___ cfe-commits mailing list cfe-commits@

[PATCH] D44804: [StaticAnalyzer] Silence an unused variable warning. NFC.

mgrang abandoned this revision. mgrang added a comment. This seems to already have been fixed in r327802. Abandoning this patch. Repository: rC Clang https://reviews.llvm.org/D44804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

r328276 - Sink PrettyDeclStackTrace down to the AST library

Author: jrose Date: Thu Mar 22 17:07:18 2018 New Revision: 328276 URL: http://llvm.org/viewvc/llvm-project?rev=328276&view=rev Log: Sink PrettyDeclStackTrace down to the AST library ...and add some very basic stack trace entries for module building. This would have helped track down rdar://proble

[PATCH] D44498: Sink PrettyDeclStackTrace down to the AST library

jordan_rose closed this revision. jordan_rose added a comment. Committed in https://reviews.llvm.org/rL328276. Repository: rC Clang https://reviews.llvm.org/D44498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

r328277 - [ARM] Add ARMv8.2-A FP16 vector intrinsic

Author: az Date: Thu Mar 22 17:08:40 2018 New Revision: 328277 URL: http://llvm.org/viewvc/llvm-project?rev=328277&view=rev Log: [ARM] Add ARMv8.2-A FP16 vector intrinsic Putting back the code in commit r327189 that was reverted in r322737. The code is being committed in three stages and this on

r328281 - [analyzer] Extend GCDAntipatternChecker to match group_enter/group_leave pattern

Author: george.karpenkov Date: Thu Mar 22 17:16:02 2018 New Revision: 328281 URL: http://llvm.org/viewvc/llvm-project?rev=328281&view=rev Log: [analyzer] Extend GCDAntipatternChecker to match group_enter/group_leave pattern rdar://38480416 Differential Revision: https://reviews.llvm.org/D44653

r328283 - [Modules] Update test to mention it requires C++14.

Author: vsapsai Date: Thu Mar 22 17:16:06 2018 New Revision: 328283 URL: http://llvm.org/viewvc/llvm-project?rev=328283&view=rev Log: [Modules] Update test to mention it requires C++14. Modified: cfe/trunk/test/Modules/self-referencing-lambda.cpp Modified: cfe/trunk/test/Modules/self-referen

r328280 - [analyzer] [NFC] Move worklist implementation to WorkList.cpp

Author: george.karpenkov Date: Thu Mar 22 17:16:01 2018 New Revision: 328280 URL: http://llvm.org/viewvc/llvm-project?rev=328280&view=rev Log: [analyzer] [NFC] Move worklist implementation to WorkList.cpp Current location is very confusing, especially because there is already WorkList.h, and othe

r328282 - [analyzer] Trust _Nonnull annotations for system framework

Author: george.karpenkov Date: Thu Mar 22 17:16:03 2018 New Revision: 328282 URL: http://llvm.org/viewvc/llvm-project?rev=328282&view=rev Log: [analyzer] Trust _Nonnull annotations for system framework Changes the analyzer to believe that methods annotated with _Nonnull from system frameworks ind

r328286 - Remove problematic PrettyStackTrace entry added in r328276

Author: jrose Date: Thu Mar 22 18:12:09 2018 New Revision: 328286 URL: http://llvm.org/viewvc/llvm-project?rev=328286&view=rev Log: Remove problematic PrettyStackTrace entry added in r328276 I'm not sure /why/ this is causing issues for libclang, but it is. Unbreak the buildbots since it's alread

r328288 - Bring r328238 back with a fix.

Author: rafael Date: Thu Mar 22 18:36:23 2018 New Revision: 328288 URL: http://llvm.org/viewvc/llvm-project?rev=328288&view=rev Log: Bring r328238 back with a fix. The issues was that we were setting hidden visibility if, when processing a hidden class, we found out that we needed to emit a refer

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. I agree with Saleem and Bob: `__is_target_*` is not confusing here and seems to be a straightforward spelling. It has also already shipped in LLVM 6.0.0: it would be awkward

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

vlad.tsyrklevich updated this revision to Diff 139554. vlad.tsyrklevich added a comment. - Add Driver tests Repository: rC Clang https://reviews.llvm.org/D44801 Files: docs/ShadowCallStack.rst docs/index.rst include/clang/Basic/Sanitizers.def lib/CodeGen/CGDeclCXX.cpp lib/CodeGen/C

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta created this revision. manojgupta added reviewers: kristof.beyls, rengolin, peter.smith, t.p.northover. Herald added subscribers: eraman, javed.absar. Allow rN registers to be simply parsed as correspoing xN registers. The "register ... asm("rN")" is an command to the compiler's registe

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta updated this revision to Diff 139556. manojgupta added a comment. Indenting and a minor fix. Repository: rC Clang https://reviews.llvm.org/D44815 Files: lib/Basic/Targets/AArch64.cpp test/CodeGen/aarch64-inline-asm.c Index: test/CodeGen/aarch64-inline-asm.c =

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta added a comment. Add more context from the email communication with Peter Smith and Robin Murphy. On 22/03/18 02:34, Manoj Gupta wrote: > Hi Robin, > > this is Manoj from Google. I was looking into implementing support for > parsing "r" registers in clang for AArch64 based on lkml t

[PATCH] D44816: [clang-format] Do not insert space before closing brace in ObjC dict literal

benhamilton created this revision. benhamilton added reviewers: djasper, jolesiak, Wizard. Herald added subscribers: cfe-commits, klimek. Previously, `clang-format` would sometimes insert a space before the closing brace in an Objective-C dictionary literal. Unlike array literals (which obey `Sty

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

srhines added a comment. Peter also requested that a test be added to make sure that rY was not accepted by the Clang assembler as a true synonym for xY. Comment at: lib/Basic/Targets/AArch64.cpp:320 +{{"r24"}, "x24"}, {{"r25"}, "x25"}, {{"r26"}, "x26"}, {{"r27"}, "x27"},

[PATCH] D44815: [AArch64]: Add support for parsing rN registers.

manojgupta added a comment. In https://reviews.llvm.org/D44815#1046451, @srhines wrote: > Peter also requested that a test be added to make sure that rY was not > accepted by the Clang assembler as a true synonym for xY. Yes, I am working on that. Wanted to send this out first. Repository:

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

kcc added a comment. [didn't look at the code yet, just at the docs] Please add a docs section describing how to handle leaf functions. If they are not handled yet, no need to change the implementation in these pathches -- ok to do it later. Comment at: docs/ShadowCallStack.

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

kcc added a comment. please also add a short comparison with Intel CET. Repository: rC Clang https://reviews.llvm.org/D44801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2