Re: r328006 - [NVPTX] Make tensor load/store intrinsics overloaded.

Sorry, I was just missing "git pull" in the llvm repo. Cheers, Rafael Artem Belevich writes: > Thanks for the heads up. > > Which buildbot shows the failure? I don't see the failure on the cuda > buildbot, nor do I see it on my machine locally. > > It may be due to llvm/clang being out of sync.

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h:75 +/// \brief Deduplicate, check for conflicts, and convert all Replacements stored +/// in \c TUs to AtomicChange. If conflicts occur, no Replacem

r328044 - [Driver] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Mar 20 14:08:59 2018 New Revision: 328044 URL: http://llvm.org/viewvc/llvm-project?rev=328044&view=rev Log: [Driver] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Driver/Action.h

[PATCH] D44692: [clang-format] Don't insert space between r_paren and 'new' in ObjC decl

stephanemoore accepted this revision. stephanemoore added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rC Clang https://reviews.llvm.org/D44692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44706: Delete BuiltinCC

espindola created this revision. espindola added reviewers: rnk, echristo. It is always identical to RuntimeCC. https://reviews.llvm.org/D44706 Files: lib/CodeGen/ABIInfo.h lib/CodeGen/CGExprComplex.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenTypeCache.h lib/CodeGen/TargetInf

r328047 - [format] Eliminate global destructors.

Author: d0k Date: Tue Mar 20 14:52:19 2018 New Revision: 328047 URL: http://llvm.org/viewvc/llvm-project?rev=328047&view=rev Log: [format] Eliminate global destructors. Modified: cfe/trunk/lib/Format/BreakableToken.cpp cfe/trunk/lib/Format/Format.cpp Modified: cfe/trunk/lib/Format/Breaka

r328048 - Add CHECKs for a few declarations. NFC.

Author: rafael Date: Tue Mar 20 14:54:14 2018 New Revision: 328048 URL: http://llvm.org/viewvc/llvm-project?rev=328048&view=rev Log: Add CHECKs for a few declarations. NFC. We were just missing test coverage for this. Modified: cfe/trunk/test/CodeGen/mingw-long-double.c Modified: cfe/trunk/

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

juliehockett created this revision. juliehockett added reviewers: alexfh, mgorny. juliehockett added a project: clang-tools-extra. Adding the config initialization (the footer) to clang-tools-extra so that tests that use REQUIRES, UNSUPPORTED, and XFAIL based on platform or target triple work pr

[PATCH] D44706: Delete BuiltinCC

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D44706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. After much digging, it looks like the lit config is never initialized in clang-tools-extra like it is in the other projects. REQUIRES et.al. work properly once that's in there (see D44708 ). Once that lands I'll reland this and *hop

[PATCH] D44710: Set dso_local on builtin functions

espindola created this revision. espindola added reviewers: rnk, echristo. With https://reviews.llvm.org/D44706 we can just forward to CreateRuntimeFunction. https://reviews.llvm.org/D44710 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/mingw-long-double.c Index: test/CodeGen/mingw-lo

r328050 - Delete BuiltinCC. NFC.

Author: rafael Date: Tue Mar 20 15:02:57 2018 New Revision: 328050 URL: http://llvm.org/viewvc/llvm-project?rev=328050&view=rev Log: Delete BuiltinCC. NFC. It is always identical to RuntimeCC. Modified: cfe/trunk/lib/CodeGen/ABIInfo.h cfe/trunk/lib/CodeGen/CGExprComplex.cpp cfe/trunk

r328051 - Change ImplicitConverionKind comments to refer to C++ stable names[NFC]

Author: erichkeane Date: Tue Mar 20 15:05:01 2018 New Revision: 328051 URL: http://llvm.org/viewvc/llvm-project?rev=328051&view=rev Log: Change ImplicitConverionKind comments to refer to C++ stable names[NFC] Modified: cfe/trunk/include/clang/Sema/Overload.h Modified: cfe/trunk/include/clang

[PATCH] D44706: Delete BuiltinCC

espindola closed this revision. espindola added a comment. r328050 https://reviews.llvm.org/D44706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44712: Set dso_local on runtime variables

espindola created this revision. espindola added reviewers: rnk, echristo, eli.friedman. https://reviews.llvm.org/D44712 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp ==

Re: r328040 - Set dso_local on string literals.

On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits wrote: > Author: rafael > Date: Tue Mar 20 13:42:55 2018 > New Revision: 328040 > > URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev > Log: > Set dso_local on string literals. I wonder if unnamed_addr shouldn'

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

smeenai added a comment. Thanks Reid. I still need to look into why this is causing some existing tests to crash, but I'll also adjust the test. Repository: rC Clang https://reviews.llvm.org/D44619 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

lebedev.ri added a comment. Nice catch! I wonder how many more `test/lit.site.cfg.in` are silently partially non-functional because they don't have that substitution... I also have an idea why it might not have worked for you - are you building clang-tools-extra repo separately manually, not as

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. As per https://github.com/llvm-project/llvm-project-20170507/search?utf8=%E2%9C%93&q=LIT_SITE_CFG_IN_FOOTER&type= this substitution already exists in most of the repos. I don't see why

r328053 - [Modules] Honor -fmodule-name when handling private framework modules

Author: bruno Date: Tue Mar 20 15:36:39 2018 New Revision: 328053 URL: http://llvm.org/viewvc/llvm-project?rev=328053&view=rev Log: [Modules] Honor -fmodule-name when handling private framework modules When skipping building the module for a private framework module, LangOpts.CurrentModule isn't

[libcxx] r328054 - Implement LWG 3039 and 3041 - 'Treating Unnecessary decay'.

Author: marshall Date: Tue Mar 20 15:37:37 2018 New Revision: 328054 URL: http://llvm.org/viewvc/llvm-project?rev=328054&view=rev Log: Implement LWG 3039 and 3041 - 'Treating Unnecessary decay'. Modified: libcxx/trunk/include/future libcxx/trunk/include/thread Modified: libcxx/trunk/incl

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

compnerd added a reviewer: dexonsmith. compnerd added a comment. I want to get Duncan's input on this. I don't think that this is a supported configuration for macOS. Repository: rCXX libc++ https://reviews.llvm.org/D44671 ___ cfe-commits maili

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

dpayne updated this revision to Diff 139212. dpayne added a comment. Adding a unit test for formatting a global namespace var with SpacesInParentheses enabled. Repository: rC Clang https://reviews.llvm.org/D43957 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Ind

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

compnerd added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + DHowett-MSFT wrote: > compnerd wrote: > > Would be nice to have a second test that uses the Microsoft definitions > > (`char *` and the offset

[libcxx] r328059 - Implement LWG3035: std::allocator's constructors should be constexpr.

Author: marshall Date: Tue Mar 20 16:02:53 2018 New Revision: 328059 URL: http://llvm.org/viewvc/llvm-project?rev=328059&view=rev Log: Implement LWG3035: std::allocator's constructors should be constexpr. Added: libcxx/trunk/test/std/utilities/memory/default.allocator/allocator.ctor.pass.cpp

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

efriedma added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + compnerd wrote: > DHowett-MSFT wrote: > > compnerd wrote: > > > Would be nice to have a second test that uses the Microsoft definitions > > >

[PATCH] D44708: [test] Adding config initialization to lit tests in clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rL328060: [lit] Adding config initialization to lit tests in clang-tools-extra (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https://r

[clang-tools-extra] r328060 - [lit] Adding config initialization to lit tests in clang-tools-extra

Author: juliehockett Date: Tue Mar 20 16:22:50 2018 New Revision: 328060 URL: http://llvm.org/viewvc/llvm-project?rev=328060&view=rev Log: [lit] Adding config initialization to lit tests in clang-tools-extra Adding the config initialization to clang-tools-extra so that tests that use REQUIRES, UN

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

rsmith added inline comments. Comment at: lib/CodeGen/CGClass.cpp:2183 ApplyInlineDebugLocation DebugScope(*this, GD); + RunCleanupsScope CleanupScope(*this); Please add a test to ensure that we still destroy function parameters in the right order and at t

Re: r328040 - Set dso_local on string literals.

Joerg Sonnenberger via cfe-commits writes: > On Tue, Mar 20, 2018 at 08:42:55PM -, Rafael Espindola via cfe-commits > wrote: >> Author: rafael >> Date: Tue Mar 20 13:42:55 2018 >> New Revision: 328040 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=328040&view=rev >> Log: >> Set dso_loca

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay created this revision. MaskRay added a reviewer: sammccall. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. Also rename `matchBonus` and `skipPenalty` to uniform `{match,miss}Score` in addition form. Repository: rCTE Clang Tools Extra https://rev

[PATCH] D44281: [analyzer] Suppress more MallocChecker positives in reference counting pointer destructors.

NoQ updated this revision to Diff 139231. NoQ added a comment. - fix `auto`. - don't use regexs yet because it's clean enough anyway; maybe later. https://reviews.llvm.org/D44281 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/NewDelete-atomics.cpp Index: test/Analysis/

[PATCH] D44720: [clangd] Simplify fuzzy matcher (sequence alignment) by removing some condition checks.

MaskRay added a comment. Brings some goodies from https://github.com/cquery-project/cquery/blob/master/src/fuzzy_match.cc (what I plagiarized from clangd) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44720 ___ cfe-commits mailin

r328063 - [Analysis] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Tue Mar 20 17:14:43 2018 New Revision: 328063 URL: http://llvm.org/viewvc/llvm-project?rev=328063&view=rev Log: [Analysis] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Analysis/Analyses

[PATCH] D44712: Set dso_local on runtime variables

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r328064 - Implement LWG3034: P0767R1 breaks previously-standard-layout types

Author: marshall Date: Tue Mar 20 17:36:05 2018 New Revision: 328064 URL: http://llvm.org/viewvc/llvm-project?rev=328064&view=rev Log: Implement LWG3034: P0767R1 breaks previously-standard-layout types Added: libcxx/trunk/test/std/strings/basic.string/char.bad.fail.cpp libcxx/trunk/test/s

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

DHowett-MSFT added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + efriedma wrote: > compnerd wrote: > > DHowett-MSFT wrote: > > > compnerd wrote: > > > > Would be nice to have a second test that uses the M

[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

vsapsai updated this revision to Diff 139233. vsapsai added a comment. Address review comments: - Replace `auto` with explicit type. - Use `llvm::makeArrayRef`. - Remove curly braces around single-statement elses. https://reviews.llvm.org/D44589 Files: clang/include/clang/Basic/SourceLocatio

[PATCH] D44589: [Sema] Make deprecation fix-it replace all multi-parameter ObjC method slots.

vsapsai marked 3 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7207-7217 +} else { + FixIts.push_back(FixItHint::CreateInsertion( + SelectorLocs[I], SelectorSlotNames[I])); +

[PATCH] D44281: [analyzer] Suppress more MallocChecker positives in reference counting pointer destructors.

This revision was automatically updated to reflect the committed changes. Closed by commit rC328066: [analyzer] Suppress more MallocChecker positives in smart pointer destructors. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D44281 Files: lib/StaticA

r328066 - [analyzer] Suppress more MallocChecker positives in smart pointer destructors.

Author: dergachev Date: Tue Mar 20 17:49:47 2018 New Revision: 328066 URL: http://llvm.org/viewvc/llvm-project?rev=328066&view=rev Log: [analyzer] Suppress more MallocChecker positives in smart pointer destructors. r326249 wasn't quite enough because we often run out of inlining stack depth limit

r328067 - Revert r326782 "[analyzer] CStringChecker.cpp: Remove the duplicated check...".

Author: dergachev Date: Tue Mar 20 17:57:37 2018 New Revision: 328067 URL: http://llvm.org/viewvc/llvm-project?rev=328067&view=rev Log: Revert r326782 "[analyzer] CStringChecker.cpp: Remove the duplicated check...". It seems that the refactoring was causing a functional change and some warnings h

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

NoQ added a comment. In https://reviews.llvm.org/D44557#1042792, @MTC wrote: > In https://reviews.llvm.org/D44557#1042357, @NoQ wrote: > > > Sorry, one moment, i'm seeing a few regressions after the previous > > refactoring but i didn't look at them closely yet to provide a reproducer. > > I'll

r328068 - Set dso_local on runtime variables.

Author: rafael Date: Tue Mar 20 18:30:16 2018 New Revision: 328068 URL: http://llvm.org/viewvc/llvm-project?rev=328068&view=rev Log: Set dso_local on runtime variables. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp cfe/trunk/test/CodeGenCXX/ubsan-vtable-checks.cpp Modified: cfe/trunk

[PATCH] D44712: Set dso_local on runtime variables

espindola closed this revision. espindola added a comment. r328068 https://reviews.llvm.org/D44712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44721: [analyzer] Enable c++-temp-dtor-inlining by default?

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Remaining temporary-destructor-inlining-related false positives i've seen so far are caused by classes with unions; i'll try to improve upon

[PATCH] D44723: Set dso_local when clearing dllimport

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44723 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp === --- test/Cod

[PATCH] D44724: [Fuchsia] Avoid using static ABI library with libc++ on Darwin

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Building libc++ with static ABI library on Darwin is not currently supported. Repository: rC Clang https://reviews.llvm.org/D44724 Fil

[clang-tools-extra] r328069 - Revert "[lit] Adding config initialization to lit tests in clang-tools-extra"

Author: phosek Date: Tue Mar 20 19:28:22 2018 New Revision: 328069 URL: http://llvm.org/viewvc/llvm-project?rev=328069&view=rev Log: Revert "[lit] Adding config initialization to lit tests in clang-tools-extra" This reverts commit r328060 because a test that was inteded to run on Windows but neve

[PATCH] D44724: [Fuchsia] Avoid using static ABI library with libc++ on Darwin

mcgrathr added a comment. When targetting Darwin we should really not be even compiling libc++/libc++abi and certainly should not have anything else compiling against their headers since at runtime the system libraries will be used and so things better compile against the system headers that ma

[PATCH] D44597: [CFG] [analyzer] Add C++17-specific variable and return value construction contexts.

NoQ updated this revision to Diff 139245. NoQ added a comment. Address review comments. https://reviews.llvm.org/D44597 Files: include/clang/Analysis/CFG.h include/clang/Analysis/ConstructionContext.h lib/Analysis/CFG.cpp lib/Analysis/ConstructionContext.cpp lib/StaticAnalyzer/Core/Ex

[PATCH] D44725: [analyzer] NFC: Move construction context allocation into a helper method.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. It is tedious to allocate and then placement-new the construction context, so i added a tiny variadic template to improve readability. Repo

[PATCH] D44724: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin

phosek updated this revision to Diff 139249. phosek retitled this revision from "[Fuchsia] Avoid using static ABI library with libc++ on Darwin" to "[Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin". phosek edited the summary of this revision. phosek added a comment. Done, they'r

[PATCH] D44727: [RISCV] Implement getTargetDefines, handleTargetFeatures and hasFeature for RISCVTargetInfo

kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, shiva0217, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar. kito-cheng added a dependency: D44189: [RISCV] Verify the input value of -march=. This patch implement ge

[PATCH] D44724: [Fuchsia] Don't install libc++, libc++abi or libunwind on Darwin

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. Lgtm with some more comments Repository: rC Clang https://reviews.llvm.org/D44724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    1   2