[PATCH] D44649: Set dso_local for guid decls

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44649 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/microsoft-templ-uuidof.cpp Index: test/CodeGenCXX/microsoft-templ-uuidof.cpp ==

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

espindola added a comment. ping https://reviews.llvm.org/D44491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

efriedma added a comment. The compiler shouldn't inline functions which call va_start, whether or not they're marked always_inline. That should work correctly, I think, at least on trunk. (See https://reviews.llvm.org/D42556 .) If you want to warn anyway, that's okay. Repository: rC Clang

[PATCH] D44606: [analyzer] Fix the crash in `IteratorChecker.cpp` when `SymbolConjured` has a null Stmt.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Just in case: we indeed do not guarantee that `SymbolConjured` corresponds to a statement; it is, however, not intended, but rather a bug. Consider: 1void clang_analyzer_eval(bool); 2 3

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

compnerd added a comment. What happens in the case that you have a variadic in C code marked with `__forceinline`? Does that also cause a warning with MSVC? Comment at: test/Sema/ms-forceinline-on-variadic.cpp:1 +// RUN: %clang_cc1 -emit-llvm -o - -triple i686-windows -verify

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

NoQ added a comment. Sorry, one moment, i'm seeing a few regressions after the previous refactoring but i didn't look at them closely yet to provide a reproducer. I'll get back to this. Repository: rC Clang https://reviews.llvm.org/D44557 ___ c

[clang-tools-extra] r327911 - Fixup test to explicitly use -fexceptions since exceptions are disabled by default on the PS4 target.

Author: dyung Date: Mon Mar 19 14:22:58 2018 New Revision: 327911 URL: http://llvm.org/viewvc/llvm-project?rev=327911&view=rev Log: Fixup test to explicitly use -fexceptions since exceptions are disabled by default on the PS4 target. Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone

RE: [clang-tools-extra] r327833 - [clang-tidy] New check bugprone-unused-return-value

This should be fixed by r327911. Douglas Yung From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Galina Kistanova via cfe-commits Sent: Monday, March 19, 2018 13:13 To: Alexander Kornienko Cc: cfe-commits Subject: Re: [clang-tools-extra] r327833 - [clang-tidy] New check

[PATCH] D44362: [clang] Change std::sort to llvm::sort in response to r327219

mgrang added a comment. Ping for reviews please. Repository: rC Clang https://reviews.llvm.org/D44362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43047: [Builtins] Overload __builtin_operator_new/delete to allow forwarding to usual allocation/deallocation functions.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Comment at: lib/Sema/SemaExprCXX.cpp:3458 + } + TheCall->getCallee()->setType(OperatorNewOrDelete->getType()); + It would be nice

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

DHowett-MSFT added a comment. In https://reviews.llvm.org/D44646#1042347, @efriedma wrote: > The compiler shouldn't inline functions which call va_start, whether or not > they're marked always_inline. That should work correctly, I think, at least > on trunk. (See https://reviews.llvm.org/D425

[PATCH] D44536: Avoid segfault when destructor is not yet known

dim added a comment. @rsmith, any objections? Repository: rC Clang https://reviews.llvm.org/D44536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44591: [AArch64] Add vmulxh_lane FP16 vector intrinsic

az updated this revision to Diff 139015. az added a comment. add LLVM codegen tests as suggested in the reviews. https://reviews.llvm.org/D44591 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/aarch64-v8.2a-neon-intrinsics.c llvm/test/Code

[PATCH] D44536: Avoid segfault when destructor is not yet known

rjmccall added a comment. I think Richard is probably catching up from a week at the C++ committee. To be clear, I am objecting to this; I think the destructor should clearly have been created at this point. I'm just hoping Richard will have an idea for how best to fix it. Repository: rC C

[PATCH] D44645: [test] Fix Cross-DSO CFI Android sanitizer test for -rtlib=compiler-rt

eugenis added inline comments. Comment at: test/Driver/sanitizer-ld.c:517 // CHECK-CFI-CROSS-DSO-ANDROID: "{{.*}}ld{{(.exe)?}}" // CHECK-CFI-CROSS-DSO-ANDROID-NOT: libclang_rt. mgorny wrote: > (an alternative would be to replace this 'NOT' clause with more sp

[PATCH] D44652: [vfs] Don't bail out after a missing -ivfsoverlay file

benlangmuir created this revision. benlangmuir added reviewers: bruno, vsapsai. Herald added a subscriber: cfe-commits. This make -ivfsoverlay behave more like other fatal errors (e.g. missing -include file) by skipping the missing file instead of bailing out of the whole compilation. This makes i

[PATCH] D44649: Set dso_local for guid decls

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Yep, these are pretty much always local. https://reviews.llvm.org/D44649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek created this revision. phosek added a reviewer: eugenis. Herald added subscribers: cfe-commits, srhines. This is needed to avoid the test failure in case when compiler-rt is set as the default runtime library for Clang. Repository: rC Clang https://reviews.llvm.org/D44655 Files: cla

r327926 - [analyzer] Fix the assertion failure when static globals are used in lambda by reference

Author: george.karpenkov Date: Mon Mar 19 17:20:58 2018 New Revision: 327926 URL: http://llvm.org/viewvc/llvm-project?rev=327926&view=rev Log: [analyzer] Fix the assertion failure when static globals are used in lambda by reference Also use the opportunity to clean up the code and remove unneces

[PATCH] D44594: [analyzer] Fix the assertion failure when static globals are used in lambda by reference

This revision was automatically updated to reflect the committed changes. Closed by commit rC327926: [analyzer] Fix the assertion failure when static globals are used in lambda by… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: ht

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. See my comment in https://reviews.llvm.org/D44655, but this change is also fine with me. Repository: rC Clang https://reviews.llvm.org/D44655 _

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen updated this revision to Diff 139036. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41148 Files: libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp libcx

[PATCH] D41415: [libcxx] implement casts.

timshen updated this revision to Diff 139039. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41415 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.casts/simd_cast.pass.cpp libcxx/test/std/experimental/simd/sim

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen updated this revision to Diff 139037. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41376 Files: libcxx/include/__config libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/include/utility libcxx/test/s

[PATCH] D41412: [libcxx] implement concat() and split()

timshen updated this revision to Diff 139038. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41412 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.horizontal/concat.pass.cpp libcxx/test/std/experimental/simd/s

[PATCH] D41747: [libcxx] implement simd_mask<> and operators.

timshen updated this revision to Diff 139041. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41747 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.elementwise/operators.pass.cpp libcxx/test/std/experimental/si

[PATCH] D41422: [libcxx] implement operators and reduction.

timshen updated this revision to Diff 139040. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41422 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.elementwise/clamp.pass.cpp libcxx/test/std/experimental/simd/s

[PATCH] D41756: [libcxx] implement simd_mask<> casts and some horizontal operations.

timshen updated this revision to Diff 139042. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41756 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.casts/to_compatible.pass.cpp libcxx/test/std/experimental/simd

[PATCH] D41844: [libcxx] implement mask reductions

timshen updated this revision to Diff 139044. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41844 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.horizontal/hmax.pass.cpp libcxx/test/std/experimental/simd/sim

[PATCH] D41845: [libcxx] clean up and complete

timshen updated this revision to Diff 139045. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41845 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.cons/load.pass.cpp libcxx/test/std/experimental/simd/simd.mask

[PATCH] D44656: [libcxx] Add conversions between underlying non-portable types and simd/simd_mask types.

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, kristof.beyls, sanjoy. Herald added a reviewer: EricWF. Currently x86, PowerPC, and ARM are supported. https://reviews.llvm.org/D44656 Files: libcxx/include/experimental/__config libcxx

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek added a comment. That link seems to be pointing to this change? Repository: rC Clang https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41843: [libcxx] implement where expressions.

timshen updated this revision to Diff 139043. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41843 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.whereexpr/const_where_expression.pass.cpp libcxx/test/std/exp

[PATCH] D44657: [libcxx] fix a sanitizer-reported bug in

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. Herald added a reviewer: EricWF. In __simd_reference, the conversion between bool and mask integer is in wrong place. https://reviews.llvm.org/D44657

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

eugenis added a comment. Indeed! https://reviews.llvm.org/D44645 Repository: rC Clang https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44658: [libcxx] Implement aligned load and store when compiled with Clang.

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. Simply use __attribute__((align_value(...))). https://reviews.llvm.org/D44658 Files: libcxx/include/experimental/simd Index: libcxx/include/exper

[PATCH] D44662: [libcxx] In , optimize masked div and rem.

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. This optimization is allowed by the semantics, as users shouldn't pass in values that may cause undefined behavior even those values are masked. http

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek added a comment. I was actually thinking about doing the same now, more specifically using `-rtlib=platform` which is already used elsewhere in this test. Do you prefer one or the other? Repository: rC Clang https://reviews.llvm.org/D44655 _

[PATCH] D44661: [libcxx] optimize reduce(), hmin(), hmax() by reordering the operations.

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. Also change std::plus<_Tp> to std::plus<>/__simd_plus_op, so that the optimization can transparently use the simd<> overloading. https://reviews.llvm

[PATCH] D44664: [libcxx] Add missing __simd_reference pieces based on R9.

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. https://reviews.llvm.org/D44664 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.access/default.pass.cpp libcxx/te

[PATCH] D44659: [libcxx] Optimize -O0 performance for operators

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. When vector extension (__attribute__((vector_size(... is available use its operators, instead of generating loops of scalar operations. https://r

[PATCH] D44665: [libcxx] Update synopsis to P0214R9

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. Herald added a reviewer: EricWF. https://reviews.llvm.org/D44665 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.ac

[PATCH] D44660: [libcxx] unroll the loops in for Clang, until LLVM bugs are fixed

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. https://reviews.llvm.org/D44660 Files: libcxx/include/experimental/simd Index: libcxx/include/experimental/simd ==

[PATCH] D44663: [libcxx] Update with R9 changes

timshen created this revision. timshen added a reviewer: mclow.lists. Herald added subscribers: christof, sanjoy. Herald added a reviewer: EricWF. - change the uses of abi_for_size to simd_abi::deduce. - remove the const in const_where_expression's template. https://reviews.llvm.org/D44663 File

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

eugenis added a comment. Since the test is about cfi, not builtins, I think it's better to check for the cfi library explicitly. Repository: rC Clang https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

phosek updated this revision to Diff 139062. phosek added a comment. SGTM, I've made the test even more explicit. https://reviews.llvm.org/D44655 Files: clang/test/Driver/sanitizer-ld.c Index: clang/test/Driver/sanitizer-ld.c =

r327932 - Allow builtins for Cross-DSO CFI on Android

Author: phosek Date: Mon Mar 19 17:56:08 2018 New Revision: 327932 URL: http://llvm.org/viewvc/llvm-project?rev=327932&view=rev Log: Allow builtins for Cross-DSO CFI on Android This is needed to avoid the test failure in case when compiler-rt is set as the default runtime library for Clang. Diff

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

This revision was automatically updated to reflect the committed changes. Closed by commit rC327932: Allow builtins for Cross-DSO CFI on Android (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44655?vs=139062&id=139063#toc Repository: rC Clang https:/

[PATCH] D44655: [Sanitizer] Allow builtins for Cross-DSO CFI on Android

eugenis accepted this revision. eugenis added a comment. LGTM https://reviews.llvm.org/D44655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r327935 - [analyzer] Improve performance of NoStoreFuncVisitor

Author: george.karpenkov Date: Mon Mar 19 18:16:46 2018 New Revision: 327935 URL: http://llvm.org/viewvc/llvm-project?rev=327935&view=rev Log: [analyzer] Improve performance of NoStoreFuncVisitor Compute modifying frames lazily on demand. Differential Revision: https://reviews.llvm.org/D44503 M

[PATCH] D44606: [analyzer] Fix the crash in `IteratorChecker.cpp` when `SymbolConjured` has a null Stmt.

MTC added a comment. > One small nit for future debugging people: Could you insert a comment line in > the test case where you explain what is this all about? E.g what you just > have written in the description: "invalidateRegions() will construct the > SymbolConjured with null Stmt" or somethi

[PATCH] D44606: [analyzer] Fix the crash in `IteratorChecker.cpp` when `SymbolConjured` has a null Stmt.

MTC added a comment. > Just in case: we indeed do not guarantee that `SymbolConjured` corresponds to > a statement; it is, however, not intended, but rather a bug. Thank you for your explanation and the reasonable example, NoQ. Repository: rC Clang https://reviews.llvm.org/D44606 ___

r327939 - [CodeGen] Ignore OpaqueValueExprs that are unique references to their

Author: ahatanak Date: Mon Mar 19 18:47:58 2018 New Revision: 327939 URL: http://llvm.org/viewvc/llvm-project?rev=327939&view=rev Log: [CodeGen] Ignore OpaqueValueExprs that are unique references to their source expressions when iterating over a PseudoObjectExpr's semantic subexpression list. Pre

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

This revision was automatically updated to reflect the committed changes. Closed by commit rL327939: [CodeGen] Ignore OpaqueValueExprs that are unique references to their (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llv

[PATCH] D44557: [analyzer] CStringChecker.cpp - Code refactoring on bug report.

MTC added a comment. In https://reviews.llvm.org/D44557#1042357, @NoQ wrote: > Sorry, one moment, i'm seeing a few regressions after the previous > refactoring but i didn't look at them closely yet to provide a reproducer. > I'll get back to this. Thank you for the code review, @NoQ ! The re

[PATCH] D44670: [CXX] Templates specialization visibility can be wrong

steven_wu created this revision. steven_wu added reviewers: rsmith, arphaman. Under some conditions, LinkageComputer can get the visibility for ClassTemplateSpecializationDecl wrong because it failed to find the Decl that has the explicit visibility. This fixes: llvm.org/bugs/pr36810 rdar://probl

r327945 - Properly construct `inline` members without initializers

Author: gbiv Date: Mon Mar 19 20:27:44 2018 New Revision: 327945 URL: http://llvm.org/viewvc/llvm-project?rev=327945&view=rev Log: Properly construct `inline` members without initializers Digging through commit logs, it appears the checks in this block predate `inline` class variables. With them,

[PATCH] D40775: [libcxx] Add underscores to win32 locale headers.

mclow.lists added a comment. We don't usually do this in source files, because they don't get included in people's builds - just the library build. if you look in src/mutex.cpp, you'll see stuff like: `void __call_once(volatile unsigned long& flag, void* arg, void(*func)(void*))` On the other h

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

phosek created this revision. phosek added reviewers: EricWF, mclow.lists, compnerd, beanz. Herald added subscribers: cfe-commits, christof, mgorny. This seems to be working without any problems. Repository: rCXX libc++ https://reviews.llvm.org/D44671 Files: libcxx/CMakeLists.txt Index:

[PATCH] D44672: [CodeGen] Disable UBSan for coroutine functions

modocache created this revision. modocache added reviewers: GorNishanov, vsk, eric_niebler, lewissbaker. As explained in http://lists.llvm.org/pipermail/llvm-dev/2018-March/121924.html, the LLVM coroutines transforms are not yet able to move the instructions for UBSan null checking past coroutine

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added a comment. Gentle ping) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44673: Make positionToOffset return llvm::Expected

simark created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. simark added a reviewer: ilya-biryukov. To implement incremental document syncing, we want to verify that the ranges provided by the front-end are valid. Currently, positionToOffset

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

smeenai added a comment. I would imagine there was a reason this configuration was unsupported on macOS – perhaps something to do with libc++/libc++abi being the default system libraries on that platform? Comment at: libcxx/CMakeLists.txt:330 # Check that this option is no

[PATCH] D44606: [analyzer] Fix the crash in `IteratorChecker.cpp` when `SymbolConjured` has a null Stmt.

MTC updated this revision to Diff 139075. MTC added a comment. Add the comments as suggested by @szepet . Repository: rC Clang https://reviews.llvm.org/D44606 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/loop-widening.c Index: test/Analysis/loop-widening.c =

[PATCH] D44582: [Builtins] Fix calling long double math functions on x86_64 mingw

mstorsjo abandoned this revision. mstorsjo added a comment. Fixed the issue via https://reviews.llvm.org/D44592 instead, thanks @efriedma for the pointers! Repository: rC Clang https://reviews.llvm.org/D44582 ___ cfe-commits mailing list cfe-com

<    1   2