sammccall added a comment.
Thanks for doing this! Some quibbles about the interface, but this makes index
useful for lots more features.
Comment at: clangd/index/Index.h:268
+ virtual bool
+ getSymbol(const SymbolID &ID,
+llvm::function_ref Callback) const = 0;
-
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:115
+ int virt_1() override { return A::virt_1(); }
+ // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: 'A::virt_1' is a grand-parent's
method, not parent's. Did you mean 'BF'?
+ //
ilya-biryukov updated this revision to Diff 137977.
ilya-biryukov marked 8 inline comments as done.
ilya-biryukov added a comment.
Addressed review comments.
The only thing that's left on my todo-list is a test for toLSPDiags().
Everything else should be ready.
Repository:
rCTE Clang Tools Ex
sammccall added a comment.
Not sure if you're waiting on comments from me: the changes look good.
As discussed I still think Fix should be a separate thing with a name because
that's how editors treat it, and this is the right layer to decide how to do
that mapping.
Comment a
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: djasper
Date: Mon Mar 12 03:11:30 2018
New Revision: 327253
URL: http://llvm.org/viewvc/llvm-project?rev=327253&view=rev
Log:
Don't re-format raw string literal contents when formatting is disable
Not entirely sure this is the best place to put this check, but it fixes
the immediate issue
Author: djasper
Date: Mon Mar 12 03:32:18 2018
New Revision: 327255
URL: http://llvm.org/viewvc/llvm-project?rev=327255&view=rev
Log:
clang-format: Properly handle implicit string concatenation in text protos
Three issues to fix:
- char_constants weren't properly treated as string literals
- Prev
sammccall added a comment.
Sorry, last comments were concurrent with the latest snapshot.
Except where noted, the old comments still apply I think.
Comment at: clangd/ClangdLSPServer.cpp:317
for (Diagnostic &D : Params.context.diagnostics) {
-auto Edits = getFixIts(Para
ilya-biryukov updated this revision to Diff 137985.
ilya-biryukov added a comment.
- Added unit test for toLSPDiags
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44142
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.
ilya-biryukov updated this revision to Diff 137987.
ilya-biryukov marked 14 inline comments as done.
ilya-biryukov added a comment.
- Addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44142
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
cla
ilya-biryukov added inline comments.
Comment at: clangd/Diagnostics.h:35
+ DiagnosticsEngine::Level Severity;
+ llvm::SmallVector FixIts;
+ // Since File is only descriptive, we store a separate flag to distinguish
sammccall wrote:
> sammccall wrote:
> > As di
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.cpp:329
+ {"title",
+ llvm::formatv("Apply FixIt {0}", GetFixitMessage(D.message))},
{"command", ExecuteCommandParams::CLANGD_APPL
SjoerdMeijer added inline comments.
Comment at: include/clang/Basic/arm_neon.td:1504
+ // Scalar floating point multiply extended (scalar, by element)
+ def SCALAR_FMULX_LANEH : IOpInst<"vmulx_lane", "ssdi", "Sh",
OP_SCALAR_MUL_LN>;
+ def SCALAR_FMULX_LANEQH : IOpInst<"vmulx_
tbourvon added a comment.
@alexfh Do you think we can merge this? I think I've been through every
suggestion and it would be nice to finally land the check!
https://reviews.llvm.org/D37014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: chefmax
Date: Mon Mar 12 05:26:15 2018
New Revision: 327258
URL: http://llvm.org/viewvc/llvm-project?rev=327258&view=rev
Log:
[analyzer] Add scope information to CFG
This patch adds two new CFG elements CFGScopeBegin and CFGScopeEnd that indicate
when a local scope begins and ends respect
ilya-biryukov added inline comments.
Comment at: clangd/XRefs.cpp:201
std::vector MacroInfos = DeclMacrosFinder->takeMacroInfos();
+ if (!MacroInfos.empty()) {
+for (auto Item : MacroInfos) {
I wonder whether we should fix the `DeclrationAndMacrosFinder`
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327258: [analyzer] Add scope information to CFG (authored by
chefmax, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D16403
Files:
include/clang/Analysis/AnalysisDeclContext.h
inclu
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/UnnecessaryIntermediateVarCheck.cpp:27-30
+ auto File = Context->getCurrentFile();
+ auto Style = format::getStyle(*Context->getOptionsForFile(File).FormatStyle,
+File, "none
baloghadamsoftware added a comment.
By moving the code that sets the type name of an anoynmous declaration from
Import(Decl*) to ImportDefinition(RecordDecl*, RecordDecl*,
ImportDefinitionKind) (and the same for Enum) we will not crash upon importing
typedefs containing anonymous strcutures. Th
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Ship it! (but let's drop the extra operator== if possible?)
Comment at: clangd/ClangdLSPServer.cpp:329
+ {"title",
+ llvm::formatv("Apply FixIt {0}",
devnexen added a comment.
ping would be nice if it was commited this week :-) especially the other bits
are already
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: chefmax
Date: Mon Mar 12 06:07:54 2018
New Revision: 327263
URL: http://llvm.org/viewvc/llvm-project?rev=327263&view=rev
Log:
[analyzer] Trying to fix buildbots after r327258
Modified:
cfe/trunk/test/Analysis/scopes-cfg-output.cpp
Modified: cfe/trunk/test/Analysis/scopes-cfg-output.c
Author: aaronballman
Date: Mon Mar 12 06:09:13 2018
New Revision: 327264
URL: http://llvm.org/viewvc/llvm-project?rev=327264&view=rev
Log:
Update the supported C language standards in the user manual.
Remove mention of -std=c94 (it is spelled iso9899:1994, not c94) and add
mention of -std=c17 an
abeserminji created this revision.
abeserminji added reviewers: sdardis, petarj.
Herald added a subscriber: arichardson.
This patch makes Clang behave more like gcc.
- On N64 ABI, -mno-abicalls is needed to disable PIC. Warning is reported when
only -fno-pic/-fno-PIC is used.
- An error is repor
Author: chefmax
Date: Mon Mar 12 06:44:19 2018
New Revision: 327270
URL: http://llvm.org/viewvc/llvm-project?rev=327270&view=rev
Log:
[analyzer] Trying to fix Windows buildbots after r327258
Modified:
cfe/trunk/test/Analysis/scopes-cfg-output.cpp
Modified: cfe/trunk/test/Analysis/scopes-cfg-
yvvan abandoned this revision.
yvvan added a comment.
It was the wrong direction
https://reviews.llvm.org/D35200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
paulsemel updated this revision to Diff 137998.
paulsemel added a comment.
Applied Francis' suggestions
Repository:
rC Clang
https://reviews.llvm.org/D44093
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
lib/Sema/SemaChecking.cpp
Index: lib/Sema/SemaChecking.cpp
===
lebedev.ri added a comment.
BTW, as far as i can tell this still has zero test coverage (no new tests are
being added).
I'd expect to see the tests for the actual output
- one struct per each type it is able to print
- probably some tests showing error handling,
and possibly the availability of
gtbercea updated this revision to Diff 137999.
gtbercea added a comment.
Herald added a subscriber: jholewinski.
Change name of folder.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGOpenMPRu
gtbercea updated this revision to Diff 138000.
gtbercea added a comment.
Rename folder. Fix test.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Drive
gtbercea updated this revision to Diff 138001.
gtbercea added a comment.
Fixes.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-g
gtbercea updated this revision to Diff 138002.
gtbercea added a comment.
Add input file.
Repository:
rC Clang
https://reviews.llvm.org/D43197
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Cuda.cpp
test/Driver/Inputs/libomptarget/libomptarget-nvptx-sm_20.bc
ilya-biryukov updated this revision to Diff 138004.
ilya-biryukov added a comment.
- Replace equality comparison ops with matchers, they were only used in tests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44142
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
c
ilya-biryukov accepted this revision.
ilya-biryukov added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/clangd/XRefsTests.cpp:587
- const char *HeaderContents = R"cpp([[]]int a;)cpp";
+ const char *HeaderContents = R"cpp([[]]#ifndef T
Author: sammccall
Date: Mon Mar 12 07:49:09 2018
New Revision: 327275
URL: http://llvm.org/viewvc/llvm-project?rev=327275&view=rev
Log:
[clangd] Collect the number of files referencing a symbol in the static index.
Summary:
This is an important ranking signal.
It's off for the dynamic index for n
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327275: [clangd] Collect the number of files referencing a
symbol in the static index. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44315?vs=137790&id=138
Hi Akira,
It seems that this commit also changes behavior for compiling C++ code as
we are seeing test failures caused by this change in our internal tests.
I'm still trying to reduce a reproducer for the failure. In the meantime,
could you please double check if this affects C++?
Thanks,
Eric
paulsemel added a comment.
Hi,
In https://reviews.llvm.org/D44093#1034610, @lebedev.ri wrote:
> BTW, as far as i can tell this still has zero test coverage (no new tests are
> being added).
> I'd expect to see the tests for the actual output
>
> - one struct per each type it is able to print
>
GBuella created this revision.
GBuella added reviewers: craig.topper, zvi.
Herald added subscribers: cfe-commits, mgorny.
Introduce pconfig and SGX related intrinsics.
Repository:
rC Clang
https://reviews.llvm.org/D44387
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Opt
Author: ibiryukov
Date: Mon Mar 12 08:28:22 2018
New Revision: 327282
URL: http://llvm.org/viewvc/llvm-project?rev=327282&view=rev
Log:
[clangd] Revamp handling of diagnostics.
Summary:
The new implementation attaches notes to diagnostic message and shows
the original diagnostics in the message o
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327282: [clangd] Revamp handling of diagnostics. (authored
by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44142?vs=138004&id=138018#toc
Repository:
rCTE Clang Tool
djasper accepted this revision.
djasper added a comment.
Ok, looks good.
Repository:
rC Clang
https://reviews.llvm.org/D43902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
stettberger updated this revision to Diff 138019.
stettberger marked an inline comment as done.
stettberger added a comment.
Addressed comments, for more details, please see the mail on cfe-devel
Repository:
rC Clang
https://reviews.llvm.org/D40731
Files:
include/clang/AST/AttrDataCollecto
stettberger added inline comments.
Comment at: include/clang/AST/CHashVisitor.h:72-79
+ template
+ void addData(const llvm::iterator_range &x) {
+addData(std::distance(x.begin(), x.end()));
+ }
+ template
+ void addData(const llvm::ArrayRef &x) {
+addData(x.size());
Author: benhamilton
Date: Mon Mar 12 08:42:40 2018
New Revision: 327285
URL: http://llvm.org/viewvc/llvm-project?rev=327285&view=rev
Log:
[clang-format] Improve detection of Objective-C block types
Summary:
Previously, clang-format would detect the following as an
Objective-C block type:
FOO(^
Author: benhamilton
Date: Mon Mar 12 08:42:38 2018
New Revision: 327284
URL: http://llvm.org/viewvc/llvm-project?rev=327284&view=rev
Log:
[clang-format] Don't detect C++11 attribute specifiers as ObjC
Summary:
Previously, clang-format would detect C++11 and C++17 attribute
specifiers like the fol
benhamilton marked an inline comment as done.
benhamilton added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:210
-bool MightBeFunctionType = !Contexts[Contexts.size() - 2].IsExpression;
-bool ProbablyFunctionType = CurrentToken->isOneOf(tok::star, tok::amp
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327284: [clang-format] Don't detect C++11 attribute
specifiers as ObjC (authored by benhamilton, committed by ).
Changed
benhamilton updated this revision to Diff 138024.
benhamilton added a comment.
- Restore short functionn type variable names and add clarifying comment.
Repository:
rC Clang
https://reviews.llvm.org/D43906
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
unittests/F
This revision was automatically updated to reflect the committed changes.
benhamilton marked an inline comment as done.
Closed by commit rC327285: [clang-format] Improve detection of Objective-C
block types (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.
The tests only failed with module enabled. FWIW, I think the change in
ASTImporter (https://reviews.llvm.org/rL327206#change-1q8vFFjJ6Cqk) needs
additional changes to make imports work for RecordDecl.
On Mon, Mar 12, 2018 at 3:56 PM Eric Liu wrote:
> Hi Akira,
>
> It seems that this commit also
I think there is a bug in the ASTImporter/Reader/Writer, but I'm not sure
what's the right way to fix it. I'll revert this commit for now to unblock
integration. Let me know if you need more information from us.
Regards,
Eric
On Mon, Mar 12, 2018 at 4:51 PM Eric Liu wrote:
> The tests only fail
Do you have a reproducer?
> On Mar 12, 2018, at 9:07 AM, Eric Liu wrote:
>
> I think there is a bug in the ASTImporter/Reader/Writer, but I'm not sure
> what's the right way to fix it. I'll revert this commit for now to unblock
> integration. Let me know if you need more information from us.
>
I have been trying to reduce a reproducer for this but haven't gotten any
luck yet. The error happens in conversion between different version of STL
containers and is a bit hard to reduce. I'll keep trying to create a
reproducer.
Could you please also take a quick look to see if ASTImporter/Reader
lebedev.ri added a comment.
Since the commit was reverted, did you mean to either recommit it, or reopen
this (with updated diff), so it does not get lost?
Repository:
rL LLVM
https://reviews.llvm.org/D41102
___
cfe-commits mailing list
cfe-comm
hokein added inline comments.
Comment at: clangd/XRefs.cpp:201
std::vector MacroInfos = DeclMacrosFinder->takeMacroInfos();
+ if (!MacroInfos.empty()) {
+for (auto Item : MacroInfos) {
ilya-biryukov wrote:
> I wonder whether we should fix the `DeclrationA
The patch I committed moved CXXRecordDecl::CanPassInRegisters to RecordDecl. It
looks like ASTImporter::ImportDefinition no longer copies the bit for
CanPassInRegisters after that change. I’m not sure that is what’s causing tests
to fail.
> On Mar 12, 2018, at 9:29 AM, Eric Liu wrote:
>
> I h
Author: hokein
Date: Mon Mar 12 09:49:24 2018
New Revision: 327293
URL: http://llvm.org/viewvc/llvm-project?rev=327293&view=rev
Log:
[clangd] Fix diagnostic errors in the test code, NFC.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: klimek, jkorous-apple, cfe-commits, ioeric
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE327293: [clangd] Fix diagnostic errors in the test code,
NFC. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44294?vs=137712&id=138039#toc
Repository:
rCTE
I think it's likely as our tests only fail with module enabled (without
module, ASTImporter isn't really used).
On Mon, Mar 12, 2018 at 5:51 PM Akira Hatanaka wrote:
> The patch I committed moved CXXRecordDecl::CanPassInRegisters to
> RecordDecl. It looks like ASTImporter::ImportDefinition no lo
I’m not sure if this a bug r327206 introduced or an existing bug in ASTImporter
as there are other bits in RecordDecl that are not copied, but I think I should
revert the patch for now.
> On Mar 12, 2018, at 9:57 AM, Eric Liu wrote:
>
> I think it's likely as our tests only fail with module en
s
patch.
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180312/221427.html
Removed:
cfe/trunk/test/CodeGenObjC/weak-in-c-struct.m
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/lib/AST/A
Author: juliehockett
Date: Mon Mar 12 10:05:14 2018
New Revision: 327295
URL: http://llvm.org/viewvc/llvm-project?rev=327295&view=rev
Log:
Reland "[clang-doc] Setup clang-doc frontend framework"
There was a missing newline in the docs, and a static_assert that needed
to be a normal assert.
Added
juliehockett added a comment.
In https://reviews.llvm.org/D41102#1034919, @lebedev.ri wrote:
> Since the commit was reverted, did you mean to either recommit it, or reopen
> this (with updated diff), so it does not get lost?
Relanded in r327295.
Comment at: clang-doc/Bitcod
Thanks a lot Akira!
FWIW, it seems that the FIXME here might be related
https://github.com/llvm-mirror/clang/blob/master/include/clang/AST/DeclCXX.h#L1484
On Mon, Mar 12, 2018 at 6:03 PM Akira Hatanaka wrote:
> I’m not sure if this a bug r327206 introduced or an existing bug in
> ASTImporter as
I will try implementing John's suggestions. Thanks.
Sam
From: rjmcc...@apple.com [mailto:rjmcc...@apple.com]
Sent: Saturday, March 10, 2018 12:14 PM
To: Richard Smith
Cc: Liu, Yaxun (Sam) ; cfe-commits
Subject: Re: r326946 - CodeGen: Fix address space of indirect function argument
On Mar 9, 2
vsk added a comment.
The new changes look fine. Do you need someone to commit this for you?
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sqlbyme
Date: Mon Mar 12 11:06:37 2018
New Revision: 327304
URL: http://llvm.org/viewvc/llvm-project?rev=327304&view=rev
Log:
[libcxx][test] Adding apple-clang-9 to UNSUPPORTED in
iter_alloc_deduction.fail.cpp.
After two failed attempts last week to make this work I am
going back to a k
vsapsai updated this revision to Diff 138059.
vsapsai added a comment.
- Some more cleanup. NFC.
https://reviews.llvm.org/D43494
Files:
clang/lib/Serialization/ASTReaderDecl.cpp
clang/test/Modules/Inputs/self-referencing-lambda/a.h
clang/test/Modules/Inputs/self-referencing-lambda/module.
devnexen added a comment.
Yes I do ☺ thanks.
https://reviews.llvm.org/D44069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai marked 6 inline comments as done.
vsapsai added inline comments.
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1798
+ // already done some merging. Either way, just merge into it.
+ if (Canon->DefinitionData && Canon->DefinitionData != DD) {
MergeDefinition
Author: george.karpenkov
Date: Mon Mar 12 11:27:36 2018
New Revision: 327309
URL: http://llvm.org/viewvc/llvm-project?rev=327309&view=rev
Log:
[analyzer] Move the GCDAsyncSemaphoreChecker to optin.performance
rdar://38383753
Differential Revision: https://reviews.llvm.org/D44228
Added:
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327309: [analyzer] Move the GCDAsyncSemaphoreChecker to
optin.performance (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
https://reviews.
Author: jkorous
Date: Mon Mar 12 11:33:55 2018
New Revision: 327313
URL: http://llvm.org/viewvc/llvm-project?rev=327313&view=rev
Log:
[Driver] Add text description of --help-hidden so it is shown in help
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Dr
ahatanak reopened this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
The patch got reverted in r325335 as it broke the Chromium build. I'm reopening
this review.
Repository:
rC Clang
https://reviews.llvm.org/D36918
___
jdemeule added inline comments.
Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:213-221
// Use the file manager to deduplicate paths. FileEntries are
// automatically canonicalized.
- if (const FileEntry *Entry =
SM.getFileMa
ahatanak updated this revision to Diff 138066.
ahatanak added a comment.
The new patch passes the calling context to CheckNonDependent so that
Sema::CheckAddressOfMemberAccess uses the correct context to check
accessibility of explicit template arguments. I initially tried moving the
declaratio
Author: vedantk
Date: Mon Mar 12 12:18:51 2018
New Revision: 327317
URL: http://llvm.org/viewvc/llvm-project?rev=327317&view=rev
Log:
Check that ubsan is the only supported sanitizer on OpenBSD
Patch by David Carlier!
Differential Revision: https://reviews.llvm.org/D44069
Modified:
cfe/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL327317: Check that ubsan is the only supported sanitizer on
OpenBSD (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4406
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327317: Check that ubsan is the only supported sanitizer on
OpenBSD (authored by vedantk, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44069
Files:
test/Driver/fsanitize.c
Index:
Author: arphaman
Date: Mon Mar 12 12:36:29 2018
New Revision: 327322
URL: http://llvm.org/viewvc/llvm-project?rev=327322&view=rev
Log:
[Tooling] Clear the PreambleSrcLocCache when preamble is discarded during
reparsing
This ensures that diagnostics are not remapped to incorrect preamble location
boga95 added a subscriber: szepet.
boga95 marked 4 inline comments as done.
boga95 added inline comments.
Comment at: test/clang-tidy/cert-properly-seeded-random-generator.cpp:76
+ // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: random number generator must be
seeded with a random
Author: jvesely
Date: Mon Mar 12 12:46:48 2018
New Revision: 327323
URL: http://llvm.org/viewvc/llvm-project?rev=327323&view=rev
Log:
travis: Add build using llvm-6
Acked-by: Aaron Watry
Signed-off-by: Jan Vesely
Modified:
libclc/trunk/.travis.yml
Modified: libclc/trunk/.travis.yml
URL:
Author: jvesely
Date: Mon Mar 12 12:46:52 2018
New Revision: 327324
URL: http://llvm.org/viewvc/llvm-project?rev=327324&view=rev
Log:
nan: Implement
Passes CTS on carrizo and turks
Reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/include/clc/math/nan.h
libcl
Hi Julie,
It looks like this commit is causing Clang tests in Windows bots to crash.
Could you take a look?
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/9413
Thanks,
Matthew
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:44
+CheckFactories.registerCheck(
+"fuchsia-zx-temporary-objects");
}
Do we want a zircon module instead? I'm wondering about people who enable
modules by do
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I think this check LGTM.
https://reviews.llvm.org/D41655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
russellmcc added a comment.
Bump!
https://reviews.llvm.org/D40988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bumblebritches57 added a comment.
Herald added a subscriber: christof.
This is the wrong approach.
C and C++ compatibility is far more important than taking the easy way out.
By doing this, you're potentially breaking the ABI for all software that relies
on atomic operations...
https://review
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: juliehockett
Date: Mon Mar 12 14:39:01 2018
New Revision: 327333
URL: http://llvm.org/viewvc/llvm-project?rev=327333&view=rev
Log:
[docs] Adding clang-doc to CTE toctree to fix docs build error
Modified:
clang-tools-extra/trunk/docs/clang-doc.rst
clang-tools-extra/trunk/docs/index
Author: rnk
Date: Mon Mar 12 14:43:02 2018
New Revision: 327334
URL: http://llvm.org/viewvc/llvm-project?rev=327334&view=rev
Log:
Re-land "[Sema] Make getCurFunction() return null outside function parsing"
This relands r326965.
There was a null dereference in typo correction that was triggered i
Hi Alex,
The test you added in this commit seems to be failing on the Windows bot
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/15855:
FAIL: Clang :: Index/reparsed-live-issue.cpp (7841 of 38815)
TEST 'Clang :: Index/reparsed-live-
Author: dergachev
Date: Mon Mar 12 16:12:40 2018
New Revision: 327343
URL: http://llvm.org/viewvc/llvm-project?rev=327343&view=rev
Log:
[CFG] [analyzer] Add construction context to C++ return-by-value call elements.
This patch adds a new CFGStmt sub-class, CFGCXXRecordTypedCall, which replaces
th
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327343: [CFG] [analyzer] Add construction context to C++
return-by-value call elements. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44120?vs=137116&id=1381
Author: dergachev
Date: Mon Mar 12 16:22:35 2018
New Revision: 327345
URL: http://llvm.org/viewvc/llvm-project?rev=327345&view=rev
Log:
[analyzer] Destroy and lifetime-extend inlined function return values properly.
This patch uses the newly added CFGCXXRecordTypedCall element at the call site
of
This revision was automatically updated to reflect the committed changes.
Closed by commit rC327345: [analyzer] Destroy and lifetime-extend inlined
function return values properly. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D44124
Files:
lib/Static
Author: sammccall
Date: Mon Mar 12 16:22:35 2018
New Revision: 327344
URL: http://llvm.org/viewvc/llvm-project?rev=327344&view=rev
Log:
[clangd] Remove Tagged and some related APIs from ClangdServer.
Context can do what Tagged was intended to support (snapshot filesystems),
and less intrusively.
Author: juliehockett
Date: Mon Mar 12 16:23:24 2018
New Revision: 327346
URL: http://llvm.org/viewvc/llvm-project?rev=327346&view=rev
Log:
Revert "Reland "[clang-doc] Setup clang-doc frontend framework""
This reverts commit r327295 since it was causing the Windows bots to
fail.
Removed:
clan
Author: dergachev
Date: Mon Mar 12 16:27:52 2018
New Revision: 327347
URL: http://llvm.org/viewvc/llvm-project?rev=327347&view=rev
Log:
[analyzer] NFC: Move the code for setting temp object lifetime into method.
Differential Revision: https://reviews.llvm.org/D44129
Modified:
cfe/trunk/inclu
1 - 100 of 124 matches
Mail list logo
