[libcxx] r327190 - [libcxx][test] Marking libcpp-no-deduction-guides unsupported.

2018-03-09 Thread Mike Edwards via cfe-commits
Author: sqlbyme Date: Fri Mar 9 16:19:25 2018 New Revision: 327190 URL: http://llvm.org/viewvc/llvm-project?rev=327190&view=rev Log: [libcxx][test] Marking libcpp-no-deduction-guides unsupported. This fixes linux bot failures with r327178. Modified: libcxx/trunk/test/std/strings/basic.st

[libcxx] r327191 - [libcxx][test] Reverting r327178 and r327190.

2018-03-09 Thread Mike Edwards via cfe-commits
Author: sqlbyme Date: Fri Mar 9 16:53:05 2018 New Revision: 327191 URL: http://llvm.org/viewvc/llvm-project?rev=327191&view=rev Log: [libcxx][test] Reverting r327178 and r327190. Reverting changes made to iter_alloc_deduction.fail.cpp as my changes seem to be making several Linux bots angry. M

[PATCH] D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC.

2018-03-09 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu added inline comments. Comment at: lib/Sema/SemaStmt.cpp:2953 + ExprResult &Res) +{ + ImplicitCastExpr AsRvalue(ImplicitCastExpr::OnStack, Value->getType(), Opening brace should follow the closing paren on previous line.

r327192 - [CodeGen] Try to not call a dtor after lifetime.end

2018-03-09 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Fri Mar 9 17:11:17 2018 New Revision: 327192 URL: http://llvm.org/viewvc/llvm-project?rev=327192&view=rev Log: [CodeGen] Try to not call a dtor after lifetime.end If CodeGenFunction::EmitCall is: - asked to emit a call with an indirectly returned value, - given an invalid retu

[PATCH] D44327: ObjCARC: teach the cloner about funclets

2018-03-09 Thread David Majnemer via Phabricator via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:692 + DenseMap &BlockColors) { + auto *CI = dyn_cast(&I); + assert(CI && "CloneCallInst must r

[libcxx] r327194 - [CMake] Copy the generated __config header into build directory

2018-03-09 Thread Petr Hosek via cfe-commits
Author: phosek Date: Fri Mar 9 17:20:11 2018 New Revision: 327194 URL: http://llvm.org/viewvc/llvm-project?rev=327194&view=rev Log: [CMake] Copy the generated __config header into build directory When the generated __config file is being used, it is currently only copied during installation proc

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

2018-03-09 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL327194: [CMake] Copy the generated __config header into build directory (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D44346: [clang-tidy] Add Fuchsia checker for temporary objects

2018-03-09 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a checker to fuchsia-zx (for zircon) to flag instances where specific objects are temporaril

r327195 - Revert r326946. It caused stack overflows by significantly increasing the size of a CallArgList.

2018-03-09 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Mar 9 17:47:22 2018 New Revision: 327195 URL: http://llvm.org/viewvc/llvm-project?rev=327195&view=rev Log: Revert r326946. It caused stack overflows by significantly increasing the size of a CallArgList. Removed: cfe/trunk/test/CodeGenCXX/amdgcn-func-arg.cpp Modifie

Re: r326946 - CodeGen: Fix address space of indirect function argument

2018-03-09 Thread Richard Smith via cfe-commits
Hi, This change increases the size of a CallArg, and thus that of a CallArgList, dramatically (an LValue is *much* larger than an RValue, and unlike an RValue, does not appear to be at all optimized for size). This results in CallArgList (which contains inline storage for 16 CallArgs) ballooning i

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, baloghadamsoftware. I've been investigating a false positive that had a pointer-type symbol with a non-zero range which had its range forgott

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 137892. NoQ added a comment. Slightly simplify one of the tests. https://reviews.llvm.org/D44347 Files: include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h test/Analysis/symbol-reaper.c Index: test/Analysis/symbol-reaper.c

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Leak false-negatives that result from bugs in `Environment::removeDeadBindings()` and `RegionStoreManager::removeDeadBindings()` are also only appearing due to the overall zombie symbol problem we have (https://reviews.llvm.org/D18860). The bugs are in the code that popula

[PATCH] D40731: Integrate CHash into CLang

2018-03-09 Thread Richard Trieu via Phabricator via cfe-commits
rtrieu added inline comments. Herald added a subscriber: JDevlieghere. Comment at: include/clang/AST/CHashVisitor.h:72-79 + template + void addData(const llvm::iterator_range &x) { +addData(std::distance(x.begin(), x.end())); + } + template + void addData(const llvm::Arr

[PATCH] D44347: [analyzer] symbol_iterator must iterate through the symbolic base.

2018-03-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > Because string length is for now only composed of `CStringChecker`-tagged > metadata symbols and constants... Even if this was not the case, it is stil certain that string length is a `NonLoc`. And as such it is either a plain `nonloc::SymbolVal` that is unaffected or a

[PATCH] D44346: [clang-tidy] Add Fuchsia checker for temporary objects

2018-03-09 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tidy/fuchsia/ZxTemporaryObjectsCheck.cpp:24 + std::string QualifiedName = Node.getQualifiedNameAsString(); + return llvm::any_of(Names, + [&](StringRef Name) { return QualifiedName == Name; }); ---

r327204 - [Driver] Pass Default=false to hasFlag.

2018-03-09 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Fri Mar 9 21:55:21 2018 New Revision: 327204 URL: http://llvm.org/viewvc/llvm-project?rev=327204&view=rev Log: [Driver] Pass Default=false to hasFlag. I forgot to do this in r326530. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/trunk/test/Driver/fno-esc

r327206 - [ObjC] Allow declaring __weak pointer fields in C structs in ARC.

2018-03-09 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Fri Mar 9 22:36:08 2018 New Revision: 327206 URL: http://llvm.org/viewvc/llvm-project?rev=327206&view=rev Log: [ObjC] Allow declaring __weak pointer fields in C structs in ARC. This patch uses the infrastructure added in r326307 for enabling non-trivial fields to be declar

[PATCH] D44095: [ObjC] Allow declaring __weak pointer fields in C structs in ObjC-ARC

2018-03-09 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL327206: [ObjC] Allow declaring __weak pointer fields in C structs in ARC. (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D44095: [ObjC] Allow declaring __weak pointer fields in C structs in ObjC-ARC

2018-03-09 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC327206: [ObjC] Allow declaring __weak pointer fields in C structs in ARC. (authored by ahatanak, committed by ). Repository: rC Clang https://reviews.llvm.org/D44095 Files: include/clang/AST/Decl.h

<    1   2