[PATCH] D44172: [analyzer] [PointerArithChecker] do not warn on indexes into vector types

This revision was automatically updated to reflect the committed changes. Closed by commit rC326952: [analyzer] [PointerArithChecker] do not warn on indexes into vector types (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://rev

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

ilya-biryukov added a comment. I would vouch for adding a log level instead. It's a very well understood concept that certainly covers this use-case and can be useful in other places. WDYT? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44226

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

niko added a comment. If this is OK as it is, can someone with commit access push this? Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[clang-tools-extra] r326954 - [Documentation] Fix Clang-tidy checks list broken in r326909.

Author: eugenezelenko Date: Wed Mar 7 14:30:50 2018 New Revision: 326954 URL: http://llvm.org/viewvc/llvm-project?rev=326954&view=rev Log: [Documentation] Fix Clang-tidy checks list broken in r326909. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified: clang-tools-ex

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

simark added a comment. In https://reviews.llvm.org/D44226#1030625, @ilya-biryukov wrote: > I would vouch for adding a log level instead. It's a very well understood > concept that certainly covers this use-case and can be useful in other places. > WDYT? I agree. How would you prefer the fla

[PATCH] D44131: [analyzer] Support temporaries conjured by conservatively evaluated functions.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D44131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

rnk updated this revision to Diff 137487. rnk added a comment. - remove Sema::recordEvaluatedWeakUse to fix Linux build https://reviews.llvm.org/D44221 Files: clang/include/clang/Sema/ScopeInfo.h clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaLambda.h clang/lib/Sema/Sema.c

r326957 - Avoid including ScopeInfo.h from Sema.h

Author: rnk Date: Wed Mar 7 14:48:35 2018 New Revision: 326957 URL: http://llvm.org/viewvc/llvm-project?rev=326957&view=rev Log: Avoid including ScopeInfo.h from Sema.h Summary: This provides no measurable build speedup, but it reinstates an optimization from r112038 that was lost in r179618. I

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL326957: Avoid including ScopeInfo.h from Sema.h (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44221?vs=137487&id=137489#to

[PATCH] D44221: Avoid including ScopeInfo.h from Sema.h

This revision was automatically updated to reflect the committed changes. Closed by commit rC326957: Avoid including ScopeInfo.h from Sema.h (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D44221?vs=137487&id=137488#toc Repository: rC Clang https://review

[libcxx] r326958 - Include since we use it. Thanks to Andrey Maksimov for the catch.

Author: marshall Date: Wed Mar 7 14:51:16 2018 New Revision: 326958 URL: http://llvm.org/viewvc/llvm-project?rev=326958&view=rev Log: Include since we use it. Thanks to Andrey Maksimov for the catch. Modified: libcxx/trunk/test/std/numerics/rand/rand.device/eval.pass.cpp Modified: libcxx/

[PATCH] D44229: Don't use -pie in relocatable link.

eugenis created this revision. eugenis added a reviewer: srhines. Android, in particular, got PIE enabled by default in r316606. It resulted in relocatable links passing both -r and -pie to the linker, which is not allowed. https://reviews.llvm.org/D44229 Files: clang/lib/Driver/ToolChains/Gn

[PATCH] D44229: Don't use -pie in relocatable link.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks for fixing this quickly. :) https://reviews.llvm.org/D44229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D44229: Don't use -pie in relocatable link.

mgrang added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 + if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || + Args.hasArg(options::OPT_r)) return false; We also need to check for -Wl,-r and -Xlinker -

[PATCH] D44231: Check for sizeof that call functions

pfultz2 created this revision. pfultz2 added reviewers: clang-tools-extra, hokein, alexfh, aaron.ballman, ilya-biryukov. Herald added a subscriber: jkorous-apple. A common mistake that I have found in our codebase is calling a function to get an integer or enum that represents the type such as:

[PATCH] D44231: Check for sizeof that call functions

pfultz2 updated this revision to Diff 137496. https://reviews.llvm.org/D44231 Files: clangd/CodeComplete.cpp test/clangd/protocol.test unittests/clangd/CodeCompleteTests.cpp Index: unittests/clangd/CodeCompleteTests.cpp === -

[PATCH] D44231: Check for sizeof that call functions

pfultz2 updated this revision to Diff 137497. https://reviews.llvm.org/D44231 Files: clang-tidy/misc/SizeofExpressionCheck.cpp clang-tidy/misc/SizeofExpressionCheck.h test/clang-tidy/misc-sizeof-expression.cpp Index: test/clang-tidy/misc-sizeof-expression.cpp ==

[PATCH] D44231: Check for sizeof that call functions

pfultz2 updated this revision to Diff 137499. https://reviews.llvm.org/D44231 Files: clang-tidy/misc/SizeofExpressionCheck.cpp clang-tidy/misc/SizeofExpressionCheck.h test/clang-tidy/misc-sizeof-expression.cpp Index: test/clang-tidy/misc-sizeof-expression.cpp ==

r326960 - [ms] Emit vtordisp initializers in a deterministic order.

Author: nico Date: Wed Mar 7 15:15:20 2018 New Revision: 326960 URL: http://llvm.org/viewvc/llvm-project?rev=326960&view=rev Log: [ms] Emit vtordisp initializers in a deterministic order. No effective behavior change, just for cleanliness. Analysis and typing by me, actual patch mostly by Reid.

r326961 - Set dso_local on tls init functions.

Author: rafael Date: Wed Mar 7 15:18:06 2018 New Revision: 326961 URL: http://llvm.org/viewvc/llvm-project?rev=326961&view=rev Log: Set dso_local on tls init functions. We copy the visibility, so copying the dso_local flag seems the natural thing to do. Modified: cfe/trunk/lib/CodeGen/Itani

[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

thakis closed this revision. thakis marked an inline comment as done. thakis added a comment. r326960, thanks! https://reviews.llvm.org/D44223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

rjmccall added a comment. I agree that having those sites just no-op themselves is the cleanest approach. https://reviews.llvm.org/D44039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D43990: set dso_local on tls init functions

espindola closed this revision. espindola added a comment. r326961 https://reviews.llvm.org/D43990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44095: [ObjC] Allow declaring __weak pointer fields in C structs in ObjC-ARC

ahatanak updated this revision to Diff 137500. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D44095 Files: include/clang/AST/Decl.h include/clang/AST/DeclCXX.h include/clang/AST/Type.h lib/AST/ASTImporter.cpp lib

[PATCH] D44095: [ObjC] Allow declaring __weak pointer fields in C structs in ObjC-ARC

ahatanak added inline comments. Comment at: include/clang/AST/Decl.h:3631 +PassedIndirectly = true; + } + rjmccall wrote: > I feel like this flag should be set by Sema for C++ types that have to be > passed indirectly as well; it can then become the single

r326962 - [MS] Accept __unaligned as a qualifier on member function pointers

Author: rnk Date: Wed Mar 7 15:26:02 2018 New Revision: 326962 URL: http://llvm.org/viewvc/llvm-project?rev=326962&view=rev Log: [MS] Accept __unaligned as a qualifier on member function pointers We need to treat __unaligned like the other 'cvr' qualifiers when it appears at the end of a functio

[PATCH] D44233: Set dso_local on external rtti GVs

espindola created this revision. espindola added a reviewer: rnk. In this particular case it would be possible to just add an else with CGM.setDSOLocal(GV), but it seems better to have as many callers as possible just call setGVProperties so that we can centralize the logic there. This patch t

[PATCH] D44229: Don't use -pie in relocatable link.

eugenis added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 + if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || + Args.hasArg(options::OPT_r)) return false; mgrang wrote: > We also need to check for -Wl,

r326965 - [Sema] Make getCurFunction() return null outside function parsing

Author: rnk Date: Wed Mar 7 16:14:34 2018 New Revision: 326965 URL: http://llvm.org/viewvc/llvm-project?rev=326965&view=rev Log: [Sema] Make getCurFunction() return null outside function parsing Summary: Before this patch, Sema pre-allocated a FunctionScopeInfo and kept it in the first, always p

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rL326965: [Sema] Make getCurFunction() return null outside function parsing (authored by rnk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44

[PATCH] D44039: [Sema] Make getCurFunction() return null outside function parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rC326965: [Sema] Make getCurFunction() return null outside function parsing (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D44039?vs=137472&id=137506#toc Repository:

r326968 - Fix a doc typo; NFC

Author: gbiv Date: Wed Mar 7 16:22:04 2018 New Revision: 326968 URL: http://llvm.org/viewvc/llvm-project?rev=326968&view=rev Log: Fix a doc typo; NFC Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib

r326971 - [MS] Pass CVRU qualifiers properly in Itanium mangler

Author: rnk Date: Wed Mar 7 16:55:09 2018 New Revision: 326971 URL: http://llvm.org/viewvc/llvm-project?rev=326971&view=rev Log: [MS] Pass CVRU qualifiers properly in Itanium mangler We already have a mangling for the __unaligned qualifier, we just have to call Qualifiers::getFromCVRUMask instea

r326973 - When substituting previously-checked template arguments into a template

Author: rsmith Date: Wed Mar 7 17:07:33 2018 New Revision: 326973 URL: http://llvm.org/viewvc/llvm-project?rev=326973&view=rev Log: When substituting previously-checked template arguments into a template template parameter that is an expanded parameter pack, only substitute into the current slice

r326974 - Revert "[Sema] Make getCurFunction() return null outside function parsing"

Author: rnk Date: Wed Mar 7 17:12:22 2018 New Revision: 326974 URL: http://llvm.org/viewvc/llvm-project?rev=326974&view=rev Log: Revert "[Sema] Make getCurFunction() return null outside function parsing" This reverts r326965. It seems to have caused repeating test failures in clang/test/Sema/dia

[PATCH] D16632: clang-cl: Take dllexport from original function decl into account

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D16632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

NoQ created this revision. NoQ added reviewers: rsmith, doug.gregor, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. In code like const int &x = A().x; the destructor for `A()` was not present in the CFG due to two problems in the p

[PATCH] D44239: [analyzer] Re-enable constructor inlining when lifetime extension through fields occurs.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. NoQ added a dependency: D44238: [CFG] Fix automatic destructors when a member is bound to a reference.. In code like const int &x = C().x;

r326979 - [Documentation] Fix Release notes problems introduced in r326889. Add highlighting.

Author: eugenezelenko Date: Wed Mar 7 17:37:39 2018 New Revision: 326979 URL: http://llvm.org/viewvc/llvm-project?rev=326979&view=rev Log: [Documentation] Fix Release notes problems introduced in r326889. Add highlighting. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/

[PATCH] D16403: Add scope information to CFG

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think we should land this and celebrate. @szepet: Ouch, i was sure i already answered this, sorry, dunno where this went. > So, LoopExit and ScopeExit would be the same but the underlying TriggerS

[PATCH] D16403: Add scope information to CFG

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:1700 /// way return valid LocalScope object. LocalScope* CFGBuilder::createOrReuseLocalScope(LocalScope* Scope) { if (Scope) NoQ wrote: > It seems that something has moved asterisks to a weird spot

[PATCH] D44241: Add a check for constructing non-trivial types without assigning to a variable

pfultz2 created this revision. pfultz2 added reviewers: clang-tools-extra, aaron.ballman. pfultz2 added a project: clang-tools-extra. Herald added a subscriber: mgorny. Diagnoses when a non-trivial type is not assigned to a variable. This is useful to check for problems like unnamed lock guards.

r326980 - Fix an unused variable warning; NFC

Author: gbiv Date: Wed Mar 7 18:15:12 2018 New Revision: 326980 URL: http://llvm.org/viewvc/llvm-project?rev=326980&view=rev Log: Fix an unused variable warning; NFC Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngine.cpp URL: h

r326982 - [analyzer] Correctly model iteration through "nil" objects

Author: george.karpenkov Date: Wed Mar 7 18:53:39 2018 New Revision: 326982 URL: http://llvm.org/viewvc/llvm-project?rev=326982&view=rev Log: [analyzer] Correctly model iteration through "nil" objects Previously, iteration through nil objects which resulted from objc-messages being set to nil we

[PATCH] D44178: [analyzer] Correctly model iteration through "nil" objects

This revision was automatically updated to reflect the committed changes. Closed by commit rC326982: [analyzer] Correctly model iteration through "nil" objects (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D44095: [ObjC] Allow declaring __weak pointer fields in C structs in ObjC-ARC

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: lib/CodeGen/CGNonTrivialStruct.cpp:764 +Object = CGF->EmitObjCConsumeObject(QT, Object); +CGF->EmitARCStoreWeak(Addrs[DstIdx], Object, t

r326988 - [CodeGen] Emit lifetime.ends in both EH and non-EH blocks

Author: gbiv Date: Wed Mar 7 21:32:30 2018 New Revision: 326988 URL: http://llvm.org/viewvc/llvm-project?rev=326988&view=rev Log: [CodeGen] Emit lifetime.ends in both EH and non-EH blocks Before this, we'd only emit lifetime.ends for these temps in non-exceptional paths. This potentially made ou

r326990 - Propagate DLLAttr to friend re-declarations of member functions

Author: sberg Date: Wed Mar 7 23:34:40 2018 New Revision: 326990 URL: http://llvm.org/viewvc/llvm-project?rev=326990&view=rev Log: Propagate DLLAttr to friend re-declarations of member functions ...that have already been constructed (e.g., in inner classes) while parsing the class definition. T

[PATCH] D16632: clang-cl: Take dllexport from original function decl into account

This revision was automatically updated to reflect the committed changes. Closed by commit rL326990: Propagate DLLAttr to friend re-declarations of member functions (authored by sberg, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D16

[PATCH] D44189: [RISCV] Verify the input value of -march=

kito-cheng updated this revision to Diff 137547. Repository: rC Clang https://reviews.llvm.org/D44189 Files: lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index: test/Driver/riscv-arch.c === --- /dev/null +++

[PATCH] D44189: [RISCV] Verify the input value of -march=

kito-cheng marked 2 inline comments as done. kito-cheng added inline comments. Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:48 + break; +default: + // First letter should be 'i' or 'g'. apazos wrote: > In the switch cases move default to first p

<    1   2