[PATCH] D43969: Improve completion experience for headers

phst created this revision. phst added a reviewer: klimek. Herald added a subscriber: cfe-commits. When calling `completing-read', we should provide a default to prevent the behavior described in https://github.com/DarwinAwardWinner/ido-completing-read-plus#why-does-ret-sometimes-not-select-the-

[PATCH] D43969: Improve completion experience for headers

phst updated this revision to Diff 136597. phst added a comment. Revert bogus additions Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 Files: include-fixer/tool/clang-include-fixer.el Index: include-fixer/tool/clang-include-fixer.el ===

[PATCH] D43969: Improve completion experience for headers

phst updated this revision to Diff 136598. phst added a comment. Fix condition Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 Files: include-fixer/tool/clang-include-fixer.el Index: include-fixer/tool/clang-include-fixer.el

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

chh updated this revision to Diff 136601. chh retitled this revision from "[CodeGen] Force the backend to follow clang's EmulatedTLS flag" to "[Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS". chh edited the summary of this revision. chh added a reviewer: srhines. https://review

r326493 - [www] Capitalize "Clang" when referring to the project, and generalize the

Author: rsmith Date: Thu Mar 1 14:01:06 2018 New Revision: 326493 URL: http://llvm.org/viewvc/llvm-project?rev=326493&view=rev Log: [www] Capitalize "Clang" when referring to the project, and generalize the introduction on the front page page. We still use the lowercase "clang" spelling when ref

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM (although I didn't test run it). https://reviews.llvm.org/D43965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

chh added a comment. Martin, thanks for finding this problem. Please review/accept my new change if it passes your tests. After this and https://reviews.llvm.org/D42999, the default emulated TLS mode should only be decided in llvm/trunk/include/llvm/ADT/Triple.h hasDefaultEmulatedTLS(). https:/

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

mstorsjo added a comment. Tested on the case that was broken before, and seems to work fine. Thanks! https://reviews.llvm.org/D43965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r326496 - [modules] Don't diagnose "redefinition" of a friend with a pending definition

Author: rsmith Date: Thu Mar 1 14:20:13 2018 New Revision: 326496 URL: http://llvm.org/viewvc/llvm-project?rev=326496&view=rev Log: [modules] Don't diagnose "redefinition" of a friend with a pending definition if the other definition is a merged copy of the same function. Added: cfe/trunk/te

r326499 - [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

Author: chh Date: Thu Mar 1 14:26:19 2018 New Revision: 326499 URL: http://llvm.org/viewvc/llvm-project?rev=326499&view=rev Log: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS Since LLVM r326341, default EmulatedTLS mode is decided in backend according to target triple. Any fro

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

This revision was automatically updated to reflect the committed changes. Closed by commit rL326499: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS (authored by chh, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D439

r326501 - [NFC] Move CommentOpts checks to the call sites that depend on it.

Author: dlj Date: Thu Mar 1 14:41:53 2018 New Revision: 326501 URL: http://llvm.org/viewvc/llvm-project?rev=326501&view=rev Log: [NFC] Move CommentOpts checks to the call sites that depend on it. When parsing comments, for example, for -Wdocumentation, slightly different behaviour occurs when -f

[PATCH] D43663: [NFC] Move CommentOpts checks to the call sites that depend on it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it. (authored by dlj, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

r326508 - Revert r326501 due to buildbot breakage.

Author: dlj Date: Thu Mar 1 15:14:00 2018 New Revision: 326508 URL: http://llvm.org/viewvc/llvm-project?rev=326508&view=rev Log: Revert r326501 due to buildbot breakage. Original change: [NFC] Move CommentOpts checks to the call sites that depend on it. When parsing comments, for example, for

Re: r326141 - Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver."

Should we key the default off the triple? (I thought that what was the patch did, but I misread.) I.e. with an MSVC triple, default to emitting codeview? On Mon, Feb 26, 2018 at 5:55 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Mon Feb 26 14:55:33 2

Re: r326141 - Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver."

I want to do that, but it will surely break the LLDB test suite, which assumes `clang -g` makes dwarf. It's just a matter of fixing up the flags their test makefiles use. On Thu, Mar 1, 2018 at 3:22 PM Nico Weber wrote: > Should we key the default off the triple? (I thought that what was the >

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 136624. jdenny marked 23 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. This update should address all outstanding comments. https://reviews.llvm.org/D43248 Files: include/clang/AST/Attr.h include/clang/Basic

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: include/clang/AST/Attr.h:206 + + void cmpable(const ParamIdx &I) const { +assert(isValid() && I.isValid() && aaron.ballman wrote: > jdenny wrote: > > aaron.ballman wrote: > > > The name here can be improved. How abou

r326512 - [NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying r326501.)

Author: dlj Date: Thu Mar 1 16:07:45 2018 New Revision: 326512 URL: http://llvm.org/viewvc/llvm-project?rev=326512&view=rev Log: [NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying r326501.) When parsing comments, for example, for -Wdocumentation, slightly different

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

rnk created this revision. rnk added a reviewer: rsmith. This is PR36536. There are a few ways to reach Sema::ActOnStartOfFunctionDef with a null Decl. Currently, the parser continues on to attempt to parse the statements in the function body without pushing a function scope or declaration contex

[PATCH] D43681: [WebAssembly] Add exception handling option

This revision was automatically updated to reflect the committed changes. Closed by commit rL326517: [WebAssembly] Add exception handling option (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43681 Files: cfe/trun

r326517 - [WebAssembly] Add exception handling option

Author: aheejin Date: Thu Mar 1 16:39:16 2018 New Revision: 326517 URL: http://llvm.org/viewvc/llvm-project?rev=326517&view=rev Log: [WebAssembly] Add exception handling option Summary: Add exception handling option to clang. Reviewers: dschuff Subscribers: jfb, sbc100, jgravelle-google, sunfi

r326518 - [analyzer] [NFC] [tests] Make test more resilient to changes in exploration strategy

Author: george.karpenkov Date: Thu Mar 1 16:54:05 2018 New Revision: 326518 URL: http://llvm.org/viewvc/llvm-project?rev=326518&view=rev Log: [analyzer] [NFC] [tests] Make test more resilient to changes in exploration strategy Modified: cfe/trunk/test/Analysis/MisusedMovedObject.cpp Modifi

r326519 - [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Thu Mar 1 16:54:51 2018 New Revision: 326519 URL: http://llvm.org/viewvc/llvm-project?rev=326519&view=rev Log: [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/StaticAnaly

r326520 - [analyzer] Prevent crashing in NonNullParamChecker

Author: george.karpenkov Date: Thu Mar 1 16:55:59 2018 New Revision: 326520 URL: http://llvm.org/viewvc/llvm-project?rev=326520&view=rev Log: [analyzer] Prevent crashing in NonNullParamChecker https://bugs.llvm.org/show_bug.cgi?id=36381 rdar://37543426 Turns out, the type passed for the lambda

[PATCH] D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option

EricMarti updated this revision to Diff 136645. EricMarti added a comment. Herald added a subscriber: klimek. Updated the comment in Format.h and ran the python script. Looks like a few more changes got pulled into the rst file. https://reviews.llvm.org/D43731 Files: docs/ClangFormatStyleOpt

[PATCH] D43925: [analyzer] Prevent crashing in NonNullParamChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC326520: [analyzer] Prevent crashing in NonNullParamChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D43925 F

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136650. juliehockett marked 16 inline comments as done. juliehockett added a comment. Adding tests, fixing comments, and removing an (as-of-yet) unused element of the CommentInfo struct. https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:196 +/// \brief Emits a record name to the BLOCKINFO block. +void ClangDocBitcodeWriter::emitRecordID(RecordId ID) { + assert(RecordIdNameMap[ID] && "Unknown Abbreviation"); lebedev.ri w

r326527 - Always set dso_local in CodeGenModule::setDSOLocal.

Author: rafael Date: Thu Mar 1 17:29:51 2018 New Revision: 326527 URL: http://llvm.org/viewvc/llvm-project?rev=326527&view=rev Log: Always set dso_local in CodeGenModule::setDSOLocal. This shouldn't change any results for now, but is more consistent with how we set dllimport/dllexport and will m

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek added a comment. Ping? Can we land this as a temporary solution until the config generator logic is rewritten? This is currently breaking the libFuzzer build for us. Repository: rCXX libc++ https://reviews.llvm.org/D43797 ___ cfe-commits

r326529 - [analyzer] [tests] Again, make tests more resilient to changes in exploration strategy

Author: george.karpenkov Date: Thu Mar 1 17:41:19 2018 New Revision: 326529 URL: http://llvm.org/viewvc/llvm-project?rev=326529&view=rev Log: [analyzer] [tests] Again, make tests more resilient to changes in exploration strategy Modified: cfe/trunk/test/Analysis/MisusedMovedObject.cpp c

[PATCH] D43990: set dso_local on tls init functions

espindola created this revision. espindola added a reviewer: echristo. We copy the visibility, so copying the dso_local flag seems the natural thing to do. https://reviews.llvm.org/D43990 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/runtime-dllstorage.cpp Index: test/CodeGenCXX/r

r326530 - Add an option to disable tail-call optimization for escaping blocks.

Author: ahatanak Date: Thu Mar 1 17:53:15 2018 New Revision: 326530 URL: http://llvm.org/viewvc/llvm-project?rev=326530&view=rev Log: Add an option to disable tail-call optimization for escaping blocks. This makes it easier to debug crashes and hangs in block functions since users can easily fin

[PATCH] D43841: Add an option to disable tail-call optimization for escaping blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL326530: Add an option to disable tail-call optimization for escaping blocks. (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r326531 - Remove debugging code I accidentally committed in r326530.

Author: ahatanak Date: Thu Mar 1 18:03:21 2018 New Revision: 326531 URL: http://llvm.org/viewvc/llvm-project?rev=326531&view=rev Log: Remove debugging code I accidentally committed in r326530. Modified: cfe/trunk/lib/Sema/SemaPseudoObject.cpp Modified: cfe/trunk/lib/Sema/SemaPseudoObject.cp

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 136660. juliehockett marked an inline comment as done. juliehockett added a comment. Cleaning up some and updating based on changes to the parent diff. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h c

[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added a subscriber: cfe-commits. These paths aren't used and don't make sense on Fuchsia. Repository: rC Clang https://reviews.llvm.org/D43992 Files: clang/lib/Frontend/InitHeaderSearch.cpp Index: clang/

[PATCH] D43995: Do not generate calls to fentry with __attribute__((no_instrument_function))

manojgupta created this revision. manojgupta added reviewers: hfinkel, rengolin, srhines, chandlerc. Currently only calls to mcount were suppressed with no_instrument_function attribute. Linux kernel requires that calls to fentry should also not be generated. This is an extended fix for PR PR33515

[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D43992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

alexshap added a comment. i see, but just in case - what about the decrement operator ? Repository: rC Clang https://reviews.llvm.org/D43741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

r326542 - [Frontend] Avoid including default system header paths on Fuchsia

Author: phosek Date: Thu Mar 1 23:19:42 2018 New Revision: 326542 URL: http://llvm.org/viewvc/llvm-project?rev=326542&view=rev Log: [Frontend] Avoid including default system header paths on Fuchsia These paths aren't used and don't make sense on Fuchsia. Differential Revision: https://reviews.l

[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL326542: [Frontend] Avoid including default system header paths on Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

<    1   2