Hi George,
On 27 February 2018 at 02:31, George Karpenkov via cfe-commits
wrote:
> Author: george.karpenkov
> Date: Mon Feb 26 17:31:06 2018
> New Revision: 326156
>
> URL: http://llvm.org/viewvc/llvm-project?rev=326156&view=rev
> Log:
> [analyzer] Logging test typo quickfix.
>
> Modified:
>
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp:60
// Generate a report for this bug.
+ std::string Str;
+ llvm::raw_string_ostream OS(Str);
SmallString<128>?
Comment at: lib/StaticAn
Author: mstorsjo
Date: Tue Feb 27 00:35:35 2018
New Revision: 326180
URL: http://llvm.org/viewvc/llvm-project?rev=326180&view=rev
Log:
[test] Extend the Driver/mingw-msvcrt.c test with a -SAME check. NFC.
Modified:
cfe/trunk/test/Driver/mingw-msvcrt.c
Modified: cfe/trunk/test/Driver/mingw-ms
a.sidorin accepted this revision.
a.sidorin added a comment.
Looks good!
https://reviews.llvm.org/D43714
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall marked 4 inline comments as done.
sammccall added a comment.
Thanks for catching all those things!
Comment at: unittests/clangd/TUSchedulerTests.cpp:127
+ /*ASTParsedCallback=*/nullptr,
+ /*UpdateDebounce=*/std::chrono::milliseconds(5
sammccall updated this revision to Diff 136045.
sammccall marked an inline comment as done.
sammccall added a comment.
review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43648
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
cl
mstorsjo created this revision.
mstorsjo added reviewers: compnerd, smeenai, rnk.
In these combinations, link a DLL as usual, but pass -Bstatic instead of
-Bdynamic to indicate prefering static libraries.
Repository:
rC Clang
https://reviews.llvm.org/D43811
Files:
lib/Driver/ToolChains/Cr
dylanmckay updated this revision to Diff 136051.
dylanmckay added a comment.
Gentle rebase
Repository:
rC Clang
https://reviews.llvm.org/D37057
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBuiltin.cpp
lib/CodeGen/CGCUDANV.cpp
lib/CodeGen/CGDeclCXX.cpp
lib/CodeGen/CGException.cpp
oren_ben_simhon marked 3 inline comments as done.
oren_ben_simhon added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:1979-1980
+static void handleNoCfCheckAttr(Sema &S, Decl *D, const AttributeList &Attrs) {
+ if (!S.getLangOpts().CFProtectionBranch)
+S.Diag(Attrs.
oren_ben_simhon updated this revision to Diff 136053.
oren_ben_simhon added a comment.
Implemented comments posted until 02/27 (Thanks Aaron and Erich)
Repository:
rL LLVM
https://reviews.llvm.org/D41880
Files:
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/At
ioeric added a comment.
Thanks for the cleanup! This looks really nice!
Comment at:
clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h:45
+/// \brief Map mapping file name to AtomicChange targeting that file.
+typedef llvm::DenseMap
+File
hokein added a comment.
Thanks for the patch!
The check provides `MakeSmartPtrFunction` option. Users can use it to customize
their self-implemented `make_unique` function (instead of using the c++14
available `std::make_unique`) even in their C++11 code. I think we need to keep
the backward c
hokein added a comment.
The change seems good to me. I'd leave the approval to @benhamilton since he
has more context on objc.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43775
___
cfe-commits mailing list
cfe-commits@lists.llv
hokein added inline comments.
Comment at: docs/clang-tidy/checks/fuchsia-restrict-includes.rst:27
+
+ A string containing a comma-separated list of header filenames to restrict.
Default is an empty string.
The check seems do nothing with the default option.
D
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome, thank you for this cleanup!
Repository:
rC Clang
https://reviews.llvm.org/D43779
___
cfe-commits mailing list
cfe-commits@lists.llvm.
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome, thank you for this cleanup!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43780
___
cfe-commits mailing list
cfe-commi
alexfh added inline comments.
Comment at: clang-tidy/modernize/MakeSharedCheck.h:38
+
+ bool isVersionSupported(const clang::LangOptions &LangOpts) const override;
};
1. s/clang:://
2. it's not clear which "version" is this all about. I'd suggest
isLanguageSup
GBuella created this revision.
GBuella added reviewers: craig.topper, ashlykov.
Herald added a subscriber: cfe-commits.
The _get_ssp intrinsic can be used to retrieve the
shadow stack pointer, independent of the current arch -- in
contract with the rdsspd and the rdsspq intrinsics.
Also, this intr
GBuella created this revision.
GBuella added reviewers: craig.topper, ashlykov.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D43815
Files:
test/CodeGen/avx512-reduceMinMaxIntrin.c
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/avx512f-builtins
Author: ikudrin
Date: Mon Feb 26 18:51:30 2018
New Revision: 326164
URL: http://llvm.org/viewvc/llvm-project?rev=326164&view=rev
Log:
[Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on
Windows.
clang used to require adding an ".exe" suffix when targeting ELF systems on
Author: davezarzycki
Date: Mon Feb 26 10:42:30 2018
New Revision: 326110
URL: http://llvm.org/viewvc/llvm-project?rev=326110&view=rev
Log:
Fix for LLVM r326109
Modified:
cfe/trunk/lib/Basic/SourceManager.cpp
Modified: cfe/trunk/lib/Basic/SourceManager.cpp
URL:
http://llvm.org/viewvc/llvm-pr
GBuella created this revision.
GBuella added reviewers: craig.topper, zvi, ashlykov.
Herald added subscribers: cfe-commits, mgorny.
Also, a new intrinsic for the wbinvd instruction.
Repository:
rC Clang
https://reviews.llvm.org/D43817
Files:
docs/ClangCommandLineReference.rst
include/cla
lebedev.ri added a comment.
Thank you.
I did re-read the diffs, and i don't see any invalid changes here.
I'm going to try to commit this (as two revisions, need to migrate to monorepo
one day :/),
and if the bots show that i still did miss something here, i'll revert.
Repository:
rCTE Clang
devnexen created this revision.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, krytarowski.
devnexen added reviewers: dlj, krytarowski.
- Like other *BSD, conditioning certain flags to pass
- To prepare future OpenBSD sanitisers.
Repository:
rC
Author: typz
Date: Tue Feb 27 05:48:21 2018
New Revision: 326191
URL: http://llvm.org/viewvc/llvm-project?rev=326191&view=rev
Log:
clang-format: fix formatting of ObjC @synchronized blocks
Summary:
The blocks used to be formatted using the "default" behavior, and would
thus be mistaken for functi
Author: hans
Date: Tue Feb 27 05:48:47 2018
New Revision: 326194
URL: http://llvm.org/viewvc/llvm-project?rev=326194&view=rev
Log:
AttrDocs.td: fix bad bullet list
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang/Basic/AttrDocs.td
URL:
http://llvm.org/vi
Author: hans
Date: Tue Feb 27 05:48:41 2018
New Revision: 326193
URL: http://llvm.org/viewvc/llvm-project?rev=326193&view=rev
Log:
AttrDocs.td: fix bad indent and code block
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang/Basic/AttrDocs.td
URL:
http://l
Author: typz
Date: Tue Feb 27 05:48:27 2018
New Revision: 326192
URL: http://llvm.org/viewvc/llvm-project?rev=326192&view=rev
Log:
clang-format: use AfterControlStatement to format ObjC control blocks
ObjC defines `@autoreleasepool` and `@synchronized` control blocks. These
used to be formatted a
Author: hans
Date: Tue Feb 27 05:48:50 2018
New Revision: 326195
URL: http://llvm.org/viewvc/llvm-project?rev=326195&view=rev
Log:
AttrDocs.td: fix some bad code-blocks
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang/Basic/AttrDocs.td
URL:
http://llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326191: clang-format: fix formatting of ObjC @synchronized
blocks (authored by Typz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43114?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326192: clang-format: use AfterControlStatement to format
ObjC control blocks (authored by Typz, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4
Typz added a comment.
>> Tweaking the penalty handling would still be needed in any case, since the
>> problem happens also when Cpp11BracedListStyle is true (though the effect is
>> more subtle)
>
> I don't understand this. Which style do you actually care about? With
> Cpp11BracedListStyle=t
djasper added a comment.
In https://reviews.llvm.org/D43290#1020537, @Typz wrote:
> >> Tweaking the penalty handling would still be needed in any case, since the
> >> problem happens also when Cpp11BracedListStyle is true (though the effect
> >> is more subtle)
> >
> > I don't understand this.
CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: rsmith, erichkeane, andreadb.
CarlosAlbertoEnciso added a project: clang.
Declaring "_Pragma("clang optimize off")" before the body of a
function with a lambda leads to the lambda functions in the body
not being affect
krytarowski added a reviewer: vitalybuka.
krytarowski added a comment.
OpenBSD ships with an aggressive ASLR (or ASR) implementation with
fragmentation of user address space. As far as I can tell, it's not possible to
disable it. This means that you are restricted to UBSan.
Repository:
rC Cl
devnexen added a comment.
In https://reviews.llvm.org/D43818#1020577, @krytarowski wrote:
> OpenBSD ships with an aggressive ASLR (or ASR) implementation with
> fragmentation of user address space. As far as I can tell, it's not possible
> to disable it. This means that you are restricted to UB
krytarowski added a comment.
OpenBSD might also have issues with allocating lazily large memory regions for
metadata, so on amd64 with 40/48-bit address space shadow is extremely large.
Although it's best to investigate it. Just noting another potential showstopper.
Repository:
rC Clang
htt
Author: lebedevri
Date: Tue Feb 27 07:19:28 2018
New Revision: 326202
URL: http://llvm.org/viewvc/llvm-project?rev=326202&view=rev
Log:
[Tooling] [1/1] Refactor FrontendActionFactory::create() to return
std::unique_ptr<>
Summary:
I'm not sure whether there are any principal reasons why it return
Author: lebedevri
Date: Tue Feb 27 07:19:20 2018
New Revision: 326201
URL: http://llvm.org/viewvc/llvm-project?rev=326201&view=rev
Log:
[Tooling] [0/1] Refactor FrontendActionFactory::create() to return
std::unique_ptr<>
Summary:
Noticed during review of D41102.
I'm not sure whether there are a
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:52-53
+ Finder->addMatcher(
+ functionDecl(allOf(hasAnyName(SmallVector(Names.begin(),
+ Names.end())),
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326201: [Tooling] [0/1] Refactor
FrontendActionFactory::create() to return std… (authored by lebedevri,
committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D43779
Files:
docs/LibTooling.r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326202: [Tooling] [1/1] Refactor
FrontendActionFactory::create() to return std… (authored by lebedevri,
committed by ).
Herald added subscribers: llvm-commits, ilya-biryukov.
Changed prior to commit:
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326201: [Tooling] [0/1] Refactor
FrontendActionFactory::create() to return std… (authored by lebedevri,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
aaron.ballman added inline comments.
Comment at: unittests/clang-tidy/ClangTidyTest.h:159-160
+ CleannedReplacements = std::move(FormattedReplacements);
+ if (!CleannedReplacements)
+llvm_unreachable("!CleannedReplacements");
+} else {
jdeme
benhamilton accepted this revision.
benhamilton added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:52
"GIF",
"GPS",
"HD",
Might as well also add GUID.
Repository:
rC
benhamilton added a comment.
Thanks for fixing this. (Sorry for not getting to it, I was away traveling
until today.)
I'll add a tidy-up in https://reviews.llvm.org/D43598 to ensure all tests which
call `getStyle()` pass in an in-memory filesystem.
Repository:
rC Clang
https://reviews.llvm
benhamilton added a comment.
Actually, looks like all the other tests explicitly want a non-empty in-memory
FS, so there's no good cleanup I can do.
Repository:
rC Clang
https://reviews.llvm.org/D43732
___
cfe-commits mailing list
cfe-commits@li
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/RestrictIncludesCheck.cpp:37-39
+IncludeDirective(SourceLocation Loc_, CharSourceRange Range_,
+ StringRef Filename_)
+: Loc(Loc_), Range(Range_), Filename(Filename_) {}
--
Author: lebedevri
Date: Tue Feb 27 07:54:41 2018
New Revision: 326203
URL: http://llvm.org/viewvc/llvm-project?rev=326203&view=rev
Log:
Revert "[Tooling] [1/1] Refactor FrontendActionFactory::create() to return
std::unique_ptr<>"
This reverts commit rL326202
This broke gcc4.8 builds, compiler j
Author: lebedevri
Date: Tue Feb 27 07:54:55 2018
New Revision: 326204
URL: http://llvm.org/viewvc/llvm-project?rev=326204&view=rev
Log:
Revert "[Tooling] [0/1] Refactor FrontendActionFactory::create() to return
std::unique_ptr<>"
This reverts commit rL326201
This broke gcc4.8 builds, compiler j
Author: benhamilton
Date: Tue Feb 27 07:56:40 2018
New Revision: 326205
URL: http://llvm.org/viewvc/llvm-project?rev=326205&view=rev
Log:
[clang-format] Tidy up new API guessLanguage()
Summary:
This fixes a few issues djasper@ brought up in his review of D43522.
Test Plan:
make -j12 FormatTest
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326205: [clang-format] Tidy up new API guessLanguage()
(authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43598?vs=1353
bjope added a comment.
In https://reviews.llvm.org/D43732#1020639, @benhamilton wrote:
> Actually, looks like all the other tests explicitly want a non-empty
> in-memory FS, so there's no good cleanup I can do.
Well, it was only this new test case that failed, so I think other tests are
fine
lebedev.ri reopened this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
And reverted.
This broke gcc4.8 builds, compiler just segfaults:
http://lab.llvm.org:8011/builders/clang-atom-d525-fedora-rel/builds/14909
...
[72/368] Building CXX object
tools/c
Typz updated this revision to Diff 136081.
Typz added a comment.
Prevent breaking between = and { when Cpp11BracedListStyle=false.
Repository:
rC Clang
https://reviews.llvm.org/D43290
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTes
devnexen added a comment.
Also true ... on OpenBSD the number of sanitisers support list won t be
enormous ... ubsan maybe tsan ... the xray instrumentation perharps ...
Repository:
rC Clang
https://reviews.llvm.org/D43818
___
cfe-commits mailin
aaron.ballman added inline comments.
Comment at: test/Sema/attr-print.c:12
+short arr[3] __attribute__((aligned));
+
// CHECK: void foo() __attribute__((const));
Please add a test showing that `objc_bridge_related` isn't mangled by
`-ast-print`.
=
krytarowski added a comment.
TSan actually demands a lot of meta-data, similar to MSan.
Repository:
rC Clang
https://reviews.llvm.org/D43818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
jdenny added inline comments.
Comment at: test/Sema/attr-print.c:12
+short arr[3] __attribute__((aligned));
+
// CHECK: void foo() __attribute__((const));
aaron.ballman wrote:
> Please add a test showing that `objc_bridge_related` isn't mangled by
> `-ast-print
devnexen added a comment.
Alright then. I ll probably try to push the compiler-rt counterpart (for only
ubsan) within the week, it can detects integer overflow already rightfully.
Repository:
rC Clang
https://reviews.llvm.org/D43818
___
cfe-comm
aaron.ballman added a reviewer: rsmith.
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some minor testing nits, I think this LGTM. However, you should wait
to see if Richard has comments as well before committing.
aaron.ballman added inline comments.
Comment at: test/Sema/attr-print.c:12
+short arr[3] __attribute__((aligned));
+
// CHECK: void foo() __attribute__((const));
jdenny wrote:
> aaron.ballman wrote:
> > Please add a test showing that `objc_bridge_related` isn't
krytarowski added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:545
CmdArgs.push_back("-lpthread");
-CmdArgs.push_back("-lrt");
+if (TC.getTriple().getOS() != llvm::Triple::OpenBSD)
+ CmdArgs.push_back("-lrt");
It's a matter
devnexen added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:545
CmdArgs.push_back("-lpthread");
-CmdArgs.push_back("-lrt");
+if (TC.getTriple().getOS() != llvm::Triple::OpenBSD)
+ CmdArgs.push_back("-lrt");
krytarowski wrote
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
Currently, we pick the first declaration of a symbol in a TU, which is
considered
canonical in the clangIndex, as the canonical declaration in clangd. Thi
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
See the inline comments. Please run clang-format over this patch after
addressing them (there are a few indentation issues).
Comment at: include/clang/Fronte
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2183
return 0;
+if (Left.Previous && Left.Previous->is(tok::equal) &&
+!Style.Cpp11BracedListStyle)
Why is this necessary?
Comment at: unittests/Format/
sepavloff updated this revision to Diff 136087.
sepavloff added a comment.
Updated patch
- command line option was renamed to `-fir-type-names=`,
- this option is not hidden, as most options in `-f` namespace,
- new value, `auto` was added to possible values of this option.
Repository:
rC Cla
sepavloff marked an inline comment as done.
sepavloff added inline comments.
Comment at: include/clang/Driver/Options.td:1735
+ HelpText<"Whether to use IR type names (option: none, use)">,
+ Values<"none,use">;
def relocatable_pch : Flag<["-", "--"], "relocatable-pch">, Flags
sdardis added a comment.
Ping.
Repository:
rCXX libc++
https://reviews.llvm.org/D43509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krytarowski added a comment.
This looks like broke ASan on NetBSD:
$ sh
./projects/compiler-rt/test/sanitizer_common/asan-i386-NetBSD/NetBSD/Output/ttyent.cc.script
/usr/lib/i386/libgcc.a(unwind-dw2.o): In function `_Unwind_RaiseException':
unwind-dw2.c:(.text+0x1b41): multiple definition
Author: sammccall
Date: Tue Feb 27 09:15:50 2018
New Revision: 326211
URL: http://llvm.org/viewvc/llvm-project?rev=326211&view=rev
Log:
[clangd] Remove codecomplete override content API. Long live addDocument!
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/tru
arsenm added a comment.
I meant we could just change the value to whatever it happens to be for AMDGPU.
That this is the language address space is surprising to me though, so maybe
that should change
https://reviews.llvm.org/D43281
___
cfe-commits
Typz added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2183
return 0;
+if (Left.Previous && Left.Previous->is(tok::equal) &&
+!Style.Cpp11BracedListStyle)
djasper wrote:
> Why is this necessary?
Otherwise the `PenaltyBreakBeforeF
Author: abataev
Date: Tue Feb 27 09:42:00 2018
New Revision: 326212
URL: http://llvm.org/viewvc/llvm-project?rev=326212&view=rev
Log:
[OPENMP] Allow multiple mappings for member expressions for pointers.
If several member expressions are mapped and they reference the same
address as a base, but a
ftingaud updated this revision to Diff 136093.
ftingaud added a comment.
Update with tests and cleaning as indicated by reviewers.
https://reviews.llvm.org/D43766
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
clang-tidy/modernize/MakeUniqueChec
ftingaud updated this revision to Diff 136094.
ftingaud added a comment.
Remove two useless namespaces
https://reviews.llvm.org/D43766
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
clang-tidy/modernize/MakeUniqueCheck.cpp
clang-tidy/modernize
lebedev.ri added a comment.
Tried fixing `tooling::FrontendActionFactory::create()` in
https://reviews.llvm.org/D43779/https://reviews.llvm.org/D43780, but had to
revert due to gcc4.8 issues :/
Thank you for working on this, some more review notes.
In https://reviews.llvm.org/D41102#1020107, @
craig.topper added inline comments.
Comment at: docs/ClangCommandLineReference.rst:2359
+.. option:: -mwbnoinvd, -mno-wbnoinvd
+
Did you manually add these? This file is normally generated by a tool and
should be in alphabetical order.
Comme
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/FileIndex.cpp:23
SymbolCollector::Options CollectorOpts;
// Although we do not index symbols in main files (e.g. cpp file),
informat
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
This means, link the CRT and other default libraries statically, but give me a
DLL, right? Just confirming.
Repository:
rC Clang
https://reviews.llvm.org/D43811
__
juliehockett updated this revision to Diff 136096.
juliehockett marked 16 inline comments as done.
juliehockett added a comment.
Fixing comments and updating tests.
https://reviews.llvm.org/D43778
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy
Thanks, this is the correct fix, and the pattern used in all the rest of
the clang-cl driver tests.
On Mon, Feb 26, 2018 at 10:06 PM Shoaib Meenai wrote:
> r326171 works locally. I'll keep an eye on the bots.
>
>
>
> *From: * on behalf of Adam Nemet
> *Date: *Monday, February 26, 2018 at 9:51
Author: kamil
Date: Tue Feb 27 10:16:47 2018
New Revision: 326219
URL: http://llvm.org/viewvc/llvm-project?rev=326219&view=rev
Log:
Handle the NetBSD case in ToolChain::getOSLibName()
Return a new CompilerRT Path on NetBSD: "netbsd", instead of
getOS(), which returns a string like "netbsd8.9.12".
bsdjhb updated this revision to Diff 136098.
bsdjhb added a comment.
- Match names used in libcxx and add LINKER_FLAGS.
Repository:
rUNW libunwind
https://reviews.llvm.org/D43585
Files:
CMakeLists.txt
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
sbc100 added a comment.
Don't we already have `-fexceptions` and `-fno-exceptions` for this?
Repository:
rC Clang
https://reviews.llvm.org/D43681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Wizard updated this revision to Diff 136100.
Wizard added a comment.
resolve comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43775
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
Index: clang-tidy/objc/PropertyDeclarationCheck.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE326222: add UUID to the acronyms list of objc property
name checks (authored by Wizard, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43775?vs=136100&id=136102#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326222: add UUID to the acronyms list of objc property name
checks (authored by Wizard, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43775
Fil
benhamilton added a comment.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jhb
Date: Tue Feb 27 10:40:04 2018
New Revision: 326223
URL: http://llvm.org/viewvc/llvm-project?rev=326223&view=rev
Log:
[libunwind] Permit additional compiler and linker flags to be passed to tests.
Summary:
This is done via new LIBUNWIND_TEST_COMPILER_FLAGS and
LIBUNWIND_TEST_LINKER_FL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326223: [libunwind] Permit additional compiler and linker
flags to be passed to tests. (authored by jhb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:64
+bool MakeSmartPtrCheck::isLanguageVersionSupported(const LangOptions &
LangOpts) const
+{
The formatting here is wrong.
https://reviews.llvm.org/D43766
___
NutshellySima created this revision.
NutshellySima added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
Before, clang does not warn -Wlogical-op-parentheses and
-Wbitwise-op-parentheses in macros, thus miss some cases like PR 18971 and
mismatch gcc's behavior.
Fix this by enabling
lebedev.ri added a comment.
Tests?
Repository:
rC Clang
https://reviews.llvm.org/D43829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: krasimir
Date: Tue Feb 27 11:07:47 2018
New Revision: 326227
URL: http://llvm.org/viewvc/llvm-project?rev=326227&view=rev
Log:
[clang-format] Format operator key in protos
Summary: This fixes a glitch where ``operator: value`` in a text proto would
mess up the underlying formatting since
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326227: [clang-format] Format operator key in protos
(authored by krasimir, committed by ).
Herald added a subscriber: llv
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
This fixes a glitch where ``operator: value`` in a text proto would mess up the
underlying formatting since it gets parsed as a kw_operator instead of an
identifier.
Repository:
rC Clang
https://reviews.llvm.org/
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC326227: [clang-format] Format operator key in protos
(authored by krasimir, committed by ).
Changed prior to commit:
ht
NoQ updated this revision to Diff 136114.
NoQ added a comment.
Add one more comment.
https://reviews.llvm.org/D43791
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/NewDelete-atomics.cpp
Index: test/Analysis/NewDelete-atomics.cpp
=
1 - 100 of 187 matches
Mail list logo
