[PATCH] D43477: [CFG] [analyzer] Add MaterializeTemporaryExpr into the construction context.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326014: [CFG] Provide construction contexts for lifetime-extended temporaries. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D43477: [CFG] [analyzer] Add MaterializeTemporaryExpr into the construction context.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326014: [CFG] Provide construction contexts for lifetime-extended temporaries. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43477 Files: include/clang/Analy

r326015 - [CFG] Provide construction contexts for functional cast-like constructors.

2018-02-23 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Feb 23 18:05:11 2018 New Revision: 326015 URL: http://llvm.org/viewvc/llvm-project?rev=326015&view=rev Log: [CFG] Provide construction contexts for functional cast-like constructors. When a constructor of a temporary with a single argument is treated as a functional ca

[PATCH] D43480: [CFG] [analyzer] Add construction context when the constructor is treated like a functional cast.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326015: [CFG] Provide construction contexts for functional cast-like constructors. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D43481: [CFG] [analyzer] Add construction context when the constructor is being no-op-casted to a const value type.

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326016: [CFG] Provide construction contexts for temporaries bound to const references. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43481 Files: lib/Analysi

r326016 - [CFG] Provide construction contexts for temporaries bound to const references.

2018-02-23 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Feb 23 18:07:50 2018 New Revision: 326016 URL: http://llvm.org/viewvc/llvm-project?rev=326016&view=rev Log: [CFG] Provide construction contexts for temporaries bound to const references. In order to bind a temporary to a const lvalue reference, a no-op cast is added to

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

2018-02-23 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. Being a cross-compiler I think it's generally a good thing to have more combinations be less broken. Note that PS4's compiler is hosted on Windows and uses the gcc-style driver; it's convenient sometimes to be able to target Windows without having to learn a new drive

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

2018-02-23 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. We were affected by this too. Thanks for fixing! (We're actually using CodeView + DWARF, since we have a bunch of tooling built around DWARF. We use the gcc-style driver for legacy reasons.) https://reviews.llvm.org/D43700 ___

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2018-02-23 Thread Erik Nyquist via Phabricator via cfe-commits
enyquist added a comment. @dtzWill thanks for the suggestion, I have submitted this change to the weekly review corner. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

r326019 - [CFG] Provide construction contexts for temporaries in conditional operators.

2018-02-23 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Feb 23 19:10:15 2018 New Revision: 326019 URL: http://llvm.org/viewvc/llvm-project?rev=326019&view=rev Log: [CFG] Provide construction contexts for temporaries in conditional operators. When a lifetime-extended temporary is on a branch of a conditional operator, materi

[PATCH] D43483: [CFG] [analyzer] Add construction context when the constructor is on a branch of a ternary operator

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL326019: [CFG] Provide construction contexts for temporaries in conditional operators. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D43483: [CFG] [analyzer] Add construction context when the constructor is on a branch of a ternary operator

2018-02-23 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC326019: [CFG] Provide construction contexts for temporaries in conditional operators. (authored by dergachev, committed by ). Repository: rC Clang https://reviews.llvm.org/D43483 Files: lib/Analysis

r326021 - [CFG] Keep speculatively working around an MSVC compiler crash.

2018-02-23 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Fri Feb 23 19:54:22 2018 New Revision: 326021 URL: http://llvm.org/viewvc/llvm-project?rev=326021&view=rev Log: [CFG] Keep speculatively working around an MSVC compiler crash. Replace if() with a switch(). Because random changes in the code seem to suppress the crash. Sto

[PATCH] D43714: [analyzer] Don't do anything when trivial-copying an empty class object.

2018-02-23 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added a subscriber: rnkovacs. When modeling implicit copy/move-constructor or copy/move-assignment operator of an empty class, don't do anything. The previous behavior was to take the

r326022 - [X86] Remove __builtin_ia32_permvarsf256_mask and __builtin_ia32_permvarsi256_mask and use the avx2 unmasked versions and a select instead.

2018-02-23 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri Feb 23 22:46:42 2018 New Revision: 326022 URL: http://llvm.org/viewvc/llvm-project?rev=326022&view=rev Log: [X86] Remove __builtin_ia32_permvarsf256_mask and __builtin_ia32_permvarsi256_mask and use the avx2 unmasked versions and a select instead. Modified: cfe/tru

r326023 - Make module use diagnostics refer to the top-level module

2018-02-23 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Fri Feb 23 22:54:09 2018 New Revision: 326023 URL: http://llvm.org/viewvc/llvm-project?rev=326023&view=rev Log: Make module use diagnostics refer to the top-level module All use declarations need to be directly placed in the top-level module anyway, knowing the submodule doe

[PATCH] D43673: Make module use diagnostics refer to the top-level module

2018-02-23 Thread Daniel Jasper via Phabricator via cfe-commits
djasper closed this revision. djasper added a comment. Submitted as r326023. https://reviews.llvm.org/D43673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r326024 - Remove unused variable. We should be warning-free.

2018-02-23 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Fri Feb 23 22:57:47 2018 New Revision: 326024 URL: http://llvm.org/viewvc/llvm-project?rev=326024&view=rev Log: Remove unused variable. We should be warning-free. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Modified: cfe/trunk/lib/StaticAnalyzer/

[PATCH] D43430: Omit nullptr check for sufficiently simple delete-expressions

2018-02-23 Thread Andrew Hunter via Phabricator via cfe-commits
ahh added a comment. > If the pointer is not null, the runtime overhead of the null check is pretty > negligible next to the cost of actually doing the allocation. If the pointer > is null, the runtime overhead of making at least one unnecessary call — > probably two, if 'operator delete' doesn

<    1   2