pcc added inline comments.
Comment at: include/math.h:1499
+// has previously been included.
+#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES)
+#include_next
Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part.
https://reviews.llvm.
eastig added a comment.
Just validated that it has fixed the issue.
Thank you, Peter.
Repository:
rCXX libc++
https://reviews.llvm.org/D42503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
jdemeule added a comment.
In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
>
> > Is there a way to make clang-apply-replacements smarter rather than forcing
> > every check to jump through hoops? I'm worried t
Author: danalbert
Date: Wed Feb 21 14:36:51 2018
New Revision: 325733
URL: http://llvm.org/viewvc/llvm-project?rev=325733&view=rev
Log:
[Driver] Generate .eh_frame_hdr for static executables too.
Summary: libgcc won't unwind without an .eh_frame_hdr section.
Reviewers: srhines, chandlerc
Review
This revision was automatically updated to reflect the committed changes.
Closed by commit rC325733: [Driver] Generate .eh_frame_hdr for static
executables too. (authored by danalbert, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43203?vs=133907&id=135336#toc
Repository:
aaron.ballman added a comment.
In https://reviews.llvm.org/D43500#1015208, @jdemeule wrote:
> In https://reviews.llvm.org/D43500#1013558, @malcolm.parsons wrote:
>
> > In https://reviews.llvm.org/D43500#1013497, @aaron.ballman wrote:
> >
> > > Is there a way to make clang-apply-replacements smart
djasper added inline comments.
Comment at: cfe/trunk/lib/Format/Format.cpp:2308
+ Guesser.process();
+ if (Guesser.isObjC()) {
+result = FormatStyle::LK_ObjC;
benhamilton wrote:
> djasper wrote:
> > In LLVM, we generally don't add braces for sin
vitalybuka added inline comments.
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6056
SmallPtrSetImpl *LoopHeaders) {
+ const Function *Fn = BB->getParent();
+ if (Fn && Fn->getMetadata("no_simplify_cfg"))
So maybe Attribute::Sani
mclow.lists added inline comments.
Comment at: include/math.h:1499
+// has previously been included.
+#if defined(_LIBCPP_MSVCRT) && defined(_USE_MATH_DEFINES)
+#include_next
pcc wrote:
> Nit: you don't actually need the ` && defined(_USE_MATH_DEFINES)` part.
I
benhamilton added inline comments.
Comment at: cfe/trunk/lib/Format/Format.cpp:2308
+ Guesser.process();
+ if (Guesser.isObjC()) {
+result = FormatStyle::LK_ObjC;
djasper wrote:
> benhamilton wrote:
> > djasper wrote:
> > > In LLVM, we generally
benhamilton added a comment.
Follow-ups (aside from the case, which I already fixed) in
https://reviews.llvm.org/D43598.
Repository:
rL LLVM
https://reviews.llvm.org/D43522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
benhamilton created this revision.
benhamilton added a reviewer: djasper.
Herald added subscribers: cfe-commits, klimek.
This fixes a few issues djasper@ brought up in his review of
https://reviews.llvm.org/D43522.
Test Plan:
make -j12 FormatTests && ./tools/clang/unittests/Format/FormatTests
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Thank you for doing these follow up changes!
Repository:
rC Clang
https://reviews.llvm.org/D43598
___
cfe-commits mailing list
cfe-commits@l
juliehockett added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
jakehehrlich wrote:
> lebedev.ri wrote:
> > julieho
juliehockett updated this revision to Diff 135342.
juliehockett marked 6 inline comments as done.
juliehockett added a comment.
Updating location creation and adding mapping from type to BlockId
https://reviews.llvm.org/D41102
Files:
CMakeLists.txt
clang-doc/BitcodeWriter.cpp
clang-doc/Bi
jakehehrlich added inline comments.
Comment at: clang-doc/BitcodeWriter.cpp:407
+
+void ClangDocBinaryWriter::writeBitstream(const EnumInfo &I,
+ BitstreamWriter &Stream,
juliehockett wrote:
> jakehehrlich wrote:
> > lebed
Hi Hans,
If there's still time for rc3, I'd like to get this crash fix in. This
adds a null check to prevent a crash on invalid.
Richard
On Mon, Feb 5, 2018 at 6:58 PM, Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Mon Feb 5 18:58:21 2018
> New Re
tra created this revision.
tra added a reviewer: jlebar.
Herald added a subscriber: sanjoy.
Initial commit missed sincos(float), llabs() and few atomics that we
used to pull in from device_functions.hpp, which we no longer include.
https://reviews.llvm.org/D43602
Files:
clang/lib/Headers/__cl
tra updated this revision to Diff 135348.
tra added a comment.
Added missing __threadfence_system().
https://reviews.llvm.org/D43602
Files:
clang/lib/Headers/__clang_cuda_device_functions.h
Index: clang/lib/Headers/__clang_cuda_device_functions.h
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
For my information, how are we verifying that we've caught everything?
https://reviews.llvm.org/D43602
___
cfe-commits mailing list
cfe-commits@l
tra added a comment.
In https://reviews.llvm.org/D43602#1015370, @jlebar wrote:
> For my information, how are we verifying that we've caught everything?
for v in 8.0 9.0 9.1 ; do
/usr/local/cuda-$v/bin/nvcc -c -x cu /dev/null -o /tmp/null.o -arch=sm_60
-keep-dir=nvcc-$v -keep -v
rnk added a comment.
Can you update the description to clarify that this is fixing a bug in the
indexing library? From the description it sounds like we have a serious bug in
FUNCDNAME codegen, which is not the case. CodeGen does the right thing. The
ASTContext API is just crappy, so the Index
STL_MSFT updated this revision to Diff 135352.
STL_MSFT added a comment.
Update based on code review feedback.
https://reviews.llvm.org/D43273
Files:
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp
test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan_init_op.pass
vsapsai added a comment.
Thanks for response, Richard. I'll look into using `CXXDefaultInitExpr`.
As for
In https://reviews.llvm.org/D42498#1007028, @rsmith wrote:
> […] your approach will still go wrong if the `This` pointer is used in other
> ways, such as an explicit mention of `this` or a
phosek created this revision.
phosek added reviewers: kcc, vitalybuka.
Herald added a subscriber: cfe-commits.
This allows reporting an error when user tries to use SafeStack with
incompatible sanitizers.
Repository:
rC Clang
https://reviews.llvm.org/D43606
Files:
clang/lib/Driver/Sanitize
Author: marshall
Date: Wed Feb 21 21:14:20 2018
New Revision: 325740
URL: http://llvm.org/viewvc/llvm-project?rev=325740&view=rev
Log:
Add another test case to the deduction guide for basic_string.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/iter_alloc_deduction.pass.cpp
Author: rtrieu
Date: Wed Feb 21 21:32:25 2018
New Revision: 325741
URL: http://llvm.org/viewvc/llvm-project?rev=325741&view=rev
Log:
[ODRHash] Handle some template weirdness.
Build the index off of DeclarationName instead of Decl pointers. When finding
an UnresolvedLookupExprClass, hash it as if
Author: rtrieu
Date: Wed Feb 21 21:50:29 2018
New Revision: 325742
URL: http://llvm.org/viewvc/llvm-project?rev=325742&view=rev
Log:
[ODRHash] Fix hashing for friend functions.
When hashing a templated function, use the hash of the function it was
instantiated from.
Added:
cfe/trunk/test/Mod
Author: kamil
Date: Wed Feb 21 22:31:40 2018
New Revision: 325746
URL: http://llvm.org/viewvc/llvm-project?rev=325746&view=rev
Log:
FreeBSD driver / Xray flags moving pthread to compile flags.
Summary:
- Using -lpthread instead, with -pthread the linkage does not work.
-Warning about the -fxray-i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325746: FreeBSD driver / Xray flags moving pthread to
compile flags. (authored by kamil, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43378
Author: kamil
Date: Wed Feb 21 22:48:34 2018
New Revision: 325748
URL: http://llvm.org/viewvc/llvm-project?rev=325748&view=rev
Log:
Revert part of r. 325746 D43378
test/Driver/XRay/xray-shared-noxray.cpp fails on !Linux hosts.
Modified:
cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp
Modi
krytarowski added inline comments.
Comment at: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp:11
//
-// REQUIRES: linux, enable_shared
+// REQUIRES: enable_shared
int foo() { return 42; }
```
FAIL: Clang :: Driver/XRay/xray-shared-noxray.cpp (6820 of 38122)
Author: kamil
Date: Wed Feb 21 23:00:29 2018
New Revision: 325749
URL: http://llvm.org/viewvc/llvm-project?rev=325749&view=rev
Log:
Revert part of D43378 in this file
It causes failure on clang-x86_64-debian-fast.
Modified:
cfe/trunk/test/Driver/XRay/xray-instrument-os.c
Modified: cfe/trunk
krytarowski added inline comments.
Comment at: cfe/trunk/test/Driver/XRay/xray-instrument-os.c:2
// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
-// XFAIL: -linux-
// REQUIRES-ANY: amd64, x86_64, x86_64h, arm, aarch64, arm64
```
Author: inouehrs
Date: Wed Feb 21 23:49:13 2018
New Revision: 325753
URL: http://llvm.org/viewvc/llvm-project?rev=325753&view=rev
Log:
[NFC] fix trivial typos in comments
"a a"->"a"
Modified:
cfe/trunk/include/clang/Sema/ScopeInfo.h
cfe/trunk/test/SemaCXX/ms-uuid.cpp
Modified: cfe/trunk
101 - 135 of 135 matches
Mail list logo
