[PATCH] D42922: [CUDA] Register relocatable GPU binaries

2018-02-16 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld marked an inline comment as done. Hahnfeld added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:330-331 // the GPU side. for (const std::string &GpuBinaryFileName : CGM.getCodeGenOpts().CudaGpuBinaryFileNames) { llvm::ErrorOr> GpuBinaryOrErr = -

r325369 - [OPENMP] Fix parsing of the directives with inner directives.

2018-02-16 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Feb 16 10:36:44 2018 New Revision: 325369 URL: http://llvm.org/viewvc/llvm-project?rev=325369&view=rev Log: [OPENMP] Fix parsing of the directives with inner directives. The parsing may lead to compiler hanging because of the incorrect processing of inner OpenMP pragmas.

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

2018-02-16 Thread Ed Maste via Phabricator via cfe-commits
emaste added a comment. LGTM with one small note. What will it take for us to enable this on the rest of the platforms Clang/FreeBSD supports? Comment at: test/Driver/XRay/lit.local.cfg:7-8 supported_targets = [ 'x86_64', 'x86_64h', 'arm', 'aarch64', 'arm64', 'powerpc64

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

2018-02-16 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 134657. vitalybuka marked 6 inline comments as done. vitalybuka added a comment. addressed comments https://reviews.llvm.org/D42995 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/Inputs/thinlto-distributed-backend-skip.bc clang/test/Co

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

2018-02-16 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. @pcc Could you please take a look? https://reviews.llvm.org/D42680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

2018-02-16 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 134659. https://reviews.llvm.org/D43378 Files: lib/Driver/ToolChains/FreeBSD.cpp lib/Driver/XRayArgs.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xray-instrument-os.c test/Driver/XRay/xray-shared-noxray.cpp Index: lib/Driver/XRayArgs.cpp ==

r325373 - [OPENMP] Fix PR35873: Fix data-sharing attributes for const variables.

2018-02-16 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Feb 16 11:16:54 2018 New Revision: 325373 URL: http://llvm.org/viewvc/llvm-project?rev=325373&view=rev Log: [OPENMP] Fix PR35873: Fix data-sharing attributes for const variables. Compiler erroneously returned wrong data-sharing attributes for the constant variables if th

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

2018-02-16 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `fuchsia-add-visibility + `_ check Please move into new checks section. Comment at

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

2018-02-16 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[clang-tools-extra] r325374 - [Documentation] Fix Sphinx error. Limit text width to 80 characters.

2018-02-16 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Fri Feb 16 11:31:28 2018 New Revision: 325374 URL: http://llvm.org/viewvc/llvm-project?rev=325374&view=rev Log: [Documentation] Fix Sphinx error. Limit text width to 80 characters. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-simd-intrinsic

r325375 - [MS] Make constexpr static data members implicitly inline

2018-02-16 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Feb 16 11:44:47 2018 New Revision: 325375 URL: http://llvm.org/viewvc/llvm-project?rev=325375&view=rev Log: [MS] Make constexpr static data members implicitly inline This handles them exactly the same way that we handle const integral static data members with inline definiti

[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

2018-02-16 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D43378#1010464, @emaste wrote: > LGTM with one small note. > > What will it take for us to enable this on the rest of the platforms > Clang/FreeBSD supports? As I see only x86_64 arch implements everything (e.g. custom event), making thing

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

2018-02-16 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added a comment. I'd like a test for #pragma GCC visibility push(hidden) which should cause each symbol to be treated as though it were explicitly hidden. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:32 + if (Name.empty()) return; + Finder->addMatcher(f

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

2018-02-16 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added a comment. > I'd like a test for #pragma GCC visibility push(hidden) which should cause > each symbol to be treated as though it were explicitly hidden. To clarify, this check should still give a warning if the specified variable doesn't actually have that in source code. e.g

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

2018-02-16 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 134684. juliehockett marked 7 inline comments as done. juliehockett edited the summary of this revision. juliehockett added a comment. 1. Added visibility parameter 2. Updated Name parameter to be a list of names, as opposed to a single name 3. Fixed comm

[clang-tools-extra] r325381 - [clang-include-fixer] Use add_clang_tool instead add_clang_executable

2018-02-16 Thread Petr Hosek via cfe-commits
Author: phosek Date: Fri Feb 16 12:25:45 2018 New Revision: 325381 URL: http://llvm.org/viewvc/llvm-project?rev=325381&view=rev Log: [clang-include-fixer] Use add_clang_tool instead add_clang_executable This makes it possible to include clang-include-fixer as distribution component when building

[PATCH] D43404: [Fuchsia] Include libClang and clang-include-fixer in the toolchain

2018-02-16 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. libClang is used by other Clang based tools such as cquery while clang-include-fixer is generally a useful tool. Repository: rC Clang https://reviews.llvm.org/D43404 F

[PATCH] D43371: [clang-include-fixer] Use add_clang_tool instead of add_clang_executable

2018-02-16 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325381: [clang-include-fixer] Use add_clang_tool instead add_clang_executable (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D43371?vs=134559&id=134691#toc Rep

[PATCH] D35894: [clangd] Code hover for Clangd

2018-02-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle updated this revision to Diff 134692. malaperle added a comment. Rebase. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/Protocol.cpp clang

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

2018-02-16 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/thinlto_backend.ll:27 +; RUN: %clang -target x86_64-unknown-linux-gnu -O2 -o %t4.o -x ir %t5.o -c -fthinlto-index=%t.thinlto.bc +; RUN: llvm-nm

Re: r325321 - [Sema] Take into account the current context when checking the

2018-02-16 Thread Akira Hatanaka via cfe-commits
Thanks for taking care of it. It looks like I had to traverse the chain of Scopes upwards until Scope::getEntity() returns something that is not null. This is a reduced test case. clang doesn’t crash if I remove “if (true)”. $ cat test1.cpp struct CmapSubtable {}; struct A { protected: typ

[PATCH] D35894: [clangd] Code hover for Clangd

2018-02-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle updated this revision to Diff 134708. malaperle added a comment. Add a missing std::move, fix some formatting. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D35894 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/Clangd

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

2018-02-16 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:36-39 + StringRef(Options.get("Names", "")).split(NamesRefs, ","); + for (const auto &Name : NamesRefs) { +if (!Name.empty()) Names.push_back(Name); + } Rather than

r325391 - [OPENMP] Do not emit messages for templates in declare target

2018-02-16 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Fri Feb 16 13:23:23 2018 New Revision: 325391 URL: http://llvm.org/viewvc/llvm-project?rev=325391&view=rev Log: [OPENMP] Do not emit messages for templates in declare target constructs. The compiler may emit some extra warnings for functions, that are implicit specialization

[clang-tools-extra] r325395 - [clangd] Implement textDocument/hover

2018-02-16 Thread Marc-Andre Laperle via cfe-commits
Author: malaperle Date: Fri Feb 16 13:38:15 2018 New Revision: 325395 URL: http://llvm.org/viewvc/llvm-project?rev=325395&view=rev Log: [clangd] Implement textDocument/hover Summary: Implemention of textDocument/hover as described in LSP definition. This patch adds a basic Hover implementation.

[PATCH] D35894: [clangd] Code hover for Clangd

2018-02-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle accepted this revision. malaperle added a comment. This revision is now accepted and ready to land. Works well and code looks good. There were only minor tweaks since the last approval. I'll land this since there are some issues with Simon's svn account. Repository: rCTE Clang Tools

[PATCH] D35894: [clangd] Code hover for Clangd

2018-02-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE325395: [clangd] Implement textDocument/hover (authored by malaperle, committed by ). Changed prior to commit: https://reviews.llvm.org/D35894?vs=134708&id=134712#toc Repository: rCTE Clang Tools E

[PATCH] D35894: [clangd] Code hover for Clangd

2018-02-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325395: [clangd] Implement textDocument/hover (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D35894 Files: clang-tools-

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

2018-02-16 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:68 + diag(MatchedDecl->getLocStart(), + "visibility attribute not set for specified function") + << MatchedDecl aaron.ballman wrote: > How about: "fu

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

2018-02-16 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:295 setFeatureEnabledImpl(Features, "xsave", true); setFeatureEnabledImpl(Features, "movbe", true); break; KNM and KNL should both have sahf Comment at: li

[PATCH] D43411: [clangd] Rename some protocol field to lower case

2018-02-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, klimek. Also fixes a GCC compilation error. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43411 Files: clangd/Protocol.cpp cla

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

2018-02-16 Thread Dimitry Andric via Phabricator via cfe-commits
dim added inline comments. Comment at: lib/Basic/Targets/X86.cpp:1049 + if (HasLAHFSAHF) +Builder.defineMacro("__LAHFSAHF__"); craig.topper wrote: > Does gcc define this? It's such a low level instruction I have a hard time > believing this define would b

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

2018-02-16 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: lib/Basic/Targets/X86.cpp:1049 + if (HasLAHFSAHF) +Builder.defineMacro("__LAHFSAHF__"); dim wrote: > craig.topper wrote: > > Does gcc define this? It's such a low level instruction I have a hard time > > bel

[clang-tools-extra] r325409 - [clangd] Rename some protocol field to lower case

2018-02-16 Thread Marc-Andre Laperle via cfe-commits
Author: malaperle Date: Fri Feb 16 15:12:26 2018 New Revision: 325409 URL: http://llvm.org/viewvc/llvm-project?rev=325409&view=rev Log: [clangd] Rename some protocol field to lower case Summary: Also fixes a GCC compilation error. Signed-off-by: Marc-Andre Laperle Subscribers: klimek, ilya-bir

[PATCH] D43411: [clangd] Rename some protocol field to lower case

2018-02-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325409: [clangd] Rename some protocol field to lower case (authored by malaperle, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43411 Files:

Re: [PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

2018-02-16 Thread Dimitry Andric via cfe-commits
On 17 Feb 2018, at 00:12, Craig Topper via Phabricator wrote: > > craig.topper added inline comments. > > > > Comment at: lib/Basic/Targets/X86.cpp:1049 > > + if (HasLAHFSAHF) > +Builder.defineMacro("__LAHFSAHF__"); > > dim wrote: >> craig.topper wrote:

[PATCH] D43394: [X86] Add 'sahf' CPU feature, and emit __LAHFSAHF__ for it

2018-02-16 Thread Dimitry Andric via Phabricator via cfe-commits
dim updated this revision to Diff 134746. dim added a comment. Added the `sahf` feature for knm, knl and amdfam10 too. Repository: rC Clang https://reviews.llvm.org/D43394 Files: include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h test/CodeGen/attr-targe

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

2018-02-16 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang updated this revision to Diff 134745. mgrang edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D43105 Files: include/clang/Basic/TargetInfo.h include/clang/Basic/TargetOptions.h include/clang/Driver/Options.td lib/Basic/Targets/Mips.h lib/Drive

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

2018-02-16 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 134752. vitalybuka marked an inline comment as done. vitalybuka added a comment. use count 0 https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp cl

r325410 - [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

2018-02-16 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Feb 16 15:34:16 2018 New Revision: 325410 URL: http://llvm.org/viewvc/llvm-project?rev=325410&view=rev Log: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set Summary: ThinLTO compilation may decide not to split module and keep at as regu

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

2018-02-16 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325410: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42680?vs=134752&id=13

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

2018-02-16 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL325410: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set (authored by vitalybuka, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

r325411 - [ThinLTO] Allow indexing to request backend to ignore the module

2018-02-16 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Fri Feb 16 15:38:22 2018 New Revision: 325411 URL: http://llvm.org/viewvc/llvm-project?rev=325411&view=rev Log: [ThinLTO] Allow indexing to request backend to ignore the module Summary: Gold plugin does not add pass to ThinLTO modules without useful symbols. In this case

[PATCH] D42995: [ThinLTO] Allow indexing to request backend to ignore the module

2018-02-16 Thread Vitaly Buka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325411: [ThinLTO] Allow indexing to request backend to ignore the module (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42995?vs=134657&id=134755#toc Reposi

r325412 - [Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

2018-02-16 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Fri Feb 16 15:40:07 2018 New Revision: 325412 URL: http://llvm.org/viewvc/llvm-project?rev=325412&view=rev Log: [Basic] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Basic/Diagnostic.h

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

2018-02-16 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse created this revision. morehouse added a reviewer: kcc. Herald added a subscriber: hiraditya. When building with libFuzzer, simplifyCFG reduces the coverage signal available to libFuzzer when trying to find new inputs. This patch provides a way to disable simplifyCFG when building with

[PATCH] D42676: Add support for LLVM_REPOSITORY_STRING.

2018-02-16 Thread Stephen Hines via Phabricator via cfe-commits
srhines abandoned this revision. srhines added a comment. I'm going to solve this a different way. Repository: rC Clang https://reviews.llvm.org/D42676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

2018-02-16 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Agreed. Repository: rC Clang https://reviews.llvm.org/D43203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D43424: [clang-doc] Implement a (simple) Markdown generator

2018-02-16 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: klimek, jakehehrlich, sammccall. juliehockett added a project: clang-tools-extra. Herald added subscribers: mgrang, mgorny. juliehockett added a dependency: D43341: [clang-doc] Implement reducer portion of the frontend framework. I

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

2018-02-16 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:109 static cl::opt MergeCondStores( "simplifycfg-merge-cond-stores", cl::Hidden, cl::init(true), why metadata instead of cl:opt like these? https://reviews.llvm.org/

[PATCH] D40284: [Sema] Improve diagnostics for template arg deduction

2018-02-16 Thread Jacob Bandes-Storch via Phabricator via cfe-commits
jtbandes added a comment. Please take another look when you get a chance :) Repository: rC Clang https://reviews.llvm.org/D40284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43105: [RISCV] Enable __int128_t and uint128_t through clang flag

2018-02-16 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: include/clang/Driver/Options.td:843 +def fforce_enable_int128 : Flag<["-"], "fforce-enable-int128">, Group, + Flags<[CC1Option]>, HelpText<"Enable support for int128_t type">; We should have an inverse flag -fno-forc

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

2018-02-16 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone updated this revision to Diff 134779. Quuxplusone added a comment. Add fixits. Repository: rC Clang https://reviews.llvm.org/D43322 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaExprCXX.cpp

[PATCH] D43423: [SimplifyCFG] Create flag to disable simplifyCFG.

2018-02-16 Thread Davide Italiano via Phabricator via cfe-commits
davide added subscribers: chandlerc, davide. davide added a comment. Some high level comments: 1. This is something that GCC does relatively frequently (adding frontend options to control optimization passes), but LLVM tends to not expose these details. FWIW, I'd very much prefer the details o

[PATCH] D43428: [CFG] NFC: Allow more complicated construction contexts.

2018-02-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: rsmith, dcoughlin, xazax.hun, a.sidorin. Herald added subscribers: cfe-commits, rnkovacs, kristof.beyls, mehdi_amini. `ConstructionContext`s introduced in https://reviews.llvm.org/D42672 are an additional piece of information included with `CFGConst

[PATCH] D43428: [CFG] NFC: Allow more complicated construction contexts.

2018-02-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 134785. NoQ added a comment. Fix comment. https://reviews.llvm.org/D43428 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp Index: lib/Analysis/CFG.cpp === --- lib/Analysis/CFG.cpp +++

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

2018-02-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a subscriber: george.karpenkov. NoQ added a comment. This revision is now accepted and ready to land. Herald added a reviewer: george.karpenkov. LGTM! @george.karpenkov has also tested that when he was gathering statistics about his traversal order improvemen

[PATCH] D16403: Add scope information to CFG

2018-02-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D16403#1010096, @szepet wrote: > In https://reviews.llvm.org/D16403#992454, @NoQ wrote: > > > @szepet: so i see that `LoopExit` goes in the beginning of the cleanup > > block after the loop, while various `ScopeEnd`s go after the `LoopExit`. > >

[PATCH] D43429: [clangd] Add missing library (clangLex) in a few places

2018-02-16 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle created this revision. Herald added subscribers: cfe-commits, ioeric, jkorous-apple, ilya-biryukov, mgorny, klimek. Fixes undefined reference to 'clang::Preprocessor::addCommentHandler' when building with -DBUILD_SHARED_LIBS. Signed-off-by: Marc-Andre Laperle Repository: rCTE Clan

<    1   2